Commit graph

100613 commits

Author SHA1 Message Date
Marina Glancy
b2d8938431 MDL-70966 various: Under PHP8 empty string is no longer equals to 0 2021-02-28 19:16:53 +01:00
AMOS bot
bb999f4ff5 Automatically generated installer lang files 2021-02-28 00:07:23 +00:00
AMOS bot
4afb746475 Automatically generated installer lang files 2021-02-27 00:07:29 +00:00
David Matamoros
52627c5f0f MDL-70910 contentbank: fix for using contentid not validated 2021-02-26 14:36:02 +01:00
Tim Hunt
0b661342dc MDL-71009 question bank: escape idnumbers when displayed 2021-02-26 12:47:33 +00:00
Eloy Lafuente (stronk7)
bbe91c4828 MDL-70876 php80: 5th param removed from custom error handlers
It was deprecated in php72 and now it's gone.

Have used this regexp to find all the uses in core:

ag set_error_handler | uniq

And then checked all them manually, that parameter was not
being used in the 3 methods where we are removing it.
2021-02-26 13:08:31 +01:00
Eloy Lafuente (stronk7)
0cbda5bda4 MDL-68735 env: Moodle 3.8.x, 3.9.x and 3.10.x do not support PHP 8.0 2021-02-26 13:08:03 +01:00
Marina Glancy
e87182d827 MDL-70877 php: remove final functions __clone and __wakeup
Implementing these functions as final does not prevent the object to be
cloned or serialized, so the comment to them was wrong.
However having these functions not public breaks in PHP 8.0.
It still does not make sense to clone or serialise file_system or external_settings classes
but there are a lot of classes in moodle that should not be cloned, no reason to have
a specific solution here.
2021-02-26 13:07:55 +01:00
David Matamoros
f648e9d0fa MDL-70941 contentbank: fix empty equality check when renaming content 2021-02-26 12:01:51 +01:00
Eloy Lafuente (stronk7)
7b1dd2fbee MDL-70457 forms: php74 fix for the (not used in core) date element
Curly brackets to access by index to strings or arrays is
deprecated since php74.
2021-02-26 11:55:28 +01:00
Amaia Anabitarte
a3cc4fd3b1 MDL-67119 core_analytics: Analyse users once per course
User's activity in a course should be analysed only once
no matter the number of enrolments the user has in that course.
2021-02-26 11:48:09 +01:00
Jun Pataleta
4652b66ee4 weekly release 3.11dev 2021-02-26 13:42:46 +08:00
Jun Pataleta
cb75adc946 Merge branch 'install_311_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_311_STABLE 2021-02-26 13:42:43 +08:00
Marina Glancy
f2adb56be0 MDL-70921 repository: filter function can not accept argument by ref
PHP8.0 shows error that filter function accepts value by reference
The nested filtering was never working but also this function was never called on a tree with sub-levels,
so this logic is now removed
2021-02-25 18:25:05 +01:00
David Mudrák
deb99d0c7e MDL-70964 lang: Use the fixed strings in tests 2021-02-25 16:32:11 +01:00
Helen Foster
d37a1b7e9f MDL-70964 lang: Import fixed English strings (en_fix) 2021-02-25 16:31:43 +01:00
Jun Pataleta
b5e913a5c4 Merge branch 'MDL-70169-311' of git://github.com/lameze/moodle into MOODLE_311_STABLE 2021-02-25 12:30:11 +08:00
Jun Pataleta
71287b89ff Merge branch 'MDL-70768-langpack-admin-MOODLE_311_STABLE' of https://github.com/brendanheywood/moodle into MOODLE_311_STABLE 2021-02-25 11:30:38 +08:00
AMOS bot
da37a00736 Automatically generated installer lang files 2021-02-25 00:07:26 +00:00
Paul Holden
7aee6e2fb2 MDL-69883 message: fix lazy loading of conversations.
Set max-height on each container section rather than the container
itself, so that each can respond to the scrollBottom event within
the lazy loading module (which handles the overflow itself).
2021-02-24 22:01:34 +00:00
Paul Holden
18628ed5b9 MDL-70995 user: format group names in course participants filter. 2021-02-24 19:26:04 +00:00
Iñigo Zendegi
62f91770e2 MDL-69097 mod_forum: Apply filters to whole forum grading 2021-02-24 17:09:50 +01:00
Víctor Déniz
31ab9835e8 Merge branch 'MDL-51111-muc-reset-MOODLE_311_STABLE' of https://github.com/brendanheywood/moodle into MOODLE_311_STABLE 2021-02-24 14:07:55 +00:00
Shamim Rezaie
4b73612459 MDL-70287 core_payment: Redirect user to the successurl after payment 2021-02-24 22:47:22 +11:00
Shamim Rezaie
058e57bc88 MDL-70287 core_payment: Add get_success_url to service_provider 2021-02-24 22:47:21 +11:00
Shamim Rezaie
e37e06d194 MDL-70287 core_payment: Improving existing and missing phpdocs 2021-02-24 22:47:21 +11:00
Eloy Lafuente (stronk7)
70a7ba1edd Merge branch 'MDL-70828-311' of git://github.com/abgreeve/moodle into MOODLE_311_STABLE 2021-02-24 12:15:05 +01:00
Adrian Greeve
e7c47b194c MDL-70828 performance: Allow session locking issue to be turned off.
If a developer has debugging on then they will recieve all debugging
messages for locking whether wanted or not. We already have a setting
to display these messages.
2021-02-24 11:28:06 +08:00
Brendan Heywood
27758f45f1 MDL-51111 cache: Don't lock and write the config file if unchanged 2021-02-24 12:43:42 +11:00
Andrew Nicols
bcd05412b6 MDL-70987 core_form: Use correct id for elementid during validation
The id of the formid was being passed instead of the elementid.
2021-02-24 09:06:27 +08:00
Eloy Lafuente (stronk7)
9e59404425 Merge branch 'MDL-52817-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE 2021-02-23 19:08:04 +01:00
Eloy Lafuente (stronk7)
197775a6bb MDL-70314 lib: Remove a few more hidden files and add instructions 2021-02-23 18:39:24 +01:00
Eloy Lafuente (stronk7)
954212adf8 Merge branch 'MDL-70314-311' of https://github.com/Chocolate-lightning/moodle into MOODLE_311_STABLE 2021-02-23 18:34:07 +01:00
Eloy Lafuente (stronk7)
6e9c9f7f87 Merge branch 'MDL-70920-311' of git://github.com/marinaglancy/moodle into MOODLE_311_STABLE 2021-02-23 17:43:39 +01:00
Sara Arjona
2ac767233a MDL-67974 core_badges: Recovered expired stamp
Expired stamp icon displayed over the badge images has been added
again to CSS (it was lost at any point).
2021-02-23 15:32:41 +01:00
Sara Arjona
0e63ad9f4c MDL-67974 core_badges: Badge expiry date when hover
Text displayed for expired badges when the user hovers over the
warning (!) icon has been fixed in the "Issued badge information"
page.
2021-02-23 15:32:41 +01:00
Víctor Déniz
fb8e9abd70 Merge branch 'MDL-70038-311' of https://github.com/jpahullo/moodle into MOODLE_311_STABLE 2021-02-23 12:23:14 +00:00
Jordi Pujol Ahulló
0846a76c68 MDL-70038 assign: add suport for pdftoppm tool
pdftoppm (from poppler-utils package) is several orders of
magnitude quicker than ghostscript extracting PNG images
from PDF documents.

We add support for this tool and use it whenever set up,
or using gs as before if missing.

Revisited code with peer review comments. In particular:

1. Make default path for pdftoppm empty string.
2. Fix a typo on the method description for get_gs_command_for_image.
3. Added more information why is useful pdftoppm into string pathtopdftoppm_help.
4. Check that path for pdftoppm is executable to prevent errors. Otherwise, use gs.
2021-02-23 08:08:23 +01:00
Brendan Heywood
e4f011cf78 MDL-70424 auth: Avoid random changes to $CFG->auth 2021-02-23 11:41:34 +11:00
Eloy Lafuente (stronk7)
8a620aa0e9 Merge branch 'MDL-43697-311' of https://github.com/praxisdigital/moodle into MOODLE_311_STABLE 2021-02-22 23:10:03 +01:00
Marina Glancy
e334bd9921 MDL-70967 enrol_meta: fix error in unittest 2021-02-22 18:06:38 +01:00
Marina Glancy
681c70017c MDL-70901 core: @ no longer masks errors in PHP 8.0 2021-02-22 16:19:37 +01:00
Marina Glancy
920331e74e MDL-70901 cache: @ no longer masks errors in unlink in php 8 2021-02-22 16:19:37 +01:00
Marina Glancy
03b198f45d MDL-70901 core_files: @ does no mask errors in php8 anymore 2021-02-22 16:19:37 +01:00
Marina Glancy
8b5bd4fb00 MDL-70901 backup: check handle before calling fclose()
@fclose no longer catches error in PHP 8.0 when handle is null
2021-02-22 16:19:37 +01:00
Sara Arjona
172dc36b46 MDL-63961 core_badges: Use high-resolution image
High-resolution image for a badge (f3) should be sent to external
backpacks through JSON and WS methods.
Besides, when a badge is cloned, the high-resolution image should be
used to avoid the copied looks blurry.
2021-02-22 12:52:04 +01:00
Mark Nelson
0f33c1b820 MDL-70125 core_grade: do not change overridden status during regrading 2021-02-22 17:35:53 +08:00
Mathew May
e7268eff4b MDL-70314 lib: Change XLSX wrapper to no change the default styles
This is required due to changes in the base library see #1712
Summary is that if a column already has styling it can't be overpowered.
2021-02-22 15:33:56 +08:00
Mathew May
f079df4ce2 MDL-70314 lib: Apply Moodle specific phpspreadsheet changes 2021-02-22 15:33:21 +08:00
Mathew May
8ff625ed61 MDL-70314 lib: Upgrade PhpSpreadsheet to 1.16.0 2021-02-22 15:33:21 +08:00