Commit graph

3045 commits

Author SHA1 Message Date
Tim Hunt
222fb6e5fe quiz MDL-24140 navigating to a question that was not first on the page was broken. 2010-11-02 19:20:58 +00:00
Tim Hunt
6723a0390b MDL-24140 Each attempt builds on last setting was being ingored in one place.
The code was behaving as if it was always true.
2010-11-02 19:12:21 +00:00
Tim Hunt
f2ca88b07f qtype_multichoice MDL-24937 multichoice questions were getting marked as answered even when they weren't. 2010-11-01 18:14:27 +00:00
Tim Hunt
157434a522 quiz/question javascript MDL-24170 Enter in a shortanswer question preview should not flag the question.
That bit of JavaScript from mod/quiz/attempt.php is needed in question preview too, so refactor a bit.

I was disappointed to find that the
$PAGE->requires->js_module('core_question_engine');
line was needed in quiz_get_js_module, but it seems to be.

Also change non-Moodle-y string "End test..." to "Finish attempt..."
2010-11-01 17:44:59 +00:00
Tim Hunt
48c19b2551 quiz lang MDL-24170 move an old string to a more logical name, before making the real change.
AMOS BEGIN
 MOV [finishattempt,mod_quiz],[submitallandfinish,mod_quiz]
AMOS END
2010-11-01 17:36:15 +00:00
Tim Hunt
6382910a87 quiz MDL-24499 simple typo when putting values into a string.
Thanks to Manish Verma for noticing this.
2010-11-01 14:40:25 +00:00
Tim Hunt
e09ca95eba quiz reports MDL-24603 columns in the overview report should be collapsible. 2010-11-01 14:36:58 +00:00
Eloy Lafuente
41941110fd MDL-22138 backup - I know smaller cathedrals than this, yay quizzes! 2010-10-24 10:43:42 +00:00
Tim Hunt
db04866591 quiz MDL-24760 recent fix quiz preview/review by teacher. 2010-10-22 17:24:09 +00:00
Tim Hunt
9bb6663e04 quiz MDL-24727 column missed from install.xml 2010-10-20 10:14:19 +00:00
Tim Hunt
fde29fa59c quiz & qbank MDL-24453 some more return URLs that I missed the first time.
Also, fix a double-escaping bug when cancelling the form.
2010-10-18 15:53:54 +00:00
Tim Hunt
fb6dcdab11 quiz & qbank MDL-24453 fix all the ways you can edit a question, so that that returnurl paramterer acutally works.
I hope. Please test thoroughly.
2010-10-18 15:28:59 +00:00
Tim Hunt
2a27a37db8 quiz recent activity MDL-24528 was setting the activity userid to the attempt id. Doh! 2010-10-05 17:11:16 +00:00
Sam Hemelryk
9db1789832 mod-quiz MDL-24418 Overflow fix allow horizontal scrolling of quiz results. 2010-09-29 03:02:18 +00:00
Tim Hunt
4033062b33 quiz statistics report NOBUG   was not being escaped twice in Analysis of responses of some qtypes. 2010-09-22 15:35:27 +00:00
Petr Skoda
6bdfef5da9 MDL-24321 switching to standard stdClass() 2010-09-21 08:54:01 +00:00
Petr Skoda
39790bd805 MDL-24321 switching to stdClass in /mod/ 2010-09-21 08:37:36 +00:00
Eloy Lafuente
767cb7f03a MDL-22151 & MDL-22138 - Quiz activity backup & questions banks too!
CV S: ----------------------------------------------------------------------
2010-09-21 01:28:30 +00:00
Eloy Lafuente
29af95f1d0 MDL-22153 backup - deleted old quiz backup code (replacement is on the way) 2010-09-19 23:03:33 +00:00
Petr Skoda
034ef76129 improved spelling 2010-09-18 12:31:20 +00:00
Petr Skoda
72d2982eb1 hmm, it is reset course not courses 2010-09-18 12:08:16 +00:00
Petr Skoda
91421f3ead a few spelling fixes 2010-09-18 12:07:01 +00:00
Petr Skoda
eab8ed9fb7 fixed a few spelling errors in /admin/ 2010-09-17 10:27:26 +00:00
Eloy Lafuente
8ad6765887 NOBUG quiz - overview & responses reports fixes 2010-09-17 01:07:17 +00:00
Petr Skoda
0f21a964a5 MDL-24079 fixing recent regressions caused by api changes in tablelib; sorry I did not find the problem earlier 2010-09-05 12:35:51 +00:00
Petr Skoda
f685e83030 MDL-14679 fixed remaining old style set_field()s 2010-09-03 18:14:55 +00:00
Petr Skoda
dd88de0ebd MDL-14679 fixed remaining old style update_record()s 2010-09-03 18:01:25 +00:00
Petr Skoda
b8ea3041eb MDL-23184 activity names are now either PARAM_TEXT or PARAM_CLEANHTML, this should be more accurate 2010-09-02 18:29:39 +00:00
Tim Hunt
ea9dbf24c5 quiz MDL-23937 fix broken URL. 2010-08-25 15:58:26 +00:00
David Mudrak
370d793c98 MDL-23318 Consistent usage of 'pluginadministration' string for the Settings block
AMOS BEGIN
 MOV [assignmentadministration,mod_assignment],[pluginadministration,mod_assignment]
 MOV [dataadministration,mod_data],[pluginadministration,mod_data]
 MOV [feedbackadministration,mod_feedback],[pluginadministration,mod_feedback]
 MOV [folderadministration,mod_folder],[pluginadministration,mod_folder]
 MOV [forumadministration,mod_forum],[pluginadministration,mod_forum]
 MOV [glossaryadministration,mod_glossary],[pluginadministration,mod_glossary]
 MOV [chatadministration,mod_chat],[pluginadministration,mod_chat]
 MOV [choiceadministration,mod_choice],[pluginadministration,mod_choice]
 MOV [imscpadministration,mod_imscp],[pluginadministration,mod_imscp]
 MOV [labeladministration,mod_label],[pluginadministration,mod_label]
 MOV [lessonadministration,mod_lesson],[pluginadministration,mod_lesson]
 MOV [pageadministration,mod_page],[pluginadministration,mod_page]
 MOV [quizadministration,mod_quiz],[pluginadministration,mod_quiz]
 MOV [resourceadministration,mod_resource],[pluginadministration,mod_resource]
 MOV [scormadministration,mod_scorm],[pluginadministration,mod_scorm]
 MOV [surveyadministration,mod_survey],[pluginadministration,mod_survey]
 MOV [urladministration,mod_url],[pluginadministration,mod_url]
 MOV [wikiadministration,mod_wiki],[pluginadministration,mod_wiki]
 MOV [workshopadministration,mod_workshop],[pluginadministration,mod_workshop]
AMOS END
2010-08-17 17:35:12 +00:00
Andrew Davis
6c2f430931 quiz MDL-23827 made a string grammatically correct 2010-08-17 01:53:32 +00:00
Petr Skoda
b11681e036 MDL-23784 fixed more incorrect pix links 2010-08-12 18:38:56 +00:00
Petr Skoda
70daa96fe5 MDL-23784 removing obsolete quiz images, pix is the only correct dir now 2010-08-12 16:50:13 +00:00
Tim Hunt
72d9358afd quiz secure mode MDL-23712 secure mode breaks the quiz navigation
This commit also fixes some other secure window problems.
2010-08-11 20:25:31 +00:00
Tim Hunt
f2cb0c3d48 quiz NOBUG whitespace fix. 2010-08-11 20:15:18 +00:00
Tim Hunt
f6d726c27a quiz javascript NOBUG missing ;s 2010-08-11 20:15:05 +00:00
Tim Hunt
d04f623be4 quiz editing MDL-23705 the edit icon after the question name disappears some times.
It is worse with some themes and some browsers.
You can still edit by clicking the question name, but that is not obvious.
I moved the edit icon to the left.
2010-08-11 19:38:16 +00:00
Tim Hunt
414e727676 quiz reports MDL-23161 notify(get_string('nostudentsyet')) breaking downloads. 2010-08-11 18:34:42 +00:00
Tim Hunt
c6764f5a2e quiz with password MDL-23699 starting an attempt was broken. 2010-08-11 17:30:44 +00:00
Tim Hunt
c0934fc42a quiz 'secure' window MDL-23713 securewindow_access_rule::make_review_link was broken. 2010-08-11 17:20:05 +00:00
Tim Hunt
150ce06891 quiz MDL-23711 was testing canattempt before canpreview, which is the wrong way round.
Meat that admins saw a Start attempt button, when they should have seen Start preview.
2010-08-11 16:57:34 +00:00
Tim Hunt
1be4990421 quiz summary MDL-23700 logic for whether to show the marks column was wrong. 2010-08-11 16:54:32 +00:00
Tim Hunt
36fa6cb133 quiz NOBUG fatal error on the review page.
I am pretty sure this check is not necessary, preload_question_states will have loaded enough information.
2010-08-11 16:54:07 +00:00
Tim Hunt
690510bd3d quiz NOBUG fix some JavaScript errors. 2010-08-11 16:31:52 +00:00
Tim Hunt
38c9edd0a0 quiz nav NOBUG whitespace and comment clean-up. 2010-08-10 13:30:32 +00:00
Dongsheng Cai
fe6ce23489 MDL-16094 File storage conversion Quiz and Questions 2010-08-10 09:56:48 +00:00
Tim Hunt
a26246eac2 quiz attempt UI NOBUG need accesshide text in the quiz navigation to say if a question has been flagged. 2010-08-09 17:10:25 +00:00
Tim Hunt
d39ba35c34 quiz overview report MDL-17569 you should be see essay questions that need grading in the report. 2010-08-06 18:09:48 +00:00
Tim Hunt
8b7d4fb70e quiz editing MDL-19766 fixed page load flicker of things revealed later by JavaScript. 2010-08-06 17:55:33 +00:00
Tim Hunt
207d145dda quiz delays MDL-20956 don't let overdue attempts + delays block students.
Suppose a quiz has a 60 min time limit, and an enforced delay of 60 mins between attempts.

Suppose a sudent starts an attempt, and then closes their browser, and then comes back 2 hours later. When they try to restart the quiz, it is submitted immediately by the timer.

Now they are blocked out for the next hour.

After this change, they would no longer be blocked, becuse if their attemtp had been submitted at the end of the first hour, then they would already have waited an hour.

That is, we compare the current time with both $lastattempt->timefinish + $delay and $lastattempt->timestart + $timelimit + $delay.
2010-08-06 11:41:50 +00:00