Commit graph

3045 commits

Author SHA1 Message Date
Dan Poltawski
6b445cb17a Merge branch 'w18_MDL-30686_m23_guessurl' of git://github.com/skodak/moodle 2012-05-01 11:27:16 +08:00
Tim Hunt
59d14f31bd Improve the wording of overdue messages. Thanks Phil. 2012-04-30 13:46:02 +01:00
Dan Poltawski
fdf26a0ec0 MDL-3030 mod_quiz: fix training whitespace 2012-04-30 11:05:29 +08:00
Tim Hunt
b640e6815a MDL-3030 quiz overdue handling: allow access to summary during grace period 2012-04-27 15:07:43 +01:00
Tim Hunt
2512341872 MDL-3030 quiz statistics: fix stict syntax problem. 2012-04-27 15:07:42 +01:00
Tim Hunt
e1bf1619e1 MDL-3030 quiz overdue handling: cron to update overdue attempts. 2012-04-27 15:07:41 +01:00
Tim Hunt
be18f589e2 MDL-3030 quiz overdue handling: test state, not timefinish where applicable. 2012-04-27 15:07:40 +01:00
Tim Hunt
3e77b60f36 MDL-3030 quiz overdue handling: ignore responses received much too late. 2012-04-27 15:07:38 +01:00
Tim Hunt
fd0537ce36 MDL-3030 quiz overdue handling: catch the overdue event and send message. 2012-04-27 15:07:37 +01:00
Tim Hunt
a403bce0bd MDL-3030 quiz overdue handling: back-end code for the new transitions 2012-04-27 15:07:36 +01:00
Tim Hunt
34b7d8383d MDL-3030 quiz overdue handling: trigger automatic state transitions.
Here, we catch all the places where a student might be accessing their
own attempts, and make sure any automatic state transitions that
should happen, do happen, before the student sees the attempt.

The places where we need to check this are view.php, startattempt.php
and processattempt.php.

We do not really need to check attempt.php or summary.php, because if
the student is on one of those pages, the JavaScript timer will
auto-submit when time expires, taking them to processattempt.php,
which will do the acutal work.

We intentionally do not trigger state transition when a teacher is
looking at a student's quiz attemp. We will trigger state transitions
on cron, but that is still to do.

Also, the body of the process_... methods still needs to be written.
2012-04-27 15:07:35 +01:00
Tim Hunt
863872e3e7 MDL-3030 quiz overdue handling: show the attempt state in the reports. 2012-04-27 15:07:33 +01:00
Tim Hunt
2cdd2df92d MDL-3030 quiz overdue handling: only finished attempts in stats. 2012-04-27 15:07:32 +01:00
Tim Hunt
c547514a9e MDL-3030 quiz overdue handling: show attempt state in the reports. 2012-04-27 15:07:31 +01:00
Tim Hunt
b39b5d77c3 MDL-3030 quiz overdue handling: show attempt state on the review page. 2012-04-27 15:07:30 +01:00
Tim Hunt
2b2b645842 MDL-3030 quiz overdue handling: display message on the summary page.
This change also includes a clean-up of how we display and initialise the countdown timer.
2012-04-27 15:07:29 +01:00
Tim Hunt
2de9be52aa MDL-3030 quiz overdue handling: show attempt state on the view page 2012-04-27 15:07:27 +01:00
Tim Hunt
fd55f4bf49 MDL-3030 quiz overdue handling: backup and restore new settings. 2012-04-27 15:07:26 +01:00
Tim Hunt
18efef384b MDL-3030 quiz overdue handling: new capability 2012-04-27 15:07:25 +01:00
Tim Hunt
87427d9c7c MDL-3030 quiz overdue handling: new settings on quiz form and admin. 2012-04-27 15:07:23 +01:00
Tim Hunt
84da4788fd MDL-3030 quiz settings: reorganise form before adding new fields. 2012-04-27 15:07:22 +01:00
Tim Hunt
c761b7757d MDL-3030 quiz db: add comments to many colums, and reorder more logically. 2012-04-27 15:07:21 +01:00
Tim Hunt
20b77578d0 MDL-3030 quiz overdue handling: new DB columns. 2012-04-27 15:07:19 +01:00
Petr Skoda
f0202ae9a2 MDL-30686 improve accuracy of qualified_me() by trying PAGE->url first
This should help SSL proxies and returning to current page after require_login().
2012-04-27 13:39:18 +02:00
Eloy Lafuente (stronk7)
cb6de349e4 Fix permissions 2012-04-27 12:45:22 +02:00
Eloy Lafuente (stronk7)
d7f84a2962 Merge branch 'MDL-32471-thumbnails' of git://github.com/mudrd8mz/moodle 2012-04-25 15:14:27 +02:00
Eloy Lafuente (stronk7)
2360f60fd8 MDL-32322 tests: apply changes in simpletests (now deleted) to phpunit ones. 2012-04-25 03:09:42 +02:00
Eloy Lafuente (stronk7)
d3cb25dfef Merge branch 'MDL-32322' of git://github.com/timhunt/moodle
Conflicts:
	mod/quiz/report/simpletest/testreportlib.php
	mod/quiz/report/statistics/simpletest/test_qstats.php
2012-04-25 03:02:14 +02:00
David Mudrak
7a00d4385d MDL-32471 preview thumbnails support for other component types
This commit affects mostly qtypes. Other standard components either do
not have pluginfile handler or have been already updated to the new API.
2012-04-24 14:29:44 +02:00
David Mudrak
261cbbacc1 MDL-32471 preview thumbnails support for activity modules
Activity module's xxx_pluginfile() now accepts the $options parameter
that is to be passed to the send_stored_file() function.
2012-04-24 12:09:45 +02:00
Dan Poltawski
bebf083159 Merge branch 'w17_MDL-31607_m23_login' of git://github.com/skodak/moodle 2012-04-23 11:47:11 +08:00
Petr Skoda
cdbea7eed1 MDL-31607 use full course object for require_login() if already available
This eliminates 1 db query.
2012-04-22 17:41:47 +02:00
Petr Skoda
f596005b6c MDL-32569 drop migrated module tests 2012-04-21 16:58:07 +02:00
Tim Hunt
9d58dae33b MDL-32322 quiz reports: fix PHPdoc comments. Thanks Smurf. 2012-04-20 11:34:56 +01:00
Tim Hunt
c0270961a8 MDL-32322 more changes to make the code more similar before refactoring. 2012-04-20 10:07:28 +01:00
Tim Hunt
361cf27d7f MDL-32322 quiz reports: refactor processing actions. 2012-04-20 10:07:26 +01:00
Tim Hunt
e97d60adce MDL-32322 quiz reports: pass options object -> table, not separate args. 2012-04-20 10:07:25 +01:00
Tim Hunt
9e67e357eb MDL-32322 quiz_reports: move some more options into the options class. 2012-04-20 10:07:23 +01:00
Tim Hunt
ac4d91575a MDL-32322 quiz reports: name improvement attempt_report -> attempts_report. 2012-04-20 10:07:22 +01:00
Tim Hunt
dcd65f1b4f MDL-32322 quiz reports: extract a mod_quiz_attempt_report_options class.
More clean-ups are possible in the reports after this, but I am committing now, having got the code back to a working state.
2012-04-20 10:07:21 +01:00
Tim Hunt
303aa3b8d0 MDL-32322 quiz reports: killing more duplication. 2012-04-20 10:07:19 +01:00
Tim Hunt
5ca45fddab MDL-32322 quiz reports: eliminate more duplication. 2012-04-20 10:07:18 +01:00
Tim Hunt
5bf8a1695d MDL-32322 quiz reports: defines -> class constants. 2012-04-20 10:07:17 +01:00
Tim Hunt
2639a68ad5 MDL-32322 quiz reports: refactor the settings forms to eliminate duplication. 2012-04-20 10:07:15 +01:00
Tim Hunt
4747c788c0 MDL-32322 quiz reports: edit to increase duplication, before refactoring. 2012-04-20 10:07:14 +01:00
Tim Hunt
768a758854 MDL-32322 quiz reports: Appease the great god codechecker. 2012-04-20 10:07:12 +01:00
Tim Hunt
90fbad644b MDL-32322 quiz reports: fix more strict syntax issues. 2012-04-20 10:07:11 +01:00
Tim Hunt
8d76124c5b MDL-32322 quiz reports: fix up PHP doc comments. 2012-04-20 10:07:09 +01:00
Tim Hunt
6b4e2d76a3 MDL-32322 quiz reports: rename classes, and fix one strict syntax. 2012-04-20 10:07:08 +01:00
Tim Hunt
f5e42695bd MDL-32322 quiz reports: split attemptsrepor.php into one file per class. 2012-04-20 10:07:06 +01:00