tjhunt
971c6fca06
question bank: MDL-17871 Kill most of the duplicated code between mod/quiz/editlib.php and question/editlib.php
2009-01-22 05:38:18 +00:00
tjhunt
0ff5afdfbf
question bank: MDL-17871 Possibility for tool tips on column headings.
2009-01-22 02:32:39 +00:00
tjhunt
babdcb4024
question bank: MDL-17302 fix errors in the previous commit.
2009-01-21 08:52:42 +00:00
tjhunt
b221dc6f23
question bank: MDL-17302 refactor question bank display code into a class.
...
Step 3. Start working ot the code to initialise things from a list of columns, and build the corresponding SQL query.
2009-01-21 08:49:15 +00:00
tjhunt
5bd22790c4
question bank: MDL-17871 refactor the code that displays particular information about each question into classes.
...
More work in progress. Print column headers, and improve sorting. These classes are still not used.
2009-01-21 07:21:43 +00:00
Jonathan Newman
4d933beb8a
cvsimport fixups
2009-01-20 23:53:34 +00:00
tjhunt
46795afcbd
question bank: MDL-17871 refactor the code that displays particular information about each question into classes.
...
Work in progress. Most required classes are writted, but nothing uses them yet, and I have not dealt with column headers yet.
2009-01-20 10:11:23 +00:00
tjhunt
80829be920
quiz backup: MDL-17970 MSSQL text / varchar compare issue.
...
Commiting this fix so it gets into 1.9.4. I've tested and it does not break sensible databases, and probably fixes the problem on MSSQL.
2009-01-20 04:24:07 +00:00
tjhunt
d61f7b7641
backup/restore: MDL-16614 more reliable test for when we are restoring a backup that was made of the same site that we are restoring to.
...
* Use this to fix a question restore bug.
* Replace older code that does something similar with the new test.
* Refactor initialisation of $CFG->siteidentifier into a function. There were about 4 copies of this code ;-)
2009-01-20 03:16:30 +00:00
tjhunt
5b5e5ab20c
question bank: MDL-17302 refactor question bank display code into a class.
...
Step 2. Remove as many as possbile of the differences between the two classes. This is mostly whitespace and irrelevant code formatting issues, but there are also a few changes to the generated output, taking the best of both views.
2009-01-19 08:50:48 +00:00
tjhunt
f4b879ddea
question bank: MDL-17302 refactor question bank display code into a class.
...
Step 1. Just convert the existing functions quiz_question_showbank and question_showbank and friends into methods of a class and subclass.
More to come.
2009-01-19 05:30:01 +00:00
skodak
56949c17de
MDL-14992 refactored use of session_write_close()
2009-01-17 15:25:08 +00:00
tjhunt
c599a68240
question bank: MDL-12787, MDL-17870 field in the question editing form to tag questions, and load and save the tags from the DB.
2009-01-16 08:00:06 +00:00
tjhunt
a18ba12ca6
quiz / questions: MDL-17919 Bad link edit questions from quiz preview page.
...
Thanks to Ann Adamcik for noticing this. It was a regression from MDL-6085.
2009-01-16 04:47:23 +00:00
tjhunt
c795dc7843
questiontypes: MDL-17800
...
Fix another merge error.
2009-01-16 04:24:24 +00:00
tjhunt
815262cab6
questiontypes: MDL-17800
...
Fix merge error.
2009-01-16 04:23:21 +00:00
tjhunt
c51c539d11
questiontypes: MDL-17800 Add extra_question_fields() support to backup/restore functions.
...
* Implement this in the base class, and
* use this in the shortanswer type as a proof of concept.
This makes writing new question type subclasses a bit easier. Thanks to Oleg Sychev for this code.
2009-01-15 07:29:07 +00:00
tjhunt
d65c238b2c
question engine: MDL-17651 this context is not used anywhere, so remove it.
...
(There was a bug in the get_context_instance call.)
2009-01-15 05:15:38 +00:00
skodak
58fa5d6f75
MDL-16483 - renamed MoodleUnitTestCase to FakeDBUnitTestCase; MDL-17841 removed bogus remove lib/simpletest/slowcodetest.php
2009-01-10 13:47:26 +00:00
tjhunt
d001dac77b
shortanswer qtype: MDL-17706 use extra_question_fields mechanism to save on code. Changes thanks to Oleg Sychev.
2009-01-09 05:10:33 +00:00
tjhunt
71990c7cf6
question preview: MDL-17418 Enable previewing of random questions.
...
Also, fix a grade rounding issue.
2009-01-08 09:03:49 +00:00
tjhunt
b4a2e41313
quiz editing: MDL-17284 fix infinite redirect bug.
2009-01-07 07:12:37 +00:00
tjhunt
807a1a8427
question bank database: MDL-17608 Drop originalquestion field from the question_states table - it was never used for anything.
2009-01-06 05:20:21 +00:00
skodak
11e7b506ce
MDL-17754, MDL-11061, MDL-9276, MDL-17777, MDL-17787 - various url handling improvemetns; rewritten $FULLME and added $ME, $SCRIPT and $FULLSCRIPT; improved slashargument handling especially for IIS; removed legacy slasharguments functions obsoleted since 1.6; some other refactoring; reverse procy support, ssl appliance support
2009-01-05 21:37:20 +00:00
thepurpleblob
9843511764
MDL-17779
...
Add simple check that question at least has questiontext before allowing it.
2009-01-05 15:23:10 +00:00
skodak
973d2660e6
MDL-16613 sesskey cleanup
2009-01-02 10:51:26 +00:00
skodak
d4a1fcaf11
MDL-16613 sesskey cleanup
2009-01-02 10:36:25 +00:00
tjhunt
7028ab335d
match qtype: MDL-17326 backup and restore problems
...
* The shuffleanswers options was not backed up or restored.
* Responses were not properly recoded on restore.
2008-12-12 06:45:07 +00:00
dongsheng
771dc7b298
"MDL-14129, fix error() in moodle2"
2008-12-12 05:45:43 +00:00
dongsheng
60e40dda6c
"MDL-14129, remove the rest error() in moodle2"
2008-12-12 04:53:32 +00:00
tjhunt
299d9fb834
matching qtype: MDL-17496 With filterall and multilang, the contents of the dropdowns was not being properly filtered
...
This was caused becuse the solution to MDL-9005 was not quite right.
2008-12-12 04:39:38 +00:00
tjhunt
be8563b63a
numerical and shortanswer question types: problems with compare_responses and test_response.
...
MDL-15315 The previous fix for this issue with wildcard answers in the item analysis report caused the following two regressions. This patch fixes it properly.
MDL-17247 This is basiclly pointing out the weridness in the previous fix and gave some useful clues as to a proper solution. Thanks Oleg.
MDL-17610 This was a report of a problem with each attempt builds on last, with a shortanswer question, where the sutdent's response contains a '.
Also, lots of unit tests to try to ensure the new code is right.
2008-12-12 03:48:39 +00:00
tjhunt
f932b81953
matching qtype: MDL-14420 Could not use '0' as a question stem. Oops, more tests need to be corrected.
2008-12-11 05:01:37 +00:00
tjhunt
9ce0983b0d
matching qtype: MDL-14420 Could not use '0' as a question stem. Bloody PHP!
2008-12-11 04:57:39 +00:00
tjhunt
f8394114c3
matching qtype: whitespace cleanup.
2008-12-11 04:55:41 +00:00
tjhunt
26b266625b
numerical qtype: MDL-15159 Error moving a numerical question type with no units from one category to another.
2008-12-11 04:33:41 +00:00
tjhunt
e8f99abc68
quiz manual grading: MDL-5517 manual grading pop-up is too small. HTML editor does not fit. Merged from MOODLE_19_STABLE.
...
Also MDL-17585 Improve layout of manual grading forms to make them look more like formslib forms. The standard trick of stealing the HTML and class names that formslib works, so the standard style rules apply to your form.
2008-12-10 09:11:30 +00:00
dongsheng
ff9b4ea40a
"MDL-17570,clean align property, merged from 1.9"
2008-12-10 07:24:11 +00:00
tjhunt
aafdb447bf
quiz: MDL-6085 when editing a question from various places like a preview attempt or review screen, don't use a popup, instead take advantage of the fact that question.php now takes a returnurl. Merged from MOODLE_19_STABLE.
...
And MDL-17568 minor niggles with new queston navigation:
* The bit that scrolls down to the question you just submitted in adaptive mode was not working with random questions.
* Teachers reviewing an open attempt were shown the qusetions as editable, not read only!
2008-12-10 06:26:47 +00:00
tjhunt
0a9356aad3
truefalse qtype: MDL-12027 remove spurious alt attribute from truefalse qtype radio buttons.
2008-12-10 00:54:27 +00:00
pichetp
636bbc8728
MDL-17524 Deleting a calculated question delete datasetdefinitions shared by other question
...
} missing...
2008-12-04 16:04:48 +00:00
pichetp
57db70affb
MDL-17524 Deleting a calculated question delete datasetdefinitions shared by other question
2008-12-04 15:56:01 +00:00
pichetp
77f60b432a
removing an echo diagnostic output...
2008-12-01 04:03:48 +00:00
pichetp
cae0b24abb
Modify a DB call so that the first index is not multiple .
...
Eliminate references to datasetdefinition->type other than 1
as the dataset tables are just used by calculated that used type =1 i.e. LITERAL.
2008-12-01 04:00:54 +00:00
pichetp
0bddf4b6ac
Displacing <label> to enclose correctly answer text in question display
...
so no possible XML problem.
Cleaning comments
Better handling of empty responses when grading,
2008-11-29 15:02:27 +00:00
jamiesensei
2280e147c5
MDL-12418 "Item Analysis shows duplicate responses for Multiple Choice questions with LaTeX in answers" This problem was caused by the formatting of questions in get_actual_responses. Now formatting is done in response_summary rather than get_actual_response which returns an array of unformatted strings.
...
Have fixed the formatting in responses report and in statistics report to use the correct formatting for the question type.
Created new functions format_responses and format_response. format_responses works on an array and normally just walks through the array calling format_response.
2008-11-28 10:14:19 +00:00
tjhunt
f24493ec9b
random essay questions: MDL-8648 Allow essay questions to be selected by random question.
...
In the 1.9 branch this is controlled by a new option under Admin -> Experimental. In Moodle 2.0 dev it is not optional, it just works.
The main change is letting the manual grading report know which random questions might need manual grading. MDL-4004 - this depends on the random question under consideration, which requires a new questiontype method.
I also changed the random question code so that I could remove some global variables.
2008-11-28 06:07:11 +00:00
tjhunt
df4e224454
question bank: MDL-14434 Cannot edit the only question category in a context.
2008-11-27 11:50:29 +00:00
tjhunt
21cbf9da8b
question bank: MDL-17078 Error after deleting a question category.
2008-11-27 07:30:17 +00:00
tjhunt
16590517fa
fix notices: MDL-15974 Some systems that were upgraded have nullable columns, leading to notices
...
A new install has NOT NULL DEFAULT 0.
2008-11-27 05:12:11 +00:00
