Commit graph

160 commits

Author SHA1 Message Date
Andrew Nicols
b8b6bd7530 MDL-65536 mod_lti: JWT should use the class loader 2019-05-14 11:27:26 +08:00
Jake Dallimore
63dd2951bb MDL-65536 mod_lti: fix stale platformid when wwwroot is changed
If the site is installed, and then the wwwroot changed, the plugin
config value for platformid for mod_lti is then stale, resulting in
OIDC errors. Given this config value was set using the wwwroot, we
should just be able to use the value of $CFG->wwwroot direcly, thus
avoiding this problem.
2019-05-13 09:09:18 +08:00
Jake Dallimore
e61312afc9 MDL-62599 mod_lti: fix coding style issues 2019-05-08 11:16:21 +08:00
Mark Nelson
379536a3a2 MDL-62599 mod_lti: use moodle_url for config values 2019-05-06 13:48:12 +08:00
Stephen Vickers
878339017d MDL-62599 mod_lti: Correct documentation 2019-05-06 13:33:42 +08:00
Stephen Vickers
408cb8d64c MDL-62599 mod_lit: Missing end of function 2019-05-06 13:33:42 +08:00
Stephen Vickers
1bc7f99bf7 MDL-62599 mod_lti: Merge lti_convert_to_jwt and lti_sign_jwt 2019-05-06 13:33:42 +08:00
Stephen Vickers
f6662ae4de MDL-62599 mod_lti: Correct content-item return
Update method used to verify the JWT version of content-items being returned by a tool.
2019-05-06 13:33:42 +08:00
Stephen Vickers
a464331db2 MDL-62599 mod_lti: Revert service configuration parameters
Code to add configuration settings for LTI services reverted to current release code which injects them directly into the edit form.  This has the risk of name clashes and changes being made to elements not created by the service.
2019-05-06 13:33:42 +08:00
Stephen Vickers
8a8221f587 MDL-62599 mod_lti: Changes from integration review 2019-05-06 13:33:42 +08:00
Stephen Vickers
27cbb5965e MDL-62599 mod_lti: Add platform support for LTI 1.3 2019-05-06 13:33:42 +08:00
Stephen Vickers
1272a926d5
MDL-63176 enrol_lti: Add $COURSE to global
Ensure that capabilities using $COURSE can be parsed.
2018-08-16 22:41:57 +01:00
Claude Vervoort
da04fb70fa MDL-61651 mod_lti: cisr lineitem support 2018-04-20 11:22:11 +08:00
Jun Pataleta
1e09c9ac8f Merge branch 'MDL-61708-lti-fullnamedisplay' of https://github.com/wjroes/moodle 2018-04-16 15:29:08 +08:00
Claude Vervoort
c02324d96a MDL-60416 mod_lti: Introduced LTI Advantage
A huge thanks goes to 'Diego del Blanco' and
'Chris Lawson' for contributing much of their
code and time to this project, and to Cengage
for sponsoring it.

Much appreciated!
2018-04-09 12:08:35 +08:00
willem
fa979cd4e1 MDL-61708 mod_lti: use fullnamedisplay to pass lis_person_name_full
Students 'firstname lastname' was passed to LTI Provider as 
lis_person_name_full. Now changed to use fullnamedisplay.
2018-03-23 13:07:36 +01:00
cescobedo
adbf7c5a43 MDL-61576 mod_lti: remove allowinstructorcustom in lib/locallib.php 2018-03-22 09:59:30 +01:00
David Knuplesch
a2701db412 MDL-60415 mod_lti: avoid confusing error-message 2018-01-09 14:00:37 +08:00
Jun Pataleta
4b560e4a8e Merge branch 'mdl58817-master' of https://github.com/tlock/moodle 2017-11-22 13:24:30 +01:00
Jun Pataleta
4768fa336a Merge branch 'master_MDL-60253' of https://github.com/CengageEng/moodle 2017-11-20 13:21:30 +13:00
Tim Lock
a33be61af8 MDL-58817 mod_lti: cartridge: maintain custom icons 2017-11-13 10:15:33 +10:30
John Okely
672f483670 MDL-42834 admin: Removal of httpswwwroot 2017-10-23 12:25:36 +08:00
Andrew Nicols
544321235d Merge branch 'master_MDL-60276' of https://github.com/CengageEng/moodle 2017-10-11 09:38:47 +08:00
Eloy Lafuente (stronk7)
f8a86c157d Merge branch 'MDL-55358-master' of https://github.com/davidknu/moodle 2017-10-11 00:00:10 +02:00
ddelblanco
4325a4d23a MDL-60276 LTI Content Item: does not populate tool url when https 2017-09-28 09:54:35 -07:00
Vervoort, Claude
18ae59bea1 MDL-60253 lti: also consider securetoolurl for URL match 2017-09-27 13:26:42 -04:00
David Knuplesch
3b3535c7ea MDL-55358 mod_lti: Add group variable Moodle.Person.userGroupIds 2017-09-08 11:00:52 +02:00
David Knuplesch
3729ff0ff4 MDL-55358 mod_lti: Add LIS Group Variable 2017-09-06 11:27:17 +02:00
Ankit Agarwal
e4f7cfe19f MDL-59198 lti: Make params LTI2 compatible
LTI2 recommends to include both upper case and lower case of custom params.
This patch makes our implementation confer to that standard.
2017-08-29 11:42:09 +05:30
David Monllao
6d6b35fd24 Merge branch 'MDL-59485' of https://github.com/IMSGlobal/moodle 2017-07-25 11:11:09 +02:00
Andrew Nicols
21b0554d00 Merge branch 'MDL-59490' of https://github.com/spvickers/moodle 2017-07-24 12:42:34 +08:00
Stephen Vickers
1bd212e860 MDL-59490 mod_lti: Prevent text wrapping
Update html_to_text method calls with a width of zero.
2017-07-10 17:01:54 +01:00
David Monllao
bef9a71934 MDL-58851 lti: Fix undefined var PHP notice 2017-07-10 14:26:24 +02:00
Bryan Holladay
1aa11df72f MDL-58851 LTI module: Add LTI admin role capability
Adding a new 'mod/lti:admin' capability and passes the LTI admin role if the user has the 'mod/lti:admin' capability.
2017-07-10 08:19:48 -04:00
Stephen Vickers
d7d8db95e9 MDL-59485 mod_lti: Add missing capabilities
Capabilities missing which should allow Moodle to pass IMS certification
for LTI 2.0
2017-07-08 12:39:02 +01:00
Stephen Vickers
1768b85f09 MDL-58770 mod_lti: Strip HTML from parameters
Remove HTML tags from parameters which should be plain text.
2017-05-01 21:15:37 +01:00
Damyon Wiese
663640f5b3 MDL-40759 icons: convert uses of pix_url to pix_icon
Also change filepicker to use scaled svgs instead of sets of custom pngs. The svgs are taken from font-awesome.
2017-03-17 15:52:17 +08:00
Frederic Massart
6b7e523b5d
MDL-56182 mod_lti: Include the query string when comparing type URLs 2016-11-23 10:16:50 +08:00
Jun Pataleta
6c43d831f0 MDL-49609 mod_lti: Fixes for problems found in testing
* Load contentitem_return doc before processing
* Also use new AMD modal instead of the YUI one.
* Remove conversion of text columns in union queries
  - Since the value column in lti_types_config was changed to a
    text type, there is no need to use $DB->sql_compare_text()
    for the lti_types columns involved in the union queries in
    lti_get_type_config().
2016-09-29 11:13:50 +08:00
Jun Pataleta
c1fae2b928 MDL-49609 mod_lti: Refactor content-item and make it work using JS
* Rebase and resolve conflicts from initial patch.
* Reorganise contentitem and contentitem_return pages.
* Add capability checks for contentitem and contentitem_return pages.
* Move the building of Content-Item selection request to a local
  lib function.
* Move contentitem_return processing logic to a local lib function.
* Fix type settings update. Content-item checkbox does not get
  checked/unchecked on load.
* Fix  tool settings update. Disabled content-item checkbox gets unchecked when
  tool settings form is submitted.
* Add "Select content" button on load which launches the content item
  selection dialogue.
* Move hardcoded HTML and JS to mustache templates and AMD modules.
* Use standard YUI dialog for displaying the Content-Item selection page.
* Added processing for the following Content-Item properties:
  - text
  - icon
* On ContentItem selection, fill out form with the configuration data retrieved,
  instead of automatically saving the tool and redirecting to the course page.
* Removed section- and sectionreturn-related code since we're not automatically
  adding the tool on ContentItem selection.
* On mod_lti_mod_form, enable configuration fields if they support ContentItem
  selection.
* New form-field module for setting fields using JS
* Change types_config table's 'value' column from char(255) to text
2016-09-23 16:29:19 +08:00
spvickers
d8f9109a12 MDL-49609 mod_lti: Add Content-Item message
Added option for tools to support Content-Item message and redirect
to/from tool provider when creating an instance.
2016-09-18 22:16:10 +08:00
Mark Nielsen
123cc912ec MDL-55314 mod_lti: Several fixes to lti_load_cartridge
* Fixed XML loading when there is an error
* Fixed exception thrown by lti_load_cartridge
* By default, don't allow LTI mod generator to
  use a toolurl as that results in a cURL call.
2016-07-27 09:08:21 -07:00
Jun Pataleta
5c1b749d55 MDL-54877 mod_lti: Clean LTI tool type name and description on output
* Use clean_param() for name and description when displaying the tool type.
    Basically in the following functions:
    - serialise_tool_type()
    - lti_get_configured_types()
* Changed name and description's type from PARAM_TEXT to PARAM_RAW
    in tool update parameters.
* Changed name and description's type from PARAM_TEXT to PARAM_RAW
   in mod_lti_external::tool_type_return_structure()
2016-06-30 15:55:43 +08:00
Nicholas Hoobin
99a5377bb7 MDL-53788 mod_lti: fix aggressive course cache rebuilding 2016-06-15 10:42:27 +10:00
Jake Dallimore
c724c98829 MDL-54702 mod_lti: Support standard cartridge icons in LTI import 2016-06-01 09:49:10 +08:00
Marina Glancy
bff0a28894 MDL-54632 mod_lti: separate show as preconfigured and in activitychooser 2016-05-19 15:15:46 +08:00
Andrew Nicols
9dfee70f6b Merge branch 'MDL-53988-master-fix' of https://github.com/xow/moodle 2016-05-19 11:58:16 +08:00
John Okely
b1c8a860cb MDL-53988 mod_lti: Add language string for unactivated proxies 2016-05-19 11:55:17 +08:00
Andrew Nicols
367c85d78c Merge branch 'MDL-53988-master' of https://github.com/xow/moodle 2016-05-19 11:43:27 +08:00
John Okely
811d9ff941 MDL-53988 mod_lti: Fix followup up issues
Fix function naming
Fix param types
Fix error popping up twice with incorrect URL
Add confirm dialog when you delete a tool
Show orphaned tool proxies in list
Fix interface jumping up and down
Change to use notification stack
Change capabilities in db/services.php
Add loading animation after registering tool
Show loading animation until tools are rendered
2016-05-19 11:18:21 +08:00