martinlanghoff
9b277c0d80
lib/datalib.php [4/6] Make the get_records* family of functions use the
...
get_recordset* functions, instead of duplicating code.
Note: I've replaced the @deprecated tokens in phpdoc with an indication
that the get_records* calls are valid as convenience calls. The
get_recordset*() calls should be considered for performance and memory
footprint, but are not mandatory.
In a sense, deprecating get_records*() would mean a commitment to remove
them within X number of versions, which I am not sure we will do. Now,
if phpdoc has a @discouraged token, I'd like to hear about it ;-)
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
2006-01-16 06:17:38 +00:00
martinlanghoff
1184063286
lib/datalib.php [3/6] Move all instances of code that processes the
...
(..., $field1, $value1, $field2, $value2, $field3, $value3, ...)
part of argument lists to a common method, and improve the
comments relating to those arguments on calling methods.
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
2006-01-16 06:07:57 +00:00
martinlanghoff
0934b9def8
lib/datalib.php [2/6] Version of Martin Langhoff's patch to add the get_recordset_*
...
family of methods.
Author: Martin Langhoff <martin@catalyst.net.nz> && Tim Hunt <T.J.Hunt@open.ac.uk>
Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
2006-01-16 06:05:43 +00:00
martinlanghoff
d4c54cd6a6
lib/datalib.php [1/6] Remove unreachable code (break statements after returns in switches).
...
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
2006-01-16 06:04:09 +00:00
martinlanghoff
061fb2e7c3
datalib: teach moodle to pull an array from a column
...
the new get_fieldset_sql() gets around the nastiness in get_recordset()
that treats the first column as the unique key of the recordset. You can
now request a column from a table, or a set of values as a set of 1 field
records.
2006-01-16 03:07:23 +00:00
mjollnir_
fbcbd77c85
Fixing bug # 4567: warning in get_my_courses
2006-01-12 02:55:59 +00:00
patrickslee
0986271ba2
Moved the new functions added for Bug #4074 to datalib.php
2005-12-13 19:31:48 +00:00
patrickslee
7fb0fec757
Fixed courses and subcategories in an invisible category being visible (Bug #4074 )
...
This patch is different from the one form MOODLE_15_STABLE as it used the stored path in category data.
2005-12-13 04:05:04 +00:00
moodler
81532b92f2
Merged bug 4351 fix from stable
2005-11-19 15:39:31 +00:00
mjollnir_
1b4fe47b08
Merged from MOODLE_15_STABLE: Pulling in a missing global CFG in datalib:execute_sql (affects CFG->dblogerror)
2005-11-17 02:27:05 +00:00
moodler
fa22fd5fff
BIG FEATURE - MULTIPLE GROUPS
...
Users can now be assigned to multiple groups. Thanks Yu!
Break out the Bob Marley!!
Otherwise groups work more or less like they did before.
This has been pretty well tested by Yu and myself, but since Yu started
uncovering lots of existing groups bugs it's possible there may be still
a few corner cases still lurking here and there.
Please help test this thoroughly for 1.6!!
2005-11-08 07:19:27 +00:00
moodler
a2bed05944
Fix for bug 4242/4243. Optimize insert_record.
2005-10-31 06:25:17 +00:00
mjollnir_
3ec22e352c
Merged from MOODLE_15_STABLE: merging check_db_compat function for backwards compatability (just in case)
2005-09-01 00:28:45 +00:00
martinlanghoff
c54a59435c
Merged from MOODLE_15_STABLE - Long-pending rollback_sql()
2005-08-26 04:02:06 +00:00
mjollnir_
5b66416fe9
Merged from MOODLE_15_STABLE: Fixing another postgres problem. With distinct, you can't order by a field not in the select field list
2005-08-25 00:03:14 +00:00
mjollnir_
d5efb299de
Merged from MOODLE_15_STABLE: Fixing typo in postgres-fixing patch from a couple days ago
2005-08-24 23:48:12 +00:00
mjollnir_
c1147b7efe
merged from MOODLE_15_STABLE: Fixing a postgres error. You can't sort by a field that isn't in the select list when you have distinct
2005-08-17 23:17:05 +00:00
mjollnir_
f41ef63ee6
materialized path & depth for course categories.
2005-08-16 23:15:58 +00:00
patrickslee
7c56e42da0
Fixed a serious bug in table_column() that modified column not having NOT NULL for postgres (merged from 15_STABLE)
2005-08-11 23:52:11 +00:00
mjollnir_
5afa0de677
Merged from MOODLE_15_STABLE: When fetching child courses for a metacourse, order by shortname (unless just counting)
2005-08-11 04:24:57 +00:00
defacer
2ecdff7894
Merging from STABLE:
...
All this time, table_column() didn't handle CHAR fields correctly! :o
2005-07-20 17:47:05 +00:00
patrickslee
7a5b1fc555
Fixed when $cm is NULL, postgres still reports error.
2005-07-18 22:21:56 +00:00
dhawes
7290c7faf2
phpdoc work
2005-07-12 02:23:58 +00:00
skodak
9a4d45aea4
fixed bug 3606, thanks Ilshat Fattakhov; merged from MOODLE_15_STABLE
2005-07-10 17:32:03 +00:00
mjollnir_
10a760b9b2
Merged from MOODLE_15_STABLE: html_entity_decode segfaults in php 4.3.1 on an empty variable... documented in bug 3508. credit: Eloy & Jose Luis Daz
2005-06-16 02:58:24 +00:00
martinlanghoff
31df0bb83c
Merged from MOODLE_14_STABLE - Better DB errors debug traces from Patrick Li
2005-05-19 21:59:00 +00:00
martinlanghoff
9feb9a19d6
Typo in table_column() breaks field renaming under postgres -- credit for the patch goes to Patrick Li
2005-05-19 05:08:03 +00:00
mjollnir_
acd2279e54
Merged from MOODLE_14_STABLE: SQL errors are now (optionally -- defaults to off) logged to the apache error log. Helps debugging! Credit: Patrick Li <patrick@catalyst.net.nz>
2005-05-11 23:34:46 +00:00
paca70
9c8513599b
handle tinyints as integers when using postgresql
2005-04-27 19:24:48 +00:00
moodler
705a2aa45c
Reverting Jon's change
2005-04-22 06:24:57 +00:00
defacer
d290029084
Correcting the behavior of update_record.
...
Fixes bug 2776.
2005-04-22 03:43:09 +00:00
moodler
7c12949d10
Rationalised get_user_info_from_db() and sundry other small bits into
...
a single function called: get_complete_user_data()
This is to help shibboleth but will also help when this function
needs to be extended in future.
2005-04-17 12:08:46 +00:00
moodler
9b10b65bbf
Function get_group_teachers() added
2005-04-16 12:21:59 +00:00
thepurpleblob
11a052a652
Added function addslashes_object().
2005-04-11 12:29:17 +00:00
moodler
e84a246a55
FIxed a problem I wasn't seeing because I was in debug mode.
...
get_record_sql now has a second parameter that specifies when
we are expecting to take one record from many (to help with debugging)
2005-04-11 12:07:49 +00:00
thepurpleblob
8a7d9d15f2
Fixed some of the incomplete or incorrect function documentation comments.
2005-04-11 10:18:33 +00:00
moodler
5baa0ad6f2
Added update_timezone_records
2005-04-10 09:15:15 +00:00
martinlanghoff
853df85e56
Performance/footprint profiling patch complete -- is enabled by CFG->default>7 or by a few defines in your config.php.
2005-04-07 00:11:28 +00:00
mjollnir_
2eab06687a
Merged from MOODLE_14_STABLE: Fixing problem with set up of site course
2005-04-06 22:25:31 +00:00
mjollnir_
9921028a3d
Merged from MOODLE_14_STABLE: Fix for return id for insert_record - needs to be cast to an int
2005-04-03 21:04:02 +00:00
moodler
fcaff7ffcd
Updated formatting in getremoteaddr, and made add_to_log use it
2005-04-01 07:40:07 +00:00
moodler
f4cbf7f214
Just documentation / reformatting while reading the code :-)
2005-04-01 06:57:26 +00:00
martinlanghoff
455c36654f
Backed out unrelated block from last commit
2005-04-01 06:01:23 +00:00
martinlanghoff
a9a9bdba55
Merged from MOODLE_14_STABLE - insert_record() - major efficiency improvements for Postgres databases on insert. Also fixed many calls to insert_record() which discard the returned record id to not ask for the record id.
2005-04-01 05:55:10 +00:00
moodler
90d0ae4f76
DOn't reference soon-to-be-defunct deleted field
2005-03-31 08:34:27 +00:00
defacer
c2aa460fe6
Fix a notice when failing to log in.
2005-03-26 18:26:49 +00:00
martinlanghoff
f78b3c3405
Merged from MOODLE_14_STABLE - add_to_log() - fixed a postgres support bug when is set to '', and clarified the logic that decides whether to update the user_students/user_teacher records.
2005-03-23 07:07:47 +00:00
moodler
6078ba3016
Misc recent changes
2005-03-22 18:10:06 +00:00
moodler
d0d0cd9c7f
You can now specify fields to get_record
2005-03-10 14:13:26 +00:00
defacer
a0413b585d
New function for sql portability: sql_isnull().
...
NOTE: I don't know how this is supposed to be phrased in Postgres. Can
someone who does give a finger of help here? :)
2005-03-07 16:58:00 +00:00
