moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 08:56:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
56425 commits 37 branches 540 tags 1.3 GiB
Commit graph

2202 commits

Author SHA1 Message Date
Eloy Lafuente (stronk7)
0858993db8 Merge branch 'MDL-35792_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2013-01-07 22:36:29 +01:00
Didier Raboud
7db20e0073 MDL-37157: Normalize short answers before comparison 
This ensures that ambiguous Unicode representations can be compared sanely.
Also add some tests to ensure it keeps working.

Thanks to Tim Hunt for the syntax check.
 2013-01-07 14:00:26 +08:00
Tim Hunt
18651b0bfa MDL-37068 qformat_learnwise: fix UTF8 and other issues. 2012-12-22 15:15:20 +00:00
Thanh Le
5b8d9521ee MDL-35792 question preview: way to update options without restarting. 
It is useful, and possible, to update the display options without
restarting the question. You now only have to restart if you are
changing the maximum mark or the behaviour.
 2012-12-22 15:15:06 +00:00
Tim Hunt
c0267dc549 MDL-32245 question bank: update URL after moving question between categories. 
Also, improve the URL when you go to edit the questions in a category.
 2012-12-20 12:12:37 +13:00
Tim Hunt
c49b83bccc MDL-32245 question bank: fix coding style in categories.php 2012-12-15 10:07:09 +00:00
Thanh Le
99231022af MDL-32245 question bank: fix moving categories between contexts. 2012-12-15 10:07:08 +00:00
Dan Poltawski
7350e439bf Merge branch 'MDL-36243_23' of git://github.com/jmvedrine/moodle into MOODLE_23_STABLE 2012-12-11 16:24:34 +08:00
Dan Poltawski
3f358a021b Merge branch 'MDL-36025-negative-zero-MOODLE_23_STABLE' of git://github.com/mpetrowi/moodle into MOODLE_23_STABLE 2012-12-11 11:07:43 +08:00
Sam Hemelryk
2e6538382a Merge branch 'MDL-36942_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2012-12-11 15:04:17 +13:00
Dan Poltawski
b0473b9bf0 Merge branch 'MDL-36732_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2012-12-10 15:18:24 +08:00
Dan Poltawski
8ffe246d69 Merge branch 'MDL-35404_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2012-12-10 11:36:49 +08:00
Jean-Michel Vedrine
f62c457ece MDL-36243 question->questiontext and question->generalfeedback should always be strings 2012-12-08 20:47:32 +01:00
Tim Hunt
a0a83bd0bf MDL-36942 xml question import: don't add spaces. 
They are not necessary anyway, there is a \n character at the end of
each line.

Thanks to Richard Lobb for fining the problem and how to fix it.
 2012-11-30 15:53:30 +00:00
Tim Hunt
5d0f5f861d MDL-36732 Cloze qtype: review marks should not depend on feedback. 
The various review options should be independent.
 2012-11-30 15:52:14 +00:00
Tim Hunt
94215aa40d MDL-35404 question export: make it work with slasharguments off. 
Thanks to Brian King for working out the problem and how to fix it. I am
just committing his patch.
 2012-11-30 15:51:33 +00:00
Dan Poltawski
dceeeb29e0 MDL-36887 quiz: reorder upgrade.txt's 2012-11-30 11:44:33 +08:00
Tim Hunt
36ab57f922 MDL-36806 question files: fix unnecessary require_login call. 
quiz_question_pluginfile later does the correct check. Doing this
other check first means you get an error about changing $PAGE->context.
 2012-11-23 15:56:46 +00:00
Dan Poltawski
254d78b75f Merge branch 'MDL-36571_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2012-11-20 15:01:38 +08:00
Dan Poltawski
042a79870c Merge branch 'MDL-32865_23' of git://github.com/jmvedrine/moodle into MOODLE_23_STABLE 2012-11-20 12:05:46 +08:00
Tim Hunt
f88bd546eb MDL-36683 qtype match restore: better subq indentification. 
This is very similar to what MDL-30018 did for question_answers.
 2012-11-19 23:06:16 +00:00
Tim Hunt
4c1a35e34c MDL-36571 qtype multichoice: don't corrupt unicode characters. 
It seems that \s includes non-breaking space, and the typical one-byte
representation of that is the same as some parts of multibyte unicode
characters. Therefore, you need to include the u modifer on the regular
expressions.

Also, remove any number of <br /> at the end of the answer.

Thanks to Joseph Rézeau and Jean-Michel Vedrine for working out what the
problem was, and how to fix it.
 2012-11-19 18:20:38 +00:00
Jean-Michel Vedrine
58310f8845 MDL-32865 CLOZE Questions imported from another course end up with broken image links 2012-11-17 16:45:40 +01:00
Dan Poltawski
6211ff4c12 Merge branch 'MDL-36422-23' of git://github.com/FMCorz/moodle into MOODLE_23_STABLE 2012-11-08 11:08:06 +08:00
Frederic Massart
8a73556f8d MDL-36422 question: Fixed malformed HTML in manual marking 2012-11-08 10:26:44 +08:00
Sam Hemelryk
f9e009a744 MDL-21625 question: Fixed phpdocs 2012-11-05 16:29:38 +13:00
Sam Hemelryk
18f6238b88 Merge branch 'MDL-21625_b_m23' of git://github.com/rwijaya/moodle into MOODLE_23_STABLE 2012-11-05 16:27:30 +13:00
Matt Petro
2cae75aacc MDL-36025 qtype calculated: Fix handling of "-0" 2012-11-02 12:11:01 -04:00
Sam Hemelryk
1d6d520a5a Merge branch 'MDL-36076_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2012-10-30 12:59:12 +13:00
Nadav Kavalerchik
00c7657edf MDL-36033 - Left align Numeric value fields in Calculated and Numeric question, when in RTL mode 2012-10-19 10:24:46 +02:00
Rossiani Wijaya
d2d17341e8 MDL-21625 Question bank: Add accessibility to table layout for viewing question list 2012-10-19 13:32:11 +08:00
Tim Hunt
db05d59534 MDL-36076 qtype multichoice: validation fails on '0' answer. 2012-10-17 13:55:52 +08:00
Frederic Massart
ad87b3a2cc MDL-35858 question: Fixed display of feedback in cloze questions 2012-10-09 16:13:33 +08:00
Dan Poltawski
845cc02904 Merge branch 'MDL-34570-23' of git://github.com/FMCorz/moodle into MOODLE_23_STABLE 2012-10-02 13:57:00 +08:00
Dan Poltawski
d9cada0a9d Merge branch 'MDL-35370_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2012-10-02 12:09:36 +08:00
Dan Poltawski
d0154d2996 Merge branch 'MDL-35693_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2012-10-02 11:47:57 +08:00
Tim Hunt
0222cd9545 MDL-35693 question engine: set id when saving a new question_attempt 2012-09-28 15:29:57 +01:00
Frederic Massart
d3187c299a MDL-34570 Accessibility: Adding labels on text inputs and selects to questions 2012-09-28 11:39:32 +08:00
Rossiani Wijaya
daa3c5ff1b MDL-34570 accessibility compliance for question: edit string label 2012-09-28 11:39:32 +08:00
Tim Hunt
f0f2014316 MDL-35620 question engine: should distinguish NULL and 0. 
This only matters in an obscure edge case, but it is an edge case we hit
with one of the OU question types.

This load data code is processing the results of a LEFT JOIN, so is_null
is the correct logic.
 2012-09-27 12:35:55 +01:00
Tim Hunt
ad1a52e07c MDL-35370 cloze qtype: distinguish wrong & unanswered subqs 
This affects the subquestions that appear as an embedded text input box.

There are three cases:
1. Input for subq left blank
2. Input for subq was wrong, and matched by a * wildcard.
3. Input for subq was wrong, and did not match any answer.

2. and 3. should look identical, apart from any feedback in case 2.

1. is different. The state should be displayed as "Not answered" even
though the mark for this part is still shown as 0.

There are some new unit tests for these cases.

Also, we slighly improve handling of , for decimal point in multianswer,
although there are still issues.

While working on this, I made some minor clean-ups in shortanswer and
numerical qtypes.
 2012-09-27 12:35:35 +01:00
Eloy Lafuente (stronk7)
c59d51b67d Merge branch 'MDL-35419_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2012-09-18 01:28:46 +02:00
Eloy Lafuente (stronk7)
0f5c4b8397 Merge branch 'MDL-34841_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2012-09-18 01:15:31 +02:00
Tim Hunt
c21f901559 MDL-35419 question manual grading: valdiation must handle 0,5 
Yet another , as decimal separator issue!

To fix this nicely, I refactored some code into question_utils.
 2012-09-13 16:40:02 +01:00
Tim Hunt
5df0a6b47e MDL-34841 error importing questions with long names. 
The problem was with the non-UTF-8-safe way that a question name
was being constructed from the question text.

I have done a proper fix with methods in the base class to
carefully construct a question name that is reasonable, and
which will fit in the database column. Then I have changed all
importers to use the new methods.

I also remembered not to break the lesson in the process.
 2012-09-12 17:38:40 +01:00
David Mudrák
babf5f522e MDL-35272 Fix typo in qformat_blackboard_six.php 
Credit goes to German Valero for spotting and reporting this.
 2012-09-11 01:03:22 +02:00
Tim Hunt
817fcbb549 MDL-35343 JavaScript visible in multichoice choice feedback. 
Also, Match correct answer, and calculated multi and multianswer
feedback.
 2012-09-10 13:08:14 +01:00
Eloy Lafuente (stronk7)
2b567e3687 Merge branch 'MDL-27818_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2012-09-04 01:07:51 +02:00
Eloy Lafuente (stronk7)
8a716e2362 Merge branch 'MDL-33306_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2012-09-04 00:30:59 +02:00
Tim Hunt
5d22b22274 MDL-27818 question bank: multilang category names don't work. 2012-08-30 22:45:51 +01:00