Commit graph

27108 commits

Author SHA1 Message Date
Shamim Rezaie
0ad48a3e68 MDL-68148 core: remove cellspacing
The cellspacing attribute of <table> is not supported in HTML5.
So the removed line did not have any effect since ages ago.
2020-04-08 11:22:34 +10:00
Eloy Lafuente (stronk7)
f1f1497f04 Merge branch 'MDL-66357-master' of git://github.com/sarjona/moodle 2020-04-08 02:52:15 +02:00
Eloy Lafuente (stronk7)
2c50e08a3b Merge branch 'MDL-68286-master' of git://github.com/andrewnicols/moodle 2020-04-08 00:37:02 +02:00
Sara Arjona
b3f562176c Merge branch 'MDL-40081' of https://github.com/paulholden/moodle 2020-04-07 15:09:56 +02:00
Sara Arjona
55339ca9d0 Merge branch 'master_MDL-65700' of https://github.com/golenkovm/moodle 2020-04-07 13:34:01 +02:00
Mikhail Golenkov
3180869e19 MDL-65700 javascript: Add url-polyfill. 2020-04-07 20:54:46 +10:00
Brendan Heywood
c1f7368e57 MDL-47271 clilib: Add support for background colors 2020-04-07 12:30:27 +10:00
Andrew Nicols
c8eca1f642 Merge branch 'MDL-67818-check-api-fixes' of https://github.com/brendanheywood/moodle 2020-04-07 10:09:34 +08:00
Brendan Heywood
a28277697d MDL-67818 check: Rename renderer to be less generic 2020-04-07 12:07:42 +10:00
Sara Arjona
dad7f2ba1d Merge branch 'MDL-65539' of https://github.com/NeillM/moodle 2020-04-06 16:40:52 +02:00
Brendan Heywood
26bb3c24d2 MDL-67818 check: Improved Check API to reduce boilerplate 2020-04-06 22:08:15 +10:00
Paul Holden
abde761cb6 MDL-40081 completion: clean up criteria records for deleted courses. 2020-04-06 12:22:51 +01:00
Sara Arjona
43cda51ea1 Merge branch 'MDL-68233' of https://github.com/timhunt/moodle 2020-04-06 12:51:22 +02:00
Paul Holden
343380d9c8 MDL-67499 user: truncate long username/email during user deletion. 2020-04-06 11:48:27 +01:00
Paul Holden
b6ea0ef7ee MDL-68280 user: fix PHP notice for unknown user invalid login token. 2020-04-06 11:46:06 +01:00
Andrew Nicols
c52f3a3efa Merge branch 'MDL-68256' of https://github.com/timhunt/moodle 2020-04-06 15:05:41 +08:00
Brendan Heywood
00c2153be1 MDL-67818 check: Added Check API and refactored security checks
AMOS BEGIN
 MOV [check_noauth_details,report_security],[check_noauth_details,auth_none]
 MOV [check_noauth_error,report_security],[check_noauth_error,auth_none]
 MOV [check_noauth_name,report_security],[check_noauth_name,auth_none]
 MOV [check_noauth_ok,report_security],[check_noauth_ok,auth_none]
AMOS END
2020-04-06 12:28:37 +10:00
Eloy Lafuente (stronk7)
631d2ad7e2 MDL-68047 tcpdf: Prevent images out from cache to be removed
This corresponds to https://github.com/tecnickcom/TCPDF/pull/174
(and was fixed bycommit 510070b) and was a regression causing
image files to be removed unconditionally. Only if the images
are from cache, they can be removed.

It's fixed upstream in version 6.3.4 and up.
2020-04-06 00:29:55 +02:00
Ruslan Kabalin
52a268a09d MDL-68315 formslib: Fix completion attribute in course form element.
This fixes 'onlywithcompletion' attribute in course form element.
2020-04-03 20:33:38 +01:00
Andrew Nicols
c540a575db MDL-68286 table: Support initials bar for dynamic tables 2020-04-03 16:54:13 +08:00
Neill Magill
28ee72fd68 MDL-65539 dragdrop: Ignore drag proxy in keyboard menu
Before this change the node that is displayed during a the last mouse
drag and drop would be listed in a keyboard drag and drop if it was
the container node of one of the types of node being moved in this action.

If a node is inside a node with the .yui3-dd-proxy class then it is
one of the proxy elements used to display the dragged content during
mouse drag and drop so we will start ignoring it.
2020-04-03 08:36:37 +01:00
Neill Magill
b08323a789 MDL-65539 dragdrop: Allow sections and blocks to move to the top
Before this change sections and blocks could not be moved to be the
top item when using keyboard drag and drop.

They can now be moved to the top in one action.

The way they move using keyboard drag and drop has changed when they
are below the item they are dropped on, not instead of appearing
below it they will be placed above it.
2020-04-03 08:36:37 +01:00
Neill Magill
472c953093 MDL-65539 dragdrop: Allow direction detection when using keyboard
Before this change keyboard drag and drop could not detect the
direction of movement, this meant that an item would only be placed
below an item or at the top of a container item.

This change means that extending modules can declare
detectkeyboarddirection to true. This will mean that when an item is
moved it's position will be determined by the direction of travel as
it would be when dragging using the mouse.

If detectkeyboarddirection is true then:

* If you move an item upwards it will be placed before the item
  selected in the drop menu
* If you move a item downwards it will be placed after the item
  selected in the drop menu
* The item above the one being dragged will now be displayed on
  the drop menu

If detectkeyboarddirection is false there will be no change in
behaviour.
2020-04-03 08:36:37 +01:00
Sara Arjona
f958f5c19b MDL-66357 core_badges: remove mozilla backpack references
Mozilla backpack closed a few months ago. It was moved to Badgr.io
(as OBv1.0) but as we're also supporting Badgr.io OBv2.0, it
makes no sense to leave old references to Mozilla backpack there.
2020-04-03 08:09:55 +02:00
Andrew Nicols
1c112ac5fd MDL-68286 table: Empty tables need the dynamic table wrapper 2020-04-03 12:08:48 +08:00
Ferran Recio
d8c9c99001 MDL-67734 core_xapi: Fix MSSQL PHPUnit failure with duplicated id 2020-04-02 10:37:41 +02:00
Andrew Nicols
17f429ed57 Merge branch 'MDL-67734-andrewapocalipse' of git://github.com/ferranrecio/moodle 2020-04-02 09:30:54 +08:00
Jake Dallimore
1bfd325307 Merge branch 'MDL-68165' of https://github.com/stronk7/moodle 2020-04-02 08:42:45 +08:00
Eloy Lafuente (stronk7)
0ab2f5b506 Merge branch 'MDL-67914-master' of git://github.com/lameze/moodle 2020-04-01 23:41:38 +02:00
Eloy Lafuente (stronk7)
1172cd028d Merge branch 'MDL-68193_master' of git://github.com/mdjnelson/moodle 2020-04-01 23:22:25 +02:00
Mark Nelson
52f993651c MDL-68193 core: added new database_text_field_content_replaced event 2020-04-01 20:44:10 +02:00
Eloy Lafuente (stronk7)
1b7327c6d4 Merge branch 'MDL-68191' of git://github.com/timhunt/moodle 2020-04-01 20:18:25 +02:00
Ferran Recio
1d4c6f5355 MDL-67734 core_xapi: add xAPI statement support webservice 2020-04-01 14:14:39 +02:00
Jake Dallimore
f5609ea9d6 Merge branch 'MDL-67672-master' of git://github.com/lucaboesch/moodle 2020-04-01 16:43:03 +08:00
Sara Arjona
8afa7cca91 Merge branch 'MDL-68281' of https://github.com/stronk7/moodle 2020-04-01 09:25:04 +02:00
Simey Lameze
a020b02078 MDL-67914 core_table: unit tests for table view fetch webservice 2020-04-01 15:13:35 +08:00
Simey Lameze
1592c3c498 MDL-67914 core_table: implement dynamic table sorting 2020-04-01 15:13:31 +08:00
Luca Bösch
dfe22c29c2 MDL-67672 user: Display name in user menu as elsewhere. 2020-04-01 09:03:03 +02:00
Sara Arjona
afb0af9cf9 Merge branch 'MDL-45227-master' of git://github.com/rezaies/moodle 2020-03-31 19:23:01 +02:00
Sara Arjona
b835386512 Merge branch 'MDL-58964-master' of git://github.com/abias/moodle 2020-03-31 19:13:15 +02:00
Eloy Lafuente (stronk7)
a63a565a7c Merge branch 'MDL-68300' of https://github.com/timhunt/moodle 2020-03-31 18:16:53 +02:00
Tim Hunt
7459856d26 MDL-68300 questions: un-break duplicating questions without idnumbers
This was a regression caused by MDL-67934
2020-03-31 11:00:39 +01:00
Eloy Lafuente (stronk7)
2bb4e2d868 Merge branch 'MDL-68269-master' of git://github.com/rezaies/moodle 2020-03-30 22:53:33 +02:00
Shamim Rezaie
27d4e606de MDL-68269 form: fieldset in group elements should be full width 2020-03-30 18:29:23 +11:00
Andrew Nicols
6eb9705154 Merge branch 'MDL-52319-master-environmentxml' of git://github.com/mudrd8mz/moodle 2020-03-30 14:35:20 +08:00
Tim Hunt
19f221961e MDL-68233 renderers/block: fix reported coding style issues 2020-03-29 15:35:04 +01:00
Tim Hunt
1dcd0d3499 MDL-68233 renderers/block: remove illegal uses of $PAGE and $OUTPUT 2020-03-29 15:34:26 +01:00
Tim Hunt
6fdc0f8796 MDL-68256 task admin: usability improvements
In the table that lists the scheduled tasks:

1. There are badges to show which components are disabled.
2. The plugin name (e.g. auth_ldap) is shown as well as the
   human-readable name (e.g. LDAP server).
3. Where a time column has a non-default value, it is highlighted
   and the default is shown.
4. If the fail-delay is non-zero, the cell is highlighted.
4. If you just interacted with a task (looked at or edited the settings,
   did Run now, or cleared the fail delay) that row is highlighted,
   and scrolled into view when the page loads.

To support this, some of the methods for loading the default tasks
have been extended with an optional argument to leave 'R' as 'R'
rather than replacing with a random number.

Also, mixed into this commit are a bunch of coding style improvements.
Sorry I did not separate them out, but ultimately this makes the
Moodle code better.
2020-03-28 18:40:51 +00:00
Eloy Lafuente (stronk7)
1ee1ce36d6 MDL-68281 unit test: Include required class
Also, add missing line break, that I did not see 1 week ago.
2020-03-28 16:23:34 +01:00
Eloy Lafuente (stronk7)
6335ed82c2 MDL-68165 install: update the list of stale files for 3.9 2020-03-27 12:57:22 +01:00