moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-08 02:16:41 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
34593 commits 37 branches 540 tags 1.3 GiB
Commit graph

2041 commits

Author SHA1 Message Date
jamiesensei
f522bf51be MDL-14988 "tables have been hardcoded with a prefix of "mdl" - causing an error." Ooops! 2008-05-26 12:51:04 +00:00
jamiesensei
686e602047 MDL-12824 "Essay type of quiz questions needs to color mark which students have been graded and which have NOT" 
As well as highlighting graded questions with a new CSS class highlightgraded which is a yellow bg in the standard theme, have also added the option to grade all ungraded attempts for a question.
 2008-05-26 12:47:42 +00:00
jamiesensei
720be6f2c3 MDL-5241 "When manually grading, identity questions by their number within the quiz as well as by question name" 
Also added a drop down box to select question to mark instead of the viewquestions table. The drop down box is available at the top of every page, but only if there is more than one manually gradeable question in the quiz. If there is only one question it is automatically selected for marking.

Also added a new constant QUESTION_EVENTS_GRADED during a general refactoring of UI code in grading report and some improvements to efficiency of SQL in report.

Merged from Moodle 1.9 branch
 2008-05-26 11:39:51 +00:00
jamiesensei
a59eb2b6a8 MDL-12547 "allow manual quiz grading to sort by groups" added code to select which group to grade. 
Merged from Moodle 1.9 branch
 2008-05-23 13:14:00 +00:00
tjhunt
95de57b8ac Inconsistency between quiz attempt->id and attempt.uniqueid 2008-05-21 11:10:06 +00:00
jamiesensei
b392a56cab MDL-14844 "Quiz Report: Bar Graph doesn't displayed maximum grade" Now using php ceil function to round up $bands as in some cases it could be a non integer. 2008-05-16 14:56:23 +00:00
skodak
f33e1ed4ae MDL-14679 ok, here is the big patch with new dmllib and ddlib API, some code is already converted, XML db editor works; see tracker for details of regressions and TODOs 2008-05-15 21:40:00 +00:00
tjhunt
994c8c3509 MDL-14835 - Grade not checked against valid range when manua grading 2008-05-15 16:02:12 +00:00
tjhunt
9c22b42ef7 MDL-14857 - Clean up summary table generation code at the top of the quiz review page - This is basically a merge of improvements we made at the OU. 2008-05-15 15:32:43 +00:00
jamiesensei
ca35974827 MDL-14852 "improve sql in overview report for fetching question grades" moved all querying for question grades into main attempts sql query. AND MDL-14200 "Add group and course averages" some fixes for functionality to display question grades averages. Grade averages are not displayed when grading method is set to Average - as this cannot be done in sql and would be expensive to do in memory. 
merged from 1.9 branch
 2008-05-15 13:59:52 +00:00
jamiesensei
e649d4b120 MDL-14200 "Add group and course averages" fix for bug introduced in this patch. We are now using a seperate sql command to get the feedback text as we need to get it for the average rows too. Since it is not part of the sql to fetch attempt data we can't sort on Feedback anymore so removed the option from the table. Sorting by feedbacktext is not really useful anyway, users are more likely to want to sort by grade. 
Merged from 1.9 branch.
 2008-05-15 12:54:01 +00:00
jamiesensei
aad5b0fca9 MDL-14200 "Add group and course averages" added extra rows to the end of the table in quiz overview report also MDL-14187 "Improve tablelib - improve api and add functionality to download table contents in a variety of formats - XLS, ODS and CSV" implemented the first of my proposals for improving tablelib. Added a extra method to use keyed arrays to add a row to a table. Seems obvious that this is an improvement to tablelib and it is an addition to the API so won't affect existing code. 
Merged from 1.9 branch.
 2008-05-15 12:27:27 +00:00
jamiesensei
a568653185 MDL-14844 "Quiz Report: Bar Graph doesn't displayed maximum grade" added perfect grade to last 'band' on graph. 2008-05-15 11:01:23 +00:00
jamiesensei
c187720b74 MDL-14201 "Summary graph" - small improvement to robustness for sql. 
Merged from 1.9 branch.
 2008-05-14 11:18:04 +00:00
jamiesensei
7d4d5cb918 MDL-14822 "Quiz Report: the quiz report do not find the first attempt" needed to include quiz id in WHERE conditions. 
merged from 1.9 branch.
 2008-05-14 09:17:09 +00:00
jamiesensei
51ca9f3095 MDL-14201 Summary graph in Overview Report - needed a little more spacing between bars of graph in some cases. 
Merged from 1.9 stable branch.
 2008-05-13 15:05:35 +00:00
jamiesensei
c5fedf065c MDL-14223 "Add a column for the user's idnumber, controllable by a site-wide setting" and MDL-14224 "Add a site-wide setting to hide the user profile image from quiz reports" 
The quiz overview report now respect the settings for the gradebook - whether to display idnumbers and user pictures.

Also re-factored the code to build table / download content a little to reduce code duplication.
 2008-05-09 13:59:36 +00:00
jamiesensei
44eb3b6e9e For the overview report : MDL-14199 "Option to only show / export final grade" small improvement to UI. Include highlighted message in the form about what the current grading method is. 
Merged from 1.9 branch.
 2008-05-08 09:53:31 +00:00
jamiesensei
b621e1a006 MDL-14198 "Make it clear which student attempt gives the final grade, if the scoring method is first, last or highest score" adding a message about the highlighting above the table. 
Merged from 1.9 branch.
 2008-05-08 09:35:08 +00:00
jamiesensei
2fecd85ba6 MDL-14734 "improve interface for deleting attempts" 
* The control for deleting attempts is a drop down box with onchange javascript to submit the form, you cannot see the label to say what the drop down box does. Better to use a button. The button label is visible so you can see what it does.
* Checkboxes should be displayed when there is no attempt to delete.
* The whole column for checkboxes should be removed when no attempts are displayed ie. when showing students with no attempts.
 2008-05-07 16:00:56 +00:00
jamiesensei
8b87ab0000 MDL-14201 "Summary graph" included a summary graph at the bottom of overview report page. Shows the distribution of grades achieved by students. If a group is selected the grades from the group are compared with the grades for all participants. 2008-05-07 14:38:18 +00:00
jamiesensei
9b617d9210 For the overview report : MDL-14199 "Option to only show / export final grade" fixing a notice warning from the form definition 2008-05-07 14:01:04 +00:00
scyrma
59fa45d0f1 MDL-11113: simplify the code - use only one function to check for html editor availability 2008-05-07 07:40:50 +00:00
jamiesensei
f4ed09faae For the overview report : MDL-14199 "Option to only show / export final grade" and MDL-14198 "Make it clear which student attempt gives the final grade, if the scoring method is first, last or highest score" fixed a small problem I noticed in this patch. 2008-05-06 18:04:03 +00:00
jamiesensei
4469159e2d For the overview report : MDL-14199 "Option to only show / export final grade" and MDL-14198 "Make it clear which student attempt gives the final grade, if the scoring method is first, last or highest score" 2008-05-06 17:34:39 +00:00
jamiesensei
0217f93275 For overview report - MDL-14185 "Switch to using formslib and improve the interface" and MDL-14186 "Switch to using moodle_url and eliminate the use of $SESSION global" 2008-05-05 13:12:11 +00:00
jamiesensei
1a85336b79 non consequential, little typo. 2008-05-03 13:56:32 +00:00
jamiesensei
2badf2e6ec MDL-14677 "should rescale the grades displayed for each question in the detailed marks view of the overview report so that all grades add up to the sum total grade" used quiz_rescale_grades function to rescale the grade properly before displaying it. Also this patch includes some general clean up and refactoring of overview report. 2008-05-03 13:06:49 +00:00
jamiesensei
e49906d3b1 MDL-14666 "overview report is very inefficient when view detailed marks is selected. There are several sql queries per row." 2008-05-02 15:26:47 +00:00
jamiesensei
92c5499a84 MDL-14666 "overview report is very inefficient when view detailed marks is selected. There are several sql queries per row." Made a new query outside the loop for adding rows. 2008-05-02 15:11:59 +00:00
jamiesensei
e0b01669ce MDL-14664 "sorting by question mark when viewing detailled mark in overview quiz report not working" Found that the problem ocurred when attempt.id != attempt.uniqueid as the sql was using the wrong field to join the question records. 2008-05-02 14:21:33 +00:00
jamiesensei
85a8704fe2 MDL-14663 "link_to_popup_window displays 'Click here....' as the link text if you pass in 0 as the link text." 
Solved this by formatting the grade using number_format to display the grade with a number of decimal places. So for 0 we display something like 0.00 and this displays OK in link_to_popup_window.
 2008-05-02 13:27:49 +00:00
jamiesensei
f33c438e5c MDL-13678 "Change default number of rows per page on quiz reports" Made a new constant to say how many attempts / questions to list per page by default. 2008-05-01 07:08:28 +00:00
jamiesensei
2018fb15ae MDL-7772 "Quiz results overview: not all combinations of Show attempts with ... & Groups settings work properly" 
Second patch, found a bug while merging and testing in 1.9.
 2008-04-30 08:22:20 +00:00
jamiesensei
86a1f1d5b9 MDL-7772 "Quiz results overview: not all combinations of Show attempts with ... & Groups settings work properly" 
This patch is based on Ann Adamcik's latest code, thanks Ann. Made a couple of small changes.
 2008-04-30 04:47:39 +00:00
tjhunt
3192d014f3 Eliminate direct references to $_REQUEST and $_POST in the quiz code. 
Also, when you edit the quiz, and therefore any preview attempts are deleted automatically, make sure the attempts are deleted properly by calling quiz_delete_attempt on each one, rathern than leaving orphaned junk in the database.
 2008-04-23 14:49:22 +00:00
tjhunt
bfecee473a Revert bogus error -> print_error changes that were stopping my patch from merging. 2008-04-23 14:45:45 +00:00
tjhunt
97344ae331 Improve PHPdocs on a function. 2008-04-23 14:31:21 +00:00
tjhunt
d20e702956 Tidy up whitespace. 2008-04-23 10:54:51 +00:00
jamiesensei
58ffdbb883 MDL-14471 - when attempt data is generated by a script then sometimes quiz_get_latest_attempt_by_user fetches the wrong attempt since timestart for the attempt is not a second apart from the last attempt - "patch to quiz/locallib.php function quiz_get_latest_attempt_by_user which makes the query simpler and also makes it more robust. 
In the case that there are two attempts started in the same second, which can happen if you are generating random attempt data then the id field is used to tell which is the later attempt."
 2008-04-23 06:45:11 +00:00
tjhunt
44847eb868 MDL-14363 - Fix a broken redirect from mod/quiz/ attempt.php to edit.php when the quiz has not questions. 
Also, when the quiz has no questions, disable the Info, Reports and Preview tabs, which, in this case, just redirect back to the Edit tab anyway.

Finally, change a redirect in quiz view.php, which used a relative URL, to a full url starting $CFG->wwwroot.
 2008-04-22 15:19:50 +00:00
tjhunt
92589cb04b MDL-8682 - yet another followup. The javascript still was not quite right. you cannot rely on the case of element.nodeName. 2008-04-17 13:07:36 +00:00
moodler
9aa82ed6d4 MDL-14399 Merged RTL fixes from 1.9 2008-04-17 08:50:56 +00:00
tjhunt
c711a7aeab MDL-14391 - Timestart shown twice in quiz overview report, instead of timefinish 2008-04-16 14:39:37 +00:00
jamiesensei
e89e09d21d MDL-14283 attempt in mdl_question_states is always 1 - typo in attempt.php introduced in Tim's access rules refactor meant that attempt in quiz_attempts table was always set to 1. This meant that only one attempt was shown on the quiz/view.php page as well as causing other problems. 2008-04-09 13:01:40 +00:00
dongsheng
5a2a53316f MDL-14129, remove all the other error() call 2008-04-04 02:54:20 +00:00
tjhunt
20b8b489ec MDL-8682 - the last commit caused a regression that stopped it working. 
!something==somethingelse

is not the same as

something!==somethingelse

in javascript, it seems.
 2008-03-31 15:07:14 +00:00
tjhunt
44266ca4ef MDL-13806 - supplimental - bug fixes to the previous commit. 2008-03-25 19:40:42 +00:00
tjhunt
d45459b7c1 MDL-13978 - Notice when adding a new quiz 2008-03-19 12:21:56 +00:00
pichetp
0410e50698 MDL-12572 splitting code and create get_questions_atttempts_data function 
improve CVS, XLS and ODS downloads so that data is easily sort.
 2008-03-17 14:21:20 +00:00