Commit graph

24321 commits

Author SHA1 Message Date
Mark Johnson
7f9e7f2982 MDL-68093 feedback: Add behat tests for non-participation groups 2023-03-14 08:52:26 +00:00
Mark Johnson
8932fe55e5 MDL-68093 data: Add behat tests for groups 2023-03-14 08:52:26 +00:00
Mark Johnson
02f7e2d37b MDL-68093 choice: Add behat tests for groups 2023-03-14 08:52:26 +00:00
Mark Johnson
dfa5310b80 MDL-68093 chat: Add behat tests for groups 2023-03-14 08:52:26 +00:00
Mark Johnson
eb1aab3437 MDL-68093 bigbluebutton: Add behat tests for non-participation groups 2023-03-14 08:52:26 +00:00
Mark Johnson
0775756551 MDL-68093 assign: Restrict group submission to participation groups 2023-03-14 08:52:26 +00:00
Mark Johnson
958da5b67e MDL-68093 groups: Add visibility and participation settings
These new settings are designed to enchance user privacy surrounding
groups. They allow groups to be configured so that users outside the
group cannot see the group, so that users in the group cannot see each
other, or so that users cannot see the group at all, even if they are in
it. This avoids issues where a group may be assigned based on sensitive
personal information (such as a person requiring special arrangements
due to a disability).

By default, groups are visible to all and available for participation in
activities, which maintains the current behaviour.

For performance, a new cache has been added to track the number of
groups on a course that are not visible to non-members. This allows us
to revert to the existing behaviour if the new features are not being
used at all on a course, and only apply the new visibility conditions if
they are.

Users who have the moodle/course:viewhiddengroups capability should be
concious of exposing hidden groups when showing their screen to other
users. The "Switch role to..." feature can be used to show a course page
on screen without exposing private availability conditions, for example.

The changes cover several specific areas:
* grouplib functions, which most code should use to get lists of groups
  and members (this includes the participants page).
* Activities supporting group overrides will not allow overrides for
  groups that are hidden from all users.
* Activities supporting separate/visible groups modes will only allow
  groups with the new "participation" flag enabled to be selected.
* Group messaging will be disabled for groups where members cannot see
  each other, or cannot see the group at all.
2023-03-14 08:52:25 +00:00
danghieu1407
b875ecdcc4 MDL-77419 Quiz: question/qengine.js tidy-up 2023-03-14 10:26:46 +07:00
Andrew Nicols
fdb1df2bfd MDL-76867 core: Add plugintype_supports_disabling to plugininfo 2023-03-14 08:34:42 +08:00
Andrew Nicols
6809289cf4 MDL-76867 core: Plugintype coding style fixes 2023-03-14 08:34:42 +08:00
Andrew Nicols
9ec46c232d MDL-77186 core: Move all uses of cronlib to new class 2023-03-13 21:21:13 +08:00
Paul Holden
3cb70de95f
MDL-77608 mod_h5pactivity: namespace component lib testcase. 2023-03-13 09:36:40 +00:00
Laurent David
301c56ae1d MDL-77275 mod_data: Template reset button changes
* Remove the reset button in the sticky footer (template page)
* Add the reset button action in the Action menu
2023-03-13 07:35:44 +01:00
Andrew Nicols
b038d8ff3c Merge branch 'MDL-77582-master' of https://github.com/sarjona/moodle 2023-03-10 12:19:17 +08:00
Jun Pataleta
5896d29905 Merge branch 'MDL-76603-master' of https://github.com/junpataleta/moodle 2023-03-10 10:15:12 +08:00
Shamim Rezaie
48b7dc597b MDL-76603 mod_assign: Move advanced grading grades out of the tables 2023-03-10 10:08:42 +08:00
Jun Pataleta
7063f9c17f Merge branch 'MDL-70613' of https://github.com/paulholden/moodle 2023-03-10 09:19:55 +08:00
Paul Holden
1218a03850
MDL-70613 mod_feedback: cast feedback text values for table sorting.
Specifically avoids Oracle ORA-00932 (inconsistent CLOB datatype).
2023-03-09 14:59:05 +00:00
Andrew Nicols
43f5bfdbe4 Merge branch 'MDL-76970-master' of https://github.com/laurentdavid/moodle 2023-03-09 22:22:32 +08:00
Andrew Nicols
4330efc85f Merge branch 'MDL-77463-master' of https://github.com/andelacruz/moodle 2023-03-09 22:09:41 +08:00
Sara Arjona
6c6adc462c MDL-77582 mod_quiz: Fix view_url() on null error 2023-03-09 13:57:41 +01:00
Jun Pataleta
8441270181 Merge branch 'MDL-77559-master-2' of https://github.com/andrewnicols/moodle 2023-03-09 16:02:01 +08:00
Andrew Nicols
8edff671b5 Merge branch 'MDL-77418' of https://github.com/paulholden/moodle 2023-03-09 10:35:16 +08:00
Andrew Nicols
511401f4f6 MDL-77559 js: Rebuild all JS with Node 16 2023-03-09 09:53:19 +08:00
Andrew Nicols
1e4a2f5dc8 MDL-77559 js: Revert "MDL-75012 js: Remove orphaned source maps"
This reverts commit baef734ef7.
2023-03-09 08:19:24 +08:00
Sara Arjona
7b6a00dec4 Merge branch 'MDL-77464' of https://github.com/timhunt/moodle 2023-03-08 16:14:40 +01:00
Ilya Tregubov
ce3fd6a75d Merge branch 'MDL-77414-master' of https://github.com/andelacruz/moodle 2023-03-08 17:04:32 +08:00
Laurent David
f5d0b197f8 MDL-76970 mod_forum: Login prompt for guest users
* When user submit to a forum as an anonymous user, the login prompt
should clearly explain the follow up actions.
2023-03-08 07:50:35 +01:00
Andrew Nicols
974d7e4dab Merge branch 'MDL-52805-42' of https://github.com/Chocolate-lightning/moodle 2023-03-08 14:49:59 +08:00
Angelia Dela Cruz
0612c6f8a5 MDL-77414 Behat: Coverage for "Require all group members submit" setting 2023-03-08 14:44:45 +08:00
Sara Arjona
022acf037b Merge branch 'MDL-77440' of https://github.com/timhunt/moodle 2023-03-08 07:23:35 +01:00
Angelia Dela Cruz
d1c03c435c MDL-77463 Behat: Coverage for assign submission notification to teacher 2023-03-08 14:11:10 +08:00
Michael Hawkins
493205b6b2 MDL-77204 mod_wiki: Clean filename in Moodle1 backup 2023-03-08 10:33:14 +08:00
Ilya Tregubov
bb69388f82 Merge branch 'MDL-77446-master' of https://github.com/andelacruz/moodle 2023-03-08 09:18:13 +08:00
Paul Holden
355556c05f MDL-77008 mod_data: require sesskey to reset module templates. 2023-03-08 00:54:14 +00:00
Jun Pataleta
85718f00d8 Merge branch 'MDL-77416-master-enfix' of https://github.com/vmdef/moodle 2023-03-08 08:50:30 +08:00
Dani Palou
aba460cec9 MDL-77550 lesson: Format decimals in feedback page 2023-03-07 15:56:26 +01:00
Tim Hunt
1a3897d1ba MDL-77464 questions: regrading was losing question_attempt metadata
This is very similar to MDL-77090, but at the time, I missed that this
also needed to be handled. (Question metadata is, I think, only used
by the quiz 'Try another question like this one' feature.)
2023-03-07 13:40:10 +00:00
Angelia Dela Cruz
76ce84befb MDL-77446 Behat: Add coverage for changing uploaded file details 2023-03-07 16:08:12 +08:00
Mathew May
33ebbddde2 MDL-52805 core: Remove legacy log plugin and more calls 2023-03-07 13:08:46 +08:00
Mathew May
5dace7abc8 MDL-52805 core: Plugins with removed tests due to old events 2023-03-07 13:08:46 +08:00
Mathew May
e5ca7766e7 MDL-52805 core: Remove legacy log calls 2023-03-07 13:08:46 +08:00
Andrew Nicols
565a615308 Merge branch 'MDL-77094' of https://github.com/timhunt/moodle 2023-03-07 12:08:58 +08:00
Andrew Nicols
be76699b78 Merge branch 'MDL-77345-master' of https://github.com/meirzamoodle/moodle 2023-03-07 11:29:23 +08:00
Sara Arjona
c282cec66c Merge branch 'MDL-77460-master' of https://github.com/lameze/moodle 2023-03-06 16:33:53 +01:00
Meirza
210b1ea87b MDL-77345 mod_wiki: Added missing class properties.
In PHP 8.2 and later, setting a value to an undeclared class property is
deprecated and emits a deprecation notice.
So we need to add missing class properties that still need to be declared.
2023-03-06 10:44:04 +07:00
Víctor Déniz
6a9f78b0e7 MDL-77416 lang: Use fixed strings in tests 2023-03-03 14:15:30 +00:00
Helen Foster
2e99dd6346 MDL-77416 lang: Import fixed English strings (en_fix) 2023-03-03 14:02:06 +00:00
Jun Pataleta
3f223172c6 Merge branch 'MDL-77428-master' of https://github.com/andelacruz/moodle 2023-03-03 16:35:22 +08:00
Laurent David
b318fa7320 MDL-76339 mod_bigbluebuttonbn: Update dismissed recordings
* When the server is not reachable (or recordings are not reacheable)
the recording is set to RECORDING_STATUS_DISMISSED and is then
not visible in the list.
* Add a CLI script to solve potential issue with DISMISSED recordings
2023-03-03 05:48:53 +01:00