Commit graph

87 commits

Author SHA1 Message Date
David Monllao
55c3845c23 MDL-59095 analytics: Update to use feedback_viewed API
Part of MDL-57791 epic.
2017-07-24 08:36:47 +02:00
Ankit Agarwal
5846c72c4d MDL-59117 core_analytics: Move all indicators to respective modules
Part of MDL-57791 epic.
2017-07-24 08:36:21 +02:00
Eloy Lafuente (stronk7)
736973d604 Merge branch 'wip-MDL-58523-master' of git://github.com/marinaglancy/moodle 2017-06-14 12:32:03 +01:00
Marina Glancy
c3c97e2ee2 MDL-58523 mod_feedback: deleting response should reset completion 2017-06-13 14:35:08 +08:00
Juan Leyva
7c3c0fa323 MDL-59132 mod_feedback: Fix anonymous responses numbering
This was done correctly by the web scrip but not by the WS.
2017-06-08 11:14:45 +01:00
Dan Poltawski
c201e4df40 Merge branch 'MDL-58772' of git://github.com/aolley/moodle 2017-05-03 16:50:29 +01:00
Adam Olley
0fb1335924 MDL-58772 mod_feedback: Dont overwrite anonymous entries
The feedback module lets you alternate between responses being anonymised and
not anonymised. When the module is in anonymous mode, its possible for a single
user to make multiple responses.

However when the activity is switched to non-anon mode, if a user leaves a
follow up feedback, one of their previously anonymous responses is used, so
their new response stays anonymous and their old anon response is lost.

This change lets them leave a new non-anonymised feedback entry and retains all
previous anonymous responses instead of incorrectly reusing one of their anon
ones at random.
2017-05-02 12:49:33 +09:30
Marina Glancy
aa708b550e MDL-58665 mod_feedback: avoid extra db queries on dashboard 2017-05-01 12:57:19 +08:00
Jake Dallimore
d8f9177462 Merge branch 'MDL-58412-master' of git://github.com/jleyva/moodle 2017-04-20 09:56:10 +08:00
Dan Poltawski
9c1889810a Merge branch 'wip-MDL-58502-master' of git://github.com/marinaglancy/moodle 2017-04-18 19:48:35 +01:00
Eloy Lafuente (stronk7)
ad02561c15 Merge branch 'MDL-58453-master' of git://github.com/jleyva/moodle 2017-04-11 16:47:29 +02:00
Juan Leyva
7f700290b2 MDL-58453 mod_feedback: Add missing security checks
Some checks done in mod/feedback/show_nonrespondents.php were missing.
- Check for anonymous feedback
- Check for real courses (not site home)
2017-04-11 09:42:27 +01:00
David Monllao
fff1b3c464 Merge branch 'wip-MDL-55950-master' of git://github.com/marinaglancy/moodle 2017-04-10 16:05:07 +02:00
David Monllao
af938cf46e Merge branch 'wip-MDL-56370-master' of git://github.com/marinaglancy/moodle 2017-04-10 13:13:20 +02:00
Andrew Nicols
b140b13c25 Merge branch 'MDL-58453-master' of git://github.com/jleyva/moodle 2017-04-10 11:23:37 +08:00
Marina Glancy
d6f77a435f MDL-56370 mod_feedback: allow to restore values from last attempt 2017-04-07 16:04:06 +08:00
Marina Glancy
d0b4c8a787 MDL-55950 mod_feedback: correct link to response in the email 2017-04-07 16:03:42 +08:00
Marina Glancy
f4dba1755c MDL-58502 mod_feedback: courseid is not course where feedback is 2017-04-07 16:02:39 +08:00
Juan Leyva
94478c083d MDL-57813 mod_feedback: New WS mod_feedback_get_last_completed 2017-04-06 09:40:26 +02:00
Juan Leyva
682aea9b84 MDL-58453 mod_feedback: Refactor get_non_respondents WS
We should return more information like if the user started or not the
feedback and the total number of non respondents (to be able to
paginate).
2017-04-05 09:28:29 +02:00
Juan Leyva
007b7cad82 MDL-57813 mod_feedback: Create exporter and required API changes 2017-04-05 09:07:43 +02:00
Juan Leyva
a24289f12f MDL-57821 mod_feedback: New WS mod_feedback_get_responses_analysis 2017-04-04 12:01:23 +02:00
Juan Leyva
495745a36e MDL-57821 mod_feedback: Allow export tables to external structure 2017-04-04 12:01:22 +02:00
Andrew Nicols
6e1523c38b MDL-57822 feedback: Correct page param for nonrespondents WS 2017-03-29 11:20:57 +08:00
Juan Leyva
bb66bc4a89 MDL-57822 mod_feedback: New WS mod_feedback_get_non_respondents 2017-03-28 22:52:03 +02:00
Juan Leyva
52f57996f4 MDL-58230 mod_feedback: New WS mod_feedback_get_finished_responses 2017-03-28 22:50:36 +02:00
Juan Leyva
2b2a0319a0 MDL-58412 mod_feedback: Handle array parameters
We should handle array parameters for multi choice (multi select) .
2017-03-28 10:13:26 +02:00
Juan Leyva
592306c60b MDL-58412 mod_feedback: Always set gonextpage when moving forward
In some cases the last page will be omitted in a feedback (for example
when using dependent questions).
Because of that the save process will be launched in a page that is not
the last.
2017-03-28 10:05:56 +02:00
Juan Leyva
1b0b4ab25f MDL-58412 mod_feedback: Add default value for responses
In some cases we will be processing pages without responses, like a
page introduction with a label.
2017-03-28 10:01:25 +02:00
Juan Leyva
8e11464fd6 MDL-58412 mod_feedback: Remove access control in get_items
This function it is used for printing the list of questions.
The feedback preview doesn’t have any access restriction, you can see
the list of questions at any time.
2017-03-28 09:58:47 +02:00
Juan Leyva
ac9f0a6800 MDL-58229 mod_feedback: New WS get_unfinished_responses 2017-03-21 13:21:32 +01:00
Juan Leyva
82b2cd7d19 MDL-57820 mod_feedback: New WS mod_feedback_get_analysis 2017-03-21 13:12:35 +01:00
Juan Leyva
82a7a67869 MDL-57818 mod_feedback: New WS mod_feedback_process_page 2017-03-21 12:25:32 +01:00
Juan Leyva
96ae31bddc MDL-57818 mod_feedback: Refactor form processing 2017-03-21 12:24:41 +01:00
Juan Leyva
74975948e5 MDL-57817 mod_feedback: New WS mod_feedback_get_page_items 2017-03-21 11:33:55 +01:00
Juan Leyva
951ddedf6f MDL-57816 mod_feedback: New WS mod_feedback_launch_feedback 2017-03-21 11:22:13 +01:00
Eloy Lafuente (stronk7)
592cdff297 Merge branch 'MDL-57815-master' of git://github.com/jleyva/moodle 2017-03-21 00:48:44 +01:00
Eloy Lafuente (stronk7)
beff62f6ec Merge branch 'MDL-57814-master' of git://github.com/jleyva/moodle 2017-03-20 18:00:48 +01:00
Eloy Lafuente (stronk7)
d8c8082998 Merge branch 'MDL-57811-master' of git://github.com/jleyva/moodle 2017-03-20 17:39:53 +01:00
Eloy Lafuente (stronk7)
ec116fe676 Merge branch 'MDL-57812-master' of git://github.com/jleyva/moodle 2017-03-20 12:35:43 +01:00
Damyon Wiese
663640f5b3 MDL-40759 icons: convert uses of pix_url to pix_icon
Also change filepicker to use scaled svgs instead of sets of custom pngs. The svgs are taken from font-awesome.
2017-03-17 15:52:17 +08:00
Juan Leyva
bb676b74fe MDL-57815 mod_feedback: New Web Service mod_feedback_get_items 2017-03-16 15:35:06 +01:00
Juan Leyva
b315d721d9 MDL-57814 mod_feedback: New WS mod_feedback_get_current_completed_tmp 2017-03-15 15:31:38 +01:00
Juan Leyva
1a305933c7 MDL-57814 mod_feedback: Create exporter and required API changes 2017-03-15 15:28:03 +01:00
Juan Leyva
0f3c09979f MDL-57811 mod_feedback: New Web Service mod_feedback_view_feedback 2017-03-15 15:25:00 +01:00
Juan Leyva
3f62cbd33e MDL-57812 mod_feedback: New WS get_feedback_access_information 2017-03-15 15:23:24 +01:00
Juan Leyva
1f7734931f MDL-50538 mod_feedback: New WS mod_feedback_get_feedbacks_by_courses 2017-03-14 15:54:26 +01:00
Damyon Wiese
a5d4b54890 MDL-56698 mod_feedback: Make it look ok in boost 2016-11-02 15:25:18 +08:00
Damyon Wiese
63e4df60f6 MDL-55839 behat: Behat fixes for theme_noname
This is a squash of many small fixes.
The list of changes are:

Initial set of behat selectors overrides required for new theme.

set core behat selectors if not overridden by theme

Remove pause

Fix for checkboxes not saving properly

Custom override for click in the user menu

Fix for behat guessing the field type.

Behat fix for guessing the correct field type.

Fix for missing closeElementBefore mforms mess.

Fix for textareas not displaying their contents.

Fix availability form element

Fix action menu selectors for activities in a course page

Fix textareas not retaining their values

Fix selector for blocks

I had to change the single select template to use an input instead of a button because of a
behat bug we have not tracked down yet.

Fix for frozen attribute in form elements

Use input instead of button while behat is still broken

Fix for navigation selector override

Behat selector fixes and multi-select fixes for templated select

Fix for configure blocks selector + booleans for autocomplete

Fixes for course_summary behat tests

Allow optgroups in single_select

Behat fixes for block_navigation

Fixes for url form element and activity chooser selectors

blocks_social - fix specific selector for behat

Fix export_for_template for selectgroups element.

Dont set empty id on the form

Fix direct call to behat_navigation in backup context

Checkbox empty value fix

Fix for assign grading panel popouts

file picker overrides to find a file manager in the page

Fix chat tests to use element name

Make selectors in mod_data behat less specific

MDL-55839: recent activity behat test relies on time()

SQUASH Honour mform element "class" attribute on the container

SQUASH Fixes for behat in mod_forum

SQUASH search form template showing value as text next to the button

SQUASH undo double selectgroup fix

SQUASH - The slightly different structure to action menus breaks course drag and drop

SQUASH Wrap loading icon in a span so the selector still works.

SQUASH Fix fragile javascript in report_loglive

SQUASH Fix tabtree, and selectgroups for mod_feedback

Also - do-not enhance the action menu - we are dropping support for this.

SQUASH Fix filemanager selector and pix_icon template for mod_forum tests.

SQUASH Fixes to breadcrumb and add formid to single select (fixes mod_glossary tests)

SQUASH lesson behat fixes. 95% of lesson styles were rubbish so they were disgarded.

SQUASH Fix lti behat tests - they were cheating and using a context step from quiz

SQUASH Behat fixes for quiz with new theme

SQUASH behat fixes for mod_wiki

SQUASH Workshop behat fixes

SQUASH Frozen form elements cannot use a readonly form element because it screws with the form JS "disabledIf" stuff.

SQUASH Fixes for grades behat tests

SQUASH behat fixes for groups

SQUASH blacklist action menu tests

SQUASH Fix for tag form element missing "manage standard tags" link

SQUASH Incomplete fixes for course behat tests

SQUASH behat fixes for badges

SQUASH Tags fixes for behat

SQUASH filepicker fixes for behat

SQUASH Abort guessing field type when we hit 'html'

SQUASH Fix for admin/tool/behat tests

SQUASH fix for admin tool behat tests

SQUASH fix for availabilty conditions hiding "aria-hidden" elements

SQUASH give the blocks more room. We get behat files because nav tree nodes are not in view

SQUASH Blocks fixed

Fix behaviour of unchecked checkboxes

SQUASH Remove incorrect step in user test

SQUASH behat fixes for course tests

Part of MDL-55071
2016-09-23 10:55:16 +01:00
Andrew Nicols
431a82bd8d MDL-55333 mod_feedback: Correct constant name 2016-08-10 10:13:07 +08:00