Juan Leyva
fa19c73350
MDL-57254 mod_choice: Add not open case in choice_can_view_results
...
If the choice is not available (not open yet), the function must return
false even is CHOICE_SHOWRESULTS_ALWAYS is set to true.
This was failing only in Web Services, in Web that function is not
reached (execution stops when the time open check is done).
2017-03-14 13:34:27 +01:00
Rajesh Taneja
57bee542ab
MDL-56519 behat: Fixed lint errors
2017-01-03 09:12:54 +08:00
Marina Glancy
e5287f9b3b
MDL-56614 behat: navigate without navigation and admin blocks
2016-12-06 11:49:14 +08:00
Rajesh Taneja
e4c98de168
MDL-56630 behat: Click on link in specificed block/region
2016-11-08 18:06:09 +08:00
Rajesh Taneja
dc90838aaa
MDL-56630 behat: Click on link in specificed block/region
2016-11-08 14:45:43 +08:00
Marina Glancy
8676e7c3e0
MDL-18592 mod_choice: Allow teachers to make choice for students
...
Capability to delete reponses becomes capability to delete or modify
responses.
This also resolves MDL-51659 (incorrect events answer_submitted and
answer_updated) by deprecating them and replacing with the answer_created
2016-08-08 14:16:57 +08:00
Andrew Nicols
8f33657dae
Merge branch 'MDL-55140_m32v2' of https://github.com/sbourget/moodle
2016-08-02 08:48:36 +08:00
Stephen Bourget
2ff504c6b2
MDL-55140 mod_choice: Allow independent open and close dates
2016-07-27 07:18:54 -04:00
Dan Poltawski
be5837d797
Merge branch 'MDL-54987-master-fixes' of https://github.com/lameze/moodle
2016-07-26 09:55:33 +01:00
Simey Lameze
e747d65514
MDL-54987 mod_choice: Fix notices and behat failures
2016-07-26 16:24:35 +08:00
Rajesh Taneja
52f3e060e4
MDL-55091 phpunit: Following has been deprecated.
...
1. getMock()
2. setExpectedException()
3. checkForUnintentionallyCoveredCode renamed to beStrictAboutCoversAnnotation
4. beStrictAboutTestSize renamed to enforceTimeLimit
5. UnitTestCase class is now fully removed.
2016-07-26 10:11:30 +08:00
Eloy Lafuente (stronk7)
731f2989c9
MDL-53803 mod_choice: fix trailing whitespace
2016-07-12 18:05:32 +02:00
Stephen Bourget
025188da5f
MDL-53803 mod_choice: remove orphaned answers when removing options
2016-07-06 17:08:50 -04:00
Dan Poltawski
1fe7dfd9f0
MDL-32135 mod_choice: fix behat tests
2016-06-30 09:24:59 +01:00
Stephen Bourget
7c2041b64d
MDL-32135 mod_choice: update behat tests
2016-06-30 09:24:59 +01:00
Rajesh Taneja
eb9ca848fa
MDL-53381 behat: Replaced chained steps with api.
...
Behat 3.x doesn't support chained steps and hence
this is first step to get rid of chained steps in core.
2016-04-06 11:32:49 +08:00
Andrew Nicols
4ed942f41e
MDL-53115 mod_choice: Remove unnecessary @javascript tags
2016-04-04 08:08:43 +08:00
Rajesh Taneja
07298309dc
MDL-46891 behat: Move wait in behat_base so it can be used easily
2016-03-11 10:51:16 +08:00
Rajesh Taneja
42ad096fdb
MDL-46891 Behat: Added support for behat 3
2016-03-11 10:51:15 +08:00
Mark Nelson
da82688689
MDL-45740 mod_choice: fixed remaining issues
2016-02-01 18:49:22 +08:00
Stephen Bourget
e62f6a01e4
MDL-45740 choice: add new events
2016-01-29 13:23:15 +08:00
Dan Poltawski
265ddbf30c
MDL-51569 mod_choice: Fix use of hardcoded ids
...
(Previous approach of making up ids longer works now we are validating
them..)
2015-11-06 08:09:47 +00:00
John Okely
531bcb13f6
MDL-51569 mod_choice: Prevent users from updating choices with curl
...
And fix unit tests.
2015-11-06 14:52:26 +08:00
Damyon Wiese
0bca129775
MDL-51569 mod_choice: Validate the submitted optionid
...
Make sure any submitted choice options actually belong to the current choice
module.
2015-11-05 10:48:40 +00:00
Juan Leyva
3dd0ac559f
MDL-51569 mod_choice: Check choice availability prior to do any action
2015-11-04 11:08:32 +00:00
Juan Leyva
4b93c3e342
MDL-51566 mod_choice: New WS mod_choice_delete_choice_responses
2015-10-07 13:58:51 +02:00
Juan Leyva
f07a2bb09b
MDL-50132 mod_choice: New WS mod_choice_get_choices_by_courses
2015-09-21 09:27:42 +02:00
David Monllao
742548e251
Merge branch 'wip-mdl-51101' of git://github.com/rajeshtaneja/moodle
2015-09-14 16:18:01 +08:00
Rajesh Taneja
1a5a476b03
MDL-51101 behat: Fixed wrong hover step usage
...
Hover step was being mis-used for checking activity completion
This is replaced with proper step which check for img element
2015-09-10 14:46:12 +08:00
Juan Leyva
dffb87edf6
MDL-50944 mod_choice: Unit tests for external functions
2015-09-02 11:29:38 +02:00
Rajesh Taneja
0fe86bbdbb
MDL-49799 behat: replaced asd.com with example.com
...
asd.com is a valid domain, we should use reserved domain names for testing
2015-04-20 11:21:20 +08:00
Damyon Wiese
221210e9b2
MDL-49412 Behat: Fix behat tests for all of @mod
...
This is after the navigation changes for 2.9.
Part of MDL-45774.
2015-04-10 17:18:23 +08:00
Tony Butler
74cc07bedf
MDL-43770 mod_choice: Add behat scenarios for 'include inactive' option
2015-03-20 09:55:16 +00:00
Rajesh Taneja
d7fec593f3
MDL-49402 behat: Fixed feature file with same scenario name
...
1. We should not have same scanrio name in 1 feature file
As it doesn't explain what is being tested. So modified.
2. Removed empty line, to keep it consistnet with other features
2015-03-06 11:47:17 +08:00
Dan Poltawski
86e5b0a707
Merge branch 'MDL-49220-master' of https://github.com/lucisgit/moodle
2015-02-24 16:54:58 +00:00
Tony Butler
f1399fb8e7
MDL-49220 mod_choice: Add behat scenario to test choice preview option
2015-02-24 16:25:18 +00:00
Dan Poltawski
6856894efe
Merge branch 'wip_MDL-49184_m29_choice' of https://github.com/skodak/moodle
2015-02-24 10:43:15 +00:00
Petr Skoda
5fb2315a8b
MDL-49184 choice: fix block actions
...
The problems was that blocks editing breaks if you redirect
after if (data_submitted()) - all form actions must make sure
it is really their form, otherwise they may hijack the post from
block actions.
Note that this is not a problem for mforms, only legacy forms
are affected.
# Conflicts:
# mod/choice/view.php
2015-02-17 17:00:15 +13:00
Stephen Bourget
c04b66a564
MDL-34375 Choice: Display choice on 'my home'
2015-02-13 14:19:55 -05:00
David Mudrák
6887e2e53e
MDL-48035 Fix Behat tests regressions after merging en_fix strings
2014-11-06 10:54:27 +01:00
Sam Hemelryk
cbb1677cb9
MDL-3034 mod_choice: minor tidy up
2014-09-25 14:03:52 +12:00
Michael Aherne
54bdf1d406
MDL-3034 choice Support multiple answers
2014-09-25 11:33:55 +12:00
Russell Smith
d2c58b95bb
MDL-43835 phpunit: Correct unit tests.
...
When different ID's are set for each sequence a number
of unit test failures appear. They have been corrected
to allow unit tests to pass with the new generator in place.
2014-06-17 19:08:01 +10:00
David Monllao
759b323e0e
MDL-43236 behat: Updating references to deprecated methods
2014-03-07 16:05:21 +08:00
David Monllao
f083d6145e
MDL-43738 behat: Updating features files
...
The following used steps were replaced by the ones
added in this issue:
- I fill the moodle form with
- I fill in with
- I select from
- I select radio button
- I check
- I uncheck
- the field should match
Also removing test for deprecated steps:
- the ASD checkbox should be checked
- the ASD checkbox should not be checked
2014-02-27 18:22:05 +08:00
Marina Glancy
1b066c06c6
Merge branch 'MDL-43440-master' of git://github.com/mr-russ/moodle
2014-02-03 13:42:23 +08:00
Rajesh Taneja
623a32e50d
MDL-43736 Events: Updated unit test to test context not used in event
2014-01-29 11:39:50 +08:00
Russell Smith
74b63eae76
MDL-43440 unit testing: Use cmid in unit tests when it should be used.
...
instance is has been used instead of cmid. This works as all id's are 1
in most cases, but not always.
accesslib_clear_all_caches_for_unit_testing was updated to clear the
$USER->access cache which would fail test when the wrong user's data was used.
2014-01-25 08:57:32 +11:00
Ankit Agarwal
1f2aeda91e
MDL-43044 events: Add unit tests
2013-12-06 16:08:03 +08:00
Marina Glancy
7fbe33fcf1
MDL-42400 generator: module generators call add_moduleinfo instead of direct inserts
2013-10-26 14:00:23 +11:00
