Commit graph

1758 commits

Author SHA1 Message Date
David Monllao
d66e54b021 Merge branch 'MDL-55161-m' of https://github.com/micaherne/moodle 2016-07-18 20:00:18 +02:00
David Monllao
90f3675d9c Merge branch 'MDL-55163-master' of git://github.com/jleyva/moodle 2016-07-18 19:42:46 +02:00
Dani Palou
9ac99220c5 MDL-55046 assign: Return submissionstatement in get_assignments 2016-07-18 09:22:12 +02:00
Jun Pataleta
667cec9ba1 MDL-55240 editpdf: Revert changes in MDL-54772
* Revert rendering of annotations and comments back to the
  drawing region.
* Bind events to stamp annotation when editing only.
2016-07-15 10:36:45 +08:00
Michael Aherne
b4beaed931 MDL-55161 assign: Check for existence of gradebook feedback plugin 2016-07-13 09:01:45 +01:00
Juan Leyva
b93ea100fc MDL-55162 mod_assign: Refactor to use new validate_assign helper 2016-07-12 14:39:24 +01:00
Juan Leyva
7336b66f05 MDL-55162 mod_assign: New WS mod_assign_view_assign 2016-07-12 14:39:24 +01:00
Dan Poltawski
9b62a3eb71 MDL-55048 js: rebuilt files with new version of uglifyjs 2016-07-11 15:53:10 +01:00
Dan Poltawski
ad3f8cd18c MDL-54944 eslint: make the .eslintrc default stricter
Instead of using the more rollup-tolerant config for all files, make the
configuration stricter by default but lower in grunt for yui modules.

This means that manual runs (prechecker) or editor integrations will
flag up the errors as well as grunt.

Also add ignore lines to the core files so that eslint isn't noisy when
not running with grunt.
2016-07-11 12:44:34 +01:00
Juan Leyva
95624eef09 MDL-55163 mod_assign: Fix mod_assign_copy_previous_attempts
- Not exposed via WS
- Have a bug when calling the api function
2016-07-11 10:35:24 +01:00
Dan Poltawski
6e304922fb MDL-54944 js: built files after changes 2016-07-07 12:11:07 +01:00
Dan Poltawski
7b7d55e11a MDL-54944 js: split variable intialisations in multiple lines
To increase code clarity, we don't allow multiple intilisations to be
confused with each other.

Detected by http://eslint.org/docs/rules/one-var-declaration-per-line
2016-07-07 12:11:06 +01:00
Dan Poltawski
b1c4d0f2d7 MDL-54944 js: Remove uncessary bind() calls
Most of these cases, we are already capturing this in a temporary
variable, so the bind becomes uncessary.

Discovered by http://eslint.org/docs/rules/no-extra-bind
2016-07-07 12:11:06 +01:00
Dan Poltawski
9f5f3dcc83 MDL-54944 js: Fix spacing of objects coding style
Fixed by http://eslint.org/docs/rules/object-curly-spacing
2016-07-07 12:11:05 +01:00
Eloy Lafuente (stronk7)
ffe0699c44 NOBUG: Fixed SVG browser compatibility 2016-07-07 10:19:45 +02:00
Cameron Ball
c30bfed180 MDL-41945 mod_assign: Add empty submission check 2016-07-06 10:07:04 +01:00
Andrew Nicols
42f7b608ed Merge branch 'MDL-54165-master' of git://github.com/ryanwyllie/moodle 2016-07-06 12:01:51 +08:00
Ryan Wyllie
2441100db9 MDL-54165 mod_assign: Fix doc in grading_events.js 2016-07-06 03:42:25 +00:00
Andrew Nicols
06d05f461e Merge branch 'MDL-54165-master' of git://github.com/ryanwyllie/moodle 2016-07-06 11:04:40 +08:00
Ryan Wyllie
f6bb3f482d MDL-54165 mod_assign: Collapsible review and grade panel 2016-07-06 02:50:24 +00:00
Eloy Lafuente (stronk7)
ed2d12a125 Merge branch 'MDL-54955-master' of git://github.com/jleyva/moodle 2016-07-05 21:15:31 +02:00
Eloy Lafuente (stronk7)
5920c233fe Merge branch 'MDL-55113-master' of git://github.com/dpalou/moodle 2016-07-05 12:21:46 +02:00
Andrew Nicols
5e47d5aee5 Merge branch 'MDL-54951-master' of git://github.com/jleyva/moodle 2016-07-05 09:41:31 +08:00
Dan Poltawski
970fcc44e6 MDL-54980 mod_assign: bump version 2016-07-04 14:10:24 +01:00
Dan Poltawski
351e06e424 Merge branch 'MDL-54980-master' of git://github.com/jleyva/moodle 2016-07-04 14:09:43 +01:00
Juan Leyva
7ef49bd393 MDL-54951 webservice: Return intro text files in modules 2016-07-04 09:24:28 +01:00
Dani Palou
5609da91fa MDL-55113 assign: Use PARAM_RAW in onlinetext text 2016-07-04 09:53:36 +02:00
Barbara Ramiro
40be0da500 MDL-54165 mod_assign: Layout icons for the new grading interface 2016-07-04 07:00:11 +00:00
Cameron Ball
c89d23ee6d
MDL-41945 mod_assign: Properly check if submission is empty
Previous empty submission checks required the submission to
be saved to the database. This patch adds a new method to
submission plugins that lets them report whether the submission
is empty before it is saved.
2016-07-04 10:55:06 +08:00
Cameron Ball
16b36d376a
MDL-41945 mod_assign: Check if submission has been modified
This patch adds a check that stops a user submitting an assignment
if someone else has modified it in the meantime.
2016-07-04 10:51:57 +08:00
Eloy Lafuente (stronk7)
4a365babb6 Merge branch 'MDL-54855-master' of git://github.com/crazyserver/moodle 2016-06-30 09:24:57 +01:00
Andrew Nicols
ea5241410d Merge branch 'MDL-54991-master' of git://github.com/crazyserver/moodle 2016-06-29 15:05:24 +08:00
Pau Ferrer Ocaña
ff6de75396 MDL-54991 assign: Invalid submissiongroup when not using groups 2016-06-27 09:24:29 +02:00
Pau Ferrer Ocaña
36f1d79ea2 MDL-54909 assign: Style editpdf background to differ from page bg 2016-06-23 15:06:59 +02:00
Pau Ferrer Ocaña
796161018c MDL-54855 assign: Add missing field in get_assignments 2016-06-23 15:05:17 +02:00
Eloy Lafuente (stronk7)
0f20bf7507 Merge branch 'wip-mdl-54589-mac' of https://github.com/rajeshtaneja/moodle 2016-06-22 01:42:15 +02:00
Eloy Lafuente (stronk7)
e822312af3 Merge branch 'MDL-54939-master' of git://github.com/danpoltawski/moodle 2016-06-21 20:00:36 +02:00
Juan Leyva
23717c804d MDL-54980 mod_assign: Add WS list_participants to the Mobile service 2016-06-21 15:30:58 +01:00
Juan Leyva
d889b58747 MDL-54955 webservice: Apply external_format_string in course names 2016-06-20 13:16:52 +01:00
Rajesh Taneja
fba0ac63b8 MDL-54589 behat: Added hack for some OS/browsers 2016-06-20 16:03:36 +08:00
Rajesh Taneja
3aaf98f62c MDL-54589 behat: Trigger change event after selecting option
After selecting option, some browsers need
explicit change event
2016-06-20 09:43:08 +08:00
Dan Poltawski
c96f55e6f9 MDL-54939 amd: fix lint issues
Mostly correcting jsdoc, some other line wrapping rules and empty
functions.
2016-06-17 09:03:18 +01:00
Dan Poltawski
4c62bdab0d MDL-54654 assignfeedback_editpdf: remove invalid CSS
The 'left' positioing was invalid and conflicting with the
right definition anyway, so wasn't necessary.
2016-06-16 20:52:04 +01:00
Dan Poltawski
35be582696 MDL-54939 amd: Fix lint issues fixable with eslint --fix 2016-06-16 19:33:00 +01:00
Dan Poltawski
0fd08fc7e5 Merge branch 'MDL-35628' of https://github.com/mr-russ/moodle 2016-06-16 09:04:12 +01:00
Eloy Lafuente (stronk7)
392c40467f Merge branch 'MDL-54890-master' of git://github.com/danpoltawski/moodle 2016-06-16 09:04:04 +01:00
Jun Pataleta
cdbdb2f9b7 MDL-54772 mod_assign: Fixes for PDF editor
* Render the annotations and comments within the drawing canvas, not in
the drawing region.
* Remove edit-related event bindings for stamp annotations.
2016-06-13 09:54:02 +08:00
Dan Poltawski
8b766dd1d8 MDL-54890 assignfeedback_editpdf: Fix missing semicolon
Detected by eslint rule 'semi'
2016-06-10 10:06:25 +01:00
Russell Smith
1fcf0ca8a5 MDL-35628 performance: Remove dirname() where possible.
dirname() is a slow function compared with __DIR__ and using
'/../'.  Moodle has a large number of legacy files that are included
each time a page loads and is not able to use an autoloader as it is
functional code.  This allows those required includes to perform as
best as possible in this situation.
2016-06-10 08:06:49 +10:00
Dan Poltawski
631edc10ae MDL-46721 assign: clarify ternerary statement 2016-06-07 12:15:19 +01:00