Commit graph

29138 commits

Author SHA1 Message Date
Shamim Rezaie
52c1e68631 MDL-71672 atto_emojipicker: Focus the search bar initially 2021-07-19 16:40:10 +10:00
Shamim Rezaie
9e801be452 MDL-71672 atto_recordrtc: focus Atto button after hide 2021-07-19 16:40:10 +10:00
Shamim Rezaie
2092f152b2 MDL-71672 javascript: Fix the issue of focusOnShowSelector being ignored
When focusOnShowSelector is not present, as a fallback, focus the first
focusable element in YUI dialogues
Ref:
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/dialog_role
2021-07-19 16:40:10 +10:00
Andrew Nicols
d55aeee10c MDL-72163 admin: Create interface for settings with a url 2021-07-16 15:20:30 +08:00
Andrew Nicols
78c96c6f44 MDL-72163 admin: Plugins overview page should link to categories 2021-07-16 13:49:11 +08:00
Andrew Nicols
87b50a42e8 MDL-72125 behat: Add get_activity_id() behat generators helper 2021-07-16 12:33:56 +08:00
Andrew Nicols
7cd408501b MDL-72125 testing: Set a default idnumber when creating activities
The activity generator currently requires an idnumber when creating
activities, but this is not a requirement when creating the same
activity through the UI. The requirement comes because we want to
provide a way to refer to activities in subsequent steps.

This commit modifies the behaviour such that the generator uses the name
of the activity as the default idnumber.

This has two  main benefits:
1. it simplfies generation of activities; and
2. it makes the language used when writing behat tests much more natural.

With this change, steps will refer to the activity by its idnumber/title
in all cases, rather than sometimes by an idnumber which bears no
relevance to the title.
2021-07-16 12:33:56 +08:00
Andrew Nicols
daf9b24b6a MDL-72125 testing: Add helper to run generators as a user 2021-07-16 12:33:56 +08:00
sam marshall
46099c7297 MDL-72152 Behat: No way to test key shortcuts with letter keys
Extends the existing step 'And I press the Shift Left key' so that
it supports letter/other keys: 'And I press the Ctrl C key'.
2021-07-15 09:42:34 +01:00
Jun Pataleta
80f0b15165 Merge branch 'MDL-63770-master' of /home/jun/moodles/stable_master/moodle 2021-07-15 16:13:11 +08:00
Jun Pataleta
e6f1baa9c8 Merge branch 'MDL-71456-master' of /home/jun/moodles/stable_master/moodle 2021-07-15 16:13:06 +08:00
Matteo Scaramuccia
7910fa322a MDL-63770 core: 'port' should be an integer like in parse_url()
Plus trivial comment cleanup.
2021-07-15 11:37:13 +08:00
Eloy Lafuente (stronk7)
a0ac76505b Merge branch 'MDL-67338' of git://github.com/paulholden/moodle 2021-07-15 00:33:57 +02:00
Paul Holden
bf97f707cd MDL-67338 message: re-implement block page type patterns.
The `page_type_list` method for the message component was deprecated
in 5b0769db as part of MDL-54744. However it is still required when
trying to configure blocks on any messaging pages.
2021-07-14 19:34:13 +01:00
Eloy Lafuente (stronk7)
be3f3b1283 Merge branch 'MDL-71790-master' of git://github.com/HuongNV13/moodle 2021-07-14 19:25:47 +02:00
Bas Brands
99a4eee699 MDL-71456 core: fix behats with new drawers
The new drawers structure shows that some elements
are dependant from the page structure and broke some
behats. This commit fixes those components and tests.
2021-07-14 11:49:57 +02:00
Eloy Lafuente (stronk7)
0139d213ac Merge branch 'MDL-71874-master' of git://github.com/andrewnicols/moodle 2021-07-13 20:38:01 +02:00
Sara Arjona
730792e51b Merge branch 'MDL-32103-master' of git://github.com/ilyatregubov/moodle 2021-07-13 16:28:36 +02:00
Ilya Tregubov
b26608d1d4 MDL-32103 completion: Fix CiBoT errors.
Old code still uses underscores in variable names, so CiBoT is
not happy. Making it constistant with Moodle code style.
2021-07-13 12:07:53 +02:00
Ilya Tregubov
4819625349 MDL-32103 completion: Allow instant completion updates.
For activity based course completion criteria allow instant
course completion updates if the activity completion state was changed
for a single user.
2021-07-13 12:07:53 +02:00
Sara Arjona
a81c372f00 MDL-72036 atto_h5p: Random error with external URL
After a major upgrade was done in h5p.com, some random errors appeared
in the "H5P options are ignored for H5P URLs" scenario.
They have been fixed replacing the URL for different (which should
load quicker). As we're checking external content, no other improvement
can be done on the Moodle site.
2021-07-13 08:36:33 +02:00
Huong Nguyen
48d21af177 MDL-71790 calendar: Revamp the manage subscriptions page 2021-07-13 13:21:20 +07:00
Paul Holden
42281e48f5 MDL-70427 task: correct missing component when queuing adhoc task.
If the task belongs to a component, and doesn't have it's own
component property set then we can lazy-load it based on class
namespace.
2021-07-12 20:47:04 +01:00
Paul Holden
689e20c8ba MDL-70427 admin: remove plugin adhoc tasks during uninstall. 2021-07-12 20:43:14 +01:00
Dmitri Pisarev
1983718149 MDL-63770 core: Fix a false-positive in reverseproxyabused check
A `reverseproxyabused` error is wrongly triggered when external port number doesn't equal internal.
2021-07-12 11:23:49 +02:00
cescobedo
084833acbe MDL-71919 core_message: Fix tests in message_send 2021-07-08 23:30:35 +02:00
cescobedo
9aa5f7fe9b MDL-71919 core_message: Fix unclosed html tags in email notification 2021-07-08 23:30:35 +02:00
Adrian Greeve
a5336912d9 Merge branch 'MDL-61460-master-4' of git://github.com/bmbrands/moodle 2021-07-08 23:30:34 +02:00
Mihail Geshoski
4772dece1d MDL-58393 core: Remove firstname argument from emailconfirmation string 2021-07-08 23:30:33 +02:00
Sujith Haridasan
b2527be7d3 MDL-71241 course: Validate and sanitize sort arguments
Signed-off-by: Sujith Haridasan <sujith@moodle.com>
2021-07-08 23:30:27 +02:00
Andrew Nicols
36f21508fb MDL-72108 js: Fix incorrect jsdoc examples for core/ajax 2021-07-08 10:39:13 +08:00
Bas Brands
3de68ad434 MDL-61460 tool_componentlibrary: Documentation for Moodle UI components
- This tool is only available for admins
- Before using this tool the hosting admin will need to have NPM installed and be able to run grunt
- To create the docs pages for the library run "grunt componentlibrary"
- After the pages are created the Library is available in Site adminstration > Development > UI Component Library
2021-07-08 09:51:02 +08:00
Jun Pataleta
341578bfde MDL-61460 core: Create a copy to clipboard JS module
This works by adding event listeners for elements that contain
the 'copytoclipboard' "data-action" attribute through event delegation.
These trigger elements must also define a "data-clipboard-target"
attribute which contains the query selector for the target element
where text will be copied.

On success, a toast message is shown to the user that the text has
been copied to the clipboard. This success message can be customised
by passing a message string to the "data-clipboard-success-message"
attribute in the trigger element.

When the element's value or innerText cannot be found, a toast message
indicating that the text cannot be copied to the clipboard is shown.

The copy to clipboard functionality is primarily using the Clipboard API
but in the event that this is not available, e.g. the site is not
running on HTTPS, this falls back to the document.execCommand('copy')
approach of copying the text in the target container.

Special thanks to Andrew for improving this module with the event
delegation approach and improved fallback handling.

Co-authored-by: Andrew Lyons <andrew@nicols.co.uk>
2021-07-08 09:50:34 +08:00
Michael Hawkins
0afab1d0f9 MDL-71916 lib: Check cURL redirects for blocked URLs before following 2021-07-06 23:45:59 +02:00
Eloy Lafuente (stronk7)
e5b76c53b3 Merge branch 'MDL-70638' of git://github.com/paulholden/moodle 2021-07-06 20:21:16 +02:00
Paul Holden
4f343bd359 MDL-70638 user: correct access checks when serving profile files.
Requests for files from a users profile file area should follow
the same access checks as for the profile itself.
2021-07-06 10:28:24 +01:00
Paul Holden
052ba69f79 MDL-71323 admin: consistently indicate disabled state of plugins.
In order to be consistent with the majority of plugin management
pages, add the `dimmed_text` class to table rows to indicate that
a given plugin is disabled.
2021-07-06 10:14:13 +01:00
Paul Holden
f3b3684e5b MDL-71981 dataformat: indicate HTML support in writer callback. 2021-07-06 09:27:15 +08:00
Andrew Nicols
44cde6766b Merge branch 'MDL-71176-master_password_autocomplete' of https://github.com/safatshahin/moodle 2021-07-01 10:08:04 +02:00
Safat Shahin
bc76ab4742 MDL-71176 login: Add html5 autocomplete attributes
This implementation will include the correct
autocomplete attribute value so that the password
managers can aid in creating good secure passwords
and not get confused with other autocomplete types.
There are some changes the password type form so
that autocomplete attribute can be passed an array.
2021-07-01 12:38:11 +10:00
Andrew Nicols
1543d600e4 Merge branch 'master_MDL-71175' of https://github.com/danmarsden/moodle 2021-07-01 09:56:31 +08:00
Andrew Nicols
744e9266f0 Merge branch 'MDL-68003' of https://github.com/timhunt/moodle 2021-07-01 09:52:48 +08:00
Sara Arjona
27243e2ff7 Merge branch 'MDL-71991' of https://github.com/timhunt/moodle 2021-06-30 16:09:30 +02:00
Leon Stringer
22825647d4 MDL-72035 csvlib: Write BOM for Excel
Add option to class csv_export_writer to prefix CSV file with UTF-8 byte
order mark (BOM).  This helps Microsoft Excel detect the file's character
encoding.
2021-06-30 15:04:16 +01:00
Andrew Nicols
b12bb97048 Merge branch 'MDL-71863-master-v02' of git://github.com/ferranrecio/moodle 2021-06-30 10:04:23 +08:00
Eloy Lafuente (stronk7)
17135030cc Merge branch 'MDL-66539-master' of git://github.com/HuongNV13/moodle 2021-06-29 18:37:20 +02:00
Tim Hunt
0bb2d16337 MDL-68003 session timeout warning: don't show in iframes 2021-06-29 16:58:06 +01:00
Ferran Recio
1c0abade3e MDL-71863 core_courseformat: mode site renderer to autoload 2021-06-29 11:52:48 +02:00
Eloy Lafuente (stronk7)
4242216e86 Merge branch 'MDL-71947-master' of https://github.com/bmbrands/moodle 2021-06-29 11:39:26 +02:00
Ferran Recio
176bf81cb1 MDL-71863 courseformat: new course editor methods in courseeditor AMD
The module now exports a getCourseEditor and a getCurrentCourseEditor
methods. The module is more consistent as it can be used to get
other course than the current one.
2021-06-28 13:50:18 +02:00