Commit graph

108098 commits

Author SHA1 Message Date
Paul Holden
5021b3a5b5 MDL-68776 search: remove support for optional add_documents return.
All six returned array elements must now be present.
2023-02-10 10:41:50 +00:00
Julien Boulen
9f3baf8c4f MDL-76314 forum: add form check to prevent combining wrong parameters
Form validation prevents combining the forum type "single discussion" and the group mode "separate groups".
2023-02-10 11:07:21 +01:00
Julien Boulen
0b1e4b57b6 MDL-76312 forum: sort subscribers list by fullname 2023-02-10 10:26:31 +01:00
Jun Pataleta
36564d26ba Merge branch 'MDL-74272-fix' of https://github.com/sarjona/moodle 2023-02-10 16:52:36 +08:00
Sara Arjona
ad1a9e85de MDL-74272 behat: Fix issue with headless
It seems unrelated to this patch... But git bisect pointed it here.
2023-02-10 09:42:53 +01:00
Jake Dallimore
7e6f706717 MDL-77140 mod_lti: fix content item return for new TinyMCE versions 2023-02-10 10:11:34 +08:00
David Woloszyn
694b3ef878 MDL-77145 enrol: Removed course shortname from unenrolme string 2023-02-10 11:10:15 +11:00
Jason A Everling
6f4011db33
MDL-62839 mod_lti: change instructorchoiceacceptgrades default value
update mod_lti behat test: renametool.feature, added  "Accept grades from the tool" to "1"
2023-02-09 10:22:17 -06:00
Paul Holden
6f4675e043 MDL-76222 tool_customlang: non-translatable export CLI filename.
This matches the name used for manual (via UI) language export.
2023-02-09 14:18:05 +00:00
Andrew Nicols
ea1f5eba27 Merge branch 'MDL-76904-master' of https://github.com/NashTechOpenUniversity/moodle 2023-02-09 12:04:21 +08:00
Andrew Nicols
219d15895e Merge branch 'MDL-74755' of https://github.com/paulholden/moodle 2023-02-09 11:44:16 +08:00
Jun Pataleta
6845a7f74f Merge branch 'MDL-77052-master' of https://github.com/Utdanningsdirektoratet/moodle 2023-02-09 11:27:43 +08:00
Jun Pataleta
5ab615c610 Merge branch 'MDL-77161-master' of https://github.com/andrewnicols/moodle 2023-02-09 11:18:24 +08:00
Andrew Nicols
8d35d59bf3 Merge branch 'MDL-76354' of https://github.com/paulholden/moodle 2023-02-09 10:58:29 +08:00
Jun Pataleta
c909797ec1 Merge branch 'MDL-77007-master' of https://github.com/andrewnicols/moodle 2023-02-09 10:52:55 +08:00
Andrew Nicols
c7a1f4c748 Merge branch 'MDL-77018' of https://github.com/timhunt/moodle 2023-02-09 10:50:58 +08:00
Andrew Nicols
2de031b74c Merge branch 'MDL-76066-master' of https://github.com/aanabit/moodle 2023-02-09 10:27:00 +08:00
Andrew Nicols
9890d88107 Merge branch 'MDL-77057' of https://github.com/paulholden/moodle 2023-02-09 10:19:22 +08:00
Andrew Nicols
43962ec9ce Merge branch 'MDL-72559-master' of https://github.com/keevan/moodle 2023-02-09 10:17:12 +08:00
Matthew Hilton
5ea4d886ee MDL-73317 assign: Move useridlist cache construction
Move the construction of the useridlist $SESSION cache to when a key
is requested.

This stops the writing of $SESSION when backing up
or restoring mod_assign instances, which is neccessary since the
backup and restore scripts close the session when processing.
2023-02-09 12:03:49 +10:00
Matthew Hilton
f106babf53 MDL-73317 search: Close session later in script
The session write_close was moved to the earliest point in the script
that does not modify the session. This is currently always after
$OUTPUT->header()
2023-02-09 12:03:49 +10:00
Matthew Hilton
49c4cfb2d5 MDL-73317 restore: Reset navcache before closing session
As part of a restore, the session is closed early so it does not
interrupt the users session during the restore.

Currently the restore controller rebuilds the course caches while
restoring. This inadvertently resets the navcache, which would edit the
session despite it being closed.

Because this tracker now adds logging for this behaviour, it means
restoring now outputs a debugging message as a warning.

To resolve the debugging message, the navcache is now reset just before
closing the session. This is allowed, since the caches are designed
to be volatile.
2023-02-09 12:03:49 +10:00
Matthew Hilton
863bad8d7e MDL-73317 report_participation: Close session later in script
The script has been reorganised so that it closes the session as early
as possible, without causing session changes after close being logged.

In this case, after the table has been output it is OK to close the
session.
2023-02-09 12:03:49 +10:00
Matthew Hilton
4faa3204d6 MDL-73317 session: Log extra details for cachestore changes
More visibility depth is required for cachestore changes since they
are usually multi dimensional arrays.
2023-02-09 12:03:49 +10:00
Matthew Hilton
9c8d8502c0 MDL-73317 session: Log session changes after close
A snapshot of the session is now taken when write_close is called.
The session at shutdown is then compared to the snapshot. If changes
are detected, they are logged. This aids developers in seeing if
early session closes may be having unintended consequences.
2023-02-09 12:03:49 +10:00
Matthew Hilton
95077da502 MDL-73317 session: Improve session diff detection
Previously, newly added keys to the session were not detected. Objects
with the same properties were also incorrectly reported as different.

This commit improves this, and updates the unit tests to reflect the
new functionality.
2023-02-09 12:03:49 +10:00
Andrew Nicols
cfb728bebb Merge branch 'MDL-76499-master' of https://github.com/andelacruz/moodle 2023-02-09 09:52:53 +08:00
Andrew Nicols
9dca529997 Merge branch 'MDL-70586-master' of https://github.com/sarjona/moodle 2023-02-09 09:40:34 +08:00
Andrew Nicols
d56df7c204 Merge branch 'MDL-76912' of https://github.com/paulholden/moodle 2023-02-09 09:37:00 +08:00
Andrew Nicols
c9956b2c94 Merge branch 'MDL-77177' of https://github.com/paulholden/moodle 2023-02-09 07:11:32 +08:00
Paul Holden
29c13cc54b Merge branch 'MDL-76672-master' of https://github.com/Utdanningsdirektoratet/moodle 2023-02-08 14:57:30 +00:00
Jun Pataleta
73cd0ff616 Merge branch 'MDL-74272-master' of https://github.com/sarjona/moodle 2023-02-08 22:25:18 +08:00
Paul Holden
f85f441914 Merge branch 'MDL-76542-master' of https://github.com/lameze/moodle 2023-02-08 14:22:10 +00:00
Laurent David
00eecda571 MDL-76620 mod_bigbluebuttonbn: Fix guest behat test
* Refactor guest_access.feature behat test
2023-02-08 14:27:47 +01:00
Laurent David
8fcf662484 MDL-76620 mod_bigbluebuttonbn: Fix guest access with forcelogin
*With "forcelogin" setting turned on, the new external guest
 links in the bigbluebutton plugin do not work but show the login screen instead
2023-02-08 14:27:47 +01:00
Sara Arjona
72f75ef344 MDL-74272 theme_boost: Coding style improvements 2023-02-08 13:05:26 +01:00
Sara Arjona
5d7d947553 MDL-74272 theme_boost: Remove plugin name on course page
In 4.0, the plugin name was added above their name. Based on the community
feedback and the research done by the UX team, this needs to be removed.
This commit removes the activity name when edit mode is disabled.
2023-02-08 13:04:31 +01:00
Paul Holden
ef47376a37 Merge branch 'MDL-73692-master-Add-support-for-missing-timestamps-to-rss-block' of https://github.com/melanietreitinger/moodle 2023-02-08 11:22:08 +00:00
Melanie Treitinger
e5709fc588 MDL-73692 blocks: Add support for missing timestamps to rss block. 2023-02-08 11:20:48 +01:00
Paul Holden
a09dc53828 MDL-77177 mod_data: re-factor internal method argument order.
We cannot have required method parameters after optional, it doesn't
make sense. Also it causes deprecation notices in PHP8.1.
2023-02-08 09:57:52 +00:00
Jun Pataleta
65228171e5 Merge branch 'MDL-74905' of https://github.com/stronk7/moodle 2023-02-08 17:19:38 +08:00
Angelia Dela Cruz
367027f979 MDL-75230 behat: Lesson Behat tests optimised
Replace steps that manually add Lesson instances via the UI and use
Behat generators. This improves the speed of the Behat test runs.
2023-02-08 14:20:21 +08:00
Simey Lameze
64799f9ace MDL-76542 behat: add step to go to user edit page directly 2023-02-08 12:22:29 +08:00
Simey Lameze
d991b12d15 MDL-76542 behat: create custom profile fields using data generators
This commit also adds a new test to verify the custom profile fields
works using the user interface.
2023-02-08 12:12:08 +08:00
Jun Pataleta
8b3e36f8a8 Merge branch 'MDL-76755-master' of https://github.com/davewoloszyn/moodle 2023-02-08 11:34:21 +08:00
Paul Holden
4402b0b677 MDL-77154 course: access checks in course format fragment callbacks. 2023-02-08 11:11:00 +08:00
Andrew Nicols
01da499897 Merge branch 'MDL-76418-master' of https://github.com/srobotta/moodle 2023-02-08 08:52:59 +08:00
Stephan Robotta
a8de5c5002 MDL-76418 course: section action menu item to show permlink to section 2023-02-07 17:56:46 +01:00
Andrew Nicols
41ccc8acb9 MDL-77171 core: Remove legacy tooltip/popuphelp YUI mods 2023-02-07 23:52:01 +08:00
Paul Holden
6f81371f7a Merge branch 'MDL-77112-master' of https://github.com/lucaboesch/moodle 2023-02-07 15:18:52 +00:00