Including:
MDL-11529 When assigning/overriding roles, the dropdown for switching to another role should have a number in brackets
MDL-16549 Should not be able to edit the permission associated with moodle/site:doanything on any role.
This steals the logic from accesslib used to detect dirty contexts and so reload cached access data when permissions are changed.
Here, we track when user preferences are changed, so that if necessary we can trigger a reaload. This helps in two situations:
1. When you are logged into Moodle with two different browsers.
2. When someone else changes one of your preferences.
After this change, you will see the changed user pref immediately in all sessions.
This adds one cheap DB query to any page that tries to access a user preference (which is almost all of them, because of deciding whether to show the messaging pop-up). It adds a few more queries in the cases when a user preference is changed. This is in the name of correctness.
* Make the role being assigned clear in the title
* Make the options in the middle of the page be in a collapsable options section, collapsed by default.
* Put them in a smaller font too.
* Switch the date selectors here to use a shorter date format, and change 'Course start date' to 'Course start'.
extra space was used in front of %d so that we can detect the difference between a leading 0 and something like 10, 20, or 30. The extra space was removed along with any leading 0 but not if there was no leading zero.
Now removing extra space even if there is no leading zero.
Now applying fix to conditional branch for when using a time offset from GMT instead of server time.
extra space was used in front of %d so that we can detect the difference between a leading 0 and something like 10, 20, or 30. The extra space was removed along with any leading 0 but not if there was no leading zero.
Now removing extra space even if there is no leading zero.
Merged from MOODLE_18_STABLE.
The fix is wrong, as it breaks auth_db_sync_users.php and
auth_ldap_sync_users.php at least. No new users are added to Moodle, as the
username is missing from the new user info record.
The fix needs to go into update_user_record() in lib/moodlelib.php to make it
skip the 'username' key, as we really need get_userinfo() to return the
username as part of the user info array.
