skodak
96608a55bd
MDL-9983 role assignment related triggers; merged from MOODLE_19_STABLE
2008-07-06 19:30:12 +00:00
skodak
17deeebc8f
MDL-15071 sqlite compatibility fix - by Andrei Bautu
2008-06-22 20:42:19 +00:00
skodak
0cbe81112a
MDL-14580 rewritten course sorting algorithms
2008-06-16 14:25:53 +00:00
dongsheng
e6edb40e7a
"MDL-14129, fix print_error"
2008-06-15 11:47:27 +00:00
skodak
b1f93b1512
MDL-15246 moving all remaining ddl function to adminlib, keeping old lib/ddllib.php only for BC withexisting code; fixed inline docs related to ddl
2008-06-15 10:32:50 +00:00
skodak
f67cab32ec
MDL-15094 some forgotten conversions
2008-06-05 18:01:22 +00:00
skodak
b820eb8c60
MDL-15073 delete_records now truncates table if deleting all records, fixed some regressions
2008-05-31 15:32:28 +00:00
thepurpleblob
57443b9af4
MDL-15056
...
Added missing global $DB
2008-05-30 11:06:49 +00:00
skodak
7de9dff6c5
MDL-15042 fixed regression - thanks Howard
2008-05-29 15:07:05 +00:00
thepurpleblob
e60d5b2676
MDL-15043
...
No need to use $USER in the log write call, it's the default
2008-05-29 12:49:29 +00:00
skodak
568df4756a
MDL-15020 fixed typo causing deleting of all roles and contexts - thanks Joseph!
2008-05-27 13:26:00 +00:00
skodak
727c22375f
MDL-14995 fixed param typo
2008-05-27 09:32:05 +00:00
skodak
bc8d118210
MDL-14679 fixed $exceptions regression in first part of datalib conversion
2008-05-25 10:16:53 +00:00
skodak
e3c7f155d8
MDL-14978 removed obsoleted isadmin()
2008-05-25 10:08:05 +00:00
skodak
dc10f119bb
MDL-14679 fixed warning and change false to array() when no users found
2008-05-24 20:43:33 +00:00
skodak
5a4e739817
MDL-14679 accesslib conversion to new dml
2008-05-24 18:35:48 +00:00
sam_marshall
c2f10673b2
MDL-14965: Pass-by-reference call broke install on php5
2008-05-23 10:36:28 +00:00
dongsheng
7ade55ad96
"MDL-14668, fix course full in activity reports (upgrade course module version)"
2008-05-16 02:15:23 +00:00
stronk7
137e0e6f65
Fixed typo preventing params to be properly passed.
2008-05-15 22:55:27 +00:00
skodak
f33e1ed4ae
MDL-14679 ok, here is the big patch with new dmllib and ddlib API, some code is already converted, XML db editor works; see tracker for details of regressions and TODOs
2008-05-15 21:40:00 +00:00
dongsheng
e49ef64a2e
"MDL-14129, fix print_error"
2008-05-15 03:07:21 +00:00
tjhunt
d33725bd2d
New convinience function in accesslib: get_parent_contextid. Also, the start of some unit tests for accesslib, but only this trivial funciton, and the get_parent_contexts function it is based on. Still, it is a start.
2008-05-12 15:28:34 +00:00
moodler
db70c4bdf3
MDL-13261 Merged the removal of get_context_users_bycap and get_context_users_byrole from accesslib
2008-04-29 06:53:19 +00:00
moodler
1969b60e61
MDL-11323 Merged from Moodle 1.9 (fixes for display of aliases)
2008-04-18 06:21:00 +00:00
moodler
1d19d8a7b3
MDL-11142 Roles upgrade was losing timestart and timeend for teachers and students (Merged from 1.7)
2008-04-18 03:33:22 +00:00
dongsheng
5a2a53316f
MDL-14129, remove all the other error() call
2008-04-04 02:54:20 +00:00
moodler
85edee26f3
MDL-13810 Merged from 1.9
2008-03-19 07:49:40 +00:00
moodler
fffb5d240a
Merged MDL-13810 Fixed check for ul.timeaccess
2008-03-06 02:15:00 +00:00
moodler
12d0d174b7
Merged MDL-13754: get_users_by_capability minor fix
2008-03-03 06:20:52 +00:00
moodler
be4c1a81d6
Merged MDL-13676 Fixed some mistakes I just made
2008-02-29 08:56:39 +00:00
moodler
87486420a5
Merged MDL-13676: last-minute field change to fix an Oracle problem
2008-02-29 08:44:23 +00:00
tjhunt
36832e1a30
MDL-13723 - Unbalanced brackets in get_users_by_capability in the groups bit.
2008-02-28 22:41:38 +00:00
skodak
8e5a25f6f0
MDL-13560 simplify dealing with role name course aliases; merged from MOODLE_19_STABLE
2008-02-21 09:20:20 +00:00
skodak
bfb6a6564d
MDL-13459 fixed hardcoded mdl_ prefix; merged from MOODLE_19_STABLE
2008-02-16 11:37:07 +00:00
nicolasconnault
d423b6dc9a
MDL-13459 Didn't use the patch, which puts its finger in too many pies. Instead just implemented a quick-fix, a temporary get_assignable_for_switchrole() function. It only affects the switchroles menu. Merging from MOODLE_19_STABLE
2008-02-15 16:40:45 +00:00
skodak
65bcf17b95
MDL-13450 and MDL-13303 - sorry for changing forum API so late, but it was needed; major perf improvement for forum; fixed printing of user pictures; merged from MOODLE_19_STABLE
2008-02-13 17:03:25 +00:00
poltawski
f405c6e4d8
MDL-13314 count_role_users was showing different count to those returned from
...
get_role_users(), based on patch from Patrick Pollett
merged from MOODLE_19_STABLE
2008-02-05 17:19:41 +00:00
skodak
76b570d602
MDL-12938, MDL-12937 - unenrol fixes - can not unenrol if can not unassign all users roles in course, do not show self unenrol if enrolment comes from parent context, fixed rturn value from get_user_roles; based on patch by Eric Merrill; merged from MOODLE_19_STABLE
2008-02-05 12:59:28 +00:00
skodak
133d5a97db
MDL-13334 get_role_access() static cache in cron only; merged from MOODLE_19_STABLE
2008-02-05 10:41:05 +00:00
skodak
683ff270fe
MDL-13317 use cached system context in get_user_access_sitewide and when rebuilding paths; merged from MOODLE_19_STABLE
2008-02-03 16:23:54 +00:00
martinlanghoff
c2d88da708
accesslib: Fix get_context_users_bycap() when no roles grant the cap
...
When no roles mention the capability, get_context_users_bycap() breaks
badly. This trivial patch does a sanity check before jumping into the
SQL shark-pool...
MDL-13160
2008-01-25 00:53:01 +00:00
skodak
588cd516e1
tweak has_capability() debug mode to add only one query per page for cap name verification; merged from MOODLE_19_STABLE
2008-01-16 17:24:08 +00:00
mjollnir_
d46a26c309
Merged from MOODLE_19_STABLE:
...
MDL-13000 Adding support for developers to add their own capabilities to local/db/access.php
This relies on a local/ language pack as well for the capability names.
Notes on implementation are in lib/locallib.php
2008-01-15 04:20:12 +00:00
tjhunt
cc3d5e10ec
Put back DEBUG_DEVELOPER sanity check in has_capability, that makes sure the capabiltiy you are asking about actually exists. I know it takes an extra DB query, but it is DEBUG_DEVELOPER only, and it is worth its weight in gold, because otherwise you get really subtle bugs that take forever to diagnose. I know, I have just been banging my head against the wall for an hour.
2008-01-08 15:04:00 +00:00
martinlanghoff
19f2318a44
accesslib: get_users_by_capability() now excludes doanything'ers properly
...
With some subselect-outer-join poison-pill magic, when the we don't
want doanything users, we remove the roles that would grant such
dubious status.
Just a flick of the SQL muscle, actually.
2008-01-06 23:26:19 +00:00
martinlanghoff
92c879cef1
accesslib: get_users_by_capability() fix subselect with ra.hidden
...
MDL-12452
2008-01-06 23:26:08 +00:00
martinlanghoff
635bfbad21
accesslib: Introducing sort_by_roleassignment_authority()
...
This will help us bridge the gap from olden-style order-by
user_teachers.id. From the phpdoc...
Will re-sort a $users results array (from get_users_by_capability(), usually)
based on a sorting policy. This is to support the odd practice of
sorting teachers by 'authority', where authority was "lowest id of the role
assignment".
Will execute 1 database query. Only suitable for small numbers of users, as it
uses an u.id IN() clause.
Notes about the sorting criteria.
As a default, we cannot rely on role.sortorder because then
admins/coursecreators will always win. That is why the sane
rule "is locality matters most", with sortorder as 2nd
consideration.
If you want role.sortorder, use the 'sortorder' policy, and
name explicitly what roles you want to cover. It's probably
a good idea to see what roles have the capabilities you want
(array_diff() them against roiles that have 'can-do-anything'
to weed out admin-ish roles. Or fetch a list of roles from
variables like $CFG->coursemanagers .
MDL-12452
2008-01-06 23:25:37 +00:00
martinlanghoff
f17a660a05
accesslib: get_user_by_capability() - Fix pagination
...
Ooops! Off-by-one error
MDL-12452
2008-01-06 23:25:03 +00:00
martinlanghoff
c92bce4614
accesslib: get_user_by_capability() - Fix last_access handling
...
We were missing $courseid, which is actually $context->instanceid.
MDL-12452
2008-01-06 23:24:37 +00:00
martinlanghoff
6c9d86b7a6
accesslib: get_user_by_capability() - Move capcheck to has_capability_from_rarc()
...
This fixes the handling of default roles as "tie breakers" for lower
RAs in conflict, and simplifies the code a lot.
The main loop in get_user_by_capability() runs a simpler state machine
that just collects role assignments (roleid and depth), and handles
pagination.
The complex part of the state machine has moved to
has_capability_from_rarc() which will walk the data structures
collected by get_user_by_capability() for each user.
Having all the complex state handling of $hascap there makes things a
lot easier for pagination and general sanity of
get_user_by_capability().
MDL-12452
2008-01-06 23:24:25 +00:00
