Commit graph

168 commits

Author SHA1 Message Date
samhemelryk
663db34daa mod-quiz MDL-19813 Added set_url calls, replaced deprecated functions 2009-09-24 09:02:58 +00:00
tjhunt
e6fb2c603e quiz: MDL-19786 - Un-break the quiz edit page following the OUTPUT changes. 2009-09-21 16:53:45 +00:00
samhemelryk
03da0c3943 quiz MDL-19813 Updated print_header_simple and build_navigation to OUTPUT and PAGE equivalents 2009-09-08 01:57:28 +00:00
samhemelryk
2698e9c1ac mod-quiz MDL-19813 Updated print_header and build_navigation to OUTPUT and PAGE equivalents 2009-09-07 02:11:54 +00:00
skodak
92ebcabeb3 MDL-20169 fixed coding style, parameter type required 2009-08-27 19:14:45 +00:00
nicolasconnault
825116fb22 MDL-19813 Upgraded calls to helpbutton, print_simple_box* and notify 2009-08-18 05:16:08 +00:00
nicolasconnault
e6f33a04aa MDL-19813 Upgraded calls to choose_from_menu 2009-08-18 00:13:03 +00:00
nicolasconnault
3b1d5cc46a MDL-19813 Converted print_box* to $OUTPUT->box* 2009-08-10 05:00:41 +00:00
nicolasconnault
867847e352 MDL-19813 Converted all print_footer() calls 2009-08-06 14:13:48 +00:00
nicolasconnault
90cd54cb2a MDL-19813 Migrated calls to print_heading 2009-08-06 08:23:24 +00:00
nicolasconnault
e42f153c33 MDL-19976 Changing redirect($url->out()) to redirect($url). NEVER, NEVER use redirect($url->out())!!! Bad Tim! :p 2009-07-31 09:30:11 +00:00
tjhunt
6f030b0f84 quiz editing: MDL-17730 need better skip links on the quiz editing page. 2009-07-17 06:54:58 +00:00
tjhunt
a5cb8d6987 MDL-19077 - Finish eliminating customcorners-specific code in core.
The custom-corners-specific code now in theme/customcornser/renderers.php
and lib/deprecatedlib.php.

Also, $CFG->pixpath is now causing more problems than ever. If it is
giving your problems, please call $OUTPUT->initialise_deprecated_cfg_pixpath()
as a temporary fix. As you can imagine, we are thinking about a better
long-term fix, which is why that method as a silly, and easy to grep name.
2009-06-29 08:17:31 +00:00
tjhunt
34a2777ccb themes: MDL-19077 new $OUTPUT->header/footer to replace print_header/footer.
Also, part of the change from weblib.php functions to $OUTPUT-> methods.

This is part of http://docs.moodle.org/en/Development:Theme_engines_for_Moodle%3F

This is a big change, and the result is not perfect yet. Expect some debugging output
on some pages.

The main part of these changes are that $OUTPUT->header now looks for a file
in the theme called layout.php, rather than header.html and footer.html. Also
you can have special templates for certain pages like layout-home.php. There is
fallback code for Moodle 1.9 themes, so they still work.

A few of the old arguments to print_header are no longer supported. (You get an
exception if you try to use them.) Sam H will be cleaning those up.

All the weblib functions that have been replaced with $OUTPUT-> have version in
deprecatedlib, so existing code will go on working for the foreseeable future.
2009-06-26 09:06:16 +00:00
tjhunt
c207b6bece Remove a few unnecessary references to global $THEME. 2009-06-25 03:26:58 +00:00
tjhunt
25ddb7efc9 javascript: MDL-19475 replace require_js calls with $PAGE->requires->js.
This is the final batch.
2009-06-15 07:57:53 +00:00
tjhunt
cf6155226c ajaxlib/require_js: MDL-16693 $PAGE->requires->... deprecates require_js etc.
There is a new implementation of require_js in lib/deprecatedlib.php,
based on $PAGE->requires.

There were a few other recently introduced functions in lib/weblib.php,
namely print_js_call, print_delayed_js_call, print_js_config and
standard_js_config. These have been removed, since they were never in
a stable branch, and all the places that used them have been changed
to use the newer $PAGE->requires->... methods.

get_require_js_code is also gone, and the evil places that were calling
it, even though it is an internal function, have been fixed.

Also, I made some minor improvements to the code I committed yesterday
for MDL-16695.

All that remains is to update all the places in core code that are
still using require_js.

(This commit also fixes the problem where the admin tree would not
start with the right categories expanded.)
2009-06-12 12:13:07 +00:00
tjhunt
51b9ccc084 quiz editing: MDL-19199 merged from HEAD. 2.0 can store decimals here, but we should still be cleaning input. 2009-06-05 09:25:34 +00:00
tjhunt
3e10e4292d quiz editing: MDL-17454 first attemtp, and MDL-18554
This is a minimal fix for MDL-18554, I have just added a cancel button and made it work.

The more substantial part of this is MDL-17454, trying to make the quiz editing screen behave appropriately when shuffle questions is on. I am sure Olli will have opinions about this and want to change it further. Rought summary:
* When shufflequestions is off, never restrict manual paging, even if questionsperpage is set.
* When shuffle questions is on:
** Always display the quiz with the defined number of questions per page.
** Remove controls to add things except at the end of the quiz.
** Disable most of the order and paging tab, but still allow the question list to be reordered, in case that helps teachers track which questions they have added.
** Still allow questions to be reordered on the edit tab, but when moving the top question on a page up, reorder with the previous question, rather than moving to the previous page.
* Change the status bar, so that the yellow highlight is reserved for alert information. The more informative stuff is now plain, and moved to under the title. To my mind that associates it more closely with the quiz name. Also it moves Total of grades and Maximum grade closer together.
* JavaScript cleaned up. I learn more about YUI every day.
* Some PHP code clean ups that I forgot to commit separately before making substantive changes.
2009-03-17 09:51:34 +00:00
tjhunt
4299df1daf quiz editing: Refactor the editing actions to make functions in editlib.php for most of them.
In the process, do MDL-17456, move/delete questions by question id rather than position, for greater robustness.
2009-02-27 08:45:05 +00:00
tjhunt
324d65763c quiz editing: MDL-17284 Major coding style cleanup.
This is a mixture of stuff in the coding guildelines and personal preference.
2009-02-26 08:30:45 +00:00
tjhunt
5d6f63bf71 quiz editing: tidy up quotes. 2009-02-25 06:53:10 +00:00
tjhunt
2b6ec12cd4 quiz editing: MDL-18016 fix regression, adding questions on the order and paging tab was broken. 2009-02-13 07:12:41 +00:00
tjhunt
68b1b19b16 quiz editing: Whitespace improvements. 2009-02-11 09:48:30 +00:00
tjhunt
ad65ff47d8 quiz: MDL-17873 small efficiency gains. 2009-02-11 07:52:26 +00:00
tjhunt
971c6fca06 question bank: MDL-17871 Kill most of the duplicated code between mod/quiz/editlib.php and question/editlib.php 2009-01-22 05:38:18 +00:00
tjhunt
5bd22790c4 question bank: MDL-17871 refactor the code that displays particular information about each question into classes.
More work in progress. Print column headers, and improve sorting. These classes are still not used.
2009-01-21 07:21:43 +00:00
tjhunt
f4b879ddea question bank: MDL-17302 refactor question bank display code into a class.
Step 1. Just convert the existing functions quiz_question_showbank and question_showbank and friends into methods of a class and subclass.

More to come.
2009-01-19 05:30:01 +00:00
tjhunt
b4a2e41313 quiz editing: MDL-17284 fix infinite redirect bug. 2009-01-07 07:12:37 +00:00
skodak
d4a1fcaf11 MDL-16613 sesskey cleanup 2009-01-02 10:36:25 +00:00
pilpi
28e6ac1174 quiz editing: MDL-17730 skip links; mistake in previous commit 2008-12-26 00:34:39 +00:00
pilpi
5669badfaf quiz editing: MDL-17730 skip links 2008-12-26 00:29:17 +00:00
pilpi
93cc3ea45e quiz editing: MDL-17417 added logging for random question creating 2008-12-16 22:36:29 +00:00
pilpi
0b31bfe8c3 quiz editing: MDL-17664 Removed unneeded yui js includes 2008-12-16 11:21:22 +00:00
tjhunt
4e6f553d43 quiz editing: MDL-15903 fix the code that updates $quiz->sumgrades,
so we only update the database when something changes, not on every page view.
2008-12-05 05:08:37 +00:00
pilpi
3e6ad1d7a4 quiz editing: MDL-17409 removed ":" from source
removed ":" from source where they occured with new (committed with the rest of Quiz UI redesign project) strings and changed the strings accordingly
2008-12-04 13:28:20 +00:00
pilpi
4897ae1b94 quiz editing: MDL-17294 removed unnecessary comment 2008-11-28 18:58:30 +00:00
pilpi
8c4d6dd2a2 quiz editing: MDL-17294 removed the $showbreaks parameter from quiz_print_question_list 2008-11-28 18:37:24 +00:00
pilpi
c7c7f25a84 quiz editing: MDL-17294 changed quiz_process_randomquestion_formdata to always return (instead of sometimes redirecting) 2008-11-28 17:29:04 +00:00
tjhunt
1372b5d2cf quiz editing: MDL-17298 We should not add JavaScript to the YAHOO namespace Also, use the newer methods for including required JavaScript. 2008-11-25 12:31:59 +00:00
pilpi
8bccba71e6 quiz editing: MDL-17299 Moved function definitions from mod/quiz/edit.php to mod/quiz/editlib.php 2008-11-22 12:36:14 +00:00
pilpi
d9daa35ca9 quiz editing: MDL-17297 Got rid of editcss.js and adjusted stylesheets accordingly 2008-11-22 11:42:06 +00:00
pilpi
1cdbd5e46f quiz editing: MDL-17301 avoid inline CSS in mod/quiz/edit.php 2008-11-22 11:29:20 +00:00
pilpi
218dfb9127 quiz editing: MDL-17291 Question moving functionality to a user-selected page now manipulates an array instead of string
The old implementation was string-based and flawed, so switched to a more readable array-based one.

Also removed strpos2() since it was only used in edit.php locally and due to this change became unused.
2008-11-21 17:08:36 +00:00
pilpi
47a8933f62 quiz editing: MDL-17288 Lang string issues
questionsperpageselected and shufflequestionsselected from lang/en_utf8/quiz.php now use a $a, rather than concatenation.
2008-11-21 13:35:15 +00:00
tjhunt
fa583f5f6e quiz editing: MDL-17285 This is Olli Savolainen's new interface for editing quizzes.
This was started and usability tested as a Finnish Summer of Code project, and then Olli did further work on it in his own time to get it in shape for inclusion in Moodle 2.0. I reviewed all the code. There are a number of minor outstanding issues that will be fixed soon. See the subtasks of MDL-17284 for a list.

The goal of these changes is to:
* help teachers new to Moodle, so when they first see the quiz editing page, they don't go "Huh! What on earth am I supposed to do here?"
* help novice Moodle users understand and learn to use some of the more advanced quiz feature;
* but, without slowing down more experienced quiz users.

Naturally, with ambitous goals like that, we won't have managed to satisy everybody, but I think this change is a big step in the right direction.

There is extensive documentation on this project at http://docs.moodle.org/en/Development:Quiz_UI_redesign.
2008-11-20 06:59:11 +00:00
tjhunt
339ef4c246 random questions: MDL-17160 Adding random questions, maximum option.
When counting how many options to put in the add NN random questions dropdown, we should only count questions of types that are usable by random.
2008-11-07 05:50:02 +00:00
dongsheng
a6344df49a "MDL-14129, fixed hardcoded print_header in quiz module" 2008-09-25 08:21:59 +00:00
tjhunt
e2249afe2b MDL-7010 Convert mod\quiz\config.html to mod/quiz/settingstree.php using the new admin tree system. 2008-08-26 01:05:01 +00:00
skodak
245ac55791 MDL-14679 last forgotten bits of dml conversion 2008-06-09 19:48:24 +00:00