Commit graph

559 commits

Author SHA1 Message Date
nicolasconnault
8ad36f4cc3 Added copyright notice 2007-10-10 06:34:20 +00:00
nicolasconnault
b7064779f5 Updated copyright notice in header 2007-10-10 05:25:14 +00:00
skodak
d763511fdd inherit by default decimal points in ranges and averages on grader report 2007-10-09 09:29:45 +00:00
moodler
dff9d94d6e Added CSS classes to totals columns (cat and course) so that styles can be applied.
Made them bold by default in standard anc custom_corners.

MDL-11666
2007-10-09 09:16:44 +00:00
toyomoyo
b11d9a9139 MDL-11665, users with no grade:viewhidden capability gets a wrong upgrade count because after deletion of a grade, the grade can be NULL and not hidden at the same time 2007-10-09 05:43:35 +00:00
skodak
e072450699 MDL-11578 , MDL-11578 , MDL-11573 :
* renamed Preferences to "My report preferences"
* renamed Site defaults to "Report defaults"
* rename Change site defaults to "Change report defaults"
* reintroduced Inherit option to Grader preferences - Nicolas was right, it is not possible to implement preference overrides without it with our current get_pref inplementation
* new separate option in plugin selector "Course settings"
* moved displaytype, decimals and aggregation position to "Course settings"
* created new table grade_settings + related functions grade_get/set_preference()
* user report now uses grade_seq class instead of grade_item::fetch_all(); added preloading of grade items into grade_grade instances
* other minor bugfixing/cleanup/improvements

Please note that the Grader report preferences and its defaults must be resaved again - sorry.
2007-10-08 23:09:10 +00:00
nicolasconnault
e699389e47 Creating course grade_category and course grade_item when not yet created and overview report is accessed 2007-10-08 09:54:51 +00:00
nicolasconnault
d0b83b0033 Making the overview report viewable by student role by default 2007-10-08 09:53:43 +00:00
moodler
4354a3e563 Some fixes to make preferences work correctly (if not set then they are 0) and so now ranges and averages show correctly on grader report when these are set to defaults in preferences MDL-11618 2007-10-08 07:26:29 +00:00
moodler
d9c1a97188 Cleaner saving of grader report prefs 2007-10-08 07:11:22 +00:00
moodler
4baf254f5a Re-ordered some preferences to be a bit more logical 2007-10-08 06:55:34 +00:00
toyomoyo
1b39b03a84 MDL-11616, adding activity link back for hidden grade items 2007-10-08 02:34:04 +00:00
skodak
d622930b39 MDL-11618 removed the inherit override from decimals and gradetype used on grader report preferences + several bug fixes + settings improvements 2007-10-07 18:15:57 +00:00
skodak
bb49f77b84 fixed whitespace 2007-10-05 14:31:57 +00:00
skodak
0dba6cb2c5 MDL-11576 grader report - if user can not see hidden grades they are treated as NULLs and column totals 2007-10-05 09:47:31 +00:00
nicolasconnault
323956abd9 MDL-11519 Commented out the Ajax option 2007-10-05 05:37:55 +00:00
skodak
4f30c61dc8 MDL-11599 missing return statement 2007-10-04 17:09:34 +00:00
nicolasconnault
3126103b74 Re-enabling inherit options for range and average rows in grader report 2007-10-04 15:07:08 +00:00
nicolasconnault
78a2d9f05f Re-enabling inherit options for range and average rows in grader report 2007-10-04 09:30:16 +00:00
nicolasconnault
5961dbfb10 MDL-11576 Added the groupsql clause to has_hidden_grades 2007-10-04 08:16:13 +00:00
nicolasconnault
6df5b04ec7 MDL-11576 New grade_item method has_hidden_grades(), which returns a simple count of hidden grades for the item. 2007-10-04 08:02:00 +00:00
nicolasconnault
a7c3671a92 MDL-11581 Implemented gradedisplaytype in user reports 2007-10-04 07:02:44 +00:00
skodak
8dd5c1ee2f MDL-11585 false is not allowed default in admin_setting_configselect constructor 2007-10-03 20:02:12 +00:00
skodak
0e4da9e34f fixed context parameter in has_capability() call 2007-10-03 14:16:04 +00:00
nicolasconnault
ece966f06e MDL-11482 Resolved the sum icon issue (added a new x-bar icon) and resolved a dependency problem in moodlelib 2007-10-03 12:22:25 +00:00
skodak
284abb0925 MDL-11495 grade letter setting improvements:
* in_null for decimals defaults checks
* store letter settings only in database - no cfg settings
* separate configuration page for letters only - pluginselector+admin tree
* new capability to manage grade letters - similar to scales and outcomes
* added grade_letters db index
* grade letters related minor bugfixing
2007-09-28 20:12:43 +00:00
nicolasconnault
e9096dc2ca MDL-11480 Reviewed, tested, and pplied Petr's patch. 2007-09-28 07:55:51 +00:00
toyomoyo
e5ea84faba MDL-11478, fixing a notice 2007-09-28 01:53:45 +00:00
nicolasconnault
9fa46707f3 MDL-11456 the .grade-report-grader table {} style was cascading down to the popups (which use tables, alas...), so I created a number of css classes which now control color, font etc for caption and feedback cells of the popup. 2007-09-27 18:00:25 +00:00
toyomoyo
0893aa30e8 when no gradebook roles is set, there are lots of sql breakages so we should check gradebookroles first 2007-09-27 02:29:46 +00:00
nicolasconnault
d32100a522 Fixing OU report issues 2007-09-25 19:32:29 +00:00
nicolasconnault
31a6c06c46 MDL-11433 Implemented grade_items.decimals instead of user preference in grader report. 2007-09-25 14:40:49 +00:00
nicolasconnault
1796708d81 Replacing GRADE_REPORT_GRADE_DISPLAY_TYPE... by GRADE_DISPLAY_TYPE... 2007-09-25 08:22:20 +00:00
skodak
465b310d2b prevent error when somebody changes scale or grading type - old value does not fit the new scale 2007-09-23 12:09:16 +00:00
skodak
3f2b0c8aba MDL-11363 merged tables grade_grades with grade_grades_text - it is now possible to define fields as required and optional
finally fixed formula validation in calculation edit form
2007-09-22 11:39:59 +00:00
nicolasconnault
41f22daa71 MDL-11353 Completed the implementation. This included a new method in grade_item: get_displaytype(), since that value could be set to default, and we must then look up to course, then site values. And the get_letter() method in grade_grade has been modified to first check the grade_letters table. All works like a dream! 2007-09-19 15:37:46 +00:00
nicolasconnault
dbdffd2c96 MDL-11340 Almost complete: Just need the "Add grade letter" button 2007-09-19 12:45:44 +00:00
nicolasconnault
a5b8be622c MDL-11275 added (submissions). Also fixed :
Issue:
    Teachers can edit grader report preferences (including switches for quickgrading and
    quickfeedback), but do not have access to the "Turn editing on/off" button, so they
    can't do quickgrading.
Solutions:
    1.Decouple the quickgrading and quickfeedback modes from the editing mode,
        and turn them on/off through the preferences page. New capability: moodle/grade:edit
        * preferences: don't show quickgrading if no capability grade:edit
        * If quickgrading is switched off as a preference and user doesn't have manage cap, show edit icons around grades when in editing mode
2007-09-17 17:31:48 +00:00
toyomoyo
5bb8a8154e MDL-11084, "s in grade comments causes problems 2007-09-17 06:53:24 +00:00
toyomoyo
4581501ede MDL-11276, average calculations are inaccurate in percentage form due to double rounding 2007-09-17 04:25:51 +00:00
toyomoyo
cb68af8b89 removing extra number_format(), format_float() already calls number_format() 2007-09-17 02:15:51 +00:00
toyomoyo
00374cc5f0 MDL-11274, hide grades in the grader report if the current grades has no viewhidden capability 2007-09-14 08:43:10 +00:00
nicolasconnault
098042baea Issue:
The number of submissions in the Group average and Course average calculations
    should be shown in brackets. (submissions) should be added after the Group average
    and Course average labels.
Solution:
    new grader report preference (Display number of grades in average cells).
2007-09-14 06:57:30 +00:00
moodler
2c7a9bd2af Fix the location of the link to the site-wide grading preferences 2007-09-14 06:51:57 +00:00
moodler
6308b91c13 Changing string for Overall average (was logged under MDL-11233 even though that's not strictly the correct bug) 2007-09-14 05:45:38 +00:00
nicolasconnault
aae94377b7 Issue:
Only students should appear in the tutor report, however
    sorting by Surname results in the tutor being included, which we don't want.
Solution:
    Confirmed as a bug and filed in tracker: http://tracker.moodle.org/browse/MDL-11233

Issue:
    Clicking on Hide Groups reveals the results for all students
    and all tutors and course staff appear. A tutor should only be able to see
    the results for their tutor group
Solution:
    Prevent tutors from ever seeing student grades from other groups: use existing capabilities
        moodle/site:accessallgroups = off AND moodle/grade:viewall = on

Issue:
    Preferences tab should not be available to users without gradereport/grader:manage capability
Solution:
    Hide the tab completely

Issue:
    Apply different style to average cells
Solution:
    Add css classes to the different average cells, and write a default style in css file.

Issue:
    The Average under group average might be better labelled Course average.
Solution:
    Rename to "Complete average"
2007-09-13 15:11:16 +00:00
nicolasconnault
c421ad4b2e MDL-11233 Corrected typo in grader report lib, and added a second sort parameter for lastname and firstname sorts, to add consistency to result sets. Non-students no longer appear in the list 2007-09-13 13:44:35 +00:00
nicolasconnault
b1b6ebf437 Replacing the capability gradereport/grader:manage with moodle/grade:manage 2007-09-12 15:02:06 +00:00
skodak
b2bc96d10b MDL-7380 added new groups API functions for use in course related pages (very similar to functions for activities) + fixed grade code to use these new functions 2007-09-06 10:19:24 +00:00
skodak
c2efb50142 MDL-11130 added aggregation inside all subcategories + added graded/all aggregation option 2007-09-05 19:15:21 +00:00