Commit graph

910 commits

Author SHA1 Message Date
Dan Poltawski
c201e4df40 Merge branch 'MDL-58772' of git://github.com/aolley/moodle 2017-05-03 16:50:29 +01:00
Adam Olley
0fb1335924 MDL-58772 mod_feedback: Dont overwrite anonymous entries
The feedback module lets you alternate between responses being anonymised and
not anonymised. When the module is in anonymous mode, its possible for a single
user to make multiple responses.

However when the activity is switched to non-anon mode, if a user leaves a
follow up feedback, one of their previously anonymous responses is used, so
their new response stays anonymous and their old anon response is lost.

This change lets them leave a new non-anonymised feedback entry and retains all
previous anonymous responses instead of incorrectly reusing one of their anon
ones at random.
2017-05-02 12:49:33 +09:30
Andrew Nicols
db2c66e700 Merge branch 'wip-MDL-58665-master' of git://github.com/marinaglancy/moodle 2017-05-02 09:00:07 +08:00
Marina Glancy
bb9d5f7f1b MDL-55468 mod_feedback: revive export analysis to excel 2017-05-01 14:28:55 +01:00
Marina Glancy
aa708b550e MDL-58665 mod_feedback: avoid extra db queries on dashboard 2017-05-01 12:57:19 +08:00
Marina Glancy
438c01d0dd MDL-58731 modules: display intro on the course page
something that was forgotten when adding _get_coursemodule_info to activities in MDL-58190
2017-04-28 09:14:25 +08:00
Marina Glancy
23e5104ae2 MDL-58666 course: add module name to cache
without it there will be an extra db read in get_array_of_activities() to retrieve it for each activity
2017-04-21 13:00:28 +08:00
Andrew Nicols
e44400ceca Merge branch 'MDL-58494-master' of git://github.com/ryanwyllie/moodle 2017-04-20 15:23:50 +08:00
Ryan Wyllie
55e55a773f MDL-58494 mod_feedback: no action after feedback submitted
Don't provide an action in the action event callback if the user has
already submitted their feedback or if they don't have permission to
submit.
2017-04-20 05:51:32 +00:00
Jake Dallimore
d8f9177462 Merge branch 'MDL-58412-master' of git://github.com/jleyva/moodle 2017-04-20 09:56:10 +08:00
Juan Leyva
cadae8dce6 MDL-58412 mod_feedback: Use constant for anonymous feedback
We were using hardcoded values instead the correct constant
FEEDBACK_ANONYMOUS_NO
2017-04-19 11:37:15 +02:00
Andrew Nicols
442908a100 Merge branch 'MDL-58138-master-v2' of git://github.com/snake/moodle 2017-04-19 11:53:40 +08:00
Jake Dallimore
273d310601 MDL-58138 completion: Fixes for a number of small issues. 2017-04-19 11:41:57 +08:00
Jake Dallimore
8db355c58f MDL-58138 tests: unit and behat tests covering bulk and default tabs
Part of MDL-58138 epic
2017-04-19 08:56:11 +08:00
Marina Glancy
7f53e8aa22 MDL-58267 completion: allow to set default activity completion
Part of MDL-58138 epic
2017-04-19 08:54:35 +08:00
Marina Glancy
06cdda468a MDL-58139 completion: bulk update completion
Part of MDL-58138 epic
2017-04-19 08:52:57 +08:00
Jake Dallimore
b54bcddda4 MDL-58190 completion: callbacks to get completion rule descriptions
- Activities can have their custom completion rules added to cm_info
through the get_coursemodule_info callback.
- Descriptions of a modules active completion rules can be fetched using
the component callback mod_xxx_get_completion_active_rule_descriptions
which takes in a cm_info object and returns an array of strings.

Part of MDL-58138 epic
2017-04-19 08:52:57 +08:00
Dan Poltawski
9c1889810a Merge branch 'wip-MDL-58502-master' of git://github.com/marinaglancy/moodle 2017-04-18 19:48:35 +01:00
Mark Nelson
59391e80ad MDL-58501 mod_*: improved docs for new calendar callbacks 2017-04-12 17:43:52 +08:00
Eloy Lafuente (stronk7)
ad02561c15 Merge branch 'MDL-58453-master' of git://github.com/jleyva/moodle 2017-04-11 16:47:29 +02:00
Juan Leyva
7f700290b2 MDL-58453 mod_feedback: Add missing security checks
Some checks done in mod/feedback/show_nonrespondents.php were missing.
- Check for anonymous feedback
- Check for real courses (not site home)
2017-04-11 09:42:27 +01:00
Andrew Nicols
23605e9fbc Merge branch 'MDL-58504_master' of git://github.com/markn86/moodle 2017-04-11 08:57:30 +08:00
David Monllao
fff1b3c464 Merge branch 'wip-MDL-55950-master' of git://github.com/marinaglancy/moodle 2017-04-10 16:05:07 +02:00
David Monllao
d096ebe0e4 MDL-56370 mod_feedback: Note about undeprecation 2017-04-10 13:15:15 +02:00
David Monllao
af938cf46e Merge branch 'wip-MDL-56370-master' of git://github.com/marinaglancy/moodle 2017-04-10 13:13:20 +02:00
Andrew Nicols
b140b13c25 Merge branch 'MDL-58453-master' of git://github.com/jleyva/moodle 2017-04-10 11:23:37 +08:00
Marina Glancy
85b969f130 MDL-56370 mod_feedback: behat for repeat completion 2017-04-07 16:04:06 +08:00
Marina Glancy
d6f77a435f MDL-56370 mod_feedback: allow to restore values from last attempt 2017-04-07 16:04:06 +08:00
Marina Glancy
d0b4c8a787 MDL-55950 mod_feedback: correct link to response in the email 2017-04-07 16:03:42 +08:00
Marina Glancy
f4dba1755c MDL-58502 mod_feedback: courseid is not course where feedback is 2017-04-07 16:02:39 +08:00
Juan Leyva
94478c083d MDL-57813 mod_feedback: New WS mod_feedback_get_last_completed 2017-04-06 09:40:26 +02:00
Mark Nelson
01f96180ff MDL-58504 mod_*: fixed PHPDoc return type for *_provide_event_action 2017-04-06 15:00:02 +08:00
Juan Leyva
682aea9b84 MDL-58453 mod_feedback: Refactor get_non_respondents WS
We should return more information like if the user started or not the
feedback and the total number of non respondents (to be able to
paginate).
2017-04-05 09:28:29 +02:00
Juan Leyva
007b7cad82 MDL-57813 mod_feedback: Create exporter and required API changes 2017-04-05 09:07:43 +02:00
Jun Pataleta
458315f857 Merge branch 'MDL-57821-master' of git://github.com/jleyva/moodle 2017-04-05 09:39:02 +08:00
Dan Poltawski
1e4e5c52d7 Merge branch 'MDL-55611-master' of git://github.com/danpoltawski/moodle 2017-04-04 17:07:41 +01:00
Mark Nelson
e1cd93ce20 MDL-58423 core_calendar: moved \core_calendar\event class
Part of MDL-55611 epic.
2017-04-04 11:01:49 +01:00
Juan Leyva
a24289f12f MDL-57821 mod_feedback: New WS mod_feedback_get_responses_analysis 2017-04-04 12:01:23 +02:00
Juan Leyva
495745a36e MDL-57821 mod_feedback: Allow export tables to external structure 2017-04-04 12:01:22 +02:00
Andrew Nicols
b375ec262d MDL-58363 mod_feedback: Remove calendar is_visible
Part of MDL-55611 epic.
2017-04-03 11:37:09 +08:00
Jun Pataleta
e44d71a6ee MDL-58102 mod: Set sensible defaults for additional completion fields
Part of MDL-55611 epic.
2017-04-03 11:37:08 +08:00
Simey Lameze
07d1abe346 MDL-58265 mod_feedback: change custom step to link behat to course
Part of MDL-55611 epic.
2017-04-03 11:37:08 +08:00
Simey Lameze
fdeeaff954 MDL-58265 core_test: replace I turn editing on steps
Also remove few more unnecessary steps that redirects behat to
site home page to actually get to the course.

Part of MDL-55611 epic.
2017-04-03 11:37:07 +08:00
Simey Lameze
93be3f730c MDL-58265 core_test: remove unnecessary steps
This commmit removes steps that take behat to site home page
to actually get to a course page.

Part of MDL-55611 epic.
2017-04-03 11:37:07 +08:00
Simey Lameze
c987d1b2ef MDL-58265 core_test: replace all uses of I follow course steps
Part of MDL-55611 epic.
2017-04-03 11:37:07 +08:00
Simey Lameze
90e8330f1a MDL-57879 mod_feedback: add action events
Part of MDL-55611 epic.
2017-04-03 11:36:33 +08:00
Mark Nelson
e057f279e4 MDL-57497 core_calendar: added new calendar event class
Moved calendar_event class to new location using replaceclasses.php

Part of MDL-55611 epic.
2017-04-03 11:33:55 +08:00
Juan Leyva
0a34838725 MDL-57411 course: Return modules updates for teachers 2017-04-01 19:39:02 +02:00
Andrew Nicols
6e1523c38b MDL-57822 feedback: Correct page param for nonrespondents WS 2017-03-29 11:20:57 +08:00
David Monllao
46c6d0df5a Merge branch 'MDL-57822_master' of git://github.com/dmonllao/moodle 2017-03-28 22:57:15 +02:00