Commit graph

22028 commits

Author SHA1 Message Date
sam marshall
5c2ef08fa3 MDL-55628 Completion: Use simpledata for completion cache
The completion cache is currently not marked as simpledata. On the
course page it is frequently retrieved hundreds of times which results
in many calls to the slow unserialize function. By making a slight
change to the data format (using arrays instead of objects) we can
mark it as simpledata, which will avoid using unserialize.
2016-08-22 17:13:36 +01:00
sam marshall
b16b1f86b1 MDL-55650 Library: s() function - tweak parameters for performance
The s() function includes a comment saying that parameter options
should be modified to improve performance once PHP 5.4 is required.
Since Moodle has required PHP 5.4 for some time, we should probably
make the change and remove the comment.

According to my benchmarking, these changes make s() about 7% faster
and will save a staggering 2ms from a typical course view that calls
it 8,000 times.
2016-08-22 15:38:13 +01:00
David Mudrák
4e96165e59 MDL-55660 tablelib: Fetch only a single row when auto defining columns
In a very rare cases where the columns are not declared explicitly, we
want to fetch single row only without a warning raised. This seems like
a valid use case for IGNORE_MULTIPLE flag.
2016-08-22 16:34:13 +02:00
Dan Poltawski
080f292ed7 Merge branch 'MDL-55273-cookie-secure-default' of https://github.com/brendanheywood/moodle 2016-08-22 15:25:15 +01:00
Dan Poltawski
cfbba4a94c Merge branch 'MDL-54864-master' of https://github.com/snake/moodle 2016-08-22 11:19:32 +01:00
Dan Poltawski
a55ff4d9fe Merge branch 'MDL_55423_master' of https://github.com/alexandru-elisei/moodle 2016-08-22 09:26:28 +01:00
Jake Dallimore
d7d4a09707 MDL-54864 core_question: Enforce context,stamp uniqueness for category
Added an upgrade step to remove duplicate stamps, added a unique index
on (contextid, stamp) and modified the question_category edit code such
that stamp duplication in the same context is not permitted.
2016-08-22 09:44:52 +08:00
Brendan Heywood
657ddbf592 MDL-55273 admin: Change $CFG->cookiesecure default to on 2016-08-22 09:20:32 +10:00
Rajesh Taneja
e99f0cbba6
MDL-55072 behat: refactor behat_config_manager 2016-08-19 06:49:13 +08:00
Rajesh Taneja
39eb8abe15
MDL-46514 behat: Delete tablesupdatedbyscenario before suite
Delete tablesupdatedbyscenario before db reset to ensure
db is fully reset. In case user exits or process terminated
then the file will be left and can lead to wrong results
2016-08-19 06:46:27 +08:00
Rajesh Taneja
43759f5e23
MDL-46514 behat: Catch errors shown by JS 2016-08-19 06:46:27 +08:00
Adrian Greeve
3b873397e6 MDL-22183 lib: More unit tests for next day start. 2016-08-18 10:13:31 +08:00
Adrian Greeve
3cdc35b44d MDL-22183 lib: Cleanup of get_next functions. 2016-08-18 10:13:31 +08:00
Adrian Greeve
4ae0691169 MDL-22183 lib: Time settings removed for stats cron.
Old settings that should be ignored have been removed from the
statistics cron code.
2016-08-18 10:13:31 +08:00
Alexandru Elisei
03856ac5e8 MDL-55423 accesslib: Prevent get_role_users() false debugging messages 2016-08-17 20:43:39 +03:00
Dan Poltawski
40a952bf0f MDL-55585 bump versions 2016-08-17 12:12:00 +01:00
Dan Poltawski
e3c9de6831 Merge branch 'MDL-55585_master' of git://github.com/dmonllao/moodle 2016-08-17 12:10:22 +01:00
Andrew Nicols
b4bb1e65dc Merge branch 'MDL-55445-master-2nd' of git://github.com/FMCorz/moodle 2016-08-17 11:25:24 +08:00
Frederic Massart
2258b4dc41
MDL-55445 core: New setting to host the logos 2016-08-17 10:26:31 +08:00
Frederic Massart
19efee14e2
MDL-55445 files: Helper functions related to serving and caching
The function send_content_uncached() is meant to be used when serving
content which should not be cached by browsers/proxies. You will
use this in development mode, or when the request is malformed
but you need to return some fallback content which shouldn't be stored
under the URL it was requested from.

The function file_safe_save_content() should only be used for content
not stored in the file API. Good candidates for this are resource
which fit well in the localcache. The function tries to write the
content in the most atomic way as possible to prevent incomplete
writes or concurrent writes.
2016-08-17 10:26:10 +08:00
David Monllao
0c417cdc5c MDL-55585 search: Remove missing report/search file 2016-08-16 17:50:19 +08:00
Andrew Nicols
9d8a3055c0 Merge branch 'MDL-55272' of https://github.com/mr-russ/moodle 2016-08-16 14:55:49 +08:00
Andrew Nicols
88a0cdada4 Merge branch 'MDL-54680-master' of https://github.com/xow/moodle 2016-08-16 14:45:33 +08:00
John Okely
3e9ab40361 MDL-54680 enrol_lti: Offer cartridges in LTI provider 2016-08-16 14:15:02 +08:00
Damyon Wiese
bb0b39b839 MDL-55520 forms: Properly format the grademax for the database 2016-08-16 11:19:51 +08:00
Russell Smith
6a3acc84de MDL-55272 lib: Improve test course create performance
Use core functions that are faster for test file creation.
To support large requests for hashes, the core hash function
must support large hashes without recursion.  PHP has a default
recursion depth of 100 and long hashes don't support this.

Remove transactions as they create performance problems for larger
courses and doesn't introduce significant benefit for developers.

Performance changes meant the times were much faster, a reasonable
guess was taken on performance of an average machine.
2016-08-16 12:00:21 +10:00
Andrew Nicols
e144182592 MDL-54647 tests: Clarify unoconv tests 2016-08-16 08:11:13 +08:00
Andrew Nicols
0a0eaa7dfc Merge branch 'MDL-54647-master' of git://github.com/damyon/moodle 2016-08-16 08:01:47 +08:00
Dan Poltawski
623f92f9f7 Merge branch 'MDL-46214-master' of git://github.com/andrewnicols/moodle 2016-08-15 09:47:02 +01:00
Damyon Wiese
36ba9c3e76 MDL-54647 tests: Reverse order of expected and actual 2016-08-15 16:34:11 +08:00
Damyon Wiese
300852ee30 MDL-54647 file_storage: Redo the test pdf every time it's viewed 2016-08-15 16:32:21 +08:00
Andrew Nicols
40cc0ba04e Merge branch 'MDL-55513-master' of https://github.com/lucisgit/moodle 2016-08-15 14:07:41 +08:00
Andrew Nicols
098aad4f72 Merge branch 'MDL-55520-master' of git://github.com/damyon/moodle 2016-08-15 10:58:39 +08:00
Frederic Massart
0eb97bfa13
MDL-55445 files: Support for cacheability in send_file() 2016-08-15 10:54:29 +08:00
Frederic Massart
92b9ef9917
MDL-55445 gdlib: Support for resizing an image 2016-08-15 10:54:28 +08:00
Andrew Nicols
62192d93ea MDL-46214 event: Mark previously deprecated events as deprecated 2016-08-15 09:17:02 +08:00
Andrew Nicols
51d85c7c6c MDL-46214 event: Support deprecation of events
This patch adds two new functions to the event base to allow deprecation of
the individual events, without entirely removing them from the UI.

This is different to our normal deprecation procedure because all events
must support display of historical data. It must also be possible to view
the event information in the event monitor.
2016-08-15 09:17:02 +08:00
Stephen Bourget
2ce8cf628f MDL-55239 Badges: Additional events for badges 2016-08-11 21:16:35 -04:00
Damyon Wiese
c3d4d3f7c1 MDL-55520 forms: Mod grade is changing values back to default
When a field is disabled in the page - no value is sent and modgrade is reverting
to the default. This change prevents the max grade from changing accidentally.
2016-08-11 14:43:05 +08:00
Tony Butler
2ee668ec56 MDL-55513 core_filestorage: Touch and test size instead of file_exists()
file_exists() can return false when file exists (in certain scenarios)
2016-08-10 09:35:23 +01:00
Tony Butler
e98483d748 MDL-55513 core_filestorage: Pass full path of temp dir to remove_dir() 2016-08-10 09:35:23 +01:00
Dan Poltawski
017230d576 Merge branch 'MDL-53765-master' of git://github.com/junpataleta/moodle 2016-08-09 13:56:49 +01:00
Dan Poltawski
a9dbd914a0 Merge branch 'MDL-55246_unoconv' of https://github.com/Syxton/moodle 2016-08-09 10:11:13 +01:00
Dan Poltawski
6259952eb2 Merge branch 'MDL-54606' of https://github.com/mr-russ/moodle 2016-08-09 09:32:46 +01:00
Andrew Nicols
5fa90114d7 MDL-55329 behat: Correct typo 2016-08-09 14:41:22 +08:00
Andrew Nicols
8173c3ef7f Merge branch 'wip-mdl-55329' of https://github.com/rajeshtaneja/moodle 2016-08-09 14:26:09 +08:00
Rajesh Taneja
e259795c4f
MDL-55329 behat: PyStrings should end with : (colon) 2016-08-09 14:22:21 +08:00
Andrew Nicols
20195fb46a Merge branch 'wip-mdl-41126' of https://github.com/rajeshtaneja/moodle 2016-08-09 12:47:35 +08:00
Andrew Nicols
a5aa1b6b00 Merge branch 'MDL-53016-master' of https://github.com/xow/moodle 2016-08-09 11:41:09 +08:00
Jun Pataleta
d3932d2b51 MDL-53765 core: Deprecate update_module_button functions
First stage deprecation for the functions update_module_button and
core_renderer::update_module_button().
2016-08-09 11:17:43 +08:00