Commit graph

170 commits

Author SHA1 Message Date
toyomoyo
8f5a640165 MDL-12419, do not present course start date if start date is invalid 2007-12-04 01:04:03 +00:00
scyrma
d417533252 Fix for par of the missing strings, as reported in MDL-12294 2007-11-26 04:10:08 +00:00
moodler
21090e447a Merged from 1.9
Improvements to the tabs for assigning and overriding roles.   MDL-12120

Tabs are now all on the top row
Tabs have clearer titles
Other help texts improved
2007-11-19 07:13:02 +00:00
tjhunt
9a41d8a1f1 MDL-11784 - On the role assign page, list who is assigned the role for roles with only a few assignments. Improved version. Now, it only shows the extra column if some roles have between 1 and 10 assignees, as per Martin D's request. Merged from MOODLE_19_STABLE. 2007-10-29 15:38:46 +00:00
tjhunt
3a48e3da50 MDL-11917 - Improve the title on the assign/override roles page. Merged from MOODLE_19_STABLE. 2007-10-26 17:00:05 +00:00
tjhunt
dcd55b7e80 MDL-11784 - On the role assign page, list who is assigned the role for roles with only a few assignments. Merged from MOODLE_19_STABLE. 2007-10-23 16:27:25 +00:00
toyomoyo
cb8cb8bf88 MDL-11241, adding logs for roles management 2007-10-18 05:53:14 +00:00
skodak
128f098418 MDL-11640
* improved handling of dirty contexts in general - caching, switching in cron, marking, loading, etc.
* role_assing() and role_unassign() now marks dirty contexts because we use has_capability() in this function - we can not do it later outside to speedup bulk operations
* fixed some inline docs
* fixed notice from rs closing
* removed cached $CONTEXT from has_capability() - $context is now required parameter; this was hiding serious bugs when context did not exist or ppl passed false as parameter
* removed some ===, we can not use these on function parameters - we must support ints, strings, '', nulls, etc. - this could be a source of really dangerous bugs in future
* some other improvements and fixes - documented inline
2007-10-09 12:49:54 +00:00
nicolasconnault
2f6c662f41 MDL-11379 and MDL-11380 fixed 2007-09-21 07:52:52 +00:00
martinlanghoff
e6560e39d7 admin/roles: context-specific role changes mark the context as dirty
And will force a reload of $USER->access for logged-in users that need
to read _this_ context. Much lower impact - still not a great idea to
edit assignments/caps on very busy courses, but impact should be low.
2007-09-19 07:10:52 +00:00
martinlanghoff
690c946c15 get_role_users() callers rework to use the new $gethidden 2007-09-19 07:09:50 +00:00
toyomoyo
40e0bea5cc minor fix for count of users 2007-09-19 03:48:44 +00:00
toyomoyo
60410add64 MDL-11324, only display users with moodle:course/view capability when assinging in module context or lower 2007-09-19 03:31:22 +00:00
moodler
d13d30ef78 The "alias" role names were not being used in the role assign screens. Now they are. MDL-11323 2007-09-18 08:35:12 +00:00
toyomoyo
694d100512 merged fix for MDL-11111 number of search results is not always correct in the role assignment view 2007-09-07 03:16:25 +00:00
nicolasconnault
f1af7aaaf5 MDL-10870 All files updated to new build_navigation() method. 2007-08-17 07:25:47 +00:00
toyomoyo
5480af3724 MDL-10181 manual enrolment changes 2007-07-04 02:35:52 +00:00
toyomoyo
9fffb69162 MDL-8877, specify time of manual enrolments and related improvements for changing enrolment period from user/index.php. Thanks Andrei! 2007-05-22 02:08:22 +00:00
skodak
40935142f7 MDL-9647 simplify dealing with headers/footers in admin sections; some more cleanup
fixed continue button in error() on admin page when link present
2007-04-30 17:28:29 +00:00
skodak
1ae083e424 MDL-9647 simplify dealing with headers/footers in admin sections 2007-04-30 17:08:34 +00:00
tjhunt
71248ce89e MDL-9061 - Only show global assign roles warning if you are assigning roles in the global context! Also, change name of admin menu entry to reduce confusion. Merged from MOODLE_18_STABLE. 2007-03-28 16:57:22 +00:00
nicolasconnault
0c0ffc08e7 MDL-9061 2007-03-27 06:58:27 +00:00
skodak
efe12f6c22 MDL-8524 general roles cleanup; MDL-8373 authenticated user role now created during upgrade from 1.7.x, xhtml and CSS cleanup in roles GUI; accesslib inline docs cleanup; risk bitmask fixes 2007-03-05 11:27:01 +00:00
moodler
6ba65fa08d Merged Nicolas' changes from MDL-8582 into HEAD. 2007-02-28 06:25:22 +00:00
toyomoyo
20e0a8021d fix for MDL-8399, unable to unassign self as admin in courses 2007-02-09 01:04:02 +00:00
toyomoyo
fbe31d22d1 xhtml validation fixes for MDL-8425 2007-02-06 08:24:37 +00:00
skodak
84c8ede022 MDL-8343 reorganize frontpage settings in admintree - admin tree now allows to specify context together with required capability for each entry
MDL-8352 Fully separate CONTEXT_COURSE, SITEID from COURSE_SYSTEM - first part of cleanup related to frontpage
2007-01-29 21:29:27 +00:00
skodak
e8e0bb2d7b MDL-8096 - advanced edit now mostly works, though still some parts missing; RIP changeme user :-) 2007-01-25 11:03:33 +00:00
Martin Langhoff
f3f7610c90 cvsimport fixups -- cvshead had strayed from upstream 2007-01-04 13:15:04 +13:00
toyomoyo
e4f86bb041 MDL-7861, fixing minor xhtml strict problem 2006-12-18 05:03:36 +00:00
toyomoyo
30c82426e3 merged fixed a bug where admin can't unassign himself from non-admin role in site context 2006-12-04 01:54:24 +00:00
toyomoyo
5613dbca34 giving some indication a role assignment is a hidden one 2006-11-21 06:42:38 +00:00
skodak
89d30d0230 removed JS from admin/course/assign.php MDL-7492 2006-11-20 08:29:50 +00:00
toyomoyo
40a2a15f20 separating the site course context and the site context, could be buggy, please report bugs! 2006-11-15 08:23:27 +00:00
toyomoyo
3997cb4037 Adding hidden role assignment, currently used in course participants page and print_course function.
Please test.
2006-11-15 04:28:18 +00:00
moodler
d24c8ceae1 Prevent admins from unassigning themselves MDL-7462 2006-11-12 06:12:15 +00:00
moodler
8c900bc3b0 Merged documentation for Roles from stable MDL-6923 2006-10-31 08:14:36 +00:00
gustav_delius
6ac0909983 Incomplete user record (the one where the username is still 'changeme') should not be included in user listing. See bug 4570. For some reason this script is not using get_users() but is instead constructing its own sql, so the change to get_users() had to be duplicated here. 2006-10-05 22:45:01 +00:00
moodler
a971a5985a FIxes for the assign screen, to make it a lot faster and able to cope
better with very large numbers of users   MDL-6766
2006-10-01 08:08:26 +00:00
skodak
adbffcb9fe role ui minor cleanup 2006-09-22 21:17:43 +00:00
skodak
305ef971fc role assign and override code fixes + other minor changes 2006-09-22 20:09:47 +00:00
moodler
aad2ba95d1 Upgrading table to rename the context->aggregatelevel field which was
really bugging me.   Code should be a little bit more readable now.

Apologies to those with non-core code already using this field.
2006-09-22 06:19:32 +00:00
skodak
b5959f3071 partial rewrite of role manage script, improved notice_yesno(), other minor fixes and changes; I will work on assign and overide tomorrow ;-) 2006-09-21 22:34:45 +00:00
skodak
eef868d17d major whitespace cleanup - fixed trailng whitespace in new files and admin area 2006-09-20 21:00:45 +00:00
skodak
a14049f107 metacourse role assignment fixes 2006-09-19 20:39:55 +00:00
skodak
681729b16e various minor Role UI fixes 2006-09-19 17:34:29 +00:00
moodler
f4af29c5a4 Fixed up some bugs and notices when assigning roles in a user context 2006-09-16 12:41:47 +00:00
tjhunt
36075e092d MDL-6041 - Proper fix that eliminates the magic number 99999 when getting lists of studnets. Now, there is no arbitrary upper limit in the datalib functions, and sensible upper limits on pages that display lists of users. However, if you try to get all the site students, then get_students prints a warning in debug mode, telling you that you need to rethink your code.
Also a few more ISNULL()s eliminated.

And a typo role_assignment -> role_assignments.
2006-09-15 14:32:35 +00:00
moodler
4b10f08b88 Rename CONTEXT_USERID --> CONTEXT_USER for consistency 2006-09-15 14:09:16 +00:00
moodler
4934c49719 Cleaning up assign and override interfaces 2006-09-15 06:04:10 +00:00