sam_marshall
82928b7954
[MDL-7287] Lesson - tweaked continue.php to include a file via filesystem not HTTP because I couldn't see any reason to do it the latter way and it breaks under our loadbalancing system
2006-10-30 11:02:08 +00:00
mark-nielsen
5491947aa1
NO CODE CHANGES. Just added PHPdoc comments at the top of lesson files.
2006-09-30 19:49:40 +00:00
mark-nielsen
4bea0828a2
Got ahead of myself, fixed by bug fix
2006-09-19 04:49:45 +00:00
mark-nielsen
9ae4e9f5de
Fix in addpage.php when one deletes all pages in a lesson then adds a new one
...
Fix numerical questions were not displaying the student's answer in the feedback
2006-09-19 04:45:18 +00:00
mark-nielsen
b14123498f
Saw several problems with lesson_choose_from_menu, so finally replaced its use with choose_from_menu in lib/weblib.php
2006-09-19 04:06:32 +00:00
mark-nielsen
f08769317f
Removed hard-coded strings and fixed labels
2006-09-19 03:47:49 +00:00
mark-nielsen
63d4c906c7
Removed a hard-coded string and added PHPdoc comments for the page
2006-09-19 02:54:57 +00:00
mark-nielsen
62bb11d837
Added display default feedback in lesson settings
...
Led to reducing some redundant code in action/continue.php
Also, a bug fix in locallib.php for function lesson_print_submit_link (needed to add slashes or else js would break)
2006-09-18 01:31:35 +00:00
mark-nielsen
260a56b114
Added some more stats to reports, added more actions to collapsed view and increased speed of lesson by using lesson_set_message() and redirects with 0 second delays.
2006-09-13 03:42:16 +00:00
mark-nielsen
8f2f1d4761
Fixed display bug for branch tables and moved message setting to the bottom of continue.php to prevent double message setting when a redirect is called.
2006-09-10 18:50:59 +00:00
mark-nielsen
c94d37997d
Removed action set to navigation because view.php no longer uses action
2006-09-10 18:41:38 +00:00
mark-nielsen
5631925a26
Started to separate out logic and presentation in view.php. Decided to wrap the question printing with HTML templates (viewstart.html and viewend.html)
...
Still needs a lot of work
2006-09-10 18:19:29 +00:00
mark-nielsen
15f3d44ae7
Moved teacherview (lesson editing) out of view.php into edit.php
...
No code improvements in edit.php as of now. Just works ;)
2006-09-10 02:09:14 +00:00
mark-nielsen
d1b025d013
Moved high scores logic out of view.php into highscores.php
...
Changed: now need to enter password on password protected lessons before being able to view high scores
Added logs to high scores and reworked logic
2006-09-10 01:20:00 +00:00
mark-nielsen
09e3b9d7eb
Fixed some formatting when clock is not displayed
...
Messages are now printed out on continue.php
2006-09-09 22:33:34 +00:00
mark-nielsen
2163c22634
Forgot the lesson_ prefix
2006-09-09 22:23:50 +00:00
mark-nielsen
2cb24b647c
Improved clock output and works when javascript is disabled
2006-09-09 22:20:51 +00:00
mark-nielsen
259990d2c6
Lesson buttons should now work with javascript disabled
...
Also improved the layout of action/continue.html
2006-09-09 21:39:11 +00:00
mark-nielsen
3466ae4f14
Cleaned up output to user. Still needs a lot of work.
2006-09-09 02:10:40 +00:00
mark-nielsen
6e1ff5c8fb
MDL-6477: Added roles support.
...
Also added lesson_set_message() and lesson_print_message() to locallib.php
Also fixed problem in continue.html with not printing nextpageid
2006-09-08 23:17:18 +00:00
mark-nielsen
c5a2e12f08
Added $Id$ to files
...
Header is not printed for all actions. Related to MDL-5403
Some redundant code removed
First attempt at separating logic and presentation in action continue (continue.html)
2006-09-06 04:04:42 +00:00
mark-nielsen
2fc13bc767
Merged differences from MOODLE_16_STABLE into HEAD
2006-08-25 18:33:50 +00:00
skodak
de5f96195c
Bug #5566 - wrong display of student's answers in MATCHING question type; merged from MOODLE_16_STABLE
2006-05-25 08:13:41 +00:00
mark-nielsen
88427c077b
[Merged][BugFix] Bug #5405 - made a new function that grades a lesson for a specific user's attempt. This is then used for grading lessons at the end of a lesson, for ongoing score feature and for updating the grade for essay question grading.
...
This new grading algorithm now enforces the lesson setting Max attempts when custom scoring is turned Off
Changed the reporting of minquestions setting to match the help file. Now it is question based instead of attempt based.
Changed the reporting of ongoing score to use the new grade function.
2006-05-19 01:05:13 +00:00
mark-nielsen
74e3524216
[Merged][BugFix] Bug 5485 - problem with regular expressions with simple analysis
2006-05-16 03:06:28 +00:00
mark-nielsen
97d2756c65
[New Feature] Tabbed navigation added to lesson (similar to quiz)
...
[Added] Graceful fails added to view.php, essay grading, and reports
[Changed] got rid of a lot of references to $_POST/GET/REQUEST
[Fixed] In reports, it required teacheredit, should only be teacher
[Changed] High scores - teachers can actually see them! Also, improved output by using print_table and print_heading
[Changed] Grade essays now uses fullname() to print user names
2006-03-25 21:38:57 +00:00
mark-nielsen
8bd7bacd14
[Fixed] this page was shooting of warnings for unset variable score. Now checks to make sure score is set before using it.
2006-03-19 02:16:00 +00:00
mark-nielsen
aeade7e227
cleaned up the left menu feature output by removing an unused form and several unnecessary string concatenations
2006-03-19 02:08:37 +00:00
mark-nielsen
0646963948
[Changed] function execute_teacherwarning to function lesson_display_teacher_warning because it was violating the function naming policy
2006-03-17 03:37:31 +00:00
michaelpenne
c5b71097bc
[BugFix] Bug #4852 - HTML editor problems
2006-03-11 00:23:21 +00:00
vyshane
05da418753
Added $CFG->pagepath so that the Moodle Doc URLs are generated properly for
...
this section.
2006-03-09 07:53:14 +00:00
michaelpenne
6094f43dd5
[Fix] Removed htmlentities on student answer.
2006-02-24 21:31:23 +00:00
michaelpenne
ee27cca526
[BugFix] Bug #4216 - cancel button
2006-02-24 19:09:14 +00:00
michaelpenne
d643cbfb73
[Added] Added Regular Expression support for short answers by Joseph Rézeau. Discussion: http://moodle.org/mod/forum/discuss.php?d=38544
...
[Changed] Some display information has been changed, now prints page contents, user answer, and response
2006-02-23 00:41:28 +00:00
michaelpenne
de1547bf6c
[Fixed] A problem with storing the answerid for numerical questions. Discussion here: http://moodle.org/mod/forum/discuss.php?d=37537
2006-01-24 00:47:11 +00:00
michaelpenne
aeb8148a57
[Changed] Now when a teacher edits a page with the "Edit page contents" button and then saves or cancels, s/he gets redirected back to the lesson navigation. This will help to streamline the editing
...
[Fixed] The cancel button on the edit page now works.
2006-01-13 18:41:37 +00:00
michaelpenne
acab90991a
BUG FIX: progress bar now does not break when student reviews the lesson.
...
BUG FIX: matching question type upgrade script now supports quotes.
CHANGED: Improved labels for form elements to improve accessibility.
NEW: added a skip navigation link for left menu.
2005-11-16 22:35:46 +00:00
michaelpenne
0017b962e6
BUG FIX: essay response was still hard coded in. Replaced it with a get_string call
2005-10-26 23:11:26 +00:00
michaelpenne
fb0f70908b
BUG FIX: if one is a teacher, the left menu is always displayed.
2005-10-26 21:43:48 +00:00
michaelpenne
62eda6ea18
NEW: Progress bar option. Now a progress bar can be optionally displayed at the bottom of the lesson page.
...
NEW: Display Left Menu IF. The left menu will only display if the student has a grade better than the one set in the lesson settings. This is nice to allow only students who are reviewing the lesson to have access to the left menu.
BUG FIX: In Windows IE, the content was being aligned center. Now, the content is explicitly aligned to left as default.
BUG FIX: High Scores variable was not spelled correctly at the End of Lesson.
ADDED: Div tags around branch tables. This will allow users to choose to display them or not or move them around
CHANGED: converted more of the links to the stylized button. Also, removed a lot of forms and javascript and replaced it with links with the variables in the href.
CHANGED: the slide show styles have been moved to the style sheet.
CHANGED: removed the CDC comments
Other minor changes have been made to the code as well.
2005-10-24 23:06:43 +00:00
michaelpenne
d6941aff55
Recoded most of the left menu:
...
Got rid of a table
Restructured and added more div tags in the left menu (much more logical)
Reworked the styles for the left menu in the styles sheet (everything should be customizable via style sheet)
More compatible with MacIE5
Added styles to the individual links in the menu (allows styling the for currently selected page and for all the rest)
Cleaned up the left menu link generation in locallib.php
2005-10-05 22:45:38 +00:00
michaelpenne
b8437c1cbc
Removed filtering on page contents, answers and responses for lesson pages and their answers (this includes removing parameter cleaning and noclean in format_text).
...
Also, fixed some warning errors in action/updatepage.php.
2005-10-03 21:29:05 +00:00
michaelpenne
544121b12d
Switched buttons in lesson navigation to stylized links similar (well, the same rather for default) to the home button in the footer. This will allow for easy (hopefully) personalized customization of the buttons in lesson (ex: background images, colors, etc).
...
styles.php: added new styles, added comments and cleaned it up
view.php: converted the buttons for each question type to the new button standard. Also recoded branch table button layout generation.
action/continue.php: updated the buttons there as well.
2005-09-28 21:55:05 +00:00
michaelpenne
af1cd0fe33
Made the shortanswer qtype grading much more reliable. Change to preg_match to speed things up. Also do a preg_quote on the teacher supplied answer to prevent confusion in the preg_match statements (before + signs and the like were causing the preg_match statements to fail).
2005-06-21 22:38:26 +00:00
michaelpenne
c5cbd215fb
Bug Fix: The code for dealing with the * character for shortanswer question type was lost. I downloaded 1.4.5+ and merged the shortanswer grading code into 1.6 dev.
2005-06-21 21:45:04 +00:00
michaelpenne
1fd92aadb0
Fixed a problem with quotes in short answers
...
and
Fixed a bug with clusters. If you enter a cluster after a page it would throw a
navigation error. It now enters the cluster properly.
2005-06-15 23:41:01 +00:00
michaelpenne
bd71134047
Bug 1650 fixed: help button calling the wrong help file
2005-06-07 20:56:37 +00:00
michaelpenne
e0b1a2bea9
BUG FIX for Bug #3059 : if there is not a response to an answer, the response gets set to an empty string
2005-06-06 18:30:34 +00:00
stronk7
271fea974f
Tabs are out.
...
(all the module was using them, please change your editor settings to 4 spaces)
2005-05-16 22:41:19 +00:00
michaelpenne
98dd2c00f4
FIXED: loss content on editing a page
2005-05-09 02:29:35 +00:00
