Commit graph

12183 commits

Author SHA1 Message Date
Tim Hunt
18efef384b MDL-3030 quiz overdue handling: new capability 2012-04-27 15:07:25 +01:00
Tim Hunt
87427d9c7c MDL-3030 quiz overdue handling: new settings on quiz form and admin. 2012-04-27 15:07:23 +01:00
Tim Hunt
84da4788fd MDL-3030 quiz settings: reorganise form before adding new fields. 2012-04-27 15:07:22 +01:00
Tim Hunt
c761b7757d MDL-3030 quiz db: add comments to many colums, and reorder more logically. 2012-04-27 15:07:21 +01:00
Tim Hunt
20b77578d0 MDL-3030 quiz overdue handling: new DB columns. 2012-04-27 15:07:19 +01:00
David Mudrak
7528e238e0 MDL-32638 workshop_pluginfile() checks for access rights to get the submission files 2012-04-27 14:58:59 +02:00
David Mudrak
92039f1cb4 MDL-32638 fixed capability checks for instructauthors and instructreviewers
The workshop_pluginfile() can't be more restrictive than the code that
actually displays the text with the embedded images. To view both
instructions fields in view.php, the capability to view the workshop is
enough. So the same level of access control is applied here by
require_login() at the top of the function.
2012-04-27 14:56:15 +02:00
David Mudrak
b7a5e3d603 MDL-32638 improved file browser access to submission_content and submission_attachment areas
The user has to have viewallsubmissions capability to be able to see the
submission files in the browser. Additionally, in the separate groups
mode, the user has to have accessallgroups or share at least one group
with the submission author to view their files.
2012-04-27 14:56:14 +02:00
David Mudrak
76966a0058 MDL-32638 fixed workshop file info library comments 2012-04-27 14:56:14 +02:00
David Mudrak
a1df59bea9 MDL-27508 workshop does not use get_users_by_capability() any more
This is a big win, we are now taking enrolment fully into account.
Also, no need to fetch big data from DB just to get their count. Should
have much better performance now.
2012-04-27 14:41:59 +02:00
David Mudrak
74f54102dc MDL-27508 display submission link at the manual allocator page 2012-04-27 14:41:59 +02:00
David Mudrak
25bae250ee MDL-27508 workshop manual allocator supports groups
Pagination support improved, too.
2012-04-27 14:41:59 +02:00
David Mudrak
079219bf07 MDL-27508 introducing workshop::count_participants() 2012-04-27 14:41:59 +02:00
David Mudrak
c90a88bfb7 MDL-27508 improving the docs for workshopallocation_manual_allocations class 2012-04-27 14:41:59 +02:00
David Mudrak
ec1bf0f23d MDL-27508 workshop manual allocator supports configurable page size for items pagination 2012-04-27 14:41:59 +02:00
David Mudrak
dda42a19cd MDL-27508 workshop::prepare_grading_report_data() accepts $groupid
Workshop grades reports in all three last phases were fixed to support
the group selection. They layout of the report has been unified to be
consistent across all phases.
2012-04-27 14:41:59 +02:00
David Mudrak
8741ebb0bd MDL-27508 introducing workshop::get_participants() and workshop::is_participant()
Note how the participant is defined: it is a user that (1) can submit or
assess or both and (2) is actively enrolled in the course. This means
that usually admins or managers won't be considered as workshop
participants, for example.
2012-04-27 14:41:59 +02:00
David Mudrak
11a97e66e8 MDL-27508 workshop supports configurable page size for items pagination 2012-04-27 14:41:59 +02:00
David Mudrak
5547b0dce1 MDL-27508 introducing mod_workshop_renderer::perpage_selector() 2012-04-27 14:41:58 +02:00
David Mudrak
0d2331cce3 MDL-27508 workshop supports pagination at the submissions list in the submission phase 2012-04-27 14:41:58 +02:00
David Mudrak
8a23733753 MDL-27508 common pagination and sorting interface across all phases in view.php 2012-04-27 14:41:58 +02:00
David Mudrak
cd57f558d9 MDL-27508 introducing workshop::count_submissions() and pagination support for get_submissions() 2012-04-27 14:41:58 +02:00
David Mudrak
9326a2aa84 MDL-27508 fixing the description of groups related behaviour of some capabilities 2012-04-27 14:41:58 +02:00
David Mudrak
3f5e99153c MDL-27508 workshop checks separate groups membership when displaying an assessment 2012-04-27 14:41:58 +02:00
David Mudrak
f65bc55fcd MDL-27508 workshop checks separate groups membership when displaying a submission 2012-04-27 14:41:58 +02:00
David Mudrak
a4e848360d MDL-27508 workshop_user_complete() checks group membership in separate groups mode 2012-04-27 14:41:58 +02:00
David Mudrak
1c0c3ef5ee MDL-27508 workshop shows submissions per group in the submission phase 2012-04-27 14:41:58 +02:00
David Mudrak
872ed8591e MDL-27508 workshop::get_submissions() now accepts optional $groupid 2012-04-27 14:41:58 +02:00
David Mudrak
9691e2b10e MDL-27508 workshop::get_users_with_capability_sql() supports groupmembersonly
If the method is called with $groupid set to 0 and the workshop is in
the groupmembersonly mode, a recursive call is used to populate the
fragments of SQL code that fetch users from all relevant groups. These
fragments are then concatenated using UNION statement.
2012-04-27 14:41:58 +02:00
David Mudrak
21f58287d7 MDL-27508 workshop: improved getting of potential authors and reviewers
This patch reimplements get_potential_authors() and get_potential_reviewers()
so that get_enrolled_sql() is used instead of get_users_by_capability().
This excludes non-enrolled users (or users with suspended enrolment)
from the list of potential users.

The patch also extends the returned user structure. Objects in the
returned collection are now suitable for user_picture renderer.
2012-04-27 14:41:58 +02:00
Petr Skoda
fffd3703cf MDL-32640 fix E_STRCIT issue when editing somebody post of other user 2012-04-27 13:53:35 +02:00
Petr Skoda
f0202ae9a2 MDL-30686 improve accuracy of qualified_me() by trying PAGE->url first
This should help SSL proxies and returning to current page after require_login().
2012-04-27 13:39:18 +02:00
Eloy Lafuente (stronk7)
cb6de349e4 Fix permissions 2012-04-27 12:45:22 +02:00
Eloy Lafuente (stronk7)
e97eefd8c8 Merge branch 'MDL-19263-master' of https://github.com/mackensen/moodle 2012-04-26 02:46:21 +02:00
Eloy Lafuente (stronk7)
0529f63373 Merge branch 'MDL-32630-workshop-calendar' of git://github.com/mudrd8mz/moodle 2012-04-26 02:17:00 +02:00
David Mudrak
de7daa8333 MDL-32630 workshop_calendar_update() does not check for calendar permissions
As discussed in MDL-32631, calendar_event::update() should not do
capability checks at all. Until that issue is fixed, we just explicitly
declare that no capability checks should be done.

The function workshop_calendar_update() is executed when adding or
updating a workshop instance (where permissions to modify the instance
were already checked and are sufficient) and in the upgrade code (where
no check should be performed anyway).
2012-04-25 15:35:59 +02:00
Eloy Lafuente (stronk7)
d7f84a2962 Merge branch 'MDL-32471-thumbnails' of git://github.com/mudrd8mz/moodle 2012-04-25 15:14:27 +02:00
David Mudrak
b861b60932 MDL-32471 fixed strict standards in the declaration of send_file() in assignment types
All subtypes declaration should be compatible with that of assignment_base::send_file()
2012-04-25 13:48:12 +02:00
Eloy Lafuente (stronk7)
2360f60fd8 MDL-32322 tests: apply changes in simpletests (now deleted) to phpunit ones. 2012-04-25 03:09:42 +02:00
Eloy Lafuente (stronk7)
d3cb25dfef Merge branch 'MDL-32322' of git://github.com/timhunt/moodle
Conflicts:
	mod/quiz/report/simpletest/testreportlib.php
	mod/quiz/report/statistics/simpletest/test_qstats.php
2012-04-25 03:02:14 +02:00
Eloy Lafuente (stronk7)
2c6dbf4a54 MDL-32490 Offline assignment: phpdocs and whitespace fixes 2012-04-25 02:40:35 +02:00
Eloy Lafuente (stronk7)
2ae4f3849a Merge branch 'MDL-32490' of git://github.com/bostelm/moodle 2012-04-25 02:28:50 +02:00
Eloy Lafuente (stronk7)
ee35fa43de Merge branch 'wip-MDL-30478-master' of git://github.com/abgreeve/moodle 2012-04-25 01:11:38 +02:00
Andreas Grabs
7e5dc9f3bb MDL-32624 - initialbars disappears 2012-04-24 21:26:56 +02:00
Aparup Banerjee
aed560a197 MDL-19391 Database : fixed icon size 2012-04-24 16:00:38 +01:00
David Mudrak
7a00d4385d MDL-32471 preview thumbnails support for other component types
This commit affects mostly qtypes. Other standard components either do
not have pluginfile handler or have been already updated to the new API.
2012-04-24 14:29:44 +02:00
David Mudrak
261cbbacc1 MDL-32471 preview thumbnails support for activity modules
Activity module's xxx_pluginfile() now accepts the $options parameter
that is to be passed to the send_stored_file() function.
2012-04-24 12:09:45 +02:00
Eloy Lafuente (stronk7)
3e0b0ae59b Merge branch 'wip-MDL-26500' of git://github.com/danpoltawski/moodle 2012-04-24 00:03:36 +02:00
Dan Poltawski
544cfe962e Merge branch 'MDL-32104-master' of git://github.com/ankitagarwal/moodle 2012-04-23 12:49:56 +08:00
Dan Poltawski
bebf083159 Merge branch 'w17_MDL-31607_m23_login' of git://github.com/skodak/moodle 2012-04-23 11:47:11 +08:00