Commit graph

4278 commits

Author SHA1 Message Date
Eloy Lafuente (stronk7)
c989d6ec61 MDL-71036 phpunit: Renamed various regexp-related assertions
In PHPUnit 9.1, the following regexp-related assertions
have been deprecated and there are new alternatives for
all them:
    - assertRegExp()     -> assertMatchesRegularExpression()
    - assertNotRegExp()  -> assertDoesNotMatchRegularExpression()

This is about to, simply, move all cases to the new alternatives.

Source: https://github.com/sebastianbergmann/phpunit/blob/9.1.0/ChangeLog-9.1.md

Regexp to find all them:

    ag 'assertRegExp|assertNotRegExp' -li
2021-03-11 23:07:30 +01:00
sam marshall
0919a04311 MDL-45242 Lib: Replace calls to deprecated functions
In all cases changes have been kept to a minimum while not making
the code completely horrible. For example, there are many instances
where it would probably be better to rewrite a query entirely, but
I have not done that (in order to reduce the risk of changes).
2021-03-10 10:58:09 +00:00
Ilya Tregubov
02af750568 MDL-69680 lib: Fix behat test backup_and_restore.feature 2021-03-04 22:51:18 +01:00
Sara Arjona
8110f4a2eb Merge branch 'MDL-70966-311' of git://github.com/marinaglancy/moodle into MOODLE_311_STABLE 2021-03-03 09:30:47 +01:00
Jun Pataleta
768fb99ba4 Merge branch 'MDL-71009_311' of https://github.com/timhunt/moodle into MOODLE_311_STABLE 2021-03-03 16:22:44 +08:00
Marina Glancy
b2d8938431 MDL-70966 various: Under PHP8 empty string is no longer equals to 0 2021-02-28 19:16:53 +01:00
Tim Hunt
0b661342dc MDL-71009 question bank: escape idnumbers when displayed 2021-02-26 12:47:33 +00:00
Tim Hunt
9bc2094202 MDL-70916 Essay/Moodle XML: min and max word limits not imported 2021-02-17 11:32:56 +00:00
Marina Glancy
d2d0cffd1d MDL-70893 various: optional function arguments must be in the end 2021-02-15 16:54:01 +01:00
Sara Arjona
4611cf3b9f Merge branch 'MDL-70796_311' of https://github.com/timhunt/moodle into MOODLE_311_STABLE 2021-02-10 16:50:09 +01:00
Sara Arjona
ea1407452c Merge branch 'MDL-69101_311' of https://github.com/timhunt/moodle into MOODLE_311_STABLE 2021-02-10 15:11:58 +01:00
Mahmoud Kassaei
dcb319c441 MDL-70377 qtype_essay: When reviewing an attempt as a teacher
In the Response history table, Action Saved: does not display the value
of $a in the language string.
2021-02-08 17:05:03 +00:00
Tim Hunt
9ca6fd447c MDL-70796 count_words: match the count from LibraOffice & MS Word 2021-02-05 15:31:10 +00:00
Tim Hunt
1550b2a3e9 MDL-69101 Essay/Moodle XML: recent new settings not imported/exported 2021-02-03 08:10:55 +00:00
Sara Arjona
82a6dc6dd1 Merge branch 'MDL-70574_311' of https://github.com/timhunt/moodle into MOODLE_311_STABLE 2021-02-02 08:20:25 +01:00
Jun Pataleta
868af1cb0b MDL-70288 qtype: Remove unnecessary empty label string
* When a label is passed to an (advanced) checkbox and no text
  was provided, the label will be displayed on the right of the the
  checkbox element. So there's no point in passing an empty string for
  the label just to render the text to the right of the checkbox.
2021-02-02 14:22:15 +08:00
Andrew Nicols
a85f7f83b9 MDL-66979 question: Improve behat test reliability
Expand all fieldsets rather than individual fieldsets.

This can fail in some situations where the page moves as the first
fieldset opens and HTML transitions take effect. This causes subsequent
fieldsets to move after WebDriver has calculated the click target.
2021-01-22 14:52:18 +08:00
Tim Hunt
296669ea36 MDL-70134 essay qtype: Provide options for smaller response boxes
And make the default box size 10
2021-01-18 09:24:57 +00:00
Tim Hunt
c2f419bc75 MDL-70134 manual grading: make starting comment box size 3 lines
I am guessing most comments are short, and the box can be expanded if needed.
2021-01-18 09:24:57 +00:00
Sara Arjona
1520ae2cbd Merge branch 'MDL-69308_311' of https://github.com/stronk7/moodle into MOODLE_311_STABLE 2021-01-14 12:03:36 +01:00
Eloy Lafuente (stronk7)
5aed7f4217 MDL-69308 upgrade: remove all the < 3.6.0 upgrade steps
This just deletes all the upgrade steps previous to 3.6.0. Some
small adjustments, like tweaking globals can also be applied
when needed.

Also includes an upgrade step to prevent upgrading from any
version < 2018120300 (v3.6.0) as anti-cheating measure.

Note that in this case, there wasn't any case of upgradelib
functions being used, hence we haven't to deprecate/remove
anything in codebase. When there is such a need, that is done
in separate commits (one for each function) and documented here.

See MDL-65809 commits for an example removing/deprecating a
good number of functions.
2021-01-13 19:28:39 +01:00
Tim Hunt
8306fc3f3e MDL-68597 qtype_essay: show the word count on the review screen 2021-01-12 19:53:01 +00:00
Tim Hunt
8d7b3b3fe7 MDL-68597 qtype_essay: switch the form to consistently use hideIf 2021-01-12 17:54:39 +00:00
Tim Hunt
48e0b24587 MDL-68597 essay word limits: fixes requested by the integrator 2021-01-11 20:32:24 +00:00
Mahmoud Kassaei
9b7439c3a8 MDL-68597 Qtype_Essay: Adding word min/max for online text input 2021-01-11 20:32:20 +00:00
Tim Hunt
7449ad7861 MDL-70574 qtype_multianswer: fractional scores should be possible 2021-01-11 17:35:51 +00:00
Jun Pataleta
fa9c582da9 Merge branch 'MDL-70374_311' of https://github.com/timhunt/moodle into MOODLE_311_STABLE 2021-01-07 12:24:26 +08:00
Jake Dallimore
d8247c90f2 Merge branch 'MDL-70426-311' of https://github.com/HuongNV13/moodle into MOODLE_311_STABLE 2020-12-22 15:16:23 +08:00
Tim Hunt
7242488cc0 MDL-70374 qtype_multichoice: code cleanup
* Remove some obsoliete CSS.
* Put the CSS in a more logical order.
* Rename some variables in the renderer, for more clarity.
2020-12-18 13:14:04 +00:00
Tim Hunt
5426f8bc35 MDL-70374 qtype_multichoice: improve alignment of choices 2020-12-18 13:14:03 +00:00
Sara Arjona
bb08b03b4f Merge branch 'MDL-70373_311' of https://github.com/timhunt/moodle into MOODLE_311_STABLE 2020-12-16 12:40:42 +01:00
Jake Dallimore
306f024312 Merge branch 'MDL-70324-3.11' of https://github.com/JBThong/moodle into MOODLE_311_STABLE 2020-12-14 11:29:57 +08:00
Huong Nguyen
0cc42a2047 MDL-70426 qtype_ddmarker: infinite markers keep duplicating 2020-12-10 15:52:09 +07:00
Andrew Nicols
c80610ac49 Merge branch 'MDL-70321_311' of https://github.com/timhunt/moodle into MOODLE_311_STABLE 2020-12-03 11:41:19 +08:00
Tim Hunt
a3cf931e3d MDL-70373 qtype_essay: missing border on atto input 2020-12-02 20:09:43 +00:00
Thong Bui
c2cb01662a MDL-70324 Question: get_all_response_file_areas() not work correctly 2020-12-01 16:08:37 +07:00
Andrew Nicols
41e1eecf36 MDL-70153 qtype_essay: Whitespace/behat fixes 2020-11-26 12:51:53 +01:00
Andrew Nicols
f225783ae8 Merge branch 'MDL-70153-311' of git://github.com/dpalou/moodle into MOODLE_311_STABLE 2020-11-26 12:51:53 +01:00
Sara Arjona
029be97d37 Merge branch 'MDL-70248-311' of https://github.com/HuongNV13/moodle into MOODLE_311_STABLE 2020-11-26 12:51:52 +01:00
Tim Hunt
48eadbc999 MDL-70321 question backup: fix MDL-47178 unit tests
They were failing if you had CodeRunner installed
2020-11-24 15:29:23 +00:00
Huong Nguyen
d921cbb41f MDL-70248 qtype_ddimageortext: Drop zones have UI issue in Editing form 2020-11-19 17:02:55 +07:00
Jun Pataleta
d31ac2f343 Merge branch 'MDL-70094-311' of https://github.com/SangNguyen2601/moodle into MOODLE_311_STABLE 2020-11-19 09:37:58 +08:00
Dani Palou
5047eac57e MDL-70153 qtype_essay: Add behat test for attachments max size 2020-11-18 10:48:08 +01:00
Dani Palou
4657c380a6 MDL-70153 qtype_essay: Fix max size displayed for attachments 2020-11-18 10:48:08 +01:00
sangnguyen2601
6b29dca9fb MDL-70094 Question: Technical info section expands if click help icon 2020-11-18 13:28:36 +07:00
Andrew Nicols
f4a38bbaac MDL-70148 qtype: Update qtype steps to new key interaction
Note: The ddmarker question type was previously getting the number of
keypresses wrong. This was because it was using both keyDown/keyUp, and
also keyPress. As a result each keypress was essentially happening two
times.
2020-11-17 15:14:43 +08:00
Andrew Nicols
5b9b1f07e6 MDL-70148 behat: Update steps for keyboard 2020-11-17 15:14:43 +08:00
Sara Arjona
0ab938d309 Merge branch 'MDL-69823-310' of git://github.com/jleyva/moodle into MOODLE_310_STABLE 2020-11-11 07:41:31 +01:00
Andrew Nicols
e78929087e Merge branch 'MDL-70065_310' of https://github.com/timhunt/moodle into MOODLE_310_STABLE 2020-11-11 10:10:24 +08:00
Juan Leyva
d0b4b6fa2f MDL-69823 qtype: Support core question types 2020-11-10 19:21:32 +01:00