Commit graph

81046 commits

Author SHA1 Message Date
Russell Smith
d59f1d3150 MDL-55124 database: Mode connection test to after connection.
To verify the client encoding and other data is correct then
the connection must have been made first.
2016-09-22 08:40:03 +10:00
David Mudrák
8df850ad6f MDL-46946 user: Make missing required custom fields trigger profile edit
If there is a required custom field that the user can fill by editing
their profile, and that field is missing, the user should be considered
as not fully set up. Instead, we want to redirect them to edit their
profile first.

There are some exceptions when we want to fall back to the previous
behaviour and check just the name and email fields. These exceptional
cases include checking remote user data in incoming MNet request (no
user id, no custom fields supported) and calls to require_login() with
redirecting disabled (typically ajax filepicker requests on profile
editing page itself).

Additional plugins that call the function user_not_fully_set_up()
themselves, should perform the strict check in most/typical cases. So
the strict mode is enabled by default even if it changes the behaviour
slightly. In improbable case of additional plugins relying on the
previous behaviour of the function, they can use the $strict parameter
and keep performing the lax check. However, I am sure the correct fix in
that case will likely be to stop abusing this function.

Note that custom fields are not currently transferred during the MNet
roaming. So having custom fields configured as required on MNet service
provider site (where users can't edit their profiles) is expected to
display an error (as the site is considered as misconfigured).
2016-09-21 17:46:30 +02:00
Adrian Greeve
f4eef5fb25 MDL-55327 mod_lesson: Fix for copying essay and match.
Matching and essay questions would display errors when
being duplicated.
2016-09-21 18:04:08 +08:00
Juan Leyva
65e961e4f2 MDL-56045 message_airnotifier: New WS message_airnotifier_enable_device 2016-09-21 10:45:13 +01:00
Juan Leyva
95f53a652a MDL-56045 message_airnotifier: Move enable device code to manager class 2016-09-21 10:44:56 +01:00
Juan Leyva
618cba3494 MDL-56044 message_airnotifier: New WS message_airnotifier_get_user_devices 2016-09-21 09:47:26 +01:00
Dan Poltawski
948e6e3fca MDL-48766 lib: fix another stupid case sensitivity issue 2016-09-21 09:31:54 +01:00
Damyon Wiese
a8225336d9 MDL-56052 block_settings: race condition
YUI events module must be loaded before global events can be used.
2016-09-21 12:21:39 +08:00
Eloy Lafuente (stronk7)
6cc077e90f Merge branch 'MDL-55982-master' of git://github.com/andrewnicols/moodle 2016-09-21 03:04:36 +02:00
Andrew Nicols
0f3bbfd4f8 MDL-55982 mod_forum: Add time-based discussion locking
This patch adds support for time-based locking of discussions.
Discussions are automatically locked after a user-definable period of
inactivity. After this time, only those with the the relevant capability
are able to add replies.

This has been designed to add support for other types of discussion locking
at a later date with relative ease.
2016-09-21 09:03:42 +08:00
Simey Lameze
f096f1bdd3 MDL-56013 lib: Create a page to test Chart.js 2016-09-21 08:25:13 +08:00
Simey Lameze
e38239b487 MDL-56013 lib: Upgrade Chart.js to version 2.2.2 2016-09-21 08:25:13 +08:00
Eloy Lafuente (stronk7)
349a6430e6 Merge branch 'MDL-45752_m32v3' of https://github.com/sbourget/moodle 2016-09-20 17:36:51 +02:00
Eloy Lafuente (stronk7)
73b2a94c7f MDL-55405 enrol_paypal: Fix set_context() call
Note that setting the page context more than once is not ideal
but as far as system->course switches are allowed, this should
not hurt, while providing more accurate messages than keeping
system context.
2016-09-20 12:27:35 +02:00
Eloy Lafuente (stronk7)
43f53ded83 Merge branch 'MDL-55405-master' of git://github.com/cameron1729/moodle 2016-09-20 12:21:37 +02:00
Eloy Lafuente (stronk7)
ce7863ba36 Merge branch 'MDL-55124' of https://github.com/mr-russ/moodle 2016-09-20 12:13:10 +02:00
Russell Smith
f834a8f5eb MDL-55124 database: Allow option to not send options.
pgbouncer doesn't accept the PostgreSQL options command as it can't
process it.  If you are using pgBouncer you need to make sure your
database is configured to set client encoding and standard_conforming_strings
correctly on each connection.  pgBouncer can do this, as can ALTER
commands.

Also using sockets without a filename did not allow different ports to work.
This is because you either specify a filename which includes a port or
you just specify a port and libpq works out the correct socket location.
2016-09-20 19:53:01 +10:00
Juan Leyva
fad980b26f MDL-55785 mod_glossary: Check user can create new entries 2016-09-20 10:52:53 +01:00
Juan Leyva
f0e1808fc4 MDL-55785 mod_glossary: New Web Service mod_glossary_add_entry 2016-09-20 10:52:53 +01:00
Juan Leyva
e6de11d7b7 MDL-55785 mod_glossary: Move edit.php code to new lib function
Most of the code that was in mod/glossary/edit.php has been moved to
mod/glossary/lib.php:glossary_edit_entry
2016-09-20 10:48:41 +01:00
Juan Leyva
114eaf519d MDL-55740 assign: Add assignment WS to the mobile service
* mod_assign_submit_grading_form
* mod_assign_get_participant to the mobile service
2016-09-20 10:31:50 +01:00
Sam Hemelryk
cb3e2e144a MDL-39117 cachestore_apc: imported into core 2016-09-20 18:52:03 +10:00
Dan Poltawski
89ae98f134 Merge branch 'MDL-55916-maintmode-503-moodle' of https://github.com/brendanheywood/moodle 2016-09-20 09:31:41 +01:00
Cameron Ball
4abbb4180b
MDL-55405 enrol_paypal: Create utility class
Some helper functions were in the IPN file. They really should be
in their own utility class to facilitate better testing.
2016-09-20 12:38:31 +08:00
Andrew Nicols
2fc56dd571 MDL-51361 backup: Documentation phpcs fix 2016-09-20 12:21:41 +08:00
Andrew Nicols
91d52985c5 Merge branch 'MDL-51361' of https://github.com/bostelm/moodle 2016-09-20 11:58:24 +08:00
Andrew Nicols
674de8e51e Merge branch 'MDL-55191_master' of git://github.com/dmonllao/moodle 2016-09-20 11:41:03 +08:00
Andrew Nicols
5a766a9e21 MDL-55327 mod_lesson: Whitespace fix 2016-09-20 11:19:28 +08:00
Andrew Nicols
25804281f1 Merge branch 'wip-MDL-55327-master' of git://github.com/abgreeve/moodle 2016-09-20 11:15:54 +08:00
Adrian Greeve
329b68c9ca MDL-55327 mod_lesson: Behat test for page duplication. 2016-09-20 10:36:13 +08:00
Adrian Greeve
f847669e33 MDL-55327 mod_lesson: Unit tests for the new function 2016-09-20 10:36:13 +08:00
Adrian Greeve
9f937c3bb3 MDL-55327 mod_lesson: Added the ability to duplicate pages. 2016-09-20 10:36:13 +08:00
Brendan Heywood
f1c6d647bc MDL-55916 setup: Maintenance mode serves HTTP 503 2016-09-20 11:59:39 +10:00
Marina Glancy
2b1c3e4d68 MDL-55990 tags: remove unnecessary index creation 2016-09-20 09:30:40 +08:00
Andrew Nicols
77391e9f09 Merge branch 'MDL-55876-master' of git://github.com/lameze/moodle 2016-09-20 09:10:43 +08:00
Adrian Greeve
6965ffe041 MDL-55519 activities: mform element shows correct maxgrade.
In certain circumstances the max grade value would revert
back to the default max grade value.
2016-09-20 08:56:24 +08:00
Andrew Nicols
13c8792606 Merge branch 'MDL-55586-master' of https://github.com/StudiUM/moodle 2016-09-20 08:17:37 +08:00
Eloy Lafuente (stronk7)
0f4b338fbb Merge branch 'wip-mdl-55379' of https://github.com/rajeshtaneja/moodle 2016-09-20 02:06:32 +02:00
Eloy Lafuente (stronk7)
8dcc999d96 Merge branch 'wip-MDL-55827-master' of git://github.com/marinaglancy/moodle 2016-09-20 01:02:06 +02:00
Eloy Lafuente (stronk7)
55a1e66cfc Merge branch 'MDL-55856-master' of git://github.com/danpoltawski/moodle 2016-09-20 00:51:36 +02:00
Ruslan Kabalin
8292fa8184 MDL-55776 enrol: Optimise enrolled users listing.
Here we optimise SQL queries for enrolled users list. Expensive subquery is
replaced with faster LEFT JOIN and the whole groups filtering component is
aded on demand.
2016-09-19 23:46:28 +02:00
Ruslan Kabalin
d76749b42c MDL-55776 enrol: Add unit tests for enrolment manager. 2016-09-19 23:46:20 +02:00
AMOS bot
dbe75154b6 Automatically generated installer lang files 2016-09-20 00:04:28 +08:00
Issam Taboubi
0d12feb6c8 MDL-55586 report_competency: Translation strings in competencies 2016-09-19 12:02:54 -04:00
Issam Taboubi
c2cd126033 MDL-55586 blocks_lp: Translation strings in competencies 2016-09-19 12:01:19 -04:00
Dan Poltawski
771a8d3394 Merge branch 'wip-mdl-55117' of https://github.com/rajeshtaneja/moodle 2016-09-19 11:39:41 +01:00
Dan Poltawski
a2184f971f Merge branch 'master_MDL-55820' of git://github.com/danmarsden/moodle 2016-09-19 11:32:19 +01:00
Dan Poltawski
daa571af9f Merge branch 'MDL-55944' of https://github.com/mr-russ/moodle 2016-09-19 11:25:12 +01:00
Eloy Lafuente (stronk7)
cecba1d92e Merge branch 'wip-MDL-29332-master-3' of git://github.com/marinaglancy/moodle 2016-09-19 11:51:08 +02:00
Dani Palou
d33c67bc47 MDL-56019 ws: Use itemid null when getting modules intro 2016-09-19 11:33:55 +02:00