Commit graph

26607 commits

Author SHA1 Message Date
nicolasconnault
c3096060de MDL-9506 Added ksort() of each level of categories and items for the gradebook. Unsorted arrays caused erratic behaviour when moving elements of the tree around. 2007-05-30 05:47:26 +00:00
toyomoyo
bb15b33bf9 respecting sortorder when restoring grade_itmes, other minor fixes 2007-05-30 05:32:47 +00:00
nicolasconnault
a3d5594248 MDL-9506 Refactored grade_tree::get_tree by doing the following:
- Extracted the $fillers array into a class variable
- Extracted the addition of elements to grade_tree::fillers into a new add_fillers($array) method
- Extracted the inclusion of fillers into the tree_array to a new include_fillers($tree, $object=NULL) method
- Removed the building of the tree_filled, which was already performed by build_tree_filled()
- Removed the generation of next_sortorder and previous_sortorder attributes, which was already performed by renumber()
Result is a much leaner and scalable set of methods, and a tighter definition of responsibilities for the varying classes. I think I have also noticed a significant inprovement in speed.
2007-05-30 03:09:38 +00:00
toyomoyo
770156e5f8 fixing a typo 2007-05-30 02:22:43 +00:00
toyomoyo
a246d4d269 during backup parent categories need to go before children 2007-05-30 02:20:56 +00:00
wildgirl
dde9f3e1a3 typo fix MDL-8093 2007-05-29 17:26:45 +00:00
thepurpleblob
2377f8dcd4 MDL-9716
'answernumbering' field now supported
2007-05-29 15:19:12 +00:00
csantossaenz
ef24d5b8fd Fixed problem with cmi.interactions.n.id duplicated ids 2007-05-29 11:22:49 +00:00
dwoolhead
6cc1a80532 MDL-9729 Ensure start of week day calculation observes user timezone setting in the same way as month start and end dates. Prevents incorrect display of dates (1 out) on main Moodle calendar display although mini calendar display is correct. (Merged from 1.8 stable branch) 2007-05-29 09:56:44 +00:00
toyomoyo
bc1637c730 restore for gradebook, needs testing for grade_history, outcomes, categories, calculations and text 2007-05-29 09:00:48 +00:00
jamiesensei
dc1f768351 reverting commit 1.889 "added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE." It turned out to be unnecessary. 2007-05-29 06:27:38 +00:00
jamiesensei
d65cb30f63 reverting last commit "added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE." It turned out to be unnecessary. 2007-05-29 06:14:09 +00:00
jamiesensei
24a905f98b fixed bug in parsing urls 2007-05-29 06:14:09 +00:00
nicolasconnault
646323549e MDL-9506 Resolved recursion issues in grade_tree:renumber and grade_tree::get_neighbour_element. Unit tests all pass now. 2007-05-29 04:07:04 +00:00
nicolasconnault
de420c11c5 MDL-9317 Applying Petr's second patch 2007-05-29 00:56:44 +00:00
mark-nielsen
e72be0548e Merging in changes for MDL-9947 and MDL-9923 from MOODLE_18_STABLE 2007-05-28 18:55:15 +00:00
jamiesensei
099f7fb6ca added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE. 2007-05-28 14:25:40 +00:00
jamiesensei
b1a61961aa MDL-9745 "Checkboxes badly lined up in forms lib, e.g. "students may review" settings on quiz settings screen." Reverted previous fix for similar problem MDL-7779 as the fix for MDL-7779 causes worse problem MDL-9745 with form elements in groups. Second part of commit in HEAD, missed a bit in HEAD. 2007-05-28 14:21:09 +00:00
bobopinna
416050aa9a patched a parse error 2007-05-28 12:53:42 +00:00
jamiesensei
5eb1924f01 MDL-9745 Checkboxes badly lined up in forms lib, e.g. "students may review" settings on quiz settings screen. Reverted previous fix for similar problem MDL-7779 as the fix for MDL-7779 causes worse problems with form elements in groups. 2007-05-28 12:17:40 +00:00
skodak
7bddd4b787 MDL-9632; MDL-9545 basic assignment grading support - event triggers implemented + some minor cleanup 2007-05-28 08:55:15 +00:00
skodak
37db0ab8f8 MDL-9960 update_record() does not store NULLs; I hope it will not break anything 2007-05-28 08:49:40 +00:00
skodak
b5b65852c6 apply magic quotes before using var in sql query in fetch_all_using_this() 2007-05-28 08:20:07 +00:00
bobopinna
27a46315e2 Added the starting point for CMIFeedback type checking 2007-05-28 08:18:25 +00:00
nicolasconnault
c91ed4be0d MDL-9506 Category and Item now set their own courseid if not set explicitly, and if they have enough information from
other sources. category::set_as_parent has a new constraint: cannot set over children from different courses.
Applied recursion to grade_tree::renumber(), but still some fine-tuning to do, since only grade_items are getting updated in DB.
2007-05-28 08:00:19 +00:00
nicolasconnault
d990776605 MDL-9137 Applied parts of Petr's patch on the gradebook objects. Unit tests unaffected. 2007-05-28 02:05:21 +00:00
nicolasconnault
526e1a8a25 MDL-9506 Corrected a number of small errors in unit tests and classes. 2007-05-28 01:26:58 +00:00
jamiesensei
3673f6bc3b added more phpdoc comments for hardFreezeAllVisibleExcept 2007-05-28 00:50:11 +00:00
jamiesensei
56015454dd new method hardFreezeAllVisibleExcept 2007-05-28 00:46:11 +00:00
nicolasconnault
4e83465eed Removed non-standard :endif notation. 2007-05-28 00:22:17 +00:00
skodak
271c7a98bc MDL-9959 debugging() shows warnings when called from call_user_func() functions
MDL-9958 addslashes_recursive() and stripslashes_recursive() modifies function parameter in PHP5
2007-05-27 22:55:52 +00:00
bobopinna
36938e1a67 fixed translation file for othersettings string 2007-05-27 21:24:51 +00:00
bobopinna
8e4838ffd7 Fixed some bugs that block ADL test suite
Still to fix ex CMIFeedback type
2007-05-27 21:22:27 +00:00
bobopinna
d7ffd685d2 added a new string for exit activity instead using the old one 2007-05-27 17:13:16 +00:00
bobopinna
bb8f14335a Added exitactivity link in navigation bar 2007-05-27 17:08:54 +00:00
bobopinna
2fce0a2e9e Modified exit string now is exit activity 2007-05-27 16:56:28 +00:00
bobopinna
35c0b12fe9 Added some missing strings 2007-05-27 16:54:56 +00:00
bobopinna
2b90f94115 commented attend fields because this feature in not implemented yet 2007-05-27 16:32:59 +00:00
bobopinna
456980415c fixed a big problem with local manifest file import
removed a white space in url generation
2007-05-27 16:28:39 +00:00
bobopinna
23ab8e8d80 removed an unrequired require_once
optimized an if branch
2007-05-27 16:26:05 +00:00
bobopinna
9b60b28a52 fixed a missing <li> tag in package TOC 2007-05-27 16:21:13 +00:00
jamiesensei
9368476553 MDL-9734 fix for clean_param PARAM_LOCALURL bug 2007-05-27 11:19:04 +00:00
jamiesensei
64360ee7b5 made hardFreeze work properly for a whole form. New paramater in moodleform constructor 'editable' defaults to true. If true then display form as normal. If false then hardFreeze whole form. Now displays form without an submit buttons. If form is hard frozen no data is ever passed to get_data. 2007-05-27 05:01:51 +00:00
jamiesensei
7d8ea28668 MDL-9891 new 'clonepermissionsfrom' key in access.php 2007-05-27 04:53:02 +00:00
moodler
9d69632b0e Automatic installer.php lang files by installer_builder (20070527) 2007-05-27 04:27:59 +00:00
skodak
19e7f33384 MDL-9643 some more polishing 2007-05-26 13:11:54 +00:00
skodak
7458bee224 MDL-9643 some more polishing 2007-05-26 12:59:13 +00:00
moodler
72d24cae14 Automatic installer.php lang files by installer_builder (20070526) 2007-05-26 04:02:24 +00:00
moodler
ed7666d8f8 Merged MDL-9826 from stable 2007-05-25 21:04:26 +00:00
anthonyforth
ae8fda4cb1 Fix for bug MDL-9942 2007-05-25 09:55:08 +00:00