moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-07 01:46:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
55292 commits 37 branches 540 tags 1.3 GiB
Commit graph

55292 commits

This branch
This branch
All branches
Author SHA1 Message Date
Tim Hunt
c33d527833 MDL-34351 quiz cron: one broken overdue attempt should not kill cron 
It seems that sometimes trying to process an overdue quiz attempt can
throw an exception. In that case, we need to catch it and report it
nicely, and then carry on processing the rest of the attempts, rather
than just killing the whole of cron processing.

Also, there may be garbage quiz attempts where the associated quiz or
course has been deleted. Skip those too.
 2012-07-19 15:21:05 +01:00
Tim Hunt
7326b7e247 MDL-34379 quiz reports: timetaken 'open' for never submitted attempts 2012-07-19 12:51:55 +01:00
Tim Hunt
dd7aa58386 MDL-34251 question engine: possible infinite loop loading usages 
In the case where either a question_attempt had not steps, or a
question_usage had not question_attempts, the load_from_records methods
could get stuck in an infinite loop.

This fix ensures that does not happen, with unit tests to verify it. At
the same time, I noticed an error in the existing tests, which this
patch fixes.
 2012-07-19 12:51:00 +01:00
Tim Hunt
be1d8ed194 MDL-34226 multianswer qtype: basic unit test. 
This verifies the previous fix, and gets rid of a rather embarassing TODO.
 2012-07-19 12:50:47 +01:00
Tim Hunt
c0a912e5ac MDL-34226 multichoice qtype: correct is_complete_response for multianswer 
The multianswer qtype uses the multi-choice one, and the way it does its
responses array breaks an assumption that multi-choice was making.
 2012-07-19 12:50:47 +01:00
Tim Hunt
a3e6ad77d2 MDL-34066 adaptive behaviour: refactor logic out of renderer. 
These changes move the logic to the behaviour class, which is how things
should be.

It also makes it easier to re-use the code that displays the messages
like "Marks for this submission: 1.00/1.00. Accounting for previous
tries, this gives 0.33/1.00." in other places.

To try to make it clearer what is going on, I introduced a new class
qbehaviour_adaptive_mark_details to hold and document the data that the
behaviour needs to return, and the renderer can base its display on.

As far as my testing can tell (and there are new unit tests), this
commit does not change the existing behaviour.

This commit also replaces all the string concatenation that is going on,
which should help translators. At the moment, a few of the old strings
are still in the language file, and are used in the unit tests to verify
that the behaviour has not changed.

Thanks to Oleg Sychev for making a helpful suggestion about the API.
 2012-07-19 12:50:17 +01:00
Andrew Davis
77d187ed1e MDL-28568 message: added a warning message when the user is about to message someone who cant reply 2012-07-19 17:14:50 +08:00
Sam Hemelryk
dd51b3b2e0 MDL-33448 javascript: Added caching for the YUI instance used for debug in get_string 2012-07-19 20:22:41 +12:00
Sam Hemelryk
2ede466e5f MDL-34286 conditionlib: Fixed up loading of user profile data for custom field conditions 2012-07-19 20:10:04 +12:00
Rajesh Taneja
fc9ae8d164 MDL-31294 Forms Library: Removed deprecated file and format form element 2012-07-19 16:06:21 +08:00
Ankit Agarwal
1868607ad6 MDL-34265 SCORM: Removing sorting from unsortable columns 2012-07-19 15:58:46 +08:00
Rajesh Taneja
11ad98ff0c MDL-31023 Libraries: removed legacypageobject usage 2012-07-19 15:48:45 +08:00
Rajesh Taneja
afb92f1b9e MDL-31023 libraries: removed deprecated function and classes from pagelib.php 2012-07-19 15:48:45 +08:00
Rajesh Taneja
405aca3532 MDL-32942 libraries: Replaced deprecated PARAM_ACTION and PARAM_FORMAT with PARAM_ALPHANUMEXT 2012-07-19 15:46:10 +08:00
Rajesh Taneja
071e68f93e MDL-32945 libraries: Replaced deprecated PARAM_MULTILANG with PARAM_TEXT 2012-07-19 15:44:40 +08:00
Dan Marsden
295c012de7 MDL-34233 SCORM backup - change to using set_source_sql to preserve order of records in backup. 2012-07-19 19:38:14 +12:00
Rajesh Taneja
1e12c1203b MDL-30651 libraries: Replaced deprecated PARAM_INTEGER with PARAM_INT 2012-07-19 15:37:46 +08:00
David Monllao
6b4885319b MDL-29563 course Throwing an exception instead of a message 2012-07-19 15:33:30 +08:00
David Monllao
8a1a951f7c MDL-29563 course Hide duplication button in activities without backup2 support - Credit to Mark Nielsen 2012-07-19 15:33:30 +08:00
Rajesh Taneja
37b5e8fee8 MDL-19430 My Moodle: Polished course_over view code of netspot 2012-07-19 15:30:37 +08:00
Adam Olley
83ea0cc17e MDL-19430 My Moodle: Merged Netspot My Course Overview Block for Moodle 2 2012-07-19 15:30:37 +08:00
Sam Hemelryk
1c8d09338e MDL-34285 condition: Fixed up missing operator 2012-07-19 19:29:47 +12:00
Sam Hemelryk
21a4e24cab MDL-34285 condition: Added is not empty option for user profile conditions and moved strings. 
As part of this change I added a new condition for user fields: is not equal.
I also copied the strings being used from the filters lang file to the condition
lang file and changed the uses in code.

AMOS BEGIN
  CPY [contains,filters],[contains,condition]
  CPY [doesnotcontain,filters],[doesnotcontain,condition]
  CPY [isequalto,filters],[isequalto,condition]
  CPY [startswith,filters],[startswith,condition]
  CPY [endswith,filters],[endswith,condition]
  CPY [isempty,filters],[isempty,condition]
AMOS END
 2012-07-19 19:27:00 +12:00
Dan Poltawski
3294034b80 weekly release 2.4dev 2012-07-19 13:45:13 +08:00
Frederic Massart
a2584294b3 MDL-29271 Alfresco: Repository can browse sites 2012-07-19 13:43:57 +08:00
Dan Poltawski
3b593a90ba Merge branch 'install_master' of git://github.com/amosbot/moodle 2012-07-19 13:41:50 +08:00
Frederic Massart
ce9e687701 MDL-34400 Alfresco: Altering the API for integration into Moodle 2012-07-19 13:29:42 +08:00
Frederic Massart
1258391a50 MDL-34400 Alfresco: Updated PHP SDK to v0.1 2012-07-19 13:29:10 +08:00
Dan Poltawski
0b9a3d7ac1 MDL-33624 externalib: fix two invalidcourseid uses with placeholder 
A placeholder no longer exists.
 2012-07-18 11:26:49 +08:00
Dan Marsden
bb5cc0e964 MDL-34374 SCORM prevent skipview being set to always when used inside a SCORM course format. 2012-07-18 10:32:46 +12:00
Sam Hemelryk
d7e0d2cb08 Merge branch 'MDL-31300' of git://github.com/rwijaya/moodle 2012-07-18 10:25:28 +12:00
Sam Hemelryk
e260e8ce57 Merge branch 'MDL-32948' of git://github.com/netspotau/moodle-mod_assign 2012-07-18 10:19:52 +12:00
Sam Hemelryk
5f7ee647ff Merge branch 'MDL-34217' of git://github.com/netspotau/moodle-mod_assign 2012-07-18 10:12:50 +12:00
Sam Hemelryk
7ee23e554d Merge branch 'MDL-31132-master' of git://github.com/ankitagarwal/moodle 2012-07-18 10:05:31 +12:00
Sam Hemelryk
2fcd79c043 Merge branch 'MDL-21572-master' of git://github.com/FMCorz/moodle 2012-07-18 09:41:42 +12:00
Frederic Massart
61c8e0d75f MDL-21572 Gradebook: Do not export fields when missing permissions 2012-07-18 12:56:57 +08:00
Sam Hemelryk
4d9f21a27e Merge branch 'MDL-33874-master-2' of git://git.luns.net.uk/moodle 2012-07-18 09:33:00 +12:00
Aparup Banerjee
816ac8dfb5 Merge branch 'MDL-33767-master' of git://github.com/FMCorz/moodle 2012-07-17 17:22:48 +08:00
Frederic Massart
5946d376cb MDL-33767 Course: General section displays its title when required 2012-07-18 17:13:11 +08:00
Davo Smith
a32dabc260 MDL-33927 Filemanager - enforce the maxfiles limit on form submission 2012-07-17 10:18:52 +01:00
Michael Aherne
7edfa373fd MDL-24298 news block Remove "more" link for improved accessibility 2012-07-17 09:53:46 +01:00
Sam Hemelryk
c1483c9c6c Merge branch 'MDL-32919-core_course_import_course' of git://github.com/jleyva/moodle 
Conflicts:
	version.php
 2012-07-17 17:38:16 +12:00
Dan Poltawski
239311aaad Merge branch 'MDL-34083' of git://github.com/jleyva/moodle 2012-07-17 13:11:07 +08:00
Sam Hemelryk
51625c4662 Merge branch 'MDL-33575' of git://github.com/rwijaya/moodle 2012-07-17 15:50:19 +12:00
Rossiani Wijaya
f92547f81c MDL-33575 choice module: add label to checkbox element when privacy of results is set to publish full results 2012-07-17 10:18:39 +08:00
Andrew Davis
fef7025c5e MDL-32665 mod_chat: disabled popup notifications in the chat windows 2012-07-17 10:15:14 +08:00
Damyon Wiese
da099b12a0 MDL-34272: Assignment module displays all assignments on my moodle instead of just open ones 2012-07-17 10:06:02 +08:00
Damyon Wiese
f70079b9bf MDL-2283: Display number of assignment submissions that need grading in the grading summary 2012-07-17 09:16:43 +08:00
AMOS bot
38cedbaab8 Automatically generated installer lang files 2012-07-17 00:31:43 +00:00
David Monllaó
8f80180de6 MDL-30876 filter_mediaplugin Wrapping the style sheets access with try & catch 
Conflicts:

	lib/javascript-static.js
 2012-07-17 12:20:35 +12:00