Commit graph

355 commits

Author SHA1 Message Date
Eloy Lafuente (stronk7)
dcb8f5fefb MDL-53778 quiz: ensure completion deps are fulfilled by generator uses
There are some mod_quiz generator issues where the new chain
of dependencies between completion settings was not being observed.

This patch just ensures that the now 3 chained settings are
enabled together (or new quiz options logic will proceed to
disable them).
2019-06-27 01:11:43 +02:00
Eloy Lafuente (stronk7)
a1c3ebd3eb Merge branch 'MDL-64340-master' of git://github.com/rezaies/moodle 2019-06-25 00:53:52 +02:00
Shamim Rezaie
3840540790 MDL-64340 mod_quiz: not display "add random question" when no permission 2019-06-21 08:52:14 +10:00
Jake Dallimore
7e72fd7b9f Merge branch 'MDL-65883-master' of git://github.com/lameze/moodle 2019-06-20 09:12:46 +08:00
Simey Lameze
58e601bf8b MDL-65883 mod_quiz: replace all hardcoded urls to proper params 2019-06-19 14:48:06 +08:00
Simey Lameze
6970450643 MDL-65883 mod_quiz: change attemptlib_test to use data generators 2019-06-19 14:48:01 +08:00
Tim Hunt
e900b2f34f MDL-65864 question engine: fix re-saving a new usage
Before this fix, test_repeated_usage_saving_new_usage was failing but
test_repeated_usage_saving_existing_usage was passing. Now the
behaviour is consistent and they both pass.
2019-06-13 18:04:02 +01:00
Shamim Rezaie
80c360d573 MDL-65630 mod_quiz: Allow redo within an attempt with random questions 2019-05-20 23:10:30 +10:00
Shamim Rezaie
2e68255609 MDL-65630 mod_quiz: Move logging in to the start of tests
The background is for set up, the scenario is for the test. Logging in
to start the test is the start of the test and the end of the background
itself.
2019-05-20 23:10:11 +10:00
David Mudrák
14f7489675 MDL-65537 lang: Use fixed strings in tests, too 2019-05-10 12:37:03 +02:00
Jun Pataleta
b6082744ed Merge branch 'MDL-65399-master' of git://github.com/rezaies/moodle 2019-05-07 16:24:38 +08:00
Shamim Rezaie
aa6a8b98c6 MDL-65399 mod_quiz: UI should prevent deleting the last slot of section 2019-05-06 18:11:22 +10:00
Shamim Rezaie
a834294228 MDL-65399 mod_quiz: remove_slot should update the existing info
The remove_slot method should update the remaining slot's slot
attribute. It also should update the remaining slot's question number
and section info.
2019-05-06 15:34:50 +10:00
Shamim Rezaie
a31194800b MDL-64988 mod_quiz: Fix questions always being added to the last section 2019-05-03 18:39:13 +10:00
Juan Leyva
2356454f21 MDL-60680 notifications: Include action buttons information 2019-04-25 14:55:57 +02:00
Juan Leyva
36fa0ec900 MDL-60680 notifications: Return custom data in notifications 2019-04-25 14:55:18 +02:00
Jun Pataleta
6bcc5dfdb4 MDL-65204 phpunit: Fix valid CiBoT errors and warnings 2019-04-03 10:44:24 +08:00
Eloy Lafuente (stronk7)
85f47bae7f MDL-65204 phpunit: various fixes to assertions
Namely:
   - 3rd param of assertEquals() cannot be null.
   - Some incorrect uses of assertNotEmpty().
   - Comparing 2 strings now uses strict (===) evaluation.
       Link: https://github.com/sebastianbergmann/phpunit/issues/3185
     Solution here is one of:
       a) Return to the previous situation, making the comparison
          softer. That can achieved by forcing different types, so
          float == string works.
       b) Changing APIs (both forms and database return strings) to
          perform some conversion to floats. That would make float
          comparison (with floats or strings) to work too.
     The patch here follows the a) approach. Changing all the internals
     for proper float handling sounds excesive when it has been working
     perfectly since ever. So we went the easier route, just getting
     rid of the new === comparisons when needed by changing expectation
     types to float.
2019-04-03 10:39:19 +08:00
Shamim Rezaie
3f4d7f805e MDL-63146 mod_quiz: Add userid param to mod_quiz calendar callbacks 2019-03-05 14:21:42 +11:00
Mathew May
e3652936f3 MDL-58428 theme: Shift templates ready for Bootstrapbase removal
Move behat override steps from boost into their Moodle core locations &
Move the effected core behat steps into bootstrapbase as override steps.
2019-02-22 15:19:33 +08:00
Eloy Lafuente (stronk7)
095d42c297 Merge branch 'MDL-64238-master' of git://github.com/peterRd/moodle 2019-02-11 23:56:44 +01:00
Peter
286631e7c0 MDL-64238 mod_quiz: Check enrollment on calendar_action generator
* Updated unit tests to account for participants
2019-02-08 06:40:52 +08:00
Andrew Nicols
024b5c5b9f Merge branch 'MDL-63722-master' of git://github.com/rezaies/moodle 2019-01-08 12:04:19 +08:00
Shamim Rezaie
b6ece79d81 MDL-63722 javascript: misinterpret as outside click if DOM is modified 2018-12-19 16:01:09 +11:00
Tim Hunt
b195523758 MDL-63809 question bank: ensure question_has_capability_on can be called 2018-12-18 14:54:28 +11:00
David Monllao
9af8b0aef1 Merge branch 'MDL-63394-master' of git://github.com/jleyva/moodle 2018-11-19 19:42:06 +01:00
Eloy Lafuente (stronk7)
6905c1c3fe MDL-64066 behat: more fixes to dialog names, old "add" steps 2018-11-17 12:10:37 +01:00
Juan Leyva
904c37c6c8 MDL-63394 mod_quiz: Do not fail overdue if there is a grace period 2018-11-16 16:56:40 +01:00
Andrew Nicols
705003beae MDL-63303 behat: Behat fixes 2018-11-15 16:26:16 +08:00
Shamim Rezaie
6cd2de3ceb MDL-63564 mod_quiz: Added delete_quizaccess_data_for_users to polyfill
This issue is a part of the MDL-62560 Epic.
2018-11-02 14:04:25 +08:00
Shamim Rezaie
0db66dcf5d MDL-63564 mod_quiz: support removal of multiple users in a context
This issue is a part of the MDL-62560 Epic.
2018-11-02 14:04:23 +08:00
Andrew Nicols
e538fc1549 Merge branch 'MDL-63626-master' of git://github.com/rezaies/moodle 2018-10-30 10:57:42 +08:00
Eloy Lafuente (stronk7)
f3d80b483b Merge branch 'MDL-63730-master-enfix' of git://github.com/mudrd8mz/moodle 2018-10-29 13:23:53 +01:00
David Mudrák
8743cade5b MDL-63730 quiz: Fix unit tests to use the new way of percents display
As agreed in MDL-63186, the English language pack has no space
separating the number and the percents. This patch removes the
regressions from the unit tests.
2018-10-26 14:26:12 +02:00
Damyon Wiese
cfd390ee94 MDL-63765 behat: Fix behat tests opening a menu
If javascript is disabled, we don't need to open the menus at all. If it is enabled
we should use the custom step where possible.

In some tests (user profile) we have to use link_or_button because
the element that opens the menu will be a link or a button in different themes.
2018-10-26 16:14:41 +08:00
Shamim Rezaie
44b30f9ced MDL-63626 mod_quiz: Fixed a bug when there was no attempt on the quiz 2018-10-12 01:03:39 +11:00
Simey Lameze
73aefa6bfc MDL-62610 mod_quiz: fix CiBoT issues 2018-10-01 08:27:28 +08:00
Shamim Rezaie
24c28f3c9b MDL-63390 Quiz: Use lang rules to format quiz summark as a percentage
Part of MDL-62610
2018-10-01 07:52:50 +08:00
Tim Hunt
c5499edaef MDL-63185 mod_quiz: more fixes to new behat code
Part of MDL-62610
2018-09-28 11:07:21 +08:00
Simey Lameze
9b1fc262d8 MDL-63185 mod_quiz: make CiBoT happy again
Part of MDL-62610
2018-09-28 11:07:21 +08:00
Simey Lameze
df48d3cc71 MDL-63185 mod_quiz: replace user session handling to use set_user()
Part of MDL-62610
2018-09-28 11:07:21 +08:00
Simey Lameze
90ef250d52 MDL-63185 mod_quiz: create steps to handle diferent behaviours
Part of MDL-62610
2018-09-28 11:07:21 +08:00
Simey Lameze
3c4ff02e41 MDL-63185 mod_quiz: replace existing tests to use new step
Part of MDL-62610
2018-09-28 11:07:21 +08:00
Simey Lameze
5c0654d7ff MDL-63185 mod_quiz: change APIs to handle attempts on behat
Thanks to Tim Hunt for all the help.

Part of MDL-62610
2018-09-28 11:07:21 +08:00
Simey Lameze
35aa9ade76 MDL-63185 mod_quiz: add custom behat step to create user attempts
Thanks to Tim Hunt for all the help.

Part of MDL-62610
2018-09-28 11:07:21 +08:00
Neill Magill
196aa50489 MDL-62944 activities: Test adding activities with no calendar capability 2018-08-31 10:15:36 +01:00
Víctor Déniz Falcón
02fda279ed MDL-57281 behat: deprecated step definition I navigate to node in
Definition step deprecated and affected tests modified.
2018-08-20 12:53:26 +01:00
Luca Bösch
4a73ecc654 MDL-62262 quiz: quiz index page showing wrong dates. 2018-07-06 14:37:07 +02:00
Andrew Nicols
63b0f6276c MDL-62432 quiz: Check contexts more carefully 2018-05-15 09:25:51 +08:00
Eloy Lafuente (stronk7)
1906a73574 MDL-61973 editor_atto: apply string changes to behat tests 2018-05-12 01:24:26 +02:00