Commit graph

319 commits

Author SHA1 Message Date
Eloy Lafuente (stronk7)
8888451ed5 Merge branch 'MDL-45870-master' of git://github.com/FMCorz/moodle 2014-06-17 00:51:26 +02:00
Marina Glancy
db8071a7f9 Merge branch 'MDL-45940-master' of git://github.com/damyon/moodle 2014-06-16 17:28:15 +08:00
Damyon Wiese
a3d7a82b64 Merge branch 'MDL-42531-alt' of https://github.com/jonof/moodle 2014-06-16 16:26:06 +08:00
Damyon Wiese
de06ce7ed3 MDL-45940 Assign: Improved access check
Call can_edit() instead of repeating a (slightly wrong) access check.
2014-06-16 16:20:11 +08:00
Jonathon Fowler
c462c35b95 MDL-42531 assign: refactor batch operations to use forms properly
Avoids a lot of ugly optional_param() use. Also fixes the
non-functional cancel buttons.
2014-06-10 14:06:41 +10:00
Damyon Wiese
5ba4ca894a MDL-45729 assign: Fix for assign unit tests
Check the user in the params, not the $USER
2014-06-10 11:39:20 +08:00
Graham Bowman
09fdd221ca MDL-45729 assign: conditional submission summary
Only show the submission summary if user has assign:submit capability.

Amended to fix some whitespace and the commit message.
2014-06-09 22:07:15 +02:00
Frederic Massart
78f69e51fc MDL-45870 mod_assign: Outcomes are saved for each group member 2014-06-05 15:56:13 +08:00
James Pratt
fdb6811224 MDL-42526 mod_assignment : fix record insert with assigment.id 0 2014-05-22 12:10:07 +07:00
John Okely
6d90ef2b4a MDL-45296 mod_assign: Revert changes to lock_submission and unlock_submission events 2014-05-09 09:58:55 +08:00
Eloy Lafuente (stronk7)
b8f0ec297d Merge branch 'MDL-45296' of git://github.com/stronk7/moodle 2014-05-08 15:58:46 +02:00
John Okely
9c94ca5843 MDL-45296 events: Fix objecttable and ids
Various events had them incorrectly set or missing:
  - submission_locked
  - submission_unlocked
  - subscription_created
  - subscription_deleted
2014-05-08 15:30:03 +02:00
Damyon Wiese
46b56588ae MDL-44606 Assign: Some grading functions are missing sesskey protection 2014-05-07 12:36:38 +08:00
Damyon Wiese
954e15bf27 Merge branch 'mdl44575-master' of https://github.com/tlock/moodle 2014-04-30 16:31:41 +08:00
Petr Škoda
4781ff2e5f MDL-41101 use snapshots for submissions and grades in assign events 2014-04-17 09:59:09 +08:00
Petr Škoda
31904cca34 MDL-41101 use record snapshots for user data in assign events
The problem is that event->get_user() would be very confusing
because it is mostly related user.
2014-04-17 09:51:12 +08:00
Petr Škoda
1b90858f23 MDL-41101 convert assign event triggers to new create_from_xxx helpers 2014-04-17 09:51:12 +08:00
Mark Nelson
9147c4e07f MDL-41101 mod_assign: replaced 'grade submission' add_to_log call with an event 2014-04-17 09:51:11 +08:00
Mark Nelson
81f92c220b MDL-41101 mod_assign: replaced 'view batch set marker allocation' add_to_log call with an event 2014-04-17 09:51:11 +08:00
Mark Nelson
eef4d5946a MDL-41101 mod_assign: replaced 'view batch set marking workflow state' add_to_log call with an event 2014-04-17 09:51:11 +08:00
Mark Nelson
cf2d7bfb49 MDL-41101 mod_assign: replaced 'view' add_to_log call for the submission status page with an event 2014-04-17 09:51:10 +08:00
Mark Nelson
47349e4eb0 MDL-41101 mod_assign: replaced 'view confirm submit assignment form' add_to_log call with an event 2014-04-17 09:51:10 +08:00
Mark Nelson
c24aaa389a MDL-41101 mod_assign: replaced 'submission statement accepted' add_to_log call with an event 2014-04-17 09:51:10 +08:00
Mark Nelson
b06decdd59 MDL-41101 mod_assign: replaced 'view' add_to_log call for the reveal identities confirmation page with an event 2014-04-17 09:51:09 +08:00
Mark Nelson
e65221c27b MDL-41101 mod_assign: replaced 'view submit assignment form' add_to_log call with an event 2014-04-17 09:51:09 +08:00
Mark Nelson
7eda466cb9 MDL-41101 mod_assign: replaced 'view submission grading table' add_to_log call with an event 2014-04-17 09:51:09 +08:00
Mark Nelson
1045b6e333 MDL-41101 mod_assign: replaced 'view grading form' add_to_log call with an event 2014-04-17 09:51:09 +08:00
Mark Nelson
3290c01dc5 MDL-41101 mod_assign: replaced 'view feedback' add_to_log call with an event 2014-04-17 09:51:08 +08:00
Mark Nelson
1be7aef2b1 MDL-41101 mod_assign: replaced 'view submission' add_to_log call with an event 2014-04-17 09:51:08 +08:00
Mark Nelson
c17e70e5b2 MDL-41101 mod_assign: introduced event base class
Also performed the following -

1) Deprecated the assignment's add_to_log function (part of it's functionality exists in the base class to set the legacy log data).
2) Edited existing events to use the new base class.
3) Renamed event_test.php to events_test.php to match the rest of core.
4) Moved the event tests from locallib_test.php to events_test.php.
5) When setting legacy data use lang_string, rather than get_string, as we may not be using them if legacy log is disabled.
2014-04-17 09:51:07 +08:00
Damyon Wiese
4b6e01cd76 Merge branch 'MDL-44629-B' of https://github.com/bostelm/moodle 2014-04-16 14:23:07 +08:00
Jonathon Fowler
c80d59f269 MDL-44268 assign: add 'not submitted' and 'no marker' filter options 2014-04-09 14:29:46 +08:00
Henning Bostelmann
af904bd75b MDL-44629 Assignment: add facility for displaying plugin-specific headers 2014-04-07 11:34:26 +01:00
Aaron Wells
d54404e5bb MDL-44971 Add hook to "add_attempt" for mod/assign/submission plugins 2014-04-07 10:52:48 +12:00
Sam Hemelryk
4b92f2b79b Merge branch 'MDL-44745-master' of git://github.com/damyon/moodle 2014-04-01 21:20:05 +13:00
Damyon Wiese
c70de965aa MDL-44583 Assign: performance fixes 2014-03-31 12:53:02 +08:00
Tim Lock
fdd3ebc545 MDL-44575: Prevent cron from sending feedback notifications when assignments are hidden in the gradebook 2014-03-26 09:47:01 +10:30
Damyon Wiese
4309255896 MDL-44745 Assign: Fix typo in assign->fullname function
This is a new function on master only.
2014-03-25 12:49:36 +08:00
Damyon Wiese
d63e7470a9 MDL-44745 Assign: Make the grading table use the fullname function from the assign class.
This will take blind marking into account when displaying student names.
2014-03-25 12:45:36 +08:00
Damyon Wiese
b5196badcd MDL-43960 assign: Add missing include
There was a report of mod_assign_save_grade webservice failing because of this.
I couldn't reproduce it, but grepping the code found one place where this include
should be added.
2014-03-25 12:38:09 +13:00
Damyon Wiese
c46db93c28 MDL-43721 Assign + groups: Improve performance of assign grading table
Add a function to the groups lib to filter a list of users down
to the ones who can see the module. Required because calling
groups_course_module_visible() for a list of users is too slow
and we shouldn't spread group logic outside of grouplib.php.

Using it in the assign grading table reduces DB queries from 6198/1 to 256/3.

This is 12secs down to 2.5secs.
2014-03-06 15:50:13 +08:00
Damyon Wiese
666abe6ecb MDL-43930 assign: Do not log when user is logged in as someone else.
I do not agree with this behaviour - but this makes it consistent with other modules.
2014-02-20 12:30:37 +08:00
Adrian Greeve
d7f05ad40c MDL-43289 mod_assign: Creation of new submission events.
New events have been created for submission plugins. This is
part of the consistancy move by adding the same type of event through
all of the modules.

AMOS BEGIN
 MOV [event_submission_updated,mod_assign],[eventsubmissionupdated,mod_assign]
AMOS END
2014-02-10 12:36:01 +08:00
Damyon Wiese
a6fd2e2cf1 MDL-43805 Assign: Quickgrading wipes out grades for hidden columns.
Grr.. quickgrading will always be a hack.
2014-01-29 20:29:35 +08:00
Damyon Wiese
57fbd5f91f MDL-28448 Assign: Add a new capability that lets teachers mess with student submissions. 2014-01-15 12:52:08 +08:00
Damyon Wiese
49ca1e77b0 Merge branch 'MDL-43610-m' of git://github.com/micaherne/moodle 2014-01-14 11:57:09 +08:00
Michael Aherne
f56ad6036f MDL-46310 assign Prevent blind marking submission notification email being sent to noreplyemail address 2014-01-10 15:19:04 +00:00
Damyon Wiese
8e1266bf77 MDL-33600 Assign: Add an admin setting to set the default for sendstudentnotifications 2014-01-08 11:03:59 +08:00
Damyon Wiese
f7dc9871e7 MDL-33600 Assign: Allow teachers to skip notifying students about grade update. 2014-01-08 10:34:57 +08:00
Dan Poltawski
812cc702ad Merge branch 'MDL-42995-master-3rd' of git://github.com/FMCorz/moodle 2014-01-07 11:51:15 +08:00