Commit graph

99818 commits

Author SHA1 Message Date
AMOS bot
4ffb2fe37c Automatically generated installer lang files 2020-11-29 00:07:35 +00:00
AMOS bot
cba8e995c3 Merge branch 'MOODLE_311_STABLE' into install_311_STABLE 2020-11-28 00:07:28 +00:00
Tim Hunt
5f4d8a800c MDL-54907 quiz unit tests: clean up code style in attempts_test.php 2020-11-27 18:30:57 +00:00
Tim Hunt
847f22b59e MDL-54907 quiz: better timefinish for attempts finished asynchronously
There are serveral ways a quiz attempt can be submitted:

1. The student click the Submit and finish button. In this case,
   no problem. We record the current time as the finish time
   for the quiz attempt.

2. The student is activly working away at the quiz, and the
   count-down timer reachers zero. In this case, we also record
   the current time. Note that, if the server is under high load,
   then this could well end up being a few seconds after the
   theoretical end time, so you could have a quiz with a 30 minute
   time limit, with an attempt that lasted 30:07. However, this
   is just an accurate reflection of what happened, so should
   be recorded like this.

3. If the student is offline when the time expires, then
   (depending on the quiz settings) the attempt may be
   automatically submitted by cron, but this will happen with
   at least some delay (to prevent race conditions between cron
   and a student working online) and if cron is running slow
   on the server, it could be a lot later. Previously, this led
   to, say, a 30 minute quiz where an attempt seemed to have
   lasted 67 minutes, which confused people.

   Now, in this situation, the finsh time for the quiz attempt is
   recorded as the time when the time limit ran out. This is not
   just less confusing for teachers looking at the quiz report,
   it is also more accurate. That is the latest time at which
   students could have made any changes to their responses.
2020-11-27 18:30:56 +00:00
Tim Hunt
82fb0fbc69 MDL-54907 quiz generator: defaults should match a new Moodle install 2020-11-27 18:30:56 +00:00
Tim Hunt
91aa099907 MDL-54907 dml: Correct incorrect PHPdoc 2020-11-27 18:30:56 +00:00
Jun Pataleta
0f05c1dc0b MDL-69422 mod_data: Deprecate unused 'unsupportedexport' string 2020-11-27 23:28:25 +08:00
Jun Pataleta
b92ff2923c MDL-69422 mod_data: Export form accessibility fixes
* Set appropriate heading element IDs
* Replace usages of deprecated HTML tag acronym with abbr instead.
* Add a label for the export fields fieldset.
* Move the CSV delimiter list outside the radio group.
* Fix div under a label element and duplicate labels
for the checkboxes of the fields to be exported by showing the field
name and type together.
* Group the fields to be exported as a fieldset.
* Move unsupported fields into a separate list.
* Move export options into its own section and group the options as a
fieldset.
2020-11-27 23:28:25 +08:00
Jun Pataleta
5f040a5ac8 MDL-69422 core: Convert required and help button container to div
* A span element cannot have a div as a child.
2020-11-27 23:28:25 +08:00
Sara Arjona
c8a6134c8c weekly release 3.11dev 2020-11-27 07:50:38 +01:00
AMOS bot
1edb7aabf4 Automatically generated installer lang files 2020-11-27 06:21:10 +00:00
Sara Arjona
fd478e6c1a Merge branch 'MDL-70276_311' of https://github.com/stronk7/moodle into MOODLE_311_STABLE 2020-11-26 15:04:21 +01:00
Peter Dias
729a45dc64 MDL-65215 core: Deprecate i_dock_block 2020-11-26 12:51:53 +01:00
Andrew Nicols
0873a544ed Merge branch 'MDL-63266-311' of git://github.com/peterRd/moodle into MOODLE_311_STABLE 2020-11-26 12:51:53 +01:00
Andrew Nicols
41e1eecf36 MDL-70153 qtype_essay: Whitespace/behat fixes 2020-11-26 12:51:53 +01:00
Andrew Nicols
f225783ae8 Merge branch 'MDL-70153-311' of git://github.com/dpalou/moodle into MOODLE_311_STABLE 2020-11-26 12:51:53 +01:00
Andrew Nicols
7c40a570d4 Merge branch 'MDL-70237-311' of git://github.com/rezaies/moodle into MOODLE_311_STABLE 2020-11-26 12:51:53 +01:00
Marina Glancy
fe9a2acbcc MDL-70242 auth_oauth2: set page context and url 2020-11-26 12:51:53 +01:00
Andrew Nicols
d8f1f5e8b8 Merge branch 'MDL-65852-311' of git://github.com/ilya-catalyst/moodle into MOODLE_311_STABLE 2020-11-26 12:51:53 +01:00
Eloy Lafuente (stronk7)
9db57a69d2 Merge branch 'MDL-42382-311' of git://github.com/NoelDeMartin/moodle into MOODLE_311_STABLE 2020-11-26 12:51:53 +01:00
Sara Arjona
029be97d37 Merge branch 'MDL-70248-311' of https://github.com/HuongNV13/moodle into MOODLE_311_STABLE 2020-11-26 12:51:52 +01:00
Sara Arjona
0f3f0c297c Merge branch 'MDL-70265_311' of https://github.com/stronk7/moodle into MOODLE_311_STABLE 2020-11-26 12:51:52 +01:00
Bas Brands
2d81fc6f65 MDL-69878 core_message: always show message drawer close icon 2020-11-26 12:51:52 +01:00
Andrew Nicols
9851292212 Merge branch 'MDL-70192_311' of https://github.com/stronk7/moodle into MOODLE_311_STABLE 2020-11-26 12:51:52 +01:00
Ilya Tregubov
5cb529630c MDL-69868 h5pactivity: Prevent breaking $USER when seeing
attempt report.
2020-11-26 12:40:23 +02:00
Eloy Lafuente (stronk7)
83875bc586 MDL-70276 github actions: First cut, phpunit and grunt checks
First working version, supports phpunit (using build matrix):

- php72 (lowest), running mysql.
- php74 (highest), running postgres.

Also verifies that the branch has been "gruntified" and there
isn't any missing change (build js/css files).

TODO: Verify the remaining checks currently in .travis.yml, namely:
 - CITEST
 - Add caching
 - Better health-check for DB images.
 - Support from the tracker (satus badges and enable check).
 - Support from CiBoT (status and enable check).
 - Consider moving both the common setup (git, composer...)
   and the database (mysql, postgres) to own actions for
   easier tweaking.
2020-11-26 00:25:42 +01:00
Paul Holden
3eab26586b MDL-70295 libraries: upgrade to version 4.3.1 of Html2Text. 2020-11-25 21:42:05 +00:00
Tim Hunt
7de93d7a6b MDL-70320 permission overrides: role names were double-escaped 2020-11-25 21:21:10 +00:00
Paul Holden
48cce80561 MDL-70293 libraries: upgrade to version 1.5.6 of SimplePie. 2020-11-25 21:03:46 +00:00
Claude Vervoort
ce5bed44ca MDL-70284 mod_lti: dynreg fix response claims 2020-11-25 10:51:45 -05:00
cescobedo
38914ee3cd MDL-70327 core_h5p: Add preventredirect to the player 2020-11-25 16:30:43 +01:00
Jordan Tomkinson
c59d3c606f MDL-70326 antivirus: fixing regression in MDL-66222 2020-11-25 11:30:58 +01:00
Ilya Tregubov
375af0e6c3 MDL-65852 user: Fix permission check to download course participants. 2020-11-25 11:27:41 +02:00
Jamie Stamp
b0c2b85310 MDL-69121 core: Add ZSTD/Gzip compression options to Redis sessions 2020-11-24 23:16:30 +01:00
Sara Arjona
e16deb2c2b Merge branch 'MOODLE_311_MDL-69773_v2' of https://github.com/golenkovm/moodle into MOODLE_311_STABLE 2020-11-24 17:24:49 +01:00
Tim Hunt
48eadbc999 MDL-70321 question backup: fix MDL-47178 unit tests
They were failing if you had CodeRunner installed
2020-11-24 15:29:23 +00:00
Simon Mok
b85314b06f MDL-67460 profile: User profile link to use HTTPS 2020-11-24 20:47:32 +08:00
Adrian Greeve
e2ea199759 Merge branch 'MDL-64776-311' of git://github.com/peterRd/moodle into MOODLE_311_STABLE 2020-11-24 08:55:17 +08:00
Mikhail Golenkov
64e7678c47 MDL-69773 block_section_links: Add an option to display section name 2020-11-24 11:34:38 +11:00
Tim Hunt
fa2e457944 MDL-70285 completion upgrade: fix performance of the MDL-69687 code 2020-11-23 20:49:56 +00:00
David Matamoros
873e8961e5 MDL-69411 core_message: Fix return structure for empty result set
Passing a timefrom higher than last message timecreated needs to
return a formatted response so it does not break ws.
2020-11-23 19:25:42 +01:00
Eloy Lafuente (stronk7)
a014ebdc6a MDL-70265 travis: Completely remove the UPGRADE check
It was broken since ages ago, see MDL-64874, so no sense
to keep it eating minutes for nothing.
2020-11-23 13:42:36 +01:00
Adrian Greeve
13c3289335 Merge branch 'MDL-67668-311-2' of git://github.com/andrewnicols/moodle into MOODLE_311_STABLE 2020-11-23 15:39:16 +08:00
Peter Burnett
08c6aad9a7 MDL-70160 cache: plugin_functions checks for function_exists() 2020-11-23 15:22:27 +08:00
Adrian Hutchinson
50baaebc31 MDL-67028 mod_lti: Support CourseSection.timeFrame custom parameters 2020-11-23 14:07:18 +08:00
Andrew Nicols
62763b84d4 MDL-70151 assign: Fix bulk change for behat
Behat does not play well with confirmation dialogues and in some
situations it does not wait for the page to reload before starting the
next step.

This change adds a pending_js call which is only resolved if the cancel
button was pressed, otherwise it remains in-progress until the page
reloads resetting the entire state of it.
2020-11-23 11:11:50 +08:00
Andrew Nicols
9bec65f04f MDL-70167 behat: Rewrite attribute check steps
This commit updates the following steps to use the
`the_attribute_of_should_be_set` step under the hood:
- the [element] [type] should be disabled
- the [element] [type] should be enabled
- the [element] [type] should be readonly
- the [element] [type] should not be readonly

This reduces unnecssary code duplication.
2020-11-23 11:03:15 +08:00
Andrew Nicols
5654ddc32e MDL-70167 behat: Boolean attributes should either exist or not 2020-11-23 11:03:15 +08:00
Andrew Nicols
94a492a0f4 MDL-67668 behat: Update tests for inplace editable field type 2020-11-23 09:00:46 +08:00
Andrew Nicols
7a2006b499 MDL-67668 behat: Add inplace editable field type
This commit promotes the Inplace Editable field to a first-class form
element by introducing a new partial selector for inplace editable
fields, and teaching the field manager how to recognise these, then
introducing a new field type which can handle setting values for this
field.
2020-11-23 09:00:46 +08:00