Commit graph

18076 commits

Author SHA1 Message Date
Tim Hunt
8011be189e MDL-33653 fix preview links on calc qtype edit forms.
Also, refactor how we render preview icons, to eliminate duplication.
2014-03-07 19:46:56 +00:00
Brian King
c484af5aa6 MDL-43497 Language: Allow course language to be overridden 2014-03-07 09:11:18 +01:00
David Monllao
759b323e0e MDL-43236 behat: Updating references to deprecated methods 2014-03-07 16:05:21 +08:00
David Monllao
c51c3b5575 MDL-43236 behat: Deprecate old steps
Correcting grammar errors and deprecating
the previous steps definitions:
- behat_data_generators::the_following_exists()
- behat_general::should_exists()
- behat_general::should_not_exists()
2014-03-07 16:05:21 +08:00
Rajesh Taneja
e1b16f9773 MDL-44017 Events: Deprecated content_viewed event
Replaced content_viewed event with appropriate events and deprecated
content_viewed event
2014-03-07 15:16:10 +08:00
Andrew Nicols
b959e5085a MDL-44334 Javascript: Prevent scroll locking for small screen heights 2014-03-07 15:04:56 +08:00
David Monllao
a542553d42 MDL-44440 behat: Refactoring features to use I navigate to
Replacing multiple "I expand node" steps by the
new "I navigate to". Also fixing few I navigate to
when dealing with non-JS.
2014-03-07 14:46:54 +08:00
David Monllao
370e88d4fe MDL-44440 behat: Other fixes to make clean work properly
- Update the step to follow links inside a treeview
  to work also when JS is disabled.
- Make regions accept header and footer.
- Change some locators refering to non-clean compatible
  regions.
- Restricting click to the table row in forum tracking
  because seems to conflict with the navigation bar when
  using narrow window sizes.
2014-03-07 14:27:52 +08:00
Rajesh Taneja
26fb3f5b71 MDL-44440 navigation: Added behat step to navigate from navigation/Admin block
This step will help navigate to different parts of moodle
using navigation or adminstration block.
2014-03-07 11:55:31 +08:00
Tim Lock
9619ff9ba3 MDL-44499: Fix PHP warning in upload_manager class 2014-03-07 14:19:26 +10:30
Marina Glancy
1480f6ea68 MDL-43966 events: link to migration wiki in lib/upgrade.txt 2014-03-07 09:55:17 +08:00
Andrew Nicols
d10e611876 MDL-44480 Javascript: Correct dialogue ID generation 2014-03-06 17:02:22 +08:00
Damyon Wiese
c46db93c28 MDL-43721 Assign + groups: Improve performance of assign grading table
Add a function to the groups lib to filter a list of users down
to the ones who can see the module. Required because calling
groups_course_module_visible() for a list of users is too slow
and we shouldn't spread group logic outside of grouplib.php.

Using it in the assign grading table reduces DB queries from 6198/1 to 256/3.

This is 12secs down to 2.5secs.
2014-03-06 15:50:13 +08:00
Damyon Wiese
052b8c81c6 Revert "MDL-32917 YUI2 to YUI3 Calendar port: only display the date from the matching selector and display the month/year matching the selector value"
There are numerous bugs with this new module to do with showing the currently selected date,
random changes in the selected dates, showing multiple selected dates and css errors.

This reverts commit 1d128663f6.
This reverts commit 4a521e6596.
2014-03-06 13:38:17 +08:00
Damyon Wiese
81b4ec4fc3 Merge branch 'MDL-32917-master-nomerge3' of git://github.com/mouneyrac/moodle 2014-03-06 11:41:09 +08:00
Jerome Mouneyrac
1d128663f6 MDL-32917 YUI2 to YUI3 Calendar port: only display the date from the matching selector and display the month/year matching the selector value 2014-03-06 11:35:00 +08:00
Damyon Wiese
d09cfab660 Merge branch 'wip-MDL-44403-master' of git://github.com/marinaglancy/moodle 2014-03-06 09:21:24 +08:00
Andrew Nicols
1fa31fb376 MDL-44061 Ajax: Log whitespace issues to the server error log 2014-03-05 16:34:35 +08:00
Petr Škoda
b3d5bd33f8 MDL-44451 fix plugin_misplaced_exception exception 2014-03-05 16:33:41 +08:00
Brent Boghosian
00dabc896b MDL-43635: Further support custom contexts
Reading from config DB table and reset method for after plugin install
Add PHPUnit test for custom context changes
2014-03-05 15:01:30 +08:00
Damyon Wiese
23d142ef5a Merge branch 'MDL-44361-master' of git://github.com/andrewnicols/moodle 2014-03-05 11:36:16 +08:00
Dan Poltawski
f1284d3cfe Merge branch 'MDL-44272-master' of git://github.com/ankitagarwal/moodle 2014-03-04 15:59:55 +08:00
Marina Glancy
24c32bdf2f MDL-44403 events: added public method to get eventdata 2014-03-04 15:16:15 +08:00
Dan Poltawski
745f2cc521 Merge branch 'MDL-44436-master' of git://github.com/FMCorz/moodle 2014-03-04 14:40:23 +08:00
Damyon Wiese
98b51f3882 Merge branch 'MDL-32917-master-nomerge2' of git://github.com/mouneyrac/moodle 2014-03-04 14:27:33 +08:00
Frederic Massart
cea24f4852 MDL-44436 context: Context IDs are forced to be int
The method context::insert_context_record() sets the context::$id to
an int, while when we create an instance, the $id is often read from
a DB $record object, and is a string. The ID should always be an int.
2014-03-04 14:24:40 +08:00
Damyon Wiese
ca0361084b Merge branch 'w10_MDL-41266_m27_logging' of https://github.com/skodak/moodle 2014-03-04 13:32:43 +08:00
Damyon Wiese
267c4b4292 Merge branch 'MDL-43738_master' of git://github.com/dmonllao/moodle 2014-03-04 13:29:03 +08:00
Dan Poltawski
d129de3761 Merge branch 'w10_MDL-44358_m27_stylesrefact' of https://github.com/skodak/moodle 2014-03-04 07:38:56 +08:00
Dan Poltawski
5a02170cb3 Merge branch 'MDL-44377' of https://github.com/stronk7/moodle 2014-03-03 15:15:23 +08:00
Petr Škoda
31f28b6ac2 MDL-44358 inform developers that CSS handling was refactored 2014-03-03 14:19:12 +08:00
Dan Poltawski
f504e63daa Merge branch 'wip-MDL-44321-master' of git://github.com/marinaglancy/moodle 2014-03-03 13:50:18 +08:00
Dan Poltawski
a8b07dbf98 Merge branch 'wip-MDL-44362-master' of git://github.com/marinaglancy/moodle 2014-03-03 13:33:40 +08:00
Dan Poltawski
818f4f953c Merge branch 'w06_MDL-43344_m27_flow' of https://github.com/skodak/moodle 2014-03-03 10:07:16 +08:00
Tim Hunt
ccba5b8805 MDL-43749 normalise quiz database structure.
The sequence of questions that made up a quiz used to be stored as a
comma-separated list in quiz.questions. Now the same information is
stored in the rows in the quiz_slots table. This is not just 'better' in
a database design sense, but it allows for the future changes we will
need as we enhance the quiz in the MDL-40987 epic.

Having changed the database structure, all the rest of the code needs to
be changed to account for it, and that is done here.

Note that there are not many unit tests for the changed bit. That is
because as part of MDL-40987 we will be changing the code further, and
we will add unit tests then.
2014-03-02 10:00:40 +01:00
Tim Hunt
9eec598ca9 MDL-44251 fix typo in DML unit tests. 2014-03-02 09:41:17 +01:00
Tim Hunt
c185726964 MDL-44251 DB helper to update rows without violating a unique index. 2014-03-02 09:41:03 +01:00
Eloy Lafuente (stronk7)
7b9ea861b6 MDL-44377 dml: enforce non-empty prefix for sqlsrv
Only MySQL is allowed to run Moodle instances without
(with an empty) database prefix. The rationale is that
"user" is a reserved word in every RDBMS but MySQL.

Before this patch, installation was breaking badly, when
the "user" CREATE TABLE statement was issued. With this
patch the error is shown earlier (on connection) preventing
any advance/use of the database.

This check is present in all the drivers, just sqlsrv was missing it.
2014-02-28 10:12:03 +01:00
Marina Glancy
21d2280361 MDL-44362 recentactivity: fix regressions from MDL-44055 2014-02-28 16:39:32 +08:00
Marina Glancy
74d45861e9 MDL-44321 events: Text correction in assessable events 2014-02-28 16:37:36 +08:00
Marina Glancy
cd5be9a504 MDL-44321 events: make sure the full object is passed to add_record_snapshot() 2014-02-28 16:37:36 +08:00
Marina Glancy
5e70ea26bb MDL-44321 events: debug on errors in add_record_snapshot()
also clone object returned by get_record_snapshot() to prevent accidental changing of $COURSE or other important objects
2014-02-28 16:37:31 +08:00
Marina Glancy
1e242b41af MDL-44321 events: cleaning up course_module_instance_list_viewed event 2014-02-28 16:36:09 +08:00
Marina Glancy
fbc4b77841 MDL-44321 events: cleaning up course_module_viewed event 2014-02-28 16:36:09 +08:00
Jerome Mouneyrac
4a521e6596 MDL-32917 port YUI2 Moodle calendar into a shifted YUI3 Calendar 2014-02-28 15:05:43 +08:00
Petr Škoda
993d8d838f MDL-41266 improve naming of log reader interfaces 2014-02-28 14:52:30 +08:00
Petr Škoda
43d91d7665 MDL-42891 fix $interface parameter in dummy log manager and add unit tests 2014-02-28 14:52:30 +08:00
Ankit Agarwal
e083efe0ac MDL-42891 logging: Add support for getting readers that implement a specific interface in log manager 2014-02-28 14:52:29 +08:00
Petr Škoda
bdae738e38 MDL-41266 add new is_logging() method to log readers
This will be useful in live logs report where we want only readers that have latest data.
2014-02-28 14:52:28 +08:00
Petr Škoda
0852f9c625 MDL-41266 fix coding style issues 2014-02-28 14:52:27 +08:00