Commit graph

22260 commits

Author SHA1 Message Date
Frederic Massart
7f8b7b2bb3 MDL-55797 output: Support form method in chooser
Part of MDL-55071
2016-09-23 10:55:17 +01:00
Frederic Massart
370e7637c6 MDL-55904 output: Deprecate action_menu::do_not_enhance()
Part of MDL-55071
2016-09-23 10:55:17 +01:00
Damyon Wiese
63e4df60f6 MDL-55839 behat: Behat fixes for theme_noname
This is a squash of many small fixes.
The list of changes are:

Initial set of behat selectors overrides required for new theme.

set core behat selectors if not overridden by theme

Remove pause

Fix for checkboxes not saving properly

Custom override for click in the user menu

Fix for behat guessing the field type.

Behat fix for guessing the correct field type.

Fix for missing closeElementBefore mforms mess.

Fix for textareas not displaying their contents.

Fix availability form element

Fix action menu selectors for activities in a course page

Fix textareas not retaining their values

Fix selector for blocks

I had to change the single select template to use an input instead of a button because of a
behat bug we have not tracked down yet.

Fix for frozen attribute in form elements

Use input instead of button while behat is still broken

Fix for navigation selector override

Behat selector fixes and multi-select fixes for templated select

Fix for configure blocks selector + booleans for autocomplete

Fixes for course_summary behat tests

Allow optgroups in single_select

Behat fixes for block_navigation

Fixes for url form element and activity chooser selectors

blocks_social - fix specific selector for behat

Fix export_for_template for selectgroups element.

Dont set empty id on the form

Fix direct call to behat_navigation in backup context

Checkbox empty value fix

Fix for assign grading panel popouts

file picker overrides to find a file manager in the page

Fix chat tests to use element name

Make selectors in mod_data behat less specific

MDL-55839: recent activity behat test relies on time()

SQUASH Honour mform element "class" attribute on the container

SQUASH Fixes for behat in mod_forum

SQUASH search form template showing value as text next to the button

SQUASH undo double selectgroup fix

SQUASH - The slightly different structure to action menus breaks course drag and drop

SQUASH Wrap loading icon in a span so the selector still works.

SQUASH Fix fragile javascript in report_loglive

SQUASH Fix tabtree, and selectgroups for mod_feedback

Also - do-not enhance the action menu - we are dropping support for this.

SQUASH Fix filemanager selector and pix_icon template for mod_forum tests.

SQUASH Fixes to breadcrumb and add formid to single select (fixes mod_glossary tests)

SQUASH lesson behat fixes. 95% of lesson styles were rubbish so they were disgarded.

SQUASH Fix lti behat tests - they were cheating and using a context step from quiz

SQUASH Behat fixes for quiz with new theme

SQUASH behat fixes for mod_wiki

SQUASH Workshop behat fixes

SQUASH Frozen form elements cannot use a readonly form element because it screws with the form JS "disabledIf" stuff.

SQUASH Fixes for grades behat tests

SQUASH behat fixes for groups

SQUASH blacklist action menu tests

SQUASH Fix for tag form element missing "manage standard tags" link

SQUASH Incomplete fixes for course behat tests

SQUASH behat fixes for badges

SQUASH Tags fixes for behat

SQUASH filepicker fixes for behat

SQUASH Abort guessing field type when we hit 'html'

SQUASH Fix for admin/tool/behat tests

SQUASH fix for admin tool behat tests

SQUASH fix for availabilty conditions hiding "aria-hidden" elements

SQUASH give the blocks more room. We get behat files because nav tree nodes are not in view

SQUASH Blocks fixed

Fix behaviour of unchecked checkboxes

SQUASH Remove incorrect step in user test

SQUASH behat fixes for course tests

Part of MDL-55071
2016-09-23 10:55:16 +01:00
Frederic Massart
f15024c18e MDL-55831 output: Convert action menu to templates
Part of MDL-55071
2016-09-23 10:55:16 +01:00
Frederic Massart
11ba3fd4c1 MDL-55831 output: Convert action_link to template
Part of MDL-55071
2016-09-23 10:55:16 +01:00
Frederic Massart
0f24d9cb25 MDL-55830 form: Selectgroups option values where not passed to template
Part of MDL-55071
2016-09-23 10:55:16 +01:00
Frederic Massart
df07fead55 MDL-55829 form: Define 'skipClientValidation' as a global JS var
Part of MDL-55071
2016-09-23 10:55:16 +01:00
Damyon Wiese
7d547564a8 MDL-55796 output: Add missing include to new chooser renderable
Part of MDL-55071
2016-09-23 10:55:15 +01:00
Frederic Massart
4f2378d929 MDL-55796 core_course: Convert course modchooser to templates
Part of MDL-55071
2016-09-23 10:55:15 +01:00
Frederic Massart
ee9dd6a278 MDL-55796 core: Do not escape pix_icon URLs
Part of MDL-55071
2016-09-23 10:55:15 +01:00
Frederic Massart
4121391d34 MDL-55805 admin: Convert admin search results to use a template
Part of MDL-55071
2016-09-23 10:55:15 +01:00
Frederic Massart
d5732f7f40 MDL-55805 admin: Notices displayed on validation errors
Part of MDL-55071
2016-09-23 10:55:15 +01:00
Andrew Nicols
2c3a6e2479 MDL-55657 theme_noname: Use a separate template for passwordunmask
Part of MDL-55071
2016-09-23 10:55:14 +01:00
Frederic Massart
fc7f69e7e8 MDL-51948 formslib: Support forcing LTR on form elements
Part of MDL-55071
2016-09-23 10:54:49 +01:00
Frederic Massart
113efed5b0 MDL-51948 admin: Make admin settings RTL friendly
Part of MDL-55071
2016-09-23 10:54:22 +01:00
Frederic Massart
a47e73ff7c MDL-55594 output: Adding template name to filenotfound exception
Part of MDL-55071
2016-09-23 10:53:57 +01:00
Frederic Massart
14395f9789 MDL-55594 output: Adding template for html_writer::select_time
Part of MDL-55071
2016-09-23 10:53:56 +01:00
Damyon Wiese
d893a4111e MDL-55700 theme_noname: Allow text nodes in breadcrumb
The new theme was showing all nodes in the breadcrumb as links even when there is no
valid link.

Part of MDL-55071
2016-09-23 10:53:56 +01:00
Frederic Massart
a84eadb88e MDL-55701 output: Adding core template for help_icon
We didn't intend to do this, but as I made the mistake of extending
core/help_icon in a core template without realising that it
works solely because I had that template in the new theme, I
decided to add this template to core too.

Part of MDL-55071
2016-09-23 10:53:56 +01:00
Andrew Nicols
ecfad63d28 MDL-55696 output: Correct handling of url_select nothingvalue
Part of MDL-55071
2016-09-23 10:53:56 +01:00
Damyon Wiese
d6f2ce1486 MDL-55656 theme_noname: Include advanced and required field markup
The new form elements were not including the markup for advanced
and required fields. I used an <abbr> tag in the label to give
and accessible indication of the advanced and required fields.

Part of MDL-55071
2016-09-23 10:53:56 +01:00
Frederic Massart
df7602298a MDL-55564 core_admin: Convert admin settings to use templates
Part of MDL-55071
2016-09-23 10:53:56 +01:00
Frederic Massart
58357d41af MDL-55564 output: Single select label wasn't translated
Part of MDL-55071
2016-09-23 10:53:56 +01:00
Frederic Massart
cd7a164bdf MDL-55564 output: Use template for password autofill hack
Part of MDL-55071
2016-09-23 10:53:55 +01:00
Damyon Wiese
ce18fb1e86 MDL-55417 forms: Change iscancel property to issecondary for submit buttons
This is more future proof for the template.

Part of MDL-55071
2016-09-23 10:53:31 +01:00
Damyon Wiese
7e2cd5b84e MDL-55417 forms: Improve some of the new templates for form elements
Also - un-deprecate selectwithlink (Fred convinced me).

Part of MDL-55071
2016-09-23 10:53:30 +01:00
Damyon Wiese
97a00c9b8e MDL-55417 forms: Keep the JS for autocomplete in the template
Part of MDL-55071
2016-09-23 10:53:30 +01:00
Damyon Wiese
344321e1ef MDL-55417 forms: Clean up form element template patch
Use a trait and a base mustache template for all form elements to reduce code
duplication and increase standardisation.

Part of MDL-55071
2016-09-23 10:53:30 +01:00
Damyon Wiese
91bda4cd45 MDL-55417 forms: Render form elements with a template
This change allows form elements to be overridden with a mustache template.
The template can even listen for form validation errors and supply the JS to
change the look of the form element when there is/isn't a validation error.

Initial support is for all core form elements including:

text, select, selectyesno and checkboxes, groups, dateselector, datetimeselector,
autocomplete, modvisible, advcheckbox, button, duration, filemanager, filepicker, editor, static, grading,
warning, textarea, password, url, submit, questioncategory, recaptcha.

Part of MDL-55071
2016-09-23 10:53:30 +01:00
Frederic Massart
386f269fae MDL-55517 theme_noname: Style the login page
Part of MDL-55071
2016-09-23 10:53:30 +01:00
Frederic Massart
1fe8e35f54 MDL-55517 login: Converting login page to use renderer/renderable
Part of MDL-55071
2016-09-23 10:53:30 +01:00
Didier 'OdyX' Raboud
23ef5a971c MDL-55517 login: Rework the login/index.php through a mustache template
Part of MDL-55071
2016-09-23 10:53:30 +01:00
Frederic Massart
99a6118f28 MDL-55381 output: Themes can post process CSS using a CSS tree object
Part of MDL-55071
2016-09-23 10:53:30 +01:00
Frederic Massart
515ceadddd MDL-55381 php-css-parser: Patch for Sabberworm/PHP-CSS-Parser#115
REMOVE ME ONCE Sabberworm/PHP-CSS-Parser#115 is merged

Part of MDL-55071
2016-09-23 10:53:30 +01:00
Frederic Massart
d7c657528a MDL-55479 output: Single button uses templates
Part of MDL-55071
2016-09-23 10:53:29 +01:00
Frederic Massart
f1b34660ed MDL-55495 output: Make url_select a templatable
Part of MDL-55071
2016-09-23 10:53:29 +01:00
Frederic Massart
b0da86e03b MDL-55496 output: Make paging_bar a templatable
Part of MDL-55071
2016-09-23 10:53:29 +01:00
Frederic Massart
bf7f35e945 MDL-55463 output: Make single select a templatable
Part of MDL-55071
2016-09-23 10:53:29 +01:00
Damyon Wiese
b7e95263fd MDL-55462 output: Make help_icon templatable
Render it with a template in the new theme.

Part of MDL-55071
2016-09-23 10:49:50 +01:00
Frederic Massart
ed7844b5f4 MDL-55224 theme_noname: RTL adjustments for auto-flipping era
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Frederic Massart
1d987cae5f MDL-55224 output: Support automatic flipping to RTL styles
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Frederic Massart
fbe18cc022 MDL-55224 core: Import PHP-CSS-Parser into core
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Frederic Massart
e86eb6b80d MDL-55224 core: Import RTLCSS-PHP into core
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Damyon Wiese
3f0544b839 MDL-55413 theme_noname: action-menu conversion
Convert action-menus to templates using bootstrap4 markup.
Includes changes to iconsmall/smallicon.

Part of MDL-55071
2016-09-23 10:49:49 +01:00
Frederic Massart
11268ae1c4 MDL-55412 output: Make tabtree and tabobject templatables
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Frederic Massart
65b8336ed3 MDL-55286 theme: Support compiling SCSS on-demand from a theme
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Frederic Massart
321c986c86 MDL-55285 core: Include library scssphp in core
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Damyon Wiese
88af020839 MDL-55411 theme_noname: Style the filepicker for bootstrap 4
Uses templates.

Part of MDL-55071
2016-09-23 10:49:49 +01:00
Damyon Wiese
f130c411d9 MDL-55410 theme_noname: Convert custom menu renderer to render bootstrap4 menus.
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Damyon Wiese
536f046033 MDL-55402 theme_noname: Convert bootstrapbase to bs4
All moodle less files are converted to sass with layouts etc
written as mustache templates.

Bootstrap 4 sass files are imported to scss/bootstrap.

Part of MDL-55071
2016-09-23 10:49:48 +01:00