Commit graph

93460 commits

Author SHA1 Message Date
David Mudrák
3b7c7918f3 MDL-61667 analytics: Deprecate the add_builtin_models() method
The functionality of the \core_analytics\manager::add_builtin_models()
method is to be replaced with automatic update of models provided by the
core moodle component. There is no need to call this method explicitly
any more. Instead, adding new models will be done by updating the
lib/db/analytics.php file and bumping the core version.
2019-04-01 14:23:06 +02:00
David Mudrák
6187213f39 MDL-61667 analytics: Add method to actually create a declared model
This is simply a wrapper around the model's create() method that works
with the model declaration syntax from the db/analytics.php file.
2019-04-01 14:23:06 +02:00
David Mudrák
f05840451e MDL-61667 analytics: Add methods to read and validate model declarations
Allow every component to declare prediction models it provides via the
db/analytics.php file.
2019-04-01 14:23:06 +02:00
David Mudrák
4de4d1652b MDL-61667 analytics: Don't autoenable models with time splitting defined
When the API had originally been designed, it was assumed that the
presence of the time splitting method implies no requirement for the
machine learning backend and that it is a sign of less performance
demanding models. So it seemed to be safe and useful to have such models
automatically enabled. That assumption did not prove to be valid. Most
of the time is spent calculating indicators that depend on log tables.

We realized it would be useful to be able to specify the default time
splitting method without the need to have such models auto-enabled.
2019-04-01 14:23:06 +02:00
David Monllaó
75dfc588b5 MDL-64779 tool_analytics: Export selector 2019-04-01 13:56:37 +02:00
Adrian Greeve
878c88df95 Merge branch 'MDL-65050-master-fix' of git://github.com/lameze/moodle 2019-04-01 16:05:34 +08:00
Simey Lameze
6e049bdbc6 MDL-65050 core: add missing lib file include 2019-04-01 15:59:03 +08:00
Damyon Wiese
647fd16ec9 MDL-65144 output: Add img-fluid to logo
Extra wide logos do not scale to the screen size - this change adds the bootstrap class
img-fluid to logos on the loginpage, signupform and in the context header.

Thanks to Maksud R for working on this.
2019-04-01 15:49:29 +08:00
Simey Lameze
73fabadadd MDL-65138 course: add a setting for course publishing 2019-04-01 15:39:07 +08:00
Jake Dallimore
4a2ee121fc Merge branch 'MDL-65089_master' of https://github.com/dvdcastro/moodle 2019-04-01 15:28:48 +08:00
Trisha Milan
600de03e05 MDL-64894 Theme: Fix unable to expand collapsible topics 2019-04-01 14:54:18 +08:00
Jake Dallimore
9f32a85852 Merge branch 'MDL-64194-37_block_myoverview_incorrect_pagination' of https://github.com/tomdickman/moodle 2019-04-01 14:36:01 +08:00
Brendan Heywood
b940ca995a MDL-64394 core: Fixed bug when using access log with pre_loginpage_hook 2019-04-01 16:48:22 +11:00
Jun Pataleta
a8c91e88bf Merge branch 'MDL-64524-master' of git://github.com/damyon/moodle 2019-04-01 13:46:48 +08:00
Adrian Greeve
d15b5340cc Merge branch 'MDL-65050-master' of git://github.com/lameze/moodle 2019-04-01 13:32:38 +08:00
Simey Lameze
d499cb3593 MDL-65050 core: delete orphaned files and functions 2019-04-01 12:57:05 +08:00
Simey Lameze
9c164d26fc MDL-65050 core: add question_stats_cleanup_task scheduled task
This commit also removes orphaned question/engine/statisticslib.php
2019-04-01 12:57:05 +08:00
Simey Lameze
10810f421b MDL-65050 core: move function code to question_preview_cleanup_task
This commit also deletes the legacy question_preview_cron() function.
2019-04-01 12:57:05 +08:00
Simey Lameze
5a01c2409a MDL-65050 core: rename task to question_preview_cleanup_task 2019-04-01 12:57:01 +08:00
Damyon Wiese
4b9c3e44e0 MDL-64524 gradingform_guide: Marking guide comments
When there are too many comments, scroll the list so they still fit in the dialogue.
2019-04-01 12:17:27 +08:00
Damyon Wiese
284babb0d7 MDL-64524 assign: Styles editpdf comments
Properly display the list of comments, but limiting their size (use title to indicate the full comments).
When there are too many comments, show a scrollbar in the menu.
2019-04-01 12:17:27 +08:00
Jun Pataleta
db3527c2cc Merge branch 'MDL-63906_master' of git://github.com/dmonllao/moodle 2019-04-01 10:32:10 +08:00
Adrian Greeve
6934691fce Merge branch 'MDL-65173_master' of git://github.com/markn86/moodle 2019-04-01 10:21:10 +08:00
Simey Lameze
9bec0e7e74 MDL-65207 core: replace typos by actually 2019-04-01 08:49:18 +08:00
Eloy Lafuente (stronk7)
6c8c286d60 MDL-65218 recycle bin: cover immunization via settings provider
Both for course and category recycle bins
2019-03-31 22:53:53 +02:00
Eloy Lafuente (stronk7)
311123bcce MDL-65218 recycle bin: immunize recycle bin from backup_auto_storage
As far as recycle bin is using MODE_AUTOMATED, it observes the backup_auto_storage
setting (storing backups @ real location. For recycle bin we want to ensure that
backup files are always stored in Moodle file area. In order to achieve that, we
hack the setting here via $CFG->forced_plugin_settings, so it won't interfere other
operations.  See MDL-65218 for more information.

This hack will be removed once recycle bin switches to use its own backup mode, with
own preferences and 100% appart from MODLE_AUTOMATED.
2019-03-31 22:53:41 +02:00
Eloy Lafuente (stronk7)
8793f25279 MDL-65218 recycle bin: Course backups (cat bin) to use MODE_AUTOMATED
Surely this should have been done as part of MDL-63263, but it wasn't.
Better let's do it here so every recycle bin backup is using the
very same mode.
2019-03-29 20:44:16 +01:00
Jason Platts
f7af1e0b9c MDL-65220 behat: test scenarios sometimes do not clear database data 2019-03-29 15:39:31 +00:00
Tim Hunt
05ea7ab19e MDL-65222 questions: explain question walkthrough tests 2019-03-29 14:49:39 +00:00
Tim Hunt
f1ffd134d3 MDL-65029 questions: change question div id to acutally be unique
This is largely based on Simey Lameze's work.
2019-03-29 13:37:44 +00:00
Tobias Reischmann
90e331bcdc MDL-65206 calendar: Enable update of location in repeated events.
The location is now updated in repeated events if it is altered in one
event and the option 'Also apply changes to the other X events in this
repeat series' is selected. If the location is not altered but some
other details, then manual changes of the location in other events
will not be overriden.
2019-03-29 14:13:43 +01:00
Victor Deniz Falcon
03fce0a71d MDL-64636 analytics: new course_completion target
Added new target to predict which students are at risk of not meeting
the course completion criteria.
2019-03-29 10:29:45 +00:00
Víctor Déniz Falcón
48ac554c51 MDL-64636 analytics: base class for course completion targets
Added new parent class for targets that use course as analysable and
student enrolments as samples. course_dropout target was modified to
extend that parent class.
2019-03-29 10:27:50 +00:00
Paul Holden
114973b549 MDL-59326 admin: use passwordunmask element for shared secrets. 2019-03-29 09:27:45 +00:00
Eloy Lafuente (stronk7)
09b97f40fc MDL-65214 install: update the list of stale files for 3.7 2019-03-29 10:00:38 +01:00
Sara Arjona
ccd4752356 MDL-65127 message: add aria-labels to the numbers in the overview
Add aria-label to the unread message and notification icons.
Add aria-label to the total conversations, unread conversations
and unread messages in the overview.
Add aria-label to the pending contact requests in the overview
and also in the contacts tab.
Add aria-hidden to the last message date.
2019-03-29 09:38:22 +01:00
Sara Arjona
3d8cf610d9 MDL-65087 message: add aria-label to some buttons on bootstrapbase
The aria-label has been added to the settings and search buttons and
also to the starred image displayed when a conversation is favourited.
2019-03-29 09:33:35 +01:00
Sara Arjona
67855b3b4e MDL-65087 message: add aria-label to search, settings and starred 2019-03-29 09:33:35 +01:00
Sara Arjona
e758a9b932 MDL-65087 message: add button role to action links on bootstrapbase
For accessibility reasons, add the role="button" attribute to the links
with href="#" performing actions for the bootstrapbase theme, like
the settings icon.
2019-03-29 09:33:35 +01:00
Sara Arjona
c0d2558c43 MDL-65087 message: add button role to all the links that perfom actions
For accessibility reasons, add the role="button" attribute to the links
with href="#" performing actions, like the icon to open the messaging
drawer.
2019-03-29 09:33:35 +01:00
Adrian Greeve
e39991c3c0 MDL-59081 mod_lesson: Behat test for new features.
1. Tests the catch all answer sections for the short answer
and numerical page types.
2. Tests to check that the continue buttons will not double
up if they both go to the same page.
2019-03-29 14:14:01 +08:00
Adrian Greeve
dab563f5a6 MDL-59081 mod_lesson: Remove continue button if not needed.
This checks to see if the continue button goes to the same
page as the try again button and removes it if it does.
2019-03-29 14:14:01 +08:00
Adrian Greeve
49898ef3b4 MDL-59081 mod_lesson: Shortanswer form update. Catch all.
The short answer question type now has a form element that
will catch all other responses.
2019-03-29 14:14:01 +08:00
Adrian Greeve
408dd99ac2 MDL-59081 mod_lesson: Update to Numerical question type
The numerical question type now has way to capture all
other answers.
2019-03-29 14:14:01 +08:00
Adrian Greeve
568ef8bb05 MDL-59081 mod_lesson: Add other answer options to questions
This adds another form field that will catch all other
answers made by the student.

Current question types updated are numerical and shortanswer.
2019-03-29 14:14:01 +08:00
Jun Pataleta
cd69d45d22 MDL-46975 core_auth: Make email validation case-insensitive
* Make email query case-insensitive
* Check only for duplicate emails if $CFG->allowaccountssameemail
is empty.
* Compare the values in "Email address" and "Email (again)" in the
signup form in a case-insensitive fashion.
2019-03-29 13:37:07 +08:00
Jun Pataleta
7eb5148264 MDL-46975 auth_email: Behat test for email validation on signup 2019-03-29 13:37:07 +08:00
Jun Pataleta
e9e1ecafda MDL-29318 login: Handle email in case-insensitive manner
* Let get_complete_user_data() handle the fetching of user data and
  handle the logic of the errors to be shown based on the exception
  it throws. This also saves us 1 DB query by eliminating the need to
  count for the users that match a given email first before fetching
  user information.
2019-03-29 13:31:44 +08:00
Jun Pataleta
99ead77b1c MDL-29318 login: Additional test for forgot_password_data_provider() 2019-03-29 13:31:44 +08:00
Jun Pataleta
b858b16130 MDL-29318 core: Fixes for get_complete_user_data()
* Added email in the list of case-insensitive fields.
* New optional parameter $throwexception for \get_complete_user_data().
  If true, an exception will be thrown when there's no matching record
  found or when there are multiple records found for the given field
  value. If false, it will simply return false.
  Defaults to false when not set. This ensures that
  get_complete_user_data() fetches the correct user data.
2019-03-29 13:31:44 +08:00