Commit graph

27594 commits

Author SHA1 Message Date
skodak
8b4fb44ed1 MDL-9545 minor refactoring and comment cleanup 2007-06-03 12:37:50 +00:00
skodak
1970d24381 MDL-9549 function param renamed 2007-06-03 12:34:56 +00:00
skodak
dd232d0100 MDL-9549 some more grading and rating improvements, cleanup and fixes 2007-06-03 12:22:23 +00:00
skodak
3e6303b7be MDL-9549 no rating fix 2007-06-03 11:29:38 +00:00
skodak
3460111498 MDL-9549 no grading fix 2007-06-03 10:30:23 +00:00
skodak
b01abc85e4 MDL-9549 fixed deleting of instance 2007-06-03 10:10:40 +00:00
skodak
4e9ba8c052 MDL-9549 added proper handling of magic quotes when dealing with mod_form 2007-06-03 09:56:49 +00:00
skodak
e8586b5f34 MDL-9549 minor code formatting cleanup 2007-06-03 09:27:16 +00:00
skodak
4a1be95c60 MDL-9545 minor code formatting cleanup 2007-06-03 09:26:45 +00:00
skodak
45fa341298 MDL-9545 refactoring of grading code in assignment, whitespace cleanup 2007-06-03 09:10:52 +00:00
skodak
d31bae7094 MDL-9549 added comments and fixed grade item delete 2007-06-03 09:06:58 +00:00
tjhunt
2ac5177aff MDL-10006 - Sorting the quiz overview report on feedback breaks it. Merged from MOODLE_18_STABLE. 2007-06-03 07:26:54 +00:00
skodak
e6d4504807 MDL-9549 Implement grade_updated event triggers in Glossary 2007-06-02 22:18:01 +00:00
skodak
b83ed1acb9 MDL-10010 improved data validation in glossary rate.php 2007-06-02 15:56:52 +00:00
skodak
d08e1a0b82 minor xhtml strict fix and coding style 2007-06-02 14:08:14 +00:00
skodak
63e21b9bda MDL-10009 ratings settings do not work in glossary 2007-06-02 14:03:06 +00:00
skodak
ada917d50a fixed handling of grade items when deleting assignment 2007-06-01 15:13:36 +00:00
tjhunt
699a472b5b Remove invalid unit test. 2007-06-01 13:52:36 +00:00
csantossaenz
1a3dad3484 Fixed problem with cmi.interactions.id elements' duplicated ids. 2007-06-01 12:42:36 +00:00
thepurpleblob
d022bf655e MDL-9265:
'correctanswer' field missing for true/false.
2007-06-01 08:25:18 +00:00
nicolasconnault
de5284f26d MDL-9137 Almost finished the edit category page. The only remaining issue is some sort of endless loop starting in grade_category::set_as_parent. Big issue... 2007-06-01 08:01:47 +00:00
nicolasconnault
ec4560cc58 MDL-9137 Removed hidden field from grade_categories and added deleted field to grade_items. Also added 2 images in pix/i 2007-06-01 04:46:24 +00:00
nicolasconnault
5fad506139 MDL-9629 Category edit page now implements delete, show/hide, lock/unlock, moveup/movedown and move actions. The edit icon is also shown but not yet implemented. 2007-06-01 04:02:37 +00:00
toyomoyo
83a021c10a adding some form headers to help read 2007-06-01 02:44:34 +00:00
skodak
b5ebd0962f bgufixing and external grading improvements 2007-05-31 20:34:41 +00:00
csantossaenz
3b2c6f99b6 Fixed a problem with cmi.interactions.n.objectives.n.id duplicated ids 2007-05-31 16:24:53 +00:00
toyomoyo
0afbd23c9e gradebook backup and restore fixes 2007-05-31 09:00:09 +00:00
nicolasconnault
88e794d6c8 MDL-9628 Move work on the category edit page 2007-05-31 08:57:05 +00:00
thepurpleblob
caa99ee735 Fixed typo stopping image importing working 2007-05-31 08:32:07 +00:00
nicolasconnault
0fc7f62445 MDL-9506 MDL-9137 MDL-9629
Added a number of small getters and setters to grade_item and grade_category, to hide the structural differences between the two, and provide a common interface for cases when we are not sure whether an $object is of one type or another.
The grade_tree::renumber() method now adds complete objects to the need_update array, because both grade_category and grade_item need to update their parent field when moved to a different parent. Amazingly, these important changes worked straight away (after 1 hour of coding without testing anything), and all the unit tests passed!
2007-05-31 03:15:43 +00:00
skodak
bffe39c6d5 MDL-4687 Password expiration support for AD (with patch) - patch by Iñaki Arenaza, thanks! 2007-05-30 08:54:52 +00:00
skodak
66fc70dd2e MDL-9954 LDAP auth settings form problem with 'Member Attribute' and 'Member Attribute uses dn'; patch by Iñaki Arenaza - thanks! 2007-05-30 08:49:19 +00:00
nicolasconnault
5bfa0d793a Implemented a test version of the gradebook category edit page, and developed the get_edit_tree method in grade_tree. Items can be successfully moved up and down, and a "move" button lets the user select a source element, then a destination box. All actions use POST. 2007-05-30 08:48:11 +00:00
skodak
81fb221d31 MDL-9626 Enable user signup with Active Directory (via LDAP); patch by Iñaki Arenaza - thanks! 2007-05-30 08:47:00 +00:00
toyomoyo
ca9cd23cf9 more fixes for gradebook backup/restore 2007-05-30 08:45:13 +00:00
toyomoyo
48ca6fd871 fix ordering bug when restoring grade item 2007-05-30 06:38:23 +00:00
toyomoyo
9bfd009441 added itemtype to backup/restore, only restore a mod type gradeitem if user data is included 2007-05-30 06:23:21 +00:00
nicolasconnault
c3096060de MDL-9506 Added ksort() of each level of categories and items for the gradebook. Unsorted arrays caused erratic behaviour when moving elements of the tree around. 2007-05-30 05:47:26 +00:00
toyomoyo
bb15b33bf9 respecting sortorder when restoring grade_itmes, other minor fixes 2007-05-30 05:32:47 +00:00
nicolasconnault
a3d5594248 MDL-9506 Refactored grade_tree::get_tree by doing the following:
- Extracted the $fillers array into a class variable
- Extracted the addition of elements to grade_tree::fillers into a new add_fillers($array) method
- Extracted the inclusion of fillers into the tree_array to a new include_fillers($tree, $object=NULL) method
- Removed the building of the tree_filled, which was already performed by build_tree_filled()
- Removed the generation of next_sortorder and previous_sortorder attributes, which was already performed by renumber()
Result is a much leaner and scalable set of methods, and a tighter definition of responsibilities for the varying classes. I think I have also noticed a significant inprovement in speed.
2007-05-30 03:09:38 +00:00
toyomoyo
770156e5f8 fixing a typo 2007-05-30 02:22:43 +00:00
toyomoyo
a246d4d269 during backup parent categories need to go before children 2007-05-30 02:20:56 +00:00
wildgirl
dde9f3e1a3 typo fix MDL-8093 2007-05-29 17:26:45 +00:00
thepurpleblob
2377f8dcd4 MDL-9716
'answernumbering' field now supported
2007-05-29 15:19:12 +00:00
csantossaenz
ef24d5b8fd Fixed problem with cmi.interactions.n.id duplicated ids 2007-05-29 11:22:49 +00:00
dwoolhead
6cc1a80532 MDL-9729 Ensure start of week day calculation observes user timezone setting in the same way as month start and end dates. Prevents incorrect display of dates (1 out) on main Moodle calendar display although mini calendar display is correct. (Merged from 1.8 stable branch) 2007-05-29 09:56:44 +00:00
toyomoyo
bc1637c730 restore for gradebook, needs testing for grade_history, outcomes, categories, calculations and text 2007-05-29 09:00:48 +00:00
jamiesensei
dc1f768351 reverting commit 1.889 "added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE." It turned out to be unnecessary. 2007-05-29 06:27:38 +00:00
jamiesensei
d65cb30f63 reverting last commit "added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE." It turned out to be unnecessary. 2007-05-29 06:14:09 +00:00
jamiesensei
24a905f98b fixed bug in parsing urls 2007-05-29 06:14:09 +00:00