Commit graph

91215 commits

Author SHA1 Message Date
Michael Hawkins
3b0a3604dc MDL-63498 mod_lti: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
2018-10-22 12:48:25 +02:00
Michael Hawkins
cea5338780 MDL-63495 comment: Added provider::get_users_in_context_from_sql
This issue is part of the MDL-62560 Epic.
2018-10-22 12:48:13 +02:00
Amaia Anabitarte
f765fb380a MDL-63153 admin: Adding Moodle services page to Site Administration 2018-10-22 11:08:27 +02:00
David Mudrák
aa7e539c6f MDL-62309 tool_policy: Add Behat scenarios for the optional policies 2018-10-22 08:49:36 +02:00
David Mudrák
222c378870 MDL-62309 tool_policy: Amend behaviour of handler's accept() method
When accepting the policies via the sitepolicy handler, only compulsory
policies are to be marked as accepted. Optional policies will be left as
pending. Users must express their consent explicitly for them.

As a side product of the change, unit tests are added for the whole
handler class.
2018-10-22 08:49:36 +02:00
David Mudrák
ad5e2135c5 MDL-62309 tool_policy: Improve permission evaluation methods
Please refer to the unit tests for the specification of the expected
behaviour.
2018-10-22 08:49:36 +02:00
David Mudrák
4a742e4f94 MDL-62309 tool_policy: Update user acceptances reports
This adds support for optional policies to the user acceptance reports.
Distinguished are "Pending" acceptances (we did not hear yet) from
"Declined" (user did not agree). The status workflow updated to support
new transitions: pending -> declined and declined -> accepted.
2018-10-22 08:49:36 +02:00
David Mudrák
56390aa246 MDL-62309 tool_policy: New icons for user acceptances report
There was an accessibility issue with the previous icons that we used
the same "checked" shape just in different colours for different
meanings. New icons added for the new statuses:

* partial - a warning icon for the overall status column that the user
  has only some policies accepted, not all.
* pending - that we did not hear yet from the user - whcih is different
  from a declined policy.
2018-10-22 08:49:36 +02:00
David Mudrák
5348b1eef5 MDL-62309 tool_policy: Optional policies can be declined by the user
For optional policies, we provide a radio selector to let the user
choose the acceptance status on the consent page. For policies displayed
on their own page, we display a link to decline the policy.

The way how we pass the list of policy version ids to index.php has
changed so that we can now not only pass the list of ids, but also the
actual acceptance status (accepted / declined).
2018-10-22 08:49:36 +02:00
David Mudrák
faf4222edc MDL-62309 tool_policy: Add api::get_agreement_optional() method
This method allows to quickly check if the given policy version is
marked as optional or compulsory. This will be needed in other places
such as permissions check.
2018-10-22 08:49:36 +02:00
David Mudrák
1617fde9a8 MDL-62309 tool_policy: New API method to decline a policy
Policy can be declined. Optional policies do not need to be accepted to
use the site. But we still want to hear explicitly from the user.
2018-10-22 08:49:36 +02:00
David Mudrák
f98cd91a13 MDL-62309 tool_policy: Improve api::is_user_version_accepted() return
The method now returns three-state logic. A bool value true/false is
returned if the user has accepted/rejected the policy, respectively. A
null value is returned if the user did not express their agreement in
either way yet.

This allows to distinguish between "rejected the policy" and "did not
say anything about it yet" cases.
2018-10-22 08:49:36 +02:00
David Mudrák
9011d394ab MDL-62309 tool_policy: Add new field to hold the optional policy flag
The patch adds a new column to the database table to hold the
information if giving agreement to the policy is compulsory or optional.
The flag can be defined via the policy editing form and is displayed at
the policies management screen.

The last modified time merged with the version column at the policies
management screen to save a bit of horizontal space - needed as we
display more information now at the first column.
2018-10-22 08:49:36 +02:00
Jun Pataleta
53f14eef37 Merge branch 'MDL-62777-master' of git://github.com/junpataleta/moodle 2018-10-22 12:26:14 +08:00
Jun Pataleta
0aacc90bbe MDL-62777 administration: Remove unnecessary whitespace 2018-10-22 12:24:58 +08:00
Damyon Wiese
efacf3a099 MDL-61052 assign: Do not queue conversions
Identical submissions do not require individual conversions from the document converter. Text passing through
format_text cannot be trusted and is likely to be unique each time, even for the same text.
2018-10-22 11:56:57 +08:00
Zig Tan
888d7b585f MDL-61052 assign: Improve strip_images() to avoid HTML5 tags errors 2018-10-22 11:56:33 +08:00
Matt Porritt
d5adb60fa3 MDL-62777 Administration: CLI upgrade new setting notification
During a CLI upgrade when there are new settings in core or in
a plugin, the settings are set to the defined defaults
automatically. There is no ouput shown on the CLI about which
new settings have been introduced or what default values the
setting are set to.

This patch outputs the name of the new setting and what the
default value being is set is to the CLI during an upgrade.
Objects and arrays are expanded into a human readable format.
This plugin also makes the function that sets the defaults to
be more robust so it isno longer required to be called multiple
times to ensure all settings are set.
2018-10-22 14:28:06 +11:00
Damyon Wiese
805f078b19 MDL-62145 theme_boost: Custom menu fixes
Make sure the site navigation element is labelled, actionmenu items
have correct role and actionmenu trigger controls the menu.
2018-10-22 10:57:50 +08:00
Damyon Wiese
934ee47b0d MDL-61391 forum: Improve semantics for permalinks
Replace the anchor tags in forum posts containing the postid but no href with
an id on the element containing the post. Use rel="bookmark" for perma links
and update the styling so they look visually the same.
2018-10-22 10:55:32 +08:00
Andrew Nicols
9c6ccfd93b Merge branch 'MDL-63213-master-2' of https://github.com/snake/moodle 2018-10-22 10:54:56 +08:00
Damyon Wiese
ede1e4a186 MDL-61388 output: Use alertdialog role for confirm 2018-10-22 10:53:32 +08:00
Damyon Wiese
9f83272207 MDL-61388 forum: accessibility
Show success alert to confirm the last action.
2018-10-22 10:53:32 +08:00
Damyon Wiese
addb26acbb MDL-61388 boost: accessibility
Dynamically show and focus on an alert that was written on page load. This ensures JAWS will read it
as soon as the page is ready, otherwise JAWS would choose to ignore it as per

https://www.w3.org/TR/wai-aria-practices/#alert.
2018-10-22 10:53:31 +08:00
Andrew Nicols
7b73fd183c Merge branch 'MDL-63691_master' of git://github.com/markn86/moodle 2018-10-22 10:52:13 +08:00
Damyon Wiese
a986cb4ba1 MDL-62144 user menu: Accessibility
Ensure user menu passes the accessibility tests.
2018-10-22 10:42:28 +08:00
Damyon Wiese
191a1c7c23 MDL-62139 output: Accessible action menus
Add label on the "gear" menu and default keyboard and focus controls.
2018-10-22 10:35:21 +08:00
Mark Nelson
d9a25f397d MDL-63408 core_message: removed usage of deprecated method in tests
Also, added tests to ensure exception is thrown if you try to
add or remove members to/from an individual conversation.
2018-10-22 10:26:37 +08:00
Mark Nelson
cbf9e41c2d MDL-63408 core_message: remove no longer needed code
We only allow the functionality of adding/removing
members on group conversations, which will never have
a conversation hash.
2018-10-22 10:26:30 +08:00
Mark Nelson
83e3a4fe26 MDL-63408 core_message: add check to ensure it is a group conversation 2018-10-22 10:26:21 +08:00
Amaia Anabitarte
623048af81 MDL-63408 core_message: New functions to manage conversation members
New functions created to add, remove and count conversation members
2018-10-22 10:26:10 +08:00
Mark Nelson
f2ac0a3e5b MDL-63691 core_message: added api::create_conversation 2018-10-22 10:21:28 +08:00
Mark Nelson
e66b915c40 MDL-63691 core_message: added api::can_create_group_conversation 2018-10-22 10:21:27 +08:00
Mark Nelson
a66ae84911 MDL-63691 core_message: deprecate create_conversation_between_users 2018-10-22 10:21:27 +08:00
Mark Nelson
59f98779fb MDL-63691 core: added capability for creating group conversations 2018-10-22 10:21:27 +08:00
Jake Dallimore
5b367baef8 MDL-63213 core_message: add web services for set/unset favourites 2018-10-22 09:56:06 +08:00
Amaia Anabitarte
e2a687f689 MDL-63691 core: Column 'convhash' now accepts null
Index 'convhash' also changed to non-unique.
2018-10-22 09:47:19 +08:00
Jake Dallimore
b8ff2c4481 MDL-63213 core_message: update get_conversations to support favourites
Added the type param here, which will be used in MDL-63549.
2018-10-22 09:43:33 +08:00
Andrew Nicols
c3918bfee9 MDL-63289 message: Remove unused global 2018-10-22 08:31:04 +08:00
Andrew Nicols
d139f45a0a Merge branch 'MDL-63289-master' of git://github.com/sarjona/moodle 2018-10-22 08:19:59 +08:00
AMOS bot
f7704b703b Automatically generated installer lang files 2018-10-22 00:07:13 +00:00
Bas Brands
3cfff88516 MDL-63058 block_myoverview: starring and storing preferences 2018-10-20 17:53:35 +02:00
Tim Hunt
b51f4f2ece MDL-63277 qtype_ddwtos: removed unneeded qtype_classname method 2018-10-20 15:25:04 +01:00
Tim Hunt
c28d0aa113 MDL-63277 qtype_ddwtos: further improvements to the JavaScript 2018-10-20 15:24:49 +01:00
M Kassaei
68943aff09 MDL-63277 qtype_ddwtos: Re-implement old YUI JS in AMD
In the rewrite is one improvement: drag items now animate when they
are moved, for example out of a drop place and back home. Other than
that, the functionality is unchanged. Also, as far as possible, the
HTML structure has not been changed (althought with changes to the HTML,
further JS improvements would be possible. However, those have been left
for a future issue).
2018-10-20 15:22:12 +01:00
Tim Hunt
ed7e30fa5c MDL-62411 qtype_ddmarker: further improvements following code review 2018-10-20 15:18:17 +01:00
John Beedell
5d4b342107 MDL-62411 qtype_ddmarker: graphical editing of drop zones
Also, all the JavaScript in this plugin has been updated from YUI to
jQuery.
2018-10-20 15:15:28 +01:00
John Beedell
0b1cc2890f MDL-62411 qtype_ddmarker: add dragdrop helper libarary
This was created by the Open University a couple of years ago, and is
very helpful for making dragging work reliably on a range of browsers
and with both mouse and touch-screens.

Sadly, HTML5 drag-drop is not yet ready for prime-time.
2018-10-20 15:15:23 +01:00
Jake Dallimore
b81722e22f MDL-63058 core_favourites: add existence checks to the service layer
This allows someone using the user_favourite_service to check whether
an item is already marked as a favourite.
2018-10-20 12:19:10 +02:00
Sara Arjona
e5eba802d5 MDL-63289 message: Deprecate is_user_non_contact_blocked method
This function has been deprecated and no other function has been
added to replace it. It was only called from can_post_message, so
its code has been moved there.
2018-10-20 08:36:24 +02:00