jamiesensei
0e13019dc4
MDL-16870 "ID is incorrectly labelled"
2008-10-14 15:19:25 +00:00
jamiesensei
ef27e74273
MDL-16869 "Exporting leaves <p> </p> in essay responses" added method to flexible_table class format_text that takes the same parameters as format_text the function in weblib. If the table is not in download mode then this formats the text as html. If it is then it strips the tags or does the right thing depending on the download type. Added methods to download classes to tell flexible_table class what should be done with html.
2008-10-14 15:00:26 +00:00
jamiesensei
1f23bda7f9
MDL-16803 "Questions with score of 0 lead to division by zero warning"
2008-10-07 08:46:24 +00:00
tjhunt
2930500104
MDL-16706 - eliminate miscellaneous inine JavaScript
...
This does the quiz (apart from the bloody 'secure' window), the question bank and a couple of others.
2008-09-26 10:49:31 +00:00
tjhunt
2ddba27f0a
Correct comment.
2008-09-26 05:57:55 +00:00
tjhunt
16851b22ad
MDL-16676 All references to the text.html and emoticons.html files need to be updated to point to text2.html and emoticons2.html
2008-09-25 10:04:01 +00:00
dongsheng
a6344df49a
"MDL-14129, fixed hardcoded print_header in quiz module"
2008-09-25 08:21:59 +00:00
tjhunt
ac324e05ea
MDL-16675 change callers to require_js to take advantage of the fact that callers no longer have to add $CFG->wwwroot themselves.
2008-09-25 06:40:52 +00:00
dongsheng
85c30b9c91
"MDL-14129, fix hardcoded print_error"
2008-09-25 01:55:39 +00:00
jamiesensei
8cc901371a
MDL-16612 "Response report : Long group names need shortening"
2008-09-24 10:55:55 +00:00
jamiesensei
04299b1f19
MDL-16632 "green highlighting should not be applied to grading method in quiz responses report form" Ooops. We do need highlighting on the reponses report. The responses page does have a grade displayed that needs highlighting. I was looking at an ungraded quiz. Need highlighting to highlight grade of graded attempt.
...
Reverted earlier patch and instead using a different colour for highlighting graded grade. Now using light yellow with a darker yellow border instead of green which is used in reports to highlight the correct answer.
2008-09-24 10:45:05 +00:00
jamiesensei
8968f51fab
MDL-16610 "Warnings when a question has a grade of 0" not seeing this issue in HEAD but committing some code to make code for generating html for response cell more robust.
2008-09-24 10:43:45 +00:00
jamiesensei
1c88737ffa
MDL-16653 "Adding colour highlighting of correct / incorrect / partially correct answers and tick / cross marks to overview report"
2008-09-24 10:22:57 +00:00
jamiesensei
bfcaf5e684
MDL-16632 "green highlighting should not be applied to grading method in quiz responses report form" Ooops. We do need highlighting on the reponses report. The responses page does have a grade displayed that needs highlighting. I was looking at an ungraded quiz. Need highlighting to highlight grade of graded attempt.
...
Reverted earlier patch and instead using a different colour for highlighting graded grade. Now using light yellow with a darker yellow border instead of green which is used in reports to highlight the correct answer.
2008-09-24 09:10:43 +00:00
jamiesensei
14133ad913
MDL-16632 "green highlighting should not be applied to grading method in quiz responses report form"
2008-09-23 10:39:12 +00:00
jamiesensei
e84cb61554
MDL-16532 "Can width of column for Essay questions be varied?" Concatenate the answers displayed in all responses in responses report for answers above a certain character count (now set to 150). Also added a link to all responses to display a review of the question response. Both the concatenation and links are only showed in the report on the Moodle site and effects are not exported.
2008-09-23 10:21:32 +00:00
jamiesensei
8b92c1e3f6
MDL-16529 "Only include closed attempts in manual grade counts"
2008-09-23 09:52:55 +00:00
tjhunt
739b07112e
MDL-16625 Detection of whether a quiz has grades was broken in HEAD.
...
1. Fix this by factoring out a quiz_has_grades function.
2. Fix the quiz unit tests.
3. Fix quiz_has_feedback to return false for ungraded quizzes.
4. Fix use of get_records to do record_exists in quiz reports.
2008-09-23 07:18:15 +00:00
jamiesensei
e1d2278b51
MDL-16527 "responses report : use question_get_feedback_class and question_get_feedback_image from questionlib.php instead of custom styles" should not style response or add feedback image if the response is not yet graded.
2008-09-22 09:20:13 +00:00
jamiesensei
452351550b
MDL-16567 "Quiz statistics report does not work when the quiz contains descriptions" slightly more elegant and efficient solution to issue.
2008-09-19 10:12:54 +00:00
tjhunt
ea16a91d2e
MDL-12391 Prevent browser autocomplete in the quiz. Acutally, there was already code trying to do that, but it was not working. Fix it in HEAD only, because it is not a big deal, and so much has changed, it is not an easy back-port.
2008-09-19 04:54:49 +00:00
tjhunt
ddf977898c
Clean up code in a couple of places by using my print_js_call function.
2008-09-19 04:53:03 +00:00
tjhunt
a1f6db1775
Nasty hack fix for MDL-16567 - I am hoping Jamie will come up with a proper fix soon, but I am about to demo this.
2008-09-18 12:47:12 +00:00
tjhunt
7fb0303d89
MDL-16564 Make admin settings work better with the cnfig_plugins table.
...
Also, take the opportunity to take the quiz-specific stuff out of adminlib.php, to make Petr happy.
2008-09-18 09:55:04 +00:00
tjhunt
766df8f72b
MDL-16334 Convert mod/quiz/comment.php to use attemptlib.php - final part of the work on the quiz navigtion, I hope.
...
MDL-16559 Remove question/comment.html template, and instead just have a function in questionlib.php
MDL-16562 Regression from MDL-16263, notices when regrading.
Sorry, the three got tangled together (coupled through questionlib) while I was fixing bugs in preparation for a demo.
2008-09-18 07:39:10 +00:00
tjhunt
8033d8423f
Minor bug fixes.
2008-09-18 04:33:38 +00:00
tjhunt
1aea04dcbf
MDL-15452 quiz navigation - followup - avoid a division by 0.
2008-09-18 04:31:11 +00:00
tjhunt
98e82289b3
MDL-16505 - Removing qtype_datasetdependent questiontype - finish off the database upgrade, after Pierre's previous work.
2008-09-17 05:24:29 +00:00
nicolasconnault
b9c639d6c2
MDL-16483 Refactored install/upgrade code into lib/adminlib. Created an intermediate MoodleUnitTestCase class that overrides simpletest's constructor, destructor and setup/teardown methods. All moodle unit tests must extend this class.
2008-09-16 12:19:43 +00:00
jamiesensei
74b40fadd5
MDL-16527 "responses report : use question_get_feedback_class and question_get_feedback_image from questionlib.php instead of custom styles" better not make styles dependent on question type. Just use overall styles.
2008-09-16 10:30:06 +00:00
jamiesensei
2ea2c1f57a
MDL-16528 "responses report : improve efficiency of sql" moved the querying for state data all into one big query rather than an individual query for each question in each attempt.
2008-09-16 09:50:24 +00:00
jamiesensei
199b946f04
MDL-16527 "responses report : use question_get_feedback_class and question_get_feedback_image from questionlib.php instead of custom styles"
2008-09-16 09:46:57 +00:00
jamiesensei
3d6de8770d
MDL-16362 "Quiz - bar graph on results screen" removing var_dump that I forgot to clean up.
2008-09-15 14:08:11 +00:00
jamiesensei
2a1995a476
MDL-16362 "Quiz - bar graph on results screen" there was a bug in my code that would put the graph generation code into an infinite loop if the overall grade for the quiz is 0. Since the change in the type of the field for quiz->grade the old test for quiz->grade being zero doesn't work. Using $quiz->grade as a bool does not work ($quiz->grade is now a string 0.0000), since Moodle 2.0 need to use $quiz->grade == 0.
2008-09-15 13:38:31 +00:00
jamiesensei
3b51802063
MDL-16125 "Improvement to Detailled Responses Report : Format of csv export" Fixed missing format string problem when downloading.
2008-09-15 11:39:15 +00:00
jamiesensei
d3e99e85d4
MDL-16502 "highlight questions that appear not to be working very well according to statistics"
...
There is a function is_dubious_question on the statistics table passed all the stats for that question and other question data and that returns a bool.
2008-09-15 11:13:31 +00:00
jamiesensei
3db543284b
MDL-16501 "moving key to colours on graph to the bottom of the graph gives more horizontal screen space for the graph itself"
2008-09-15 09:16:57 +00:00
tjhunt
4906997bbb
MDL-16492: the fix for MDL-16411 broke the fix for MDL-16200. Fix it.
2008-09-15 04:20:23 +00:00
jamiesensei
9176976151
MDL-16463 "Long group names can make drop down box too wide" added an if condition to test the length of the group name. If it is more than 20 characters then we use the string 'this group' instead of the group name.
2008-09-12 08:33:40 +00:00
jamiesensei
c308138f89
MDL-14202 "Replace Item Analysis Report with new improved 'Statistics' report." Removing Quiz Item Analysis report
2008-09-11 12:59:33 +00:00
jamiesensei
869309b8d8
MDL-14202 "Replace Item Analysis Report with new improved 'Statistics' report." finished statistics report. This patch includes some changes to lib/tablelib.php so that it is possible to export the content of a table as part of a multi table export - with mutliple tables / multiple worksheets.
2008-09-11 12:48:08 +00:00
tjhunt
ad4cd8374a
Improve comment.
2008-09-11 10:37:50 +00:00
tjhunt
5f9c912241
MDL-16447 move quiz-specific pictures out of theme/standard/pix/
2008-09-11 07:34:51 +00:00
tjhunt
dee2bdc010
MDL-16449 error unexpected event exception in essay question
2008-09-11 03:57:28 +00:00
tjhunt
cca6e300e7
Refactor getting question bank capabilties in mod/quiz/lib.php - don't hard code them.
...
Also, functions for getting a URL for editing questions in a particular context, ready for MDL-16409.
2008-09-10 05:28:25 +00:00
jamiesensei
c8b2ab1b00
MDL-7308 "Check all the DB columns used to store grades, and make sure they all use a consistent type." Since quiz->sumgrades is now string "0.00000" (quiz->sumgrades) no longer evaluates as false. Changing to (quiz->sumgrades != 0)
2008-09-08 10:35:14 +00:00
tjhunt
316defd2d3
MDL-3633 Further refinement.
2008-09-04 09:27:19 +00:00
tjhunt
152d3c0242
MDL-3633 Don't show the attempt number column on the quiz view page if the quiz only allows one attempt.
2008-09-04 09:22:37 +00:00
tjhunt
40d1feeb49
MDL-15540 Navigation panel did not work on the review page for multi-page quizzes because of the way states were loaded. Fix the regressions caused by the previous refactor.
2008-09-04 07:05:14 +00:00
tjhunt
81d833adaa
MDL-15540 Navigation panel did not work on the review page for multi-page quizzes because of the way states were loaded. Refactor.
2008-09-04 06:37:43 +00:00
