Commit graph

20785 commits

Author SHA1 Message Date
Christian Lawson-Perfect
7dcbe6a983 MDL-61355 SCORM: fix correct_response prefix check
The regexes to detect the optional prefixes at the start of some
interaction types are constructed to optionally match the prefix, so we
need to ensure that the matched group is really there when trying to
strip it from the given value in CRCheckValueNodes.

also remove "check for prefix" from CRcheckValueNodes

prefixes on correct responses patterns are removed in the section above
by CRremovePrefixes, so this block was redundant.
The `.pre` property for each correct_response is not used anywhere
else, so this removes their definitions too.
2018-07-12 10:44:30 +12:00
David Monllao
2a021ac3a0 Merge branch 'MDL-62618-master' of git://github.com/mickhawkins/moodle 2018-07-11 18:47:57 +02:00
David Monllao
76dbb5884d Merge branch 'MDL-62262-master' of https://github.com/lucaboesch/moodle 2018-07-10 13:30:17 +02:00
David Monllao
58b987282e Merge branch 'MDL-42818-master' of git://github.com/zig-moodle/moodle 2018-07-10 11:31:24 +02:00
David Monllao
cbc67cba73 Merge branch 'MDL-62533-master' of git://github.com/zig-moodle/moodle 2018-07-10 07:37:19 +02:00
Jake Dallimore
793fe5fc4c Merge branch 'MDL-62772-master_always_show_disclosure' of https://github.com/jmcgettrick/moodle 2018-07-10 08:59:34 +08:00
David Monllao
6ce50554ee Merge branch 'MDL-56881-master' of https://github.com/snake/moodle 2018-07-09 14:38:19 +02:00
David Monllao
381bb72153 Merge branch 'MDL-62831-master' of git://github.com/damyon/moodle 2018-07-09 13:36:05 +02:00
John McGettrick
9481cc0e06 MDL-62772 mod_assign: Show disclosure for all submitters 2018-07-09 09:26:38 +01:00
Jake Dallimore
5a8791336a MDL-56881 mod_choice: add unit tests for choice_user_submit_response
Tests cover option limits and multiple option responses.
2018-07-09 11:02:50 +08:00
Jake Dallimore
03577962ef MDL-56881 mod_choice: clarify lang string for limit-reached scenarios 2018-07-09 11:02:50 +08:00
Jake Dallimore
a039751aee MDL-56881 mod_choice: fix bug with limits when saving existing choice
The check determining whether a choice option's limit was exceeded was
including the user's existing answers in its checks, meaning a user
couldn't save an existing choice answer, or select further options,
if all a choice option limit was reached. This patch fixes that.
2018-07-09 11:02:45 +08:00
Luca Bösch
4a73ecc654 MDL-62262 quiz: quiz index page showing wrong dates. 2018-07-06 14:37:07 +02:00
John McGettrick
707dfd0c39 MDL-62771 mod_forum: Reformat for modern coding style 2018-07-06 09:32:14 +01:00
John McGettrick
f3bf0ed5fc MDL-62771 mod_forum: Fix to move print_disclosure 2018-07-06 09:30:34 +01:00
Michael Hawkins
26cee43786 MDL-62618 forum: Made full names displayed consistent 2018-07-05 10:03:18 +08:00
Tim Hunt
0b18d0c960 MDL-62820 question import: properly escape output 2018-07-04 15:40:50 +08:00
Damyon Wiese
166fa40a98 MDL-62782 assign: viewgrades allows files
Grade viewer role should be able to see feedback files for an assignment submission.
2018-07-04 14:17:28 +08:00
Damyon Wiese
e655cbb857 MDL-62831 mod_assign: Download as folders help
The help string for the download as folders setting should not mention the number of files
submitted by the student. It is not related to that, it is only dependant on the value of this setting.
2018-07-04 12:20:24 +08:00
Jake Dallimore
bbaab1bae7 Merge branch 'MDL-44081-master' of git://github.com/zig-moodle/moodle 2018-07-04 10:50:25 +08:00
Eloy Lafuente (stronk7)
a101b25863 Merge branch 'MDL-62288_master' of https://bitbucket.org/ujiapps/moodle-uji 2018-07-04 01:20:08 +02:00
Eloy Lafuente (stronk7)
7fb95a9d2d Merge branch 'MDL-62834' of git://github.com/timhunt/moodle 2018-07-04 00:46:33 +02:00
David Monllao
2af5c8e7ef Merge branch 'MDL-60014-master-catcherror-nopermission-annotatepdfcron' of https://github.com/Eva-Dv/moodle 2018-07-03 23:33:01 +02:00
David Monllao
772ae9d4fd Merge branch 'MDL-62691-master' of git://github.com/bmbrands/moodle 2018-07-03 23:33:00 +02:00
David Monllao
3a0e92cd6a Merge branch 'MDL-32232-master' of https://github.com/lucaboesch/moodle 2018-07-03 13:59:57 +02:00
Jake Dallimore
25a592ff5f Merge branch 'MDL-62715-master' of git://github.com/andrewnicols/moodle 2018-07-03 08:49:35 +08:00
Helen Foster
9722f6a25e MDL-62763 lang: Merge English strings from the en_fix language pack
Significant string changes:

* various strings in tool_dataprivacy and tool_policy - 'Data Protection
  Officer' changed to 'privacy officer'
* idnumbermod_help,core - mentioning resource and custom reporting
2018-07-02 11:15:26 +02:00
Tim Hunt
8aedf6d478 MDL-62834 behat: new step for enabling filters 2018-06-29 11:26:41 +01:00
Zig Tan
a8f7818beb MDL-62533 assign: Show assign hidden status on grading summary page 2018-06-29 09:37:57 +08:00
Zig Tan
bc87f6a2e3 MDL-44081 assign: Fix Grader annotation button accessibility ordering 2018-06-29 09:26:58 +08:00
Luca Bösch
73e571aae1 MDL-32232 lesson: changing a page type chooser option for consistency 2018-06-28 23:06:34 +02:00
Eloy Lafuente (stronk7)
b66476d15d Merge branch 'wip-MDL-62755-master' of git://github.com/abgreeve/moodle 2018-06-28 01:55:53 +02:00
Eloy Lafuente (stronk7)
e872f93325 Merge branch 'MDL-41265-master' of git://github.com/mihailges/moodle 2018-06-27 03:06:47 +02:00
Juan Segarra Montesinos
77e17113a1 MDL-62288 mod_glossary: Add links to glossary entries for all users 2018-06-26 09:03:10 +02:00
Eva Davitasvili
88c77c8ea3 MDL-60014 assign: Annotate PDF - catch no permission error 2018-06-25 14:11:24 -04:00
Adrian Greeve
11d828ef6f MDL-62755 mod_assign: Update to unit tests.
Overrides are now checked to be exported properly.
2018-06-25 09:49:13 +08:00
Adrian Greeve
ea24047619 MDL-62755 mod_assign: Fix override export problem.
The cutoffdate and allowsubmissionsfromdate were not
being exported.
2018-06-25 09:49:13 +08:00
Mihail Geshoski
f721ac68d4 MDL-41265 resource: Page resource option to show/hide last modified 2018-06-25 09:13:04 +08:00
Tim Hunt
bc6687bab3 MDL-62698 quiz_overview: new index should not be unique 2018-06-22 13:32:04 +01:00
Tim Hunt
db421d4d52 MDL-62769 quiz statistics: graph should show all, not last, variant 2018-06-21 12:55:43 +01:00
Andrew Nicols
de06b63344 MDL-62715 mod_assign: Bump submissions back when grading in tests 2018-06-21 08:40:39 +08:00
David Monllao
62dc3fde0a Merge branch 'MDL-61482-master' of git://github.com/zig-moodle/moodle 2018-06-20 13:29:17 +02:00
Eloy Lafuente (stronk7)
61a9f8d147 Merge branch 'MDL-36424-master' of https://github.com/lucaboesch/moodle 2018-06-19 19:19:59 +02:00
Eloy Lafuente (stronk7)
3a55517a53 Merge branch 'MDL-62449-master' of git://github.com/sarjona/moodle 2018-06-19 18:18:51 +02:00
Zig Tan
8be71d396b MDL-61482 mod_assign: Clean html in offline grading CSV 2018-06-19 23:19:13 +08:00
Bas Brands
c8c595e6d0 MDL-62691 Theme boost: editpdf hide dropdown close btn 2018-06-19 16:57:10 +02:00
Zig Tan
fcb7d2a976 MDL-42818 assign: Add grading UI indicator about followup submission 2018-06-19 14:06:17 +08:00
Andrew Nicols
67196d5080 Merge branch 'MDL-60950-master' of git://github.com/damyon/moodle 2018-06-19 11:36:59 +08:00
Damyon Wiese
994d0da35e MDL-60950 assign: Update incompatible unit test
Maintain compatibility with unit test changes after MDL-55609.
2018-06-19 10:56:53 +08:00
Damyon Wiese
c957707106 MDL-60950 assign: Rename class
testable_assign was renamed to mod_assign_testable_assign
2018-06-19 10:53:51 +08:00