Commit graph

23989 commits

Author SHA1 Message Date
hieuvu
5cfaa18cad MDL-74533 core_completion: Update using new grade pass for completion 2022-05-23 15:14:12 +07:00
Jun Pataleta
60fcabfa6d MDL-73386 mod_quiz: Use plain text for quiz navigation fake block title
* No need to enclose the title of the quiz navigation fake block in
a span tag. The block title also gets appended to the skip link which
means that a block title with a span tag assigned with an identifier
can cause duplicate ID errors on the DOM.
2022-05-21 00:32:38 +08:00
Laurent David
bad2e0bb54 MDL-73225 mod_bigbluebuttonbn: Improve error message when joining
Display more friendly messages when:
    * When displaying activity and the server is not available
    * When we join a meeting and the server is not available or an error is detected
2022-05-20 13:07:14 +02:00
Dan Marsden
b95d2b94a5 MDL-74785 mod_scorm: Add scorm content filearea to global search. 2022-05-18 19:47:44 +12:00
Jun Pataleta
eae7ec37ca Merge branch 'MDL-74413' of https://github.com/stronk7/moodle 2022-05-12 12:09:05 +08:00
Shamiso.Jaravaza
41f40c7d7a MDL-74726 mod_bigbluebuttonbn: Fix muteonstart
Added missing muteonstart_editable in mod_form  block condition
2022-05-11 08:29:16 -06:00
Jun Pataleta
817db2b7f3 Merge branch 'MDL-74041' of https://github.com/timhunt/moodle 2022-05-10 17:59:45 +08:00
Ilya Tregubov
8de866dc3f MDL-74710 mod_bigbluebuttonbn: Fix settings url. 2022-05-10 11:11:51 +06:00
Eloy Lafuente (stronk7)
caf55abf17 MDL-74413 phpunit: Move more tests to use correct names and namespaces
Applied the following changes to various testcase classes:

- Namespaced with component[\level2-API]
- Moved to level2-API subdirectory when required.
- Fixed incorrect use statements with leading backslash.
- Remove file phpdoc block
- Remove MOODLE_INTERNAL if not needed.
- Changed code to point to global scope when needed.
- Fix some relative paths and comments here and there.
- All them passing individually.
- Complete runs passing too.

Special mention to:

- Moved to the level2 "privacy" namespace:
  - \mod_assign\privacy\feedback_legacy_polyfill_test
  - \mod_assign\privacy\submission_legacy_polyfill_test

- Moved to the level2 "task" namespace:
  - \core_message\task\migrate_message_data_test
  - \ltiservice_gradebookservices\task\cleanup_test
  - \message_email\task\send_email_test
  - \mod_lti\task\clean_access_tokens_test
  - \mod_workshop\task\cron_task_test

- Moved to the level2 "event" namespace:
  - \core_h5p\event\deleted_test
  - \core_h5p\event\viewed_test

- Renamed to a better name:
  - backup_forum_activity_task_test.php (missing "task")
2022-05-07 20:32:30 +02:00
Jake Dallimore
d84738eb08 MDL-74602 mod_assign: fix js error with assign grader on classic 2022-05-06 16:46:58 +08:00
Jun Pataleta
48cab7f948 Merge branch 'MDL-74584-master-v1' of https://github.com/mihailges/moodle 2022-05-06 14:47:04 +08:00
Mihail Geshoski
154dbce845 MDL-74584 mod_bigbluebuttonbn: Update behat tests 2022-05-06 14:39:06 +08:00
Mihail Geshoski
75d9476420 MDL-74584 mod_bigbluebuttonbn: Update unit tests 2022-05-06 14:39:06 +08:00
Mihail Geshoski
c23b67be46 MDL-74584 mod_bigbluebuttonbn: Add install script and new upgrade step
Adds a new install script for the BBB module and a new upgrade step.
The BBB module now will be disabled by default for new installations
and also it will be disabled for the existing sites that use the
default BBB server configuration. Admistrators will be required to
confirm the acceptance of the related DPA prior to (re)enabling the
plugin once again.
2022-05-06 14:39:06 +08:00
Mihail Geshoski
b9b9ec82d4 MDL-74584 mod_bigbluebuttonbn: Add DPA info in the general setting page
Adds a note in the BBB general settings page to raise awareness about
the legal obligations related to the data processing agreement with the
service provider which is currently configured.
2022-05-06 13:36:53 +08:00
Mihail Geshoski
6588baec97 MDL-74584 mod_bigbluebuttonbn: Implement 'pre_enable_plugin_actions'
Implements a function for the 'pre_enable_plugin_actions' callback.
When the default BBB server settings are used while the administrator
attempts to enable the BBB plugin, the function will prevent this
action and trigger a dynamic form requesting the admin to conifrm
their acceptance of the related data processing agreement. The process
of enabling the plugin will continue as usual in cases where the
admin has already confirmed the acceptance of the dpa or a different
BBB server configuration is used other than the default.
2022-05-06 13:36:53 +08:00
Ilya Tregubov
93e96e0aa2 Merge branch 'MDL-74602-master' of https://github.com/snake/moodle 2022-05-05 07:46:33 +06:00
Tim Hunt
aac5b47cea MDL-74041 quiz: use own size for paging the question bank 2022-05-04 11:01:44 +01:00
Paul Holden
6abe964bba MDL-74204 mod_assign: escape identity fields in allocate marker form. 2022-05-04 04:04:15 +02:00
Leon Stringer
b460ea470f MDL-74631 mod_lti: Remove </img>
Remove illegal HTML tag.

Added example context to pass CI checks.
2022-05-03 17:27:13 +01:00
Jun Pataleta
b625dabb83 Merge branch 'MDL-74543' of https://github.com/timhunt/moodle 2022-05-03 22:22:39 +08:00
Tim Hunt
7d3eaf892d MDL-74543 quiz attemptlib: covert string comparison to ===
Where obviously safe.
2022-05-03 13:45:39 +01:00
Tim Hunt
52b8962dbd MDL-74543 quiz: correctly record time when overdue attempt submitted 2022-05-03 13:41:45 +01:00
Jake Dallimore
9e70147e05 Merge branch 'MDL-74441-master' of https://github.com/cameron1729/moodle 2022-05-03 16:54:35 +08:00
Jake Dallimore
db933339fa MDL-74602 mod_wiki: disable activity header in wiki print view 2022-05-03 09:58:01 +08:00
Jake Dallimore
a8fcf50e55 MDL-74602 mod_chat: disable activity header in ajax chat interface 2022-05-03 09:57:19 +08:00
Jake Dallimore
edf2c5ea2f MDL-74602 mod_book: disable activity header on book print page 2022-05-03 09:56:56 +08:00
Jake Dallimore
0402dfdc95 MDL-74602 mod_assign: disable activity header on embedded grader page 2022-05-03 09:55:22 +08:00
Marina Glancy
ac7c952b84 MDL-73435 mod_wiki: htmlspecialchars changed default in PHP8.1 2022-04-29 16:22:43 +02:00
Marina Glancy
a0398fdde8 MDL-73423 core_privacy: Calling reset() on objects deprecated PHP8.1 2022-04-29 16:16:07 +02:00
Cameron Ball
34c3392f49 MDL-74441 mod_forum: Fix overflow in unified grader 2022-04-28 15:55:18 +08:00
Jun Pataleta
c0466920b3 Merge branch 'MDL-74537-master-enfix' of https://github.com/vmdef/moodle 2022-04-27 15:56:00 +06:00
Ilya Tregubov
af8155036f Merge branch 'MDL-74510' of https://github.com/stronk7/moodle 2022-04-27 15:56:00 +06:00
Víctor Déniz
57b300e27f Merge branch 'MDL-74320' of https://github.com/stronk7/moodle 2022-04-27 15:56:00 +06:00
Víctor Déniz
b7a06ebb68 Merge branch 'MDL-74514' of https://github.com/call-learning/moodle 2022-04-27 15:56:00 +06:00
Ilya Tregubov
03c237525c Merge branch 'MDL-74481-LTI13-InstructorRole' of https://github.com/cengage/moodle 2022-04-27 15:56:00 +06:00
Helen Foster
a1699a58f4 MDL-74537 lang: Import fixed English strings (en_fix) 2022-04-26 11:21:12 +01:00
Eloy Lafuente (stronk7)
76f5445451 MDL-74510 upgrade: add the 4.0.0 separation line to all upgrade scripts 2022-04-22 18:45:10 +02:00
Eloy Lafuente (stronk7)
b952441d22 MDL-74320 lesson: Remove tested elsewhere parts of the scenario
The scenario has not only grades related completion conditions
but also timing conditions or reach the end conditions that
shouldn't be tested by a grades feature.

More yet, those completion conditions are already tested by
other feature files, namely:
- reach the end: completion_condition_end_reached.feature
- visit and timing: lesson_activity_completion.feature

So we have removed all those parts that are being tested
by other features.

Specially the visit and timing ones, because they lead to
random failures in slow environments and they have been
fixed in the lesson_activity_completion.feature scenarios
by MDL-72698.
2022-04-22 18:45:00 +02:00
Laurent David
7c0b2d4f90 MDL-74514 mod_bigbluebuttonbn: BBB server is polled too often
* Fix issue with the roomupdater that should not force the updatecache flag
for get_meeting_info API
* Fix issue when meeting is not started (and does not exist) and bigbluebutton_proxy::get_meeting_info
throws an exception, skipping the cache and then polling the server every second.
2022-04-21 20:22:16 +02:00
Ilya Tregubov
5c3563e3a2 Merge branch 'MDL-74064-master' of https://github.com/HuongNV13/moodle 2022-04-14 13:35:11 +06:00
Huong Nguyen
3956dd856b MDL-74064 mod_assign: Behat test for Assignment with time limit 2022-04-14 12:49:55 +07:00
Shamim Rezaie
7252fef24b MDL-74064 mod_assign: Notify submission removal does not reset timelimit 2022-04-14 10:48:45 +07:00
Shamim Rezaie
6ac1477e98 MDL-74064 mod_assign: Use core_user::get_user instead of querying DB 2022-04-14 10:48:37 +07:00
Shamim Rezaie
76c0d3d6bc MDL-74064 mod_assign: Late submission recognition depends on timestarted 2022-04-14 10:48:29 +07:00
Claude Vervoort
696eace98d MDL-74481 mod_lti: fix role lookup for LTI 1.3 2022-04-13 12:57:58 -04:00
Ilya Tregubov
e39a1fff2c Merge branch 'MDL-74471-master' of https://github.com/junpataleta/moodle 2022-04-13 14:59:21 +06:00
Jun Pataleta
70f6b1605b MDL-74471 versions: bump all versions and requires near release 2022-04-13 10:37:36 +08:00
Tim Hunt
2e1a632302 MDL-74470 quiz: put back random Q description on the Question page
This got lost in the 4.0 question bank work.

We are trying to phase out qtype_random, that is where the old
code and lang strings for describing random questions is, so
OK to add back a call to it. When we get better qbank filtering
we can replace this again.

Note, the asserts in the Behat were copied from my 3.11, checkout,
to really verify we are restoring the previous behaviour.
2022-04-11 19:01:00 +01:00
Tim Hunt
95b0f86ed3 MDL-74470 quiz: fix typos & small bug from MDL-74255.
I think that, because how PHP works, the MDL-74255 bug (lack
of explode) generally does not break anything, which is why
no tests failed. Still. Good to fix.
2022-04-11 12:21:50 +01:00