Commit graph

99879 commits

Author SHA1 Message Date
Sara Arjona
a3f78dbd7a MDL-70264 badges: remove badges/oauth2callback.php
File badges/oauth2callback.php has been removed and now badges
API will use admin/oauth2callback.php because it makes no sense having
it twice.

Credits go to Andrew Nicols for raising it!
2021-02-11 16:58:55 +01:00
Sara Arjona
1d17c73e9e weekly release 3.9.4+ 2021-02-11 14:54:44 +01:00
Sara Arjona
b21076309d Merge branch 'install_39_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_39_STABLE 2021-02-11 14:54:42 +01:00
Mihail Geshoski
c34c00a762 MDL-47410 mod_assign: Update mod_assign behat tests
Updates the mod_assign behat tests to utilize the ability to
conviniently populate the datetime selector fields.
2021-02-11 12:15:45 +08:00
Mihail Geshoski
3d87e93f02 MDL-47410 behat: Support selection from the datetime selector element
Adds behat support for selecting date and time from a datetime selector
element. The passed values should represent a textual date and time
description wrapped in '##' (e.g. '##first day of January 2020 08:00##',
'##1 Jan 2020 10:30##'). Also, the value 'disabled' is valid and can be
used to disable the datetime selector element.
2021-02-11 12:15:45 +08:00
Mihail Geshoski
76f2dc1f14 MDL-47410 tool_licensemanager: Update tool_licensemanager behat tests
Updates the tool_licensemanager behat tests to utilize the ability to
conviniently populate the date selector fields.
2021-02-11 12:15:45 +08:00
Mihail Geshoski
77e578a91a MDL-47410 behat: Support date selection from the date selector element
Adds behat support for selecting a date from the date selector element.
The passed values should represent a textual date description wrapped
in '##' (e.g. '##first day of January 2020##', '##1 Jan 2020##'). Also,
the value 'disabled' is valid and can be used to disable the date
selector element.
2021-02-11 12:15:44 +08:00
Mihail Geshoski
eb0e5a1297 MDL-47410 behat: Create custom selector for the date and datetime fields
Creates a custom field selector to locate the requested date or datetime
form fields.
2021-02-11 12:11:18 +08:00
Mihail Geshoski
8844095259 MDL-47410 behat: Move logic from guess_type() to a separate method
Moves the logic from guess_type() to a separate protected method
get_field_instance_for_element(). This would be quite useful for
form field classes as they can now use this method when there is
a need to determine the type of a given node element.
2021-02-11 12:11:18 +08:00
Mihail Geshoski
4b58966938 MDL-47410 behat: Use data-fieldtype attribute to guess the field type
The data-fieldtype attribute (if present) should be also utilized in
guess_field_type() and match the behavior in get_field_node_type().
2021-02-11 12:11:18 +08:00
Mihail Geshoski
69ec780e95 MDL-47410 form: Add data-fieldtype attribute to checkbox inline element
Includes the data-fieldtype attribute to the checkbox inline form
element. This element does not extend the parent inline element
template due to its specific nature and therefore this attribute was
missing.
2021-02-11 12:11:18 +08:00
Adrian Greeve
e539a0aa30 Merge branch 'MDL-70513_39' of https://github.com/timhunt/moodle into MOODLE_39_STABLE 2021-02-11 10:05:29 +08:00
Adrian Greeve
7116f5fde8 Merge branch 'MDL-69867-39_display_grade_with_scale' of git://github.com/moffe42/moodle into MOODLE_39_STABLE 2021-02-11 09:25:19 +08:00
AMOS bot
aba0e6b70d Automatically generated installer lang files 2021-02-11 00:07:45 +00:00
Sara Arjona
37136525d9 Merge branch 'MDL-70732-39' of git://github.com/aanabit/moodle into MOODLE_39_STABLE 2021-02-10 17:20:43 +01:00
Sara Arjona
8e6d2ba38d Merge branch 'MDL-70796_39' of https://github.com/timhunt/moodle into MOODLE_39_STABLE 2021-02-10 16:50:20 +01:00
Sara Arjona
f418bf8c96 Merge branch 'MDL-69101_39' of https://github.com/timhunt/moodle into MOODLE_39_STABLE 2021-02-10 15:12:12 +01:00
Sara Arjona
8a40250c49 Merge branch 'MDL-70631-39-unzip' of git://github.com/mudrd8mz/moodle into MOODLE_39_STABLE 2021-02-10 12:38:24 +01:00
Sara Arjona
e516a662c5 Merge branch 'MDL-70736_MOODLE_39_STABLE' of https://github.com/TomoTsuyuki/moodle into MOODLE_39_STABLE 2021-02-10 08:28:32 +01:00
Jacob Christiansen
4adfbf3cba MDL-69867 mod_assign: Display current grade with scale value
When using workflow we show the current grade with its scale value
instead of the internal index
2021-02-10 08:10:55 +01:00
John Yao
ecafdc45d0 MDL-65390 accessibility: correct focus after "Show more" clicked 2021-02-09 15:11:37 +01:00
Sara Arjona
499bf7df7d Merge branch 'MDL-70173-39' of git://github.com/rezaies/moodle into MOODLE_39_STABLE 2021-02-09 08:29:34 +01:00
Sara Arjona
378725c05f Merge branch 'MDL-70377_39' of https://github.com/mkassaei/moodle into MOODLE_39_STABLE 2021-02-09 08:23:43 +01:00
Shamim Rezaie
e3142ca2e2 MDL-70173 core: Use a meaningful first level header 2021-02-09 16:33:44 +11:00
Shamim Rezaie
23ed4c4440 MDL-70173 theme_boost: Fix empty link issue on the "Go to top" button
On behat, we have to use a more specific test step if we are looking
for a "Go" button on a modal. The reason is that the html of the modal
content is put after the html of the "Go to top" button, so behat
may find the "Go to top" button if we just look for "Go".
2021-02-09 16:33:44 +11:00
Shamim Rezaie
4ac8ae1be7 MDL-70173 theme_boost: Increase the size of notification counter
WAVE considers any text with the size of 10px or below really small.
Increasing the font size of the navbar counter by 1px should not make a
big negative impact on the design, but improves accessibility.
2021-02-09 16:33:44 +11:00
Shamim Rezaie
254aa09f40 MDL-70173 output: All pages should have a heading
In MDL-63040, it was decided that the page header for the dashboad page
should be removed.
However, Based on Success Criteria 1.3.1 and 2.4.6 from the WebAIM's
WCAG 2 Checklist, all pages should have an <h1> element.
So I put an sr-only heading on the dashboard and all other pages, where
no page header is shown.
2021-02-09 16:33:44 +11:00
Shamim Rezaie
d27c60a90a MDL-70173 dashboard: ARIA role presentation conflicted the empty alt
The markup <img role="presentation" alt="alt text"> is contradictory.

According to https://www.w3.org/TR/2017/WD-wai-aria-practices-1.1-20170628/examples/presentation/PresentationRoleExamples.html
 It is recommended that authors instead use empty alt text (alt="")
 where they use role="presentation".
2021-02-09 16:33:43 +11:00
Shamim Rezaie
5fae9c213d MDL-70173 message: Fix empty link 2021-02-09 16:33:43 +11:00
Shamim Rezaie
e7a160da9a MDL-70173 output: use an empty alt to hide user pic from screen readers
There is no need to use WAI-ARIA to hide images from screen readers.
See https://www.w3.org/WAI/tutorials/images/decorative/
2021-02-09 16:33:43 +11:00
Tomo Tsuyuki
ac1402d552 MDL-70525 tool_profiling: Cannot import profiling file
Change type from int to integer to be able to have big numbers
2021-02-09 10:17:56 +11:00
Mahmoud Kassaei
2c5adf1c5b MDL-70377 qtype_essay: When reviewing an attempt as a teacher
In the Response history table, Action Saved: does not display the value
of $a in the language string.
2021-02-08 17:08:17 +00:00
Andrew Nicols
4d54712518 Merge branch 'MDL-70614-39' of git://github.com/paulholden/moodle into MOODLE_39_STABLE 2021-02-08 10:47:23 +08:00
Andrew Nicols
853cbc5973 Merge branch 'MDL-70725-39' of git://github.com/sarjona/moodle into MOODLE_39_STABLE 2021-02-08 10:30:51 +08:00
AMOS bot
630325a4e4 Automatically generated installer lang files 2021-02-06 00:07:46 +00:00
Tim Hunt
842e7aa041 MDL-70796 count_words: match the count from LibraOffice & MS Word 2021-02-05 15:27:15 +00:00
Amaia Anabitarte
46916975a2 MDL-70732 behat: Adding second parameter to ExpectationException() 2021-02-05 11:01:44 +01:00
Sara Arjona
8fc5c6214a weekly release 3.9.4+ 2021-02-04 14:56:17 +01:00
Sara Arjona
263419e10d Merge branch 'install_39_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_39_STABLE 2021-02-04 14:56:15 +01:00
Mikhail Golenkov
f4024153e1 MDL-70752 restore: Fix remote file recovery 2021-02-04 19:23:23 +11:00
Tomo Tsuyuki
61752e9e0f MDL-70736 gradingform_guide: Fix loading marking guide template issue
Do not check grade item name if it is from shared template.
2021-02-04 16:08:05 +11:00
Andrew Nicols
d9e13438d1 Merge branch 'MDL-69748-39' of git://github.com/rezaies/moodle into MOODLE_39_STABLE 2021-02-04 11:52:41 +08:00
Shamim Rezaie
6a7750a141 MDL-69748 core: Fix hideif issue with array elements
Changed the element selector to get all array elements,
whether named or unnamed. The previus selector was only
working for elements that thir names were like name="something[]".
It was not working for name="something[a]" elements.
2021-02-04 14:39:04 +11:00
AMOS bot
f025935c1c Automatically generated installer lang files 2021-02-04 00:07:51 +00:00
Eloy Lafuente (stronk7)
4640d8f9ca MDL-70741 capability overview: missing whitespace after placeholder 2021-02-04 00:01:03 +01:00
Tim Hunt
c420408522 MDL-70513 quiz manual grading: use formchangechecker to avoid dataloss 2021-02-03 16:11:18 +00:00
David Mudrák
2020498bd5 MDL-70631 files: Replace hard-coded value with FL_ENC_RAW constant
This is not related to the issue but I noticed it while trying to debug
it.

Back when this line was introduced in 9c140a681e, the ZipArchive had
not yet exposed this flag as a constant. It was added later with PHP
7.0.8 and we can switch to using it now.
2021-02-03 16:11:00 +01:00
David Mudrák
6ad9b1314f MDL-70631 files: Fix performance of zip_packer::extract_to_pathname()
The original implementation was based on ZipArchive::getStream() which
turns out to be very slow and if the archive contains many files, the
unzipping performance is very slow.

The patch changes the implementation to use ZipArchive::extractTo()
unless the extracted entry path contains a folder name ending with dot
(such as some/path./to/file.txt). There is a known upstream bug in the
PHP ZIP extension #77214 (also #74619 and #69477) so that we fall back
to keep using the stream in those cases.
2021-02-03 16:11:00 +01:00
Sara Arjona
994e833c20 Merge branch 'MDL-70705-39' of git://github.com/lucaboesch/moodle into MOODLE_39_STABLE 2021-02-03 15:33:26 +01:00
Luca Bösch
ab3f29f739 MDL-70705 block_blog_recent: support multilang blog entry titles 2021-02-03 15:15:43 +01:00