moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-07 09:56:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
80378 commits 37 branches 540 tags 1.3 GiB
Commit graph

482 commits

Author SHA1 Message Date
David Monllao
1a51661b94 MDL-52503 mod_assign: Removing session cache 
Replaced with a global $SESSION var, deferring cleanup to session
destroy.
 2016-01-05 15:04:32 +08:00
Michael Aherne
f6b4fe38a9 MDL-52439 assign: correct get_user_submission() phpdoc 2015-12-29 10:37:14 +00:00
Eloy Lafuente (stronk7)
71a2aaabd4 Merge branch 'MDL-44598_master' of https://github.com/jonof/moodle 2015-11-30 23:52:45 +01:00
Michael Aherne
72797e6845 MDL-52013 assign: Allow subplugins to add calendar events 2015-11-26 14:28:53 +00:00
Neill Magill
3fca693751 MDL-44330 Assign: Assignment grading may not display expected student 
Before this patch it was possible for the student displayed on the grading page to
not be the student that the user selected to grade. This would occur if:

1) The user had the table ordered by a value that could be modified,
   for example Last modified (submission), Grade, Last modified (grade)
2) Another user performed an action that was recorded in Moodle in the time
   between the user generating the table and clicking on a grade link.

If a user did not notice a different user had been loaded it could result in them giving
a grade to the incorrect user.

This patch ensures that the state of the table is cached every time it is viewed by a user
who has the capability to grade.
 2015-11-24 08:42:00 +00:00
Eloy Lafuente (stronk7)
9e9754b7aa Merge branch 'MDL-51515-master' of git://github.com/junpataleta/moodle 2015-11-11 23:14:47 +01:00
Damyon Wiese
6c2cfe281f MDL-51515 assign: Fix typo setting url in nav tree. 
Thanks to Nelson Moller and Tyler Bannister.
 2015-11-11 11:14:03 -06:00
Dan Poltawski
8e4c398b52 Merge branch 'MDL-51314-groupmembership' of https://github.com/dmitriim/moodle 2015-11-10 14:44:22 +00:00
Dan Poltawski
f46aa6bc42 Merge branch 'MDL-51628-master' of git://github.com/damyon/moodle 2015-11-09 11:01:21 +00:00
David Monllao
0f1b3c69d8 Merge branch 'MDL-40245_master' of git://github.com/SWiT/moodle 2015-11-09 16:12:44 +08:00
Dmitrii Metelkin
6d6e297b13 MDL-51314 mod_assign: cache group membership in can_edit_submission 2015-11-06 15:21:01 +11:00
Matt Switlik
08334e0692 MDL-40245 assignment: download all submissions raise time limit 2015-11-04 16:32:37 -05:00
Damyon Wiese
cfca338d7a MDL-52004 assign: Set unique urls when grading so autosaves work 
The Atto autosave feature uses the $PAGE->url to generate unique hashes for
each page. Assignment uses a MUC cache to persist ordering of lists - the result
is that the urls are not unique (they depend on the cached filter).

The fix is to spoof a unique url that will grade only that student with no
active grading list (no next/prev buttons).
 2015-11-02 16:41:55 +08:00
Jonathon Fowler
26670f5ee9 MDL-44598 assign: improve 'grant extension' form to show user names 
Presents the first several students like the 'Set marking workflow
state' facility does, and processes the submitted ids through the
grading batch intermediary form. (For reference: MDL-42531)
 2015-10-20 12:19:16 +10:00
David Monllao
7d45554019 Merge branch 'MDL-50724' of git://github.com/andrewhancox/moodle 2015-10-19 17:21:58 +08:00
Damyon Wiese
ab848fea81 MDL-48861 assign: Make the requires grading filter consistent 
Consistently include submissions with a null grade (see MDL-47694).
 2015-10-13 14:52:50 +08:00
Damyon Wiese
fb6bae3eae MDL-48861 assign: Fix unit tests and behat tests 
The tests were not working with the change to the needs grading filter.
 2015-10-13 12:59:13 +08:00
Dan Poltawski
37029775f9 Merge branch 'MDL-48861-master' of git://github.com/damyon/moodle 2015-10-12 16:53:18 +01:00
Andrew Hancox
ce449f6307 MDL-50724 mod_assign: show issues with groups in grading table 
Where a user is in multiple or no groups show and group membership
is required show an appropriate error in the gradding table rather
than 'Default Group'
 2015-10-12 12:04:28 +01:00
Damyon Wiese
64f6ef1f3a MDL-48861 mod_assign: use >= for requires grading filter 
If the grade and submission were modified at exactly the same time,
assume that this means the grade was automatically created for the submission
and is not a real grade from a teacher interaction.
 2015-10-09 15:08:06 +08:00
Damyon Wiese
dc40503680 MDL-51628 assign: invalid hardcoded capability check 
Use existing function to do the check instead.
 2015-10-09 14:09:33 +08:00
Dan Poltawski
a059ef2e9f MDL-50524 assign: improve method visibility and upgrade.txt 2015-10-06 16:32:57 +01:00
Damyon Wiese
9d3c6b95c7 MDL-48861 assign: Fix the "needs grading" filter 
When auto-creating a new grade record - do not set the timemodified > than the submission timemodified
 2015-09-04 11:05:57 +08:00
Andrew Hancox
ee5d4eef08 MDL-50524 mod_assign: preventsubmissionnotingroup for multiple groups 
When preventsubmissionnotingroup and a user is in multiple groups, display
relevant error messages to the user and teacher
 2015-09-03 14:54:46 +01:00
David Monllao
5c012a7426 Merge branch 'MDL-49637' of git://github.com/NeillM/moodle 2015-04-29 12:04:43 +08:00
Neill Magill
129d26aac4 MDL-49637 assign: Workflow & blind marking do not always show feedback 
Before this patch if an assignment has workflow and blind marking enabled if a teacher
sets a submission to have its grades released to students before they reveal student
identities the feedback they have given is not displayed to the student.

The patch causes the reveal_identities() method to pass the correct value to the
get_feedback_plugin_by_type() function in the assign class.
 2015-04-28 09:05:05 +01:00
Dan Poltawski
2be9a45389 Merge branch 'MDL-49977_master' of git://github.com/markn86/moodle 2015-04-27 10:46:08 +01:00
Mark Nelson
ccc1bc7e2e MDL-49977 mod_assign: added missing page titles 2015-04-23 16:24:18 -07:00
Tony Butler
2224f2c598 MDL-49933 mod_assign: Sort marker select lists alphabetically by name 2015-04-21 16:58:38 +01:00
Andrew Hancox
e528997a4a MDL-48159 mod_assign: Added setting preventsubmissionnotingroup 
If enabled a user will be unable to make a submission unless they are a
member of a group.
 2015-04-07 14:30:40 +01:00
Tony Butler
251d85c013 MDL-49075 mod_assign: Keep unreleased assign grades out of gradebook 2015-02-26 11:52:46 +00:00
Zachary Durber
3547f186a8 MDL-35392 mod_assign: Push feedback to gradebook when releasing grades 
When bulk changing workflow status a mismatch in variable
names meant that feedback wasn't being sent to the gradebook.
 2015-02-23 09:14:05 +08:00
Mark Nelson
0b1df17129 MDL-48884 mod_assign: prevented setting gradebook feedback unnecessarily 2015-02-02 23:34:54 -08:00
Eloy Lafuente (stronk7)
ccb722b76c Merge branch 'MDL-48574_workflow_state_updated_batch_single' of https://github.com/Dave-B/moodle 2015-01-15 08:35:01 +00:00
Eloy Lafuente (stronk7)
639910a75d Merge branch 'MDL-41166-master' of git://github.com/danpoltawski/moodle 2015-01-15 08:35:01 +00:00
David Balch
5bd9cdec1d MDL-48574 assign: Fire workflow_state_updated event on batch and single. 
This change adds the workflow_state_updated event when changing workflow
state using the single grading page and the quick grading mechanisms.
Previously, it only fired for batch updates using
process_set_batch_marking_workflow_state().
 2015-01-07 13:57:03 +00:00
David Monllao
b301753ba9 Merge branch 'MDL-48549_master' of git://github.com/markn86/moodle 2015-01-07 09:37:35 +08:00
Dan Poltawski
ccd8992b29 Merge branch 'MDL-48534_master' of https://github.com/markn86/moodle 2015-01-06 11:11:42 +00:00
Dan Poltawski
418bd23ffb MDL-41166 assign: don't display portfolio button when no permissions 
Thanks to Katja Krüger for the basis of the patch.
 2014-12-30 16:46:53 +00:00
Mark Nelson
26ac0abc22 MDL-48549 mod_assign: delete entries from the flags/mapping tables 2014-12-26 18:53:14 -08:00
Mark Nelson
bd3ee80716 MDL-46498 mod_assign: display correct grading status 2014-12-23 23:46:22 -08:00
Mark Nelson
c588fdac36 MDL-48534 mod_assign: display correct workflow state and marker 2014-12-23 22:37:25 -08:00
Dan Poltawski
cb878d027b Revert "Merge branch 'MDL-48534_master' of https://github.com/markn86/moodle" 
This reverts commit b8572fa904, reversing
changes made to 172d7f16ce.
 2014-12-23 10:46:39 +00:00
Dan Poltawski
b8572fa904 Merge branch 'MDL-48534_master' of https://github.com/markn86/moodle 2014-12-22 13:52:36 +00:00
Andrew Nicols
2da076e6bc Merge branch 'MDL-45324_master' of https://github.com/markn86/moodle 2014-12-18 14:07:46 +08:00
David Monllao
2d7b234362 Merge branch 'MDL-48235-master-fixes' of git://github.com/xow/moodle 2014-12-18 12:35:55 +08:00
Zachary Durber
a68b8d8d16 MDL-47442 mod_assign: Notify student when quick-grading grade 2014-12-18 12:10:01 +08:00
John Okely
3a5581c1ad MDL-48235 mod_assign: Fix grade of 0 not showing on feedback page in oracle 2014-12-18 10:23:03 +08:00
Mark Nelson
acb525551f MDL-48534 mod_assign: display correct workflow state and marker 2014-12-17 00:06:49 -08:00
Mark Nelson
8dc1f5ff71 MDL-45324 mod_assign: always notify students when requested 2014-12-16 23:41:00 -08:00