nicolasconnault
210611f6ee
MDL-9629 Changed grade_item.gradetype default to 1, added GRADE_TYPE_NONE constant = 0, incrementing existing constants by 1. Set up auto-generation of idnumber for grade_item if itemmodule and iteminstance are set, only a temporary stub if they are not set (must be replaced by correct generation code). New category form now has server-side validation (not using formslib)
2007-06-05 08:50:24 +00:00
toyomoyo
1b63e57388
adding a usermodified field to post table
2007-06-05 05:40:10 +00:00
nicolasconnault
bbac4ae7c5
MDL-9972 Removed the __destruct() method, which was not needed. Also fixed a few bugs that caused notices in PHP5.
2007-06-05 01:19:09 +00:00
nicolasconnault
ffa6e8d3c0
MDL-9629 Category edit page now supports creation of a new category for selected items or categories.
2007-06-05 00:39:01 +00:00
nicolasconnault
de5284f26d
MDL-9137 Almost finished the edit category page. The only remaining issue is some sort of endless loop starting in grade_category::set_as_parent. Big issue...
2007-06-01 08:01:47 +00:00
nicolasconnault
ec4560cc58
MDL-9137 Removed hidden field from grade_categories and added deleted field to grade_items. Also added 2 images in pix/i
2007-06-01 04:46:24 +00:00
nicolasconnault
5fad506139
MDL-9629 Category edit page now implements delete, show/hide, lock/unlock, moveup/movedown and move actions. The edit icon is also shown but not yet implemented.
2007-06-01 04:02:37 +00:00
nicolasconnault
88e794d6c8
MDL-9628 Move work on the category edit page
2007-05-31 08:57:05 +00:00
nicolasconnault
0fc7f62445
MDL-9506 MDL-9137 MDL-9629
...
Added a number of small getters and setters to grade_item and grade_category, to hide the structural differences between the two, and provide a common interface for cases when we are not sure whether an $object is of one type or another.
The grade_tree::renumber() method now adds complete objects to the need_update array, because both grade_category and grade_item need to update their parent field when moved to a different parent. Amazingly, these important changes worked straight away (after 1 hour of coding without testing anything), and all the unit tests passed!
2007-05-31 03:15:43 +00:00
nicolasconnault
5bfa0d793a
Implemented a test version of the gradebook category edit page, and developed the get_edit_tree method in grade_tree. Items can be successfully moved up and down, and a "move" button lets the user select a source element, then a destination box. All actions use POST.
2007-05-30 08:48:11 +00:00
nicolasconnault
c3096060de
MDL-9506 Added ksort() of each level of categories and items for the gradebook. Unsorted arrays caused erratic behaviour when moving elements of the tree around.
2007-05-30 05:47:26 +00:00
nicolasconnault
a3d5594248
MDL-9506 Refactored grade_tree::get_tree by doing the following:
...
- Extracted the $fillers array into a class variable
- Extracted the addition of elements to grade_tree::fillers into a new add_fillers($array) method
- Extracted the inclusion of fillers into the tree_array to a new include_fillers($tree, $object=NULL) method
- Removed the building of the tree_filled, which was already performed by build_tree_filled()
- Removed the generation of next_sortorder and previous_sortorder attributes, which was already performed by renumber()
Result is a much leaner and scalable set of methods, and a tighter definition of responsibilities for the varying classes. I think I have also noticed a significant inprovement in speed.
2007-05-30 03:09:38 +00:00
jamiesensei
dc1f768351
reverting commit 1.889 "added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE." It turned out to be unnecessary.
2007-05-29 06:27:38 +00:00
jamiesensei
d65cb30f63
reverting last commit "added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE." It turned out to be unnecessary.
2007-05-29 06:14:09 +00:00
jamiesensei
24a905f98b
fixed bug in parsing urls
2007-05-29 06:14:09 +00:00
nicolasconnault
646323549e
MDL-9506 Resolved recursion issues in grade_tree:renumber and grade_tree::get_neighbour_element. Unit tests all pass now.
2007-05-29 04:07:04 +00:00
nicolasconnault
de420c11c5
MDL-9317 Applying Petr's second patch
2007-05-29 00:56:44 +00:00
jamiesensei
099f7fb6ca
added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE.
2007-05-28 14:25:40 +00:00
skodak
7bddd4b787
MDL-9632; MDL-9545 basic assignment grading support - event triggers implemented + some minor cleanup
2007-05-28 08:55:15 +00:00
skodak
37db0ab8f8
MDL-9960 update_record() does not store NULLs; I hope it will not break anything
2007-05-28 08:49:40 +00:00
skodak
b5b65852c6
apply magic quotes before using var in sql query in fetch_all_using_this()
2007-05-28 08:20:07 +00:00
nicolasconnault
c91ed4be0d
MDL-9506 Category and Item now set their own courseid if not set explicitly, and if they have enough information from
...
other sources. category::set_as_parent has a new constraint: cannot set over children from different courses.
Applied recursion to grade_tree::renumber(), but still some fine-tuning to do, since only grade_items are getting updated in DB.
2007-05-28 08:00:19 +00:00
nicolasconnault
d990776605
MDL-9137 Applied parts of Petr's patch on the gradebook objects. Unit tests unaffected.
2007-05-28 02:05:21 +00:00
nicolasconnault
526e1a8a25
MDL-9506 Corrected a number of small errors in unit tests and classes.
2007-05-28 01:26:58 +00:00
jamiesensei
3673f6bc3b
added more phpdoc comments for hardFreezeAllVisibleExcept
2007-05-28 00:50:11 +00:00
jamiesensei
56015454dd
new method hardFreezeAllVisibleExcept
2007-05-28 00:46:11 +00:00
skodak
271c7a98bc
MDL-9959 debugging() shows warnings when called from call_user_func() functions
...
MDL-9958 addslashes_recursive() and stripslashes_recursive() modifies function parameter in PHP5
2007-05-27 22:55:52 +00:00
jamiesensei
9368476553
MDL-9734 fix for clean_param PARAM_LOCALURL bug
2007-05-27 11:19:04 +00:00
jamiesensei
64360ee7b5
made hardFreeze work properly for a whole form. New paramater in moodleform constructor 'editable' defaults to true. If true then display form as normal. If false then hardFreeze whole form. Now displays form without an submit buttons. If form is hard frozen no data is ever passed to get_data.
2007-05-27 05:01:51 +00:00
jamiesensei
7d8ea28668
MDL-9891 new 'clonepermissionsfrom' key in access.php
2007-05-27 04:53:02 +00:00
skodak
19e7f33384
MDL-9643 some more polishing
2007-05-26 13:11:54 +00:00
skodak
7458bee224
MDL-9643 some more polishing
2007-05-26 12:59:13 +00:00
anthonyforth
ae8fda4cb1
Fix for bug MDL-9942
2007-05-25 09:55:08 +00:00
skodak
a9cca58ea2
MDL-9643 minor maths unit test cleanup
2007-05-25 07:07:05 +00:00
nicolasconnault
8ae28b4959
MDL-9506 WOrking on grade_tree edit tree
2007-05-25 07:02:04 +00:00
skodak
8bbb7e471e
MDL-9643 removing the sample files, use our unit tests instead
2007-05-25 06:54:48 +00:00
skodak
ffaa6c4abd
MDL-9643 mathslib.php library, unit tests, removed e and pi constants
2007-05-25 06:50:09 +00:00
skodak
2d53fa5031
MDL-9643 evalmath library improvement - sample calc functions
2007-05-25 06:07:45 +00:00
jamiesensei
61d9b9fc5d
oops. reverting changes which shouldn't have been committed to HEAD.
2007-05-25 05:49:51 +00:00
jamiesensei
bdc66c2a5d
fix for category.php lists. Slight change in listlib api caused breakage.
2007-05-25 04:59:17 +00:00
skodak
0b5f7f5948
MDL-9643 evalmath library import - tweaks and wrapper class ahead
2007-05-24 19:12:18 +00:00
tjhunt
6e9debfbf1
Removing remaining references to RQP in core code. I had not realised there were so many.
By the way, I am committing this from a pub in York. Pub's with wireless, whatever next?
2007-05-24 17:25:37 +00:00
skodak
98518b6221
MDL-9876 import adodb 4.95a
2007-05-24 17:14:58 +00:00
sam_marshall
8101dccb8e
MDL-9920 Allowed xmldb to create 32-bit serial fields if specified, in postgres
2007-05-24 15:18:35 +00:00
nicolasconnault
2186f72cb1
MDL-9629 Beginning the edit category page. Also added dmllib::sql_max($field) and fixed a few bugs. Grade_item should now extrapolate its sortorder upon insertion if not set, by looking up the last sortorder in the table, and incrementing by 1.
2007-05-24 08:50:01 +00:00
nicolasconnault
5e2274737c
MDL-9506 Added grademax extrapolation from scale info for grade_item, in insert() and update() methods. Corrected a few other minor bugs.
2007-05-24 03:32:20 +00:00
toyomoyo
3abe994563
fixing a typo
2007-05-24 03:07:27 +00:00
toyomoyo
ce34ed3a76
fix for MDL-9137, adding support for gradebook plugins for db, cron, events, permission structures etc
2007-05-24 02:16:31 +00:00
nicolasconnault
a15428a2f6
MDL-9889 Fixed a couple of bugs that were only detected by PHP5. Nothing major at all.
2007-05-24 02:08:20 +00:00
toyomoyo
5283e9598d
correcting handling of scales
2007-05-23 07:26:38 +00:00
