Commit graph

688 commits

Author SHA1 Message Date
Damyon Wiese
9f014461db MDL-36804 Assign attempt history: Submit button missing 2013-04-05 16:40:16 +08:00
Damyon Wiese
e7af192606 MDL-36804 Assign history: Fix automatic coding error when using auto-reopen method
This fix should call the gradebook function is_passed - but the gradebook is returning a record with
not enough information to create an instance of grade_grade.
2013-04-05 15:53:38 +08:00
Damyon Wiese
f39aaadb35 MDL-38933 Assign - improved wording for help string. 2013-04-05 14:20:45 +08:00
Damyon Wiese
a8fdb36cf2 MDL-36804 Assignment attempt history: Fix warning on saving a new grade.
This is a fix for the case when there is a submission but no grade.
2013-04-05 10:03:00 +08:00
Damyon Wiese
e84900648b MDL-36804 Assign attempt history: Fix course unit tests
Handle missing attemptreopenmethod in add/update instance.
2013-04-03 17:31:12 +08:00
Damyon Wiese
c9c34c7a65 MDL-36804 Assign attempt history - Add missing index to upgrade step. 2013-04-03 16:44:31 +08:00
Damyon Wiese
74c9283854 MDL-36804: Assign attempt history - add upgrade.txt 2013-04-03 16:16:21 +08:00
Damyon Wiese
fab5cb3604 MDL-36804: Assign resubmission history - remove locked/mailed
Remove locked/mailed flags from the grade record in the unit tests.
It just would not have done anything because the columns dont exist.
2013-04-03 14:17:00 +08:00
Damyon Wiese
95bef9d170 MDL-36804 Assign: Fix undeclared global $USER and undefined variable $userid 2013-04-02 13:44:25 +08:00
Damyon Wiese
3a9dc7f22f MDL-36804 Assign submission history - One language string change. 2013-04-02 13:37:51 +08:00
Damyon Wiese
7b647abcb8 MDL-36804 Assignment submisison history - fix width column
Fix the width of the left column in the history and submission tables so
they all line up on the page.
2013-04-02 13:37:51 +08:00
Damyon Wiese
a13fbf5fe8 MDL-36804 Assignment - Make sure webservice only returns the last submission/grade. 2013-04-02 13:37:51 +08:00
Damyon Wiese
df211804f1 MDL-36804 mod_assign - allow students to resubmit work and display a submission + grading history
This is based on work by Davo Smith with input from Fernando Oliveira (Thanks guys!).
2013-04-02 13:37:51 +08:00
prateeksachan
f7884095de MDL-38361: Fixed typos in mod/assign/locallib.php 2013-03-30 23:39:56 +05:30
Jonathon Fowler
bdc4cb9ef0 MDL-37966 Assignment: put upgraded modules where the originals were 2013-03-27 12:40:28 +10:00
Damyon Wiese
8fe55f6862 Merge branch 'MDL-37079-master2' of git://github.com/mouneyrac/moodle 2013-03-19 11:13:23 +08:00
Jerome Mouneyrac
dd5d933f30 MDL-37079 create/update_module() 2013-03-18 14:41:35 +08:00
Frederic Massart
807cf3d0ae MDL-38005 form: Headers have a proper name 2013-03-15 11:06:25 +08:00
Eloy Lafuente (stronk7)
641577eb32 Merge branch 'MDL-38352-en_fix' of git://github.com/mudrd8mz/moodle 2013-03-06 17:26:37 +01:00
Helen Foster
ca084ef149 MDL-38352 Merge English strings from the en_fix language pack 2013-03-06 16:44:39 +01:00
Sam Hemelryk
1668803ae2 Merge branch 'MDL-35127-master' of git://github.com/damyon/moodle 2013-03-04 16:08:08 +13:00
Damyon Wiese
520fee918e MDL-36832 Assignment Use MUC for useridlist: Fix for quickgrading checkbox 2013-02-27 11:24:42 +08:00
Damyon Wiese
b8d3aa8fc8 MDL-35127 Assignment - declare the variables in the outer scope (for readability) 2013-02-27 09:27:55 +08:00
Eric Merrill
d77731d612 MDL-35127 mod_assign More efficient use of expensive database queries
Moving two relatively expensive DB queries so they are only executed when needed
instead of on every function call. They will still only execute once, and not
repeatedly during execution of the loop.
2013-02-27 09:01:25 +08:00
Eloy Lafuente (stronk7)
46e120c561 Merge branch 'MDL-37835-master' of git://github.com/damyon/moodle 2013-02-26 10:06:14 +01:00
Damyon Wiese
115277060a MDL-37835 Assignment unit tests - Do not fail if custom plugins are installed. 2013-02-26 09:09:53 +08:00
Damyon Wiese
9c986ee01d MDL-38115 Assignment Unit tests : speedup (round 2) 2013-02-26 09:00:06 +08:00
Dan Poltawski
f4e34c5ffb Merge branch 'MDL-37770-master' of git://github.com/damyon/moodle 2013-02-25 14:32:01 +08:00
Dan Poltawski
e1350c61d1 Merge branch 'MDL-36832-master' of git://github.com/damyon/moodle 2013-02-25 14:19:36 +08:00
Tim Lock
9ecded01cc MDL-38113: Blind Marking grader email reveals submitters details 2013-02-25 11:13:25 +08:00
Damyon Wiese
d08e6c31fb MDL-38061 Assignment - Use $CFG->showuseridentity to add extra fields to the assignment grading table/user summary. 2013-02-22 10:30:56 +08:00
Damyon Wiese
0b352fd94e MDL-37770 Assignment submission comments do not work without javascript.
This is mostly fixed by MDL-36832 which correctly sets the $PAGE->url.

This patch hides the submit and textareas from submission comments in the grading table when
javascript is disabled and quickgrading is enabled. This particular combination results in a form
nested in a form which does not work (and cannot be fixed in a reasonable amount of time).
2013-02-21 11:55:24 +08:00
Damyon Wiese
c211409998 MDL-36832 Assignment Fix issues found by unit tests with previous patch 2013-02-21 11:22:06 +08:00
Damyon Wiese
d04557b364 MDL-36832 Assignment - Use MUC for caching the useridlist and change all pages to redirect after post.
This means that the $PAGE->url is properly set for all pages and is required to fix some edge cases with the comments api when
javascript is disabled. It also means logging in after a timeout will work nicely and other Good Things (tm).
2013-02-21 11:04:07 +08:00
Dan Poltawski
3770eadb82 Merge branch 'MDL-38047-master' of git://github.com/damyon/moodle 2013-02-19 13:31:11 +08:00
Damyon Wiese
a5c793c38c MDL-38047 Assignment unit tests - Shave 1 minute from the unit tests for mod_assign. 2013-02-15 12:36:21 +08:00
Damyon Wiese
b0da618b61 MDL-37337 Assignment: Restructure assignment settings screen to make it "wieldy" 2013-02-15 11:26:21 +08:00
Damyon Wiese
7688a3191c MDL-37883 Assignment Grade import/export. Additional fix to prevent different grade rounding on export. 2013-02-13 15:33:10 +08:00
Dan Poltawski
26f94655d5 Merge branch 'MDL-37883-master' of git://github.com/damyon/moodle 2013-02-12 13:47:37 +08:00
Dan Poltawski
4dea0a7719 Merge branch 'MDL-37074-master' of git://github.com/damyon/moodle 2013-02-12 13:39:07 +08:00
Dan Poltawski
9d7d0c4f2b Merge branch 'MDL-37039-master' of git://github.com/damyon/moodle 2013-02-11 14:32:53 +08:00
Damyon Wiese
93d1de6d3f MDL-37039 Assignment - Do not apply filters to grading table for offline assignments
Because the filters do not make sense for offline assignments, they are hidden. But if the active filter
prevents you from seeing any assignments you cannot change it. This change makes it so the filters are
also not applied when the assignment is an offline assignment.
2013-02-08 15:44:18 +08:00
Damyon Wiese
7a15c5c458 MDL-37074 Assign theming: Use addClass/removeClass instead of setAttribute to preserve existing classes 2013-02-08 15:16:47 +08:00
Damyon Wiese
6b219310cf MDL-37122 core get_max_upload_sizes: Include "Course/Site/Activity limit (X)" in list of options
This change removes the "0 bytes" option from the get_max_upload_sizes list
and replaces it with "Course limit (X)" or "Site limit (X)" (whichever is smaller).
This means we can remove all custom handling in the modules that were removing and
adding these options. It only affects pages that pass valid options for sitelimit and
courselimit - so admin pages will work correctly.

It also orders the list so the course/site limit options will be first
(as it will be the largest).

AMOS START
 REM [courseuploadlimit, core] has been parameterized to get [uploadlimitwithsize, core]
AMOS END
2013-02-07 10:50:52 +08:00
Damyon Wiese
070d431771 MDL-37883 Assign offline marking: Properly handle french decimal grades when importing worksheet. 2013-02-06 15:43:19 +08:00
Dan Poltawski
4ac341c9b6 Merge branch 'MDL-37646-master' of git://github.com/damyon/moodle 2013-02-04 13:49:23 +08:00
Dan Poltawski
d5a13bca09 Merge branch 'MDL-37710-master' of git://github.com/damyon/moodle 2013-02-04 12:12:11 +08:00
Damyon Wiese
46692c3a81 MDL-37635 Assign: Prevent errors when viewing a feedback for an assignment with no gradeitem in gradebook
Also adds unit tests to verify that:
Feedback is visible even if there is no grade
The grade is not shown if the gradeitem is hidden unless you have mod/assign:grade capability
2013-02-01 13:46:08 +08:00
Petr Škoda
7a18f49c60 MDL-37726 remove PREVIOUS/NEXT from all install.xml files
YAY!
2013-01-29 22:34:46 +01:00
Damyon Wiese
3e1b63f1c8 MDL-37710 Assign: Fix pluginfile permission checks for student viewing their own team submission.
This change adds a function to the assign class to allow the permissions for a group submission
to be checked and updates all the submission plugins to call it.
2013-01-29 17:14:36 +08:00