Commit graph

24246 commits

Author SHA1 Message Date
Shamim Rezaie
6ac1477e98 MDL-74064 mod_assign: Use core_user::get_user instead of querying DB 2022-04-14 10:48:37 +07:00
Shamim Rezaie
76c0d3d6bc MDL-74064 mod_assign: Late submission recognition depends on timestarted 2022-04-14 10:48:29 +07:00
Claude Vervoort
696eace98d MDL-74481 mod_lti: fix role lookup for LTI 1.3 2022-04-13 12:57:58 -04:00
Ilya Tregubov
e39a1fff2c Merge branch 'MDL-74471-master' of https://github.com/junpataleta/moodle 2022-04-13 14:59:21 +06:00
Jun Pataleta
70f6b1605b MDL-74471 versions: bump all versions and requires near release 2022-04-13 10:37:36 +08:00
Tim Hunt
2e1a632302 MDL-74470 quiz: put back random Q description on the Question page
This got lost in the 4.0 question bank work.

We are trying to phase out qtype_random, that is where the old
code and lang strings for describing random questions is, so
OK to add back a call to it. When we get better qbank filtering
we can replace this again.

Note, the asserts in the Behat were copied from my 3.11, checkout,
to really verify we are restoring the previous behaviour.
2022-04-11 19:01:00 +01:00
Tim Hunt
95b0f86ed3 MDL-74470 quiz: fix typos & small bug from MDL-74255.
I think that, because how PHP works, the MDL-74255 bug (lack
of explode) generally does not break anything, which is why
no tests failed. Still. Good to fix.
2022-04-11 12:21:50 +01:00
Tim Hunt
5be2fc1ddc MDL-74255 quiz/question versions: update SQL to work in Oracle 2022-04-08 12:19:53 +01:00
Tim Hunt
a43f56836a MDL-74255 quiz: fix redo and regrade question version handling 2022-04-08 12:19:53 +01:00
Tim Hunt
839cccead4 MDL-74255 quiz: handle draft question status correctly
The main issue to fix is that questions vesions which should not have
been used (that is, hidden or draft versions) were getting offered
as an option and acutally being used.

As part of this I was able to substantially un-tangle
mod_quiz\question\bank\qbank_helper, which previously was
a mass of functions calling other functions in a complicated way.
Hopefully, it is now a bit easer to understand, and perhaps
less buggy.
2022-04-08 12:19:53 +01:00
Tim Hunt
5fff990e25 MDL-74255 quiz: clean up lots of stuff mainly in the tests
This fixes lots of stuff like outdated or incomplete PHPdoc comments
or test heler functions where the arguments don't have their types
declared.

A few more significant fixes, like places were a silly method
was used to get a context which was readily available.
2022-04-08 12:19:52 +01:00
Tim Hunt
37e8faf0ed MDL-74255 quiz: Remove un-needed method question_array_sort 2022-04-08 12:19:52 +01:00
Ilya Tregubov
49eb6ed755 Merge branch 'MDL-74339' of https://github.com/call-learning/moodle 2022-04-08 09:57:41 +06:00
Laurent David
978bdb5b4d MDL-74398 mod_bigbluebuttonbn: Fix issue with Visible groups
* In visible group user should see all recordings. This fixes an issue while integrating
MDL-74052 with this issue.
2022-04-07 19:25:50 +02:00
Jun Pataleta
d848bc7ece Merge branch 'MDL-74329' of https://github.com/odeialba/moodle 2022-04-07 20:14:14 +08:00
Laurent David
8d3f6e7133 MDL-74339 mod_bigbluebuttonbn: Fix upgrade recording from 2.4
* Only delete "Create" or "Update" logs when a recording has been effectively created
* Reschedule task if fail or logs are left over
* One task per meetingid
2022-04-07 13:02:12 +02:00
Odei Alba
9446af726d MDL-74329 mod_quiz: scroll to top and to question container
When reviewing the answers:
1- When there are all the questions in one page and you click in the first question,
it will scroll to the first question.
2- When there is one question per page and you click in the question number,
it will go to that question page and scroll to the top.
If you click again the question number, it will scroll to the question container.
2022-04-07 12:49:42 +02:00
Ilya Tregubov
fa1d1ea378 Merge branch 'MDL-74235-patch' of https://github.com/ilyatregubov/moodle 2022-04-07 13:53:44 +06:00
Andrew Nicols
9dc2ee548d MDL-74235 mod_lti: Update use of logo to monologo 2022-04-07 13:43:55 +06:00
Andrew Nicols
f57461cfb7 Merge branch 'MDL-74398' of https://github.com/call-learning/moodle 2022-04-07 15:25:36 +08:00
Laurent David
d8f3c831c9 MDL-74398 mod_bigbluebuttonbn: Remove (All participants) meeting title
* When course groups are disable the meeting title should not display (All participants)
2022-04-07 08:15:12 +02:00
Shamim Rezaie
43e37471f1 MDL-74404 mod_bigbluebuttonbn: Delete the unnecessary $datagenerator var 2022-04-07 16:13:11 +10:00
Shamim Rezaie
db75461893 Merge branch 'MDL-74404' of https://github.com/call-learning/moodle 2022-04-07 16:09:34 +10:00
Ilya Tregubov
29da0c7f2a Merge branch 'MDL-74235-master-2' of https://github.com/andrewnicols/moodle 2022-04-07 12:06:38 +06:00
Andrew Nicols
4b388fc239 MDL-74235 core: Update core uses of activity icons to monologo 2022-04-07 12:56:14 +08:00
Andrew Nicols
eb0a95956f MDL-74235 mod: Rename activity icons to new monologo naming 2022-04-07 12:56:14 +08:00
Andrew Nicols
ffc227c9d5 MDL-74235 output: Fall back to icon and support monologo 2022-04-07 12:56:13 +08:00
Jun Pataleta
55fb55f7dc Merge branch 'MDL-74332-master' of https://github.com/sharidas/moodle 2022-04-07 00:35:20 +08:00
Sara Arjona
aa96ef42ca Merge branch 'MDL-74052' of https://github.com/call-learning/moodle 2022-04-06 17:47:11 +02:00
Sara Arjona
f2d666e8c6 Merge branch 'MDL-74325' of https://github.com/ssj365/moodle 2022-04-06 16:29:11 +02:00
Ilya Tregubov
e2a8a3cbf9 Merge branch 'MDL-74381-master' of https://github.com/aanabit/moodle 2022-04-06 15:37:42 +06:00
Amaia Anabitarte
8d8b8d9066 MDL-74381 core_themes: Resizing svg mod icons to 24px 2022-04-06 11:19:10 +02:00
Jake Dallimore
1f16a2cd69 Merge branch 'MDL-74371-master' of https://github.com/sharidas/moodle 2022-04-06 12:25:55 +08:00
Sujith Haridasan
cc24705880 MDL-74371 mod_survey: Indent the file as per coding style
Indent the file as per the coding style.
Adjust the comments so that they start with Caps and have a full
stop at the end.
Added file-level phpdoc.
2022-04-06 09:37:02 +05:30
Sujith Haridasan
33923a7969 MDL-74371 mod_survey: Wordrap long questions in response reports
Word wrap long questions in Response reports so that the users dont
see broken questions in the questions page.
2022-04-06 09:37:02 +05:30
Eloy Lafuente (stronk7)
70e29b77f0 Merge branch 'MDL-74330-master-enfix' of https://github.com/vmdef/moodle 2022-04-05 18:39:23 +02:00
Jun Pataleta
f949a28d1d Merge branch 'MDL-74302-master' of https://github.com/rezaies/moodle 2022-04-05 12:05:55 +08:00
Sara Arjona
fea804b5dc Merge branch 'MDL-74383-master' of https://github.com/mihailges/moodle 2022-04-04 15:46:19 +02:00
Shamim Rezaie
abbb55eadf MDL-74302 mod_quiz: Users with preview cap should see prevent messages 2022-04-04 19:03:20 +10:00
Shamim Rezaie
2b5be06b68 MDL-74302 mod_quiz: use notification renderable to display quiz notices 2022-04-04 19:03:20 +10:00
Shamim Rezaie
3a25a52375 MDL-74302 mod_quiz: preview cap has higher priority than the attempt cap 2022-04-04 19:03:20 +10:00
Jake Dallimore
bd58b70e66 Merge branch 'MDL-74276-master-linkfarm' of https://github.com/peterRd/moodle 2022-04-04 15:59:19 +08:00
Sujith Haridasan
6edb78c86b MDL-74332 mod_survey: Indent the file properly
Correct the indentation of the file.
Replaced print_error with moodle_exception.
Updated the comments to start with capital and end with fullstop.
2022-04-04 11:29:15 +05:30
Ilya Tregubov
39ff636316 Merge branch 'master_MDL-74361-course-restore' of https://github.com/catalyst/moodle-MDL-70329 2022-04-04 10:28:32 +06:00
Sujith Haridasan
bfb4c2797a MDL-74332 mod_survey: Critical incidents dont require summary and scales
Do not show summary and scales for the survey with critical
incidents. So critical incidents survey would have questions
and participants only under response reports.
Also corrected the heading for the Questions page.
2022-04-04 09:56:15 +05:30
Mihail Geshoski
c1ab472180 MDL-74383 assignfeedback_editpdf: Fix comment issues in the pdf editor 2022-04-04 10:55:46 +08:00
Mihail Geshoski
2202c71a76 MDL-74383 assignfeedback_editpdf: 'Annotated PDF' link style update 2022-04-04 10:55:46 +08:00
Safat Shahin
294c77d8f7 MDL-74361 quiz: pre4.0 course restore bug fix for random question tags 2022-04-03 23:20:44 +10:00
Shamiso.Jaravaza
4483261625 MDL-74325 mod_bigbluebuttonbn: Fix presentation setting 2022-04-01 17:12:49 -02:30
Laurent David
8ab0990345 MDL-74404 mod_bigbluebuttonbn: Delete logs when course reset
* When Delete custom logs is selected we should delete all logs in
bigbluebuttonbn_logs table related to this course (join, add events...)
2022-04-01 20:07:08 +02:00