Commit graph

98 commits

Author SHA1 Message Date
Amaia Anabitarte
1c968103b7 MDL-75492 mod_data: Remove redirection messages on preset apply process 2022-11-16 09:08:26 +01:00
Amaia Anabitarte
9b343752e2 MDL-75492 mod_data: Cosmetic changes on mapping page 2022-11-16 09:08:26 +01:00
Sara Arjona
caf139a47d Merge branch 'MDL-76177-master' of https://github.com/aanabit/moodle 2022-11-04 11:01:42 +08:00
Amaia Anabitarte
565aafccc6 MDL-76177 mod_data: Don't close a div that has not been opened 2022-11-02 18:39:54 +01:00
Sara Arjona
61e8b806ec MDL-75289 mod_data: Implement prototyped tertiary nav
On the Database page:
- The List/single view is displayed in the right.
- The buttons Import entries, export entries and Export to portfolio
have been moved to the Actions menu.
- The List/Single view headings have been removed.
- The "Save settings" secondary button is hidden when advanced search
is enabled.
- The result (Found X out of Y entries, No records found) are not
displayed as notifications anymore.

On the Presets page:
- The buttons (Import, Export and Save as preset) have been moved to an
actions menu to the tertiary navigation. Some of these options have been
renamed.
- Remove the Action column heading from the table.

On the Presets preview page:
- Move the preset name to the heading in the tertiary navigation (Preview
of xxxxx), and remove the current preset name from the page.
- Align the List/single template to the right in the tertiary navigation.
- Make primary the "Use this preset" button.

On the Fields page:
- Remove the "Manage fields" menu.
- Remove the Export and Save as preset from the tertiary navigation.
- Align Create a field to the right in the tertiary navigation.
- Add a description at the top of the page.
- Remove the Action column heading from the table.
- Move field actions (Edit and Delete) to ellipsis.

On the Templates page:
- Move Export and Save as preset to the Actions menu.
- Move the templates list to a tertiary navigation selector and remove
the template heading.
- Reorder the templates list (Add entry template should be displayed
at the begining, instead of List template).
- Rename "Enable editor" to "Enable code editor".
2022-10-31 15:24:13 +01:00
Laurent David
cf12af7519 MDL-75188 mod_data: Use cmid instead of id
* Based on previous changes, fix ids so they are consistent with other modules (in preparation for MDL-75255)
2022-10-27 18:34:45 +02:00
Laurent David
d67fbbb80d MDL-75188 mod_data: Move import preset for to a modal
* Use a modal instead of a standard page to select the preset file
   and import it.
 * Change the zero state import button to a modal dialog so it uses the same
   workflow as on the preset page
2022-10-27 18:32:23 +02:00
Ferran Recio
f002af96b6 MDL-75597 mod_data: content max width 2022-10-19 17:07:14 +02:00
Amaia Anabitarte
bc7caa3ac8 MDL-75140 mod_data: Skip mapping form if there is no field created 2022-10-11 11:00:26 +02:00
Ferran Recio
37b9bd48b6 MDL-75234 mod_data: introduce manager get_renderer 2022-10-03 15:58:28 +02:00
Jun Pataleta
359e7c7ca4 Merge branch 'MDL-75186-master' of https://github.com/sarjona/moodle 2022-09-19 12:01:53 +08:00
Sara Arjona
a66cdcd9a8 MDL-75186 mod_data: Export saved presets 2022-09-16 11:12:14 +02:00
Ferran Recio
2b48b29c86 MDL-75149 mod_data: add preview to presets 2022-09-14 12:30:13 +02:00
Amaia Anabitarte
ae5dc809ec MDL-75187 mod_data: Move delete preset to a modal
Co-author: Ferran Recio <ferran@moodle.com>
2022-09-02 16:01:38 +02:00
Sara Arjona
aecb87f53e MDL-75142 mod_data: Add description to presets
This commit adds support to description field for presets:
- For plugin presets, description will be stored in the module_help
string in lang files.
- For saved presets, a new element, <description>, has been added
to the preset.xml file, to include this information.

A new field has been added to the "Save as preset" modal, to let users
define description (which is empty by default, to support pre-existing
presets that won't have it).

Apart from that, the "Save as preset" workflow has been slightly improved,
following the Product UX/UX suggestions to hide the checkbox to overwrite
the preset by default and show it only if the user tries to save a preset
with an existing name.
2022-08-05 14:51:49 +02:00
Sara Arjona
9d10f7d19e MDL-75148 mod_data: Add isplugin info to presets
This activity currently supports two different preset types:
- Datapreset plugins, that can be installed copying them to the
mod/data/preset folder.
- Presets saved manually by users.

This commit adds an attribute to the presets to mark them, in order
to identify them later (because, for instance, the plugins can't be
removed).

Apart from that, the methods in lib.php, involved with this issue, have
been deprecated. New methods have been implemented in the manager class,
covering them with PHPUnit tests.
2022-08-01 12:08:16 +02:00
Sujith Haridasan
73d604369d MDL-71062 core: Step 1 deprecation of print_error function 2022-07-13 08:20:54 +05:30
Mihail Geshoski
4cc2b15e51 MDL-73357 mod_data: Update tertiary navigation
The following commit disables the acivity header information in
pages where this information is not required, adds missing headings,
updates the breadcrumbs, repositions the groups selector in the
database view page.
2022-02-01 11:45:12 +08:00
Peter Dias
535bbed24e MDL-72413 data: Use the common module for setting the header 2021-12-13 09:49:34 +08:00
Mihail Geshoski
6470282e93 MDL-71913 mod_data: Add tertiary navigation 2021-10-13 11:05:29 +08:00
Michael Hawkins
1ea2ae17be MDL-71162 mod_data: Ensure completion conditions displayed on all tabs 2021-04-29 00:41:07 +08:00
sam marshall
5e72715e4f MDL-71099 Lib: Move new user_fields class from core to core_user
This class would belong more appropriately within the 'user' API
(core_user) instead of within the 'core' API, since it is
directly related to user data.

Since the class has only just been added to Moodle, now is a good
time to move it.
2021-03-25 13:47:23 +00:00
sam marshall
558cc1b85e MDL-45242 Lib: Replace calls to deprecated functions
In all cases changes have been kept to a minimum while not making
the code completely horrible. For example, there are many instances
where it would probably be better to rewrite a query entirely, but
I have not done that (in order to reduce the risk of changes).
2021-03-10 10:57:10 +00:00
sam marshall
225eb7b27e MDL-66679 Forms: Submit button remains disabled after file download
When you download a file directly from a Moodle form submit button,
the submit button disables when you click it, but you remain on that
page so we need to re-enable the button.

This commit causes it to re-enable once the file download finishes,
setting a temporary cookie to indicate this to the JavaScript code.

It also adds a method to disable the system on a given form by
setting data-double-submit-protection="off".
2019-10-30 16:36:28 +00:00
Neill Magill
0b673d9714 MDL-62944 mod_data: Action menu missing from database pages
The action menu was missing from many of the database activity pages,
which meant that it could not be accessed until enough had been done to
the activity to make the editing tabs that used view.php accessible.
2018-08-31 10:15:32 +01:00
Damyon Wiese
663640f5b3 MDL-40759 icons: convert uses of pix_url to pix_icon
Also change filepicker to use scaled svgs instead of sets of custom pngs. The svgs are taken from font-awesome.
2017-03-17 15:52:17 +08:00
Mark Nelson
1f386b13c7 MDL-45676 mod_data: added missing additional name fields 2014-05-22 21:59:52 -07:00
Sam Hemelryk
002a2a44a7 MDL-44154 mod_data: unified @package use 2014-02-18 11:22:41 +13:00
Andrew Davis
66e2b9f8c2 MDL-38856 reposition activity group control and fixed titles in chat, database and forum 2013-09-02 11:49:39 +07:00
Damyon Wiese
74df2951d1 Revert "MDL-39876 Change get_record('course') calls to get_course"
This reverts commit ab7632b74c.
2013-08-21 13:42:30 +08:00
sam marshall
ab7632b74c MDL-39876 Change get_record('course') calls to get_course 2013-08-15 11:31:20 +01:00
Adrian Greeve
f7a00e9dbf MDL-39040 - mod_data: Database description available in single view tab. 2013-04-30 09:06:02 +08:00
Rossiani Wijaya
819b1de681 MDL-38892 data module: Fixed action setType to use PARAM_ALPHANUM 2013-04-24 13:49:09 +08:00
Adrian Greeve
590e3ef0ee MDL-36453 - mod_data: Presets now load in a Windows environment.
Thanks to Michael de Raadt for this patch.
2012-11-15 08:51:42 +08:00
Sam Hemelryk
c56d266a58 MDL-31763 mod_data: Fixed array iteration reference issue 2012-05-10 17:31:42 +12:00
Adrian Greeve
541685ec20 MDL-31763 - data - users can only override their own presets unless they have manage presets permission. 2012-05-10 10:04:30 +08:00
Petr Skoda
cdbea7eed1 MDL-31607 use full course object for require_login() if already available
This eliminates 1 db query.
2012-04-22 17:41:47 +02:00
Adrian Greeve
901d58dfd3 MDL-29086 - data - Fix for allowing the deletion of database activity presets.
Thank you to Matthias Hunstock for providing the patch for this.
2012-03-02 14:18:32 +08:00
Dan Poltawski
39b7715099 MDL-29696 mod/data - fixed page continuing after footer. 2011-11-09 15:42:07 +08:00
Tom Lanyon
7aa06e6ded MDL-28701 Change all uses of $CFG->dataroot/temp to $CFG->tempdir 2011-09-10 10:35:39 +02:00
Sam Hemelryk
8aff1574dc mod-data MDL-23656 Convert mod-data-preset to use the new file API 2010-08-25 01:22:15 +00:00
Sam Hemelryk
0170b834b1 NOBUG: Added missing quotes to database preset header call 2010-08-24 07:32:25 +00:00
Sam Hemelryk
cba87c36ea mod-data MDL-23618 Converted preset page to make use of mforms and new file picker element 2010-08-04 08:23:52 +00:00
Petr Skoda
f728d49b00 MDL-19380 uploadlib cleanup before readding of antivirus integration 2010-07-14 08:40:48 +00:00
Rossiani Wijaya
91bc072a31 MDL-20447 - add heading to the page 2010-05-28 02:30:14 +00:00
Andrew Davis
eaed2fd163 ajax MDL-22286 removed references to the previous version of the JS function openpopup() 2010-05-05 02:05:58 +00:00
David Mudrak
7719b4db37 MDL-21695 Database module now uses new help strings
AMOS BEGIN
 HLP data/exportzip.html,[exportaszip_help,mod_data]
 HLP data/fields.html,[newfield_help,mod_data]
 HLP data/fieldmappings.html,[fieldmappings_help,mod_data]
 HLP data/importcsv.html,[csvimport_help,mod_data]
 HLP data/importfromfile.html,[fromfile_help,mod_data]
 HLP data/maxentries.html,[maxentries_help,mod_data]
 HLP data/requireapproval.html,[requireapproval_help,mod_data]
 HLP data/requiredentries.html,[requiredentries_help,mod_data]
 HLP data/requiredentriestoview.html,[requiredentriestoview_help,mod_data]
 HLP data/savepreset.html,[saveaspreset_help,mod_data]
 HLP data/tags.html,[availabletags_help,mod_data]
 HLP data/usepreset.html,[usestandard_help,mod_data]
AMOS END
2010-04-30 14:56:41 +00:00
Petr Skoda
596509e431 MDL-21695 renaming ->help_icon() to old_help_icon() and going to introduce new help_icon() with new parameters and detailed debugging - hopefully this will help during the conversion to new help 2010-04-13 20:34:27 +00:00
Petr Skoda
a685593466 MDL-21233 moodle_url improvemewnts, code simplification, more diagnostics; fixed several regressions 2010-01-16 15:39:56 +00:00
Petr Skoda
5c2ed7e215 MDL-21198 $OUTPUT->single_button() resurrection, hopefully much easier to use than $OUTPUT->button(); fixed some regressions and code style improvements 2010-01-03 15:46:14 +00:00