jamiesensei
850e85b7b2
some changes to make it easier to override editing icons in child classes and to make several lists work well with each other on the same page.
2007-05-11 22:22:14 +00:00
ikawhero
9aaa214e0c
Addng two new options to the custom profile fields:
...
1. Force unique - force the field data to be unique
2. Signup - display the field on the signup page
MDL-9702
2007-05-11 12:16:44 +00:00
nicolasconnault
2df712352d
MDL-9506 Almost completed category aggregation, including generation of raw and final grades held by these categories. Only a few small glitches remain, that cause these grades not to be generated properly. This is the last critical element of the gradebook API, so I'm looking forward to finishing it :-)
2007-05-11 08:46:34 +00:00
nicolasconnault
77d2540eea
MDL-9506 Finished implementing the propagation of needsupdate flag up the hierarchy when a lower element justifies it. All unit tests pass. The next task is to implement the generation of raw grades and final grades based on this needsupdate setting.
2007-05-11 03:29:00 +00:00
nicolasconnault
1d4b666828
MDL-9506 Fixed a bug with the fetch method. This method should not be called statically when setting an internal object. For example, when the grade_category is calling its load_parent_category, it should not call grade_category::fetch, but new grade_category. Otherwise, the method assigns the new variables to the calling object.
2007-05-11 02:43:46 +00:00
moodler
b55997c112
Removed set_timecreated and just tidied up some time-related things
2007-05-11 02:11:30 +00:00
moodler
f744267a28
A few small fixes and clean ups
2007-05-10 09:07:37 +00:00
skodak
63c9ee991f
MDL-9764 Require_course_login() should check cm visibility in frontpage course too; merged from MOODLE_18_STABLE
2007-05-10 09:02:41 +00:00
nicolasconnault
cb64c6b257
MDL-9506 small fix
2007-05-10 08:58:00 +00:00
toyomoyo
76127f3797
adding new global variable to deter which export should write the exported timestamp in grade_grades_final table
2007-05-10 08:23:44 +00:00
nicolasconnault
8f4a626d5c
MDL-9506
...
grade_grades_raw
added grade_item object
added load_grade_item()
added call to grade_item->flag_for_update() when object is inserted, deleted or updated
grade_grades_final
added grade_item object
added load_grade_item()
grade_grades_text
added grade_item object
added load_grade_item()
grade_item
added qualifies_for_update()
added call to grade_category->flag_for_update() when object is inserted, deleted or updated (only when qualifies_for_update() is true)
However since I have made this last set of changes, the unit tests are performing extremely slow, and several of them fail. I suspect that there is a serious performance issue involved in using objects too heavily, instead of performing more SQL queries, especially when updates are concerned. Often a complete object is SELECTed before it is amended in an object form then UPDATEd.
In the next iteration I will look at this seriously, and put together some tests with thousands of users and many grade_items, to see how well the API responds.
2007-05-10 08:08:43 +00:00
toyomoyo
8df8bbfbd0
removing extra code
2007-05-10 03:51:55 +00:00
toyomoyo
e8565225c9
removed extra code
2007-05-10 03:50:07 +00:00
toyomoyo
ecca85812f
prefix is no longer needed for the array containing event dataI(e.g. $mod_assignment_events", $events is sufficient.
2007-05-10 03:46:10 +00:00
nicolasconnault
8c8462437d
MDL-9506
...
grade_category:
new parent_category object
new load_parent_category() method
new flag_for_update() recursive method
grade_item:
new category object
changed get_category() to load_category() and updated testgradeitem
added missing idnumber field
new flag_for_update() recursive method
2007-05-10 02:34:01 +00:00
urs_hunkler
f145c2482d
added/changed custom corners lib and calls to add the necessary divs
2007-05-09 15:03:01 +00:00
urs_hunkler
d94f580294
library to add the surrounding divs for custom corners and borders.
2007-05-09 14:33:42 +00:00
nfreear
ce3735d453
Fixes bug MDL-9753, "THEME->larrow, rarrow don't work in stock IE6"
2007-05-09 14:15:33 +00:00
nicolasconnault
5de0c5cb76
MDL-9506 Replaces grade_grades_text.gradesid by composite key userid and itemid.
2007-05-09 09:01:56 +00:00
nicolasconnault
6c76ea8dfa
MLD-9506 Grade_grades_raw object now infers grademax and grademin from scale, if scaleid is given at the time of insert of update.
2007-05-09 08:56:08 +00:00
nicolasconnault
70f9a148af
MDL-9506 Added grade_grades_text object to grade_grades_final and raw objects.
2007-05-09 08:10:27 +00:00
toyomoyo
ec19392b06
changing grade book db so that grade_grades_text can be referenced from grade_grades_final
2007-05-09 07:52:00 +00:00
nicolasconnault
6527197b4e
MDL-9506 Unit test tables are now created and emptied using XMLDB. raw.gradescale and final.gradescale have been removed in favour of a single gradevalue. Scale value is no longer rounded until moment of display. A number of other changes which you can look at by browsing the diff :-)
2007-05-09 07:50:28 +00:00
moodler
b0b4ffe1ec
Added CSS class for current language to every page MDL-9750
2007-05-09 06:49:23 +00:00
toyomoyo
48b8bba944
dropping gradescale for grade_raw and grade_final table
2007-05-09 05:56:34 +00:00
nicolasconnault
251aa315d1
Removed breaking unit test, originally set up to test xhtml validity throughout the site.
2007-05-09 05:42:06 +00:00
poltawski
72d2845296
MDL-9742 Converting tabs to spaces
2007-05-09 01:11:45 +00:00
poltawski
9f439b177d
MDL-9742 Replaced stray tabs with spaces
2007-05-08 16:25:18 +00:00
poltawski
a044c05ddb
MDL-9742 - changed tabs to spaces in a few places where there are one
...
or two
2007-05-08 15:07:25 +00:00
sam_marshall
3ef1be377b
MDL-9741: Fixed broken link on editor help page
2007-05-08 14:57:37 +00:00
nicolasconnault
2c72af1f08
MDL-9506 Stuck on grade_category->generate_grades. I cannot figure out how to recursively generate raw grades for each category's associated grade_item based on that category's children categories and items. Heaps of other changes with this commit, including a new grade_object::update_from_db() method, which uses the state of the record in DB to update the current object with a matching id (useful when you insert an incomplete object in the DB and want to get the default values as set up in the DB).
2007-05-08 08:01:55 +00:00
nicolasconnault
0aa32279b7
MDL-9506 Issue 1: adjusting a gradeitem's value would result in a grade_final object with gradevalue assigned, even when a gradescale should have been assigned. Issue 2: double grade_final entries when calling grade_item->load_final() after grade_item->generate_final(). Issue 3: Calling grade_item->update_final_grade() without first calling grade_item->generate_final() would result in fatal error. generate_final() is now called if the raw and final arrays' sizes don't match.
2007-05-08 02:20:26 +00:00
poltawski
c3d1fbe943
MDL-9726 - fixed phpdoc comment from MartinD's commit
2007-05-07 08:34:08 +00:00
nicolasconnault
f151b07393
MDL-9506 Added category's associated grade_item object, and changed unit tests database data so that it creates its own test tables.
2007-05-07 07:33:11 +00:00
jamiesensei
986effb653
pass the category list page param from page to page in question bank editing pages.
2007-05-07 05:53:20 +00:00
jamiesensei
400edee1ec
always make sure that page param is in the pageurl
2007-05-07 05:30:06 +00:00
jamiesensei
81be5cdec3
added argument to constructor to specify the name of the page parameter used to pass the page no of the list. Default to 'page'
2007-05-07 05:25:44 +00:00
toyomoyo
6ceebc1f32
merged fix for MDL-9656, blocks parents can be system context
2007-05-07 03:24:22 +00:00
moodler
6eaa3f09ce
Merged changes for better performance in cases where there are lots of enrolment plugins MDL-9726
2007-05-07 03:10:22 +00:00
nicolasconnault
712d500777
MDL-9506 Removed implicit loading of associated objects from constructors (grade_item and grade_grades_raw) to avoid very large numbers of sql queries when only little data is required. The load_scale() method, for example, needs to be called explicitly.
2007-05-07 02:04:06 +00:00
martinlanghoff
0f7caaf84f
get_my_courses() - ensure we have groupmode, groupmodeforce in $d_fields - calendar/lib.php counts on it
2007-05-06 05:37:28 +00:00
martinlanghoff
4dbca99edf
get_my_courses() - added optimisation for guest login
...
- was causing very slow page generation
2007-05-06 05:28:39 +00:00
martinlanghoff
e4271d740c
get_my_courses() - tighten default fields - faster, risky
...
This makes get_my_courses() faster/lighter in 2 ways
- We fetch a ton less data from the DB
- We store a tone less data in the Session
In a test environment, with a student enrolled in 3 _empty_ courses
(just created, empty modinfo, etc), this shaves 50% off the session
size on-disk.
The problem is callers that may be expecting a given field to appear by
default. Next step: walk all callers...
2007-05-06 05:27:31 +00:00
martinlanghoff
601edb900e
get_my_courses() - skip checks if we know the user has moodle/site:doanything and we are observing $doanything
...
Author: Martin Langhoff <martin@catalyst.net.nz>
2007-05-06 05:26:59 +00:00
martinlanghoff
5970ccfbaf
get_my_courses(): tighten cache scheme - part 2
...
the tighter cache was fragile as we always edit $field
2007-05-06 05:26:04 +00:00
martinlanghoff
c6325ef155
get_my_courses(): tighten cache scheme
...
This tightens the rather lax caching mechanism that
cached regardless of parameters.
Thanks to Matt Clarkson for the heads-up...
2007-05-06 05:22:03 +00:00
nicolasconnault
2b4f19a9ce
MDL-9506 Fixed some small issues.
2007-05-04 09:04:40 +00:00
nicolasconnault
46566dd8c6
MDL-9506 Moved unit tests in a simpletest subfolder so they can be automatically grouped. Added grade_history and grade_text object and another heap of small implementations.
2007-05-04 07:40:51 +00:00
toyomoyo
6ec4869ecb
adding a missing feedbackformat field
2007-05-04 07:35:54 +00:00
jamiesensei
e744ebba7b
added a param to moodle_url constructor to provide params as an array just as a convenience to quickly construct a url with an array of params.
2007-05-04 05:45:33 +00:00
