Commit graph

2608 commits

Author SHA1 Message Date
Andrew Nicols
f7ffb41db4 MDL-71055 behat: Update core settings to use generator
These changes have only been applied to settings which were already
using settings names and values, but which were still using the UI.
2021-08-23 12:47:22 +08:00
Paul Holden
264fe69743 MDL-71981 user: escape identity fields if writer supports HTML. 2021-07-06 09:29:44 +08:00
Paul Holden
97d63b6272 MDL-71003 user: fix alignment of autocomplete participant filters. 2021-04-04 23:21:33 +01:00
Adrian Greeve
1d70790168 Merge branch 'MDL-66025-39' of git://github.com/paulholden/moodle into MOODLE_39_STABLE 2021-03-11 11:38:07 +08:00
Adrian Greeve
17a5e73a9b Merge branch 'MDL-71026-39' of git://github.com/ilyatregubov/moodle into MOODLE_39_STABLE 2021-03-11 11:01:52 +08:00
Ilya Tregubov
472fdf0603 MDL-69680 lib: Replace deprecated jQuery functions 2021-03-04 12:47:44 +08:00
Ilya Tregubov
f702707ef7 MDL-71026 user: Fix incorrect get_string call. 2021-03-03 11:44:30 +02:00
Paul Holden
fac00d7e8c MDL-70995 user: format group names in course participants filter. 2021-02-24 19:26:12 +00:00
Paul Holden
b70b06bc61 MDL-66025 user: require message content in bulk action.
Also import missing 'core/notification' dependency.
2021-02-14 20:10:38 +00:00
Andrew Nicols
52eb636ebe MDL-66979 behat: Switch to generators
These steps were creating content manually in an unnecessary fashion. I
had to debug some issues with features in these areas so took the time
to update them to make use of data generators, which are significantly
faster.
2021-01-22 14:52:21 +08:00
Andrew Nicols
8c3091e5f3 MDL-69107 user: Fix autocomplete usages 2020-12-16 07:50:56 +08:00
Gareth Barnard
547a6dcdde
MDL-70267 ux, theme: Course user profile inconsistent page layout. 2020-11-29 23:52:32 +00:00
Ilya Tregubov
68c3eb8aa9 MDL-65852 user: Fix permission check to download course participants. 2020-11-25 11:27:31 +02:00
Eloy Lafuente (stronk7)
1194dde152 Merge branch 'MDL-70148-39' of git://github.com/andrewnicols/moodle into MOODLE_39_STABLE 2020-11-17 23:13:27 +01:00
Andrew Nicols
61d0134488 MDL-70148 behat: Update steps for keyboard 2020-11-17 15:14:43 +08:00
Paul Holden
b932b798f1 MDL-69964 course: toggle participant checkboxes in root element.
For a given toggleGroup, the relevant action elements are not
necessarily descendants of the same tableRoot element, on the
course participants page.
2020-11-16 17:44:26 +00:00
andreasschenkel
fd7db38d8b MDL-69844 user: Fix no email in download_participants_table
Only include eMail in download_participants_table 
if selected in showuseridentity 
($identityfieldsselect)
2020-11-03 12:27:34 +01:00
Shamim Rezaie
eb238722da MDL-68167 user: Fix missing label for participants filter input fields 2020-10-30 16:11:16 +11:00
Shamim Rezaie
da1f204a0a MDL-68167 lib: Clear single-select autocomplete elements with keyboard
Following MDL-57680, it should be possible to clear the selected option
using keyboard as well.
2020-10-30 16:11:16 +11:00
Shamim Rezaie
5dd385d522 MDL-68167 user: Fix a hardcoded string to be read from lang pack 2020-10-30 16:11:16 +11:00
Shamim Rezaie
dca6513b8a MDL-68167 lib: Fix label for autocomplete selection/suggestion box
The content of the autocomplete selection div is purged by javascript
so we have to move its label outside of it. aria-labeledby is the way
to go.

Each time the suggestion box is expanded, autocomplete js renders the
autocomplete suggestions template. So the label cannot be outside the
suggestions ul.
2020-10-30 16:11:08 +11:00
Shamim Rezaie
6484e89188 MDL-68167 user: filter elements should listen to accessibleChange event 2020-10-30 14:58:54 +11:00
Shamim Rezaie
18702b5869 MDL-68167 lib: Autocomplete selection to use listbox aria role
The aria-selected state cannot be used for the listitem role. The
autocomplete widget highly uses the aria-selected state internally.
2020-10-30 14:56:39 +11:00
Shamim Rezaie
d0ab1d1540 MDL-68167 user: Improve keyboard navigation on autocomplete fields 2020-10-30 14:56:39 +11:00
Paul Holden
070454489f MDL-66648 user: consistent checks for linking to full profile.
The access checks for displaying a link to a users' full profile
now match the checks performed on the full profile page itself.
2020-09-14 20:22:03 +01:00
Mathew May
ffa17ad17d MDL-69240 tool_moodlenet: Clean MoodleNet profile field
Amended by: Eloy Lafuente (stronk7) <stronk7@moodle.org>
- adjust versions for every branch.
- modify verify_webfinger->profileurl external to PARAM_NOTAGS.
2020-09-07 17:25:13 +02:00
Sara Arjona
b80006b600 MDL-61215 core_user: use the new optimised_image filetype group
For the user profile picture (instead of the web_image which includes
SVG files).
2020-08-14 17:06:57 +02:00
Luca Bösch
f1743d9179 MDL-68334 user: Display name in footer as elsewhere. 2020-08-08 10:38:40 +02:00
Adrian Greeve
13a31a6b83 Merge branch 'MDL-60932-39' of git://github.com/aanabit/moodle into MOODLE_39_STABLE 2020-08-05 10:08:50 +08:00
Michael Hawkins
52925cb9df MDL-69336 lib: Reinstating tablelib column show/hide functionality
Also added behat testing for hide/show columns in participants table.
2020-08-04 15:20:29 +08:00
Amaia Anabitarte
3161583d89 MDL-60932 core_user: Fix docs link for participants page
Co-authored by: David Mudrák <david@moodle.com>
2020-07-31 10:30:18 +02:00
Paul Holden
4a16804df7 MDL-69214 user: correct participant table forced group SQL. 2020-07-07 14:37:23 +01:00
Andrew Nicols
8d5926bead MDL-69026 user: Correct statuses => status in test 2020-06-12 10:03:06 +08:00
Andrew Nicols
8bcf74e9bc MDL-69026 user: Wrap sub-query in brackets
It is perfectly valid to have a query like:

Match None of the following:
- Role is ANY of the following:
-- 'Teacher'
-- 'Editing teacher'
-- 'Manager'; AND
- Keyword is NONE of the following:
-- 'Kevin'

However, due to the way in which the query is constructed, this leads to
a query which includes

    WHERE NOT ef.id IS NOT NULL
    AND NOT
        u.id IN (SELECT userid FROM {role_assignments} WHERE roleid IN (...) AND contextid IN (...))
    AND NOT
        NOT (u.firstname || ' ' || u.lastname LIKE '%Kevin%')

The use of NOT NOT is valid in Postgres, MariaDB, MySQL, and MSSQL, but
not in Oracle.

To counter this when the outer jointype is of type NONE, we must wrap
each of the inner WHERE clauses in a set of brackets, which makes the
query:

    WHERE NOT ef.id IS NOT NULL
    AND NOT
        (u.id IN (SELECT userid FROM {role_assignments} WHERE roleid IN (...) AND contextid IN (...)))
    AND NOT
        (NOT (u.firstname || ' ' || u.lastname LIKE '%Kevin%'))

Whilst Oracle does not support the use of `AND NOT NOT ...`, it does support
`AND NOT (NOT ...)`
2020-06-12 10:03:06 +08:00
Jun Pataleta
02b7fac93d Merge branch 'MDL-69017-master' of git://github.com/andrewnicols/moodle 2020-06-11 16:59:04 +08:00
Andrew Nicols
d3bfae8fcc MDL-69017 user: Show all links should work for students 2020-06-11 15:51:41 +08:00
Jun Pataleta
49a34f1593 Merge branch 'MDL-68912' of https://github.com/rlorenzo/moodle 2020-06-11 11:01:05 +08:00
Rex Lorenzo
330c871c3f MDL-68912 user: "Send a message" select all not working 2020-06-10 17:53:53 -07:00
Eloy Lafuente (stronk7)
5364577065 Merge branch 'MDL-68994-master' of git://github.com/andrewnicols/moodle 2020-06-10 23:31:11 +02:00
Victor Deniz Falcon
034ba327d0 Merge branch 'MDL-68980-master' of git://github.com/andrewnicols/moodle 2020-06-10 21:41:56 +01:00
Jun Pataleta
15823a94c1 Merge branch 'MDL-68989-master' of git://github.com/mickhawkins/moodle 2020-06-11 00:03:54 +08:00
Andrew Nicols
9a7bd66b4e MDL-68980 user: Add additional groupmode participants tests 2020-06-10 16:23:58 +08:00
Jake Dallimore
337e2e2b23 Merge branch 'MDL-68973' of https://github.com/stronk7/moodle 2020-06-10 16:13:57 +08:00
Jake Dallimore
2b983d29a0 Merge branch 'MDL-68977-master' of git://github.com/andrewnicols/moodle 2020-06-10 15:36:44 +08:00
Andrew Nicols
eb45751b7b MDL-68994 user: Reset filterverb value when resetting filter 2020-06-10 14:19:02 +08:00
Marina Glancy
09fe2a0ce2 MDL-68980 user: Test for groupmode participants behaviour 2020-06-10 14:15:41 +08:00
Andrew Nicols
20531b30f6 MDL-68980 core_user: Show user participation group when groupmode set 2020-06-10 14:14:50 +08:00
Andrew Nicols
7b3026fabe MDL-68977 core_user: Refresh table after removing all filters
Previously the update function was called for each row as it was
removed. This patch changes the behaviouro to only remove one row at at
ime.
2020-06-10 08:03:16 +08:00
Eloy Lafuente (stronk7)
115cc0214f MDL-68973 versions: bump all versions and requires near release
version = 2020061500 release version
requires= 2020060900 current rc1 (week7roll1) version
2020-06-09 16:23:09 +02:00
Víctor Déniz Falcón
b28f530a84 Merge branch 'MDL-68984-master' of git://github.com/mickhawkins/moodle 2020-06-09 13:45:40 +01:00