Commit graph

644 commits

Author SHA1 Message Date
dongsheng
94b8568628 "MDL-16954, get rid of remote_addr notice on cli, set ip = 0.0.0.0 in mdl_log table when accessed from cli, merged from 1.9" 2008-12-11 05:18:17 +00:00
tjhunt
8ed5dd63ee course categories: Fix many bugs with category editing and permissions. Clean up code.
Bugs: MDL-17479, MDL-16426, MDL-16063, MDL-16013, MDL-15658, MDL-15556, MDL-15161, MDL-14925, MDL-13742, MDL-11557.

* Simplify category editing permissions to just moodle/category:manage and moodle/category:seehiddencategories.
* Enforce those correctly. (Note MDL 17502 is still outstanding.)
* Don't screw up category sort order when you just edit name or description.
* Niceties like where redirects go when you cancel or submit forms.
* Make sure a global course creator can see the site admin block.
* Don't allow a category to be made the child of one of its children!
* General code cleanup to bring key files more in line with best pracitice.

Apologies for the fact it is one big patch, rather than a series of smaller patches. However, categoryedit.php, category.php and index.php where in pretty bad shape and needed significant cleaning up. categoryedit.php, in particular, was almost completely rewritten.

Merged from MOODLE_19_STABLE.
2008-12-04 08:53:10 +00:00
tjhunt
df73f8d4e1 restore: MDL-17480 Potentially expensive function user_can_create_courses called repeatedly from restore UI. 2008-12-01 06:55:11 +00:00
skodak
78a0635ccd MDL-17408 DML: new sql_modulo() method used in course sorting 2008-11-26 08:51:08 +00:00
tjhunt
9101efd312 cleanup: MDL-17083 Remove the old teacher, teachers, student and students columns from the course table.
For something that has been deprecated for over two years, they were still used in a lot of places!
2008-11-13 08:40:57 +00:00
peterbulmer
f76a259e10 MDL-14488 - start sql query with unique field - credit David Monllaó 2008-09-07 06:00:22 +00:00
skodak
8aff848213 MDL-14589 minor database driver loading refactoring 2008-09-02 20:32:03 +00:00
skodak
a1b892ccec MDL-16226 get_coursemodule_xx() improvements 2008-08-27 11:31:37 +00:00
jmg324
8b09e84569 MDL-7971 check in get_categories if user can see hidden categories uses specific capability not course:create 2008-07-16 15:12:09 +00:00
skodak
54a606e91c MDL-15469 adding fclose before write to already open file; merged from MOODLE_19_STABLE 2008-07-09 10:35:25 +00:00
dongsheng
ffc5dbdec1 "MDL-15469, limit email notification" 2008-07-02 04:54:37 +00:00
skodak
6566118c51 MDL-15320 support for other database driver types 2008-06-20 07:05:46 +00:00
skodak
0cbe81112a MDL-14580 rewritten course sorting algorithms 2008-06-16 14:25:53 +00:00
skodak
3dce78e125 MDL-15247 lib/dmllib.php is now obsolete 2008-06-15 11:35:25 +00:00
skodak
245ac55791 MDL-14679 last forgotten bits of dml conversion 2008-06-09 19:48:24 +00:00
skodak
294ce9870f MDL-15189 magic quotes finally removed 2008-06-09 16:53:30 +00:00
skodak
655b09ca8a MDL-15117 wiki converted and other regressions fixed 2008-06-04 21:34:14 +00:00
skodak
f93ea22284 MDL-15142 Bug in datalib.php instance_is_visible() thanks Jerome 2008-06-04 07:54:58 +00:00
nicolasconnault
8a44548456 MDL-14967 Bug in DB upgrade for get_coursemodule_from_instance: named params were using :$modulename instead of :modulename 2008-06-02 14:18:18 +00:00
skodak
e098550433 MDL-15084 get_coursemodules_in_course regression 2008-06-02 10:41:59 +00:00
skodak
fd0e6640cc MDL-14679 fixed some more $db's 2008-05-31 22:18:41 +00:00
skodak
b820eb8c60 MDL-15073 delete_records now truncates table if deleting all records, fixed some regressions 2008-05-31 15:32:28 +00:00
skodak
606d760312 MDL-14679 fixed datalib prefix use 2008-05-30 17:06:41 +00:00
skodak
ac1ba33e4a MDL-14679 fixed datalib addslashes 2008-05-30 17:00:25 +00:00
skodak
d251907c51 MDL-14679 fixed datalib whitespace 2008-05-30 16:51:01 +00:00
skodak
c3df090199 MDL-14679 datalib conversion completed 2008-05-30 16:47:21 +00:00
skodak
06c1a1daf4 MDL-14981 regex search support in datalib, fixed course search 2008-05-25 20:43:46 +00:00
skodak
3b8a284cca MDL-14679 more datalib conversions 2008-05-25 15:16:17 +00:00
skodak
624a690b3d MDL-14679 first part of datalib conversion 2008-05-25 09:39:02 +00:00
skodak
f33e1ed4ae MDL-14679 ok, here is the big patch with new dmllib and ddlib API, some code is already converted, XML db editor works; see tracker for details of regressions and TODOs 2008-05-15 21:40:00 +00:00
dongsheng
12d0687748 "MDL-14460, fix get_context_instance, merged from MOODLE_19_STABLE" 2008-05-01 06:07:24 +00:00
stronk7
341b5ed236 Finally fixed version of lastaccess hadling.
Moved from add_to_log() to require_login(). MDL-14272 ; merged from 19_STABLE
2008-04-15 21:46:04 +00:00
stronk7
252720c45a Correct usage of debugging. MDL-11893 ; merged from 19_STABLE 2008-04-15 21:32:06 +00:00
stronk7
0fdf06cd78 Fixing logic + minor formatting of email. MDL-11893 ; merged from 19_STABLE 2008-04-15 20:02:59 +00:00
dongsheng
0369268bba MDL-11893, append failed SQL to email, see tracker 2008-04-15 05:37:31 +00:00
stronk7
edb15b8f04 Check for 60s interval from PHP. Save 3 queries per request. MDL-14272 ; merged from 19_STABLE 2008-04-10 21:00:38 +00:00
stronk7
cb8aaedf61 Unset rcache on UPDATE statements not using dmllib.php. MDL-14257 ; merged from 19_STABLE 2008-04-08 23:17:20 +00:00
dongsheng
c7a7112781 MDL-12263, under certain conditions, $catctxids is NULL, so an if statement should be here. 2008-03-20 07:20:00 +00:00
sam_marshall
6c5a2108b5 MDL-13915: Fixed add_to_log when very long url is specified (now doesn't try to insert more than 100 chars into database) 2008-03-13 15:32:08 +00:00
martinlanghoff
656418b179 MDL-11180 datalib: get_courses() - grab the course context as part of the select
This speeds up course & category listing enormously - cutting 2500 DB queries
for a site with 2500 courses. It's the power of the JOIN...
2008-02-26 21:48:08 +00:00
moodler
f191a887c6 MDL-12294 merge parentlang 2008-02-26 07:29:09 +00:00
skodak
585385278c MDL-13483 found two more native php mail() commands; merged from MOODLE_19_STABLE 2008-02-25 14:05:06 +00:00
skodak
c7e6b7e462 MDL-13399, MDL-13614 fixed regression caused by last commit; merged from MOODLE_19_STABLE 2008-02-23 19:29:25 +00:00
skodak
7007049315 MDL-13399 prevent ambiguous column names in get_my_courses; merged from MOODLE_19_STABLE 2008-02-18 20:14:16 +00:00
skodak
ac0b1a1987 MDL-13155 reworked get_all_instances_in_course() and get_all_instances_in_courses(), based on patch by Tim; merged from MOODLE_19_STABLE 2008-02-05 21:34:58 +00:00
skodak
b4619aba72 MDL-12945 disabled mods are not returned from get_course_mods() anymore, the results are used in scheduled backup and other parts that do not expect disabled mods; merged from MOODLE_19_STABLE 2008-02-01 07:33:37 +00:00
skodak
dd97c32868 MDL-12945 a slightly bigger patch for performance in recent activity and various group related issues + some other fixes - see list of subtasks in tracker; merged from MOODLE_19_STABLE 2008-01-24 20:33:50 +00:00
martinlanghoff
c26ecb1a29 datalib: get_admins() - Rewrite to avoid get_users_by_capability()
get_admins() and get_admin() were counting on
get_users_by_capability() returning a role-assignment id to pick the
"primary" admin account. With the get_users_by_capability() rewrite,
we no longer have an RA id to clearly blame for the capability.

So, rewrite get_admins() based on the known-good SQL used in
is_siteadmin().

MDL-12452
2008-01-06 23:24:50 +00:00
stronk7
0f62a5b5bb Better behaviour for "-" course searches under MSSQL and Oracle. MDL-7312 ; merged from 19_STABLE 2008-01-01 12:03:00 +00:00
stronk7
a599aeebe5 Prevent some debugging notices, cast to object before inserting. Merged from 19_STABLE 2007-12-31 15:20:02 +00:00