Commit graph

491 commits

Author SHA1 Message Date
skodak
8dd5c1ee2f MDL-11585 false is not allowed default in admin_setting_configselect constructor 2007-10-03 20:02:12 +00:00
skodak
0e4da9e34f fixed context parameter in has_capability() call 2007-10-03 14:16:04 +00:00
nicolasconnault
ece966f06e MDL-11482 Resolved the sum icon issue (added a new x-bar icon) and resolved a dependency problem in moodlelib 2007-10-03 12:22:25 +00:00
skodak
284abb0925 MDL-11495 grade letter setting improvements:
* in_null for decimals defaults checks
* store letter settings only in database - no cfg settings
* separate configuration page for letters only - pluginselector+admin tree
* new capability to manage grade letters - similar to scales and outcomes
* added grade_letters db index
* grade letters related minor bugfixing
2007-09-28 20:12:43 +00:00
nicolasconnault
e9096dc2ca MDL-11480 Reviewed, tested, and pplied Petr's patch. 2007-09-28 07:55:51 +00:00
toyomoyo
e5ea84faba MDL-11478, fixing a notice 2007-09-28 01:53:45 +00:00
nicolasconnault
9fa46707f3 MDL-11456 the .grade-report-grader table {} style was cascading down to the popups (which use tables, alas...), so I created a number of css classes which now control color, font etc for caption and feedback cells of the popup. 2007-09-27 18:00:25 +00:00
nicolasconnault
d32100a522 Fixing OU report issues 2007-09-25 19:32:29 +00:00
nicolasconnault
31a6c06c46 MDL-11433 Implemented grade_items.decimals instead of user preference in grader report. 2007-09-25 14:40:49 +00:00
nicolasconnault
1796708d81 Replacing GRADE_REPORT_GRADE_DISPLAY_TYPE... by GRADE_DISPLAY_TYPE... 2007-09-25 08:22:20 +00:00
skodak
465b310d2b prevent error when somebody changes scale or grading type - old value does not fit the new scale 2007-09-23 12:09:16 +00:00
skodak
3f2b0c8aba MDL-11363 merged tables grade_grades with grade_grades_text - it is now possible to define fields as required and optional
finally fixed formula validation in calculation edit form
2007-09-22 11:39:59 +00:00
nicolasconnault
41f22daa71 MDL-11353 Completed the implementation. This included a new method in grade_item: get_displaytype(), since that value could be set to default, and we must then look up to course, then site values. And the get_letter() method in grade_grade has been modified to first check the grade_letters table. All works like a dream! 2007-09-19 15:37:46 +00:00
nicolasconnault
dbdffd2c96 MDL-11340 Almost complete: Just need the "Add grade letter" button 2007-09-19 12:45:44 +00:00
nicolasconnault
a5b8be622c MDL-11275 added (submissions). Also fixed :
Issue:
    Teachers can edit grader report preferences (including switches for quickgrading and
    quickfeedback), but do not have access to the "Turn editing on/off" button, so they
    can't do quickgrading.
Solutions:
    1.Decouple the quickgrading and quickfeedback modes from the editing mode,
        and turn them on/off through the preferences page. New capability: moodle/grade:edit
        * preferences: don't show quickgrading if no capability grade:edit
        * If quickgrading is switched off as a preference and user doesn't have manage cap, show edit icons around grades when in editing mode
2007-09-17 17:31:48 +00:00
toyomoyo
5bb8a8154e MDL-11084, "s in grade comments causes problems 2007-09-17 06:53:24 +00:00
toyomoyo
4581501ede MDL-11276, average calculations are inaccurate in percentage form due to double rounding 2007-09-17 04:25:51 +00:00
toyomoyo
cb68af8b89 removing extra number_format(), format_float() already calls number_format() 2007-09-17 02:15:51 +00:00
toyomoyo
00374cc5f0 MDL-11274, hide grades in the grader report if the current grades has no viewhidden capability 2007-09-14 08:43:10 +00:00
nicolasconnault
098042baea Issue:
The number of submissions in the Group average and Course average calculations
    should be shown in brackets. (submissions) should be added after the Group average
    and Course average labels.
Solution:
    new grader report preference (Display number of grades in average cells).
2007-09-14 06:57:30 +00:00
moodler
2c7a9bd2af Fix the location of the link to the site-wide grading preferences 2007-09-14 06:51:57 +00:00
moodler
6308b91c13 Changing string for Overall average (was logged under MDL-11233 even though that's not strictly the correct bug) 2007-09-14 05:45:38 +00:00
nicolasconnault
aae94377b7 Issue:
Only students should appear in the tutor report, however
    sorting by Surname results in the tutor being included, which we don't want.
Solution:
    Confirmed as a bug and filed in tracker: http://tracker.moodle.org/browse/MDL-11233

Issue:
    Clicking on Hide Groups reveals the results for all students
    and all tutors and course staff appear. A tutor should only be able to see
    the results for their tutor group
Solution:
    Prevent tutors from ever seeing student grades from other groups: use existing capabilities
        moodle/site:accessallgroups = off AND moodle/grade:viewall = on

Issue:
    Preferences tab should not be available to users without gradereport/grader:manage capability
Solution:
    Hide the tab completely

Issue:
    Apply different style to average cells
Solution:
    Add css classes to the different average cells, and write a default style in css file.

Issue:
    The Average under group average might be better labelled Course average.
Solution:
    Rename to "Complete average"
2007-09-13 15:11:16 +00:00
nicolasconnault
c421ad4b2e MDL-11233 Corrected typo in grader report lib, and added a second sort parameter for lastname and firstname sorts, to add consistency to result sets. Non-students no longer appear in the list 2007-09-13 13:44:35 +00:00
nicolasconnault
b1b6ebf437 Replacing the capability gradereport/grader:manage with moodle/grade:manage 2007-09-12 15:02:06 +00:00
skodak
c2efb50142 MDL-11130 added aggregation inside all subcategories + added graded/all aggregation option 2007-09-05 19:15:21 +00:00
toyomoyo
f8ae1f86c5 MDL-10963, group average code broken, count_ungraded is ignoring groups altogether. 2007-08-29 04:05:56 +00:00
nicolasconnault
33a34cd4d0 MDL-10875 Corrected bug in averaging plus a couple of typos 2007-08-20 07:29:05 +00:00
toyomoyo
d8c684de7e replacing round() with number_format (for a number betweem 0-100), because round does not respect decimal places, e.g. round(90.50, 2) = 90.5 2007-08-17 06:28:12 +00:00
toyomoyo
54c7e5e064 removing old broken sql 2007-08-17 06:15:35 +00:00
nicolasconnault
09cef06a10 MDL-10873 If both site default and user pref are empty for studentsperpage, we assume that paging is not wanted, so all paging functionality is switched off in the report. 2007-08-16 18:09:49 +00:00
nicolasconnault
4f8783fe91 MDL-10873 Now deleting the preference from user_preferences if the value submitted is empty. The grader report will then revert to the site default 2007-08-16 17:53:08 +00:00
nicolasconnault
66ef0471ae MDL-10838 Applied standard table classes and scopes to tr, th and tds of the grader report. Also fixed a bug with the display of grand averages when a group is selected and the average column is set to aggregate all grades. 2007-08-15 11:15:39 +00:00
toyomoyo
8c40e0919d fixing grader report paging bar when groups are present 2007-08-15 05:47:34 +00:00
nicolasconnault
89f33581ba MDL-9628 At the suggestion of Tim Hunt, interchanged the position of grade letter select elements with percentage selectors, in the grader report preferences form. 2007-08-14 11:54:44 +00:00
toyomoyo
ab3444d79d fixed a warning when group members have no grades 2007-08-14 02:13:08 +00:00
skodak
76317c73a2 MDL-10791 improve handling of localised floating point numbers in moodle; replaced/fixed some float_format() that were used instead of round(); expect some more patches soon 2007-08-10 15:00:35 +00:00
nicolasconnault
060d1e1792 MDL-9628 More category collapse updates 2007-08-10 05:49:46 +00:00
nicolasconnault
384960dd68 MDL-9628 Simplified and improved the expanding/collapsing of categories. There are now three view types: full, aggregates only and grades only. 2007-08-09 16:41:39 +00:00
nicolasconnault
d4795a0792 MDL-9628 When a timestamp is selected for locktime or hiddenuntil, the grader report now shows a new icon (lock or eye in front of a calendar), with a tooltip showing the selected date. Very useful :-) 2007-08-08 15:48:20 +00:00
skodak
aea4df411e MDL-10544 support for outcomes showing/hiding in grader report 2007-08-08 08:31:04 +00:00
skodak
0658afc9a1 fixes for overriding of scales, outcomes and minor access control tweak 2007-08-07 22:50:32 +00:00
skodak
d3c3da1b77 MDL-9628 non-existent grades can be locked/hidden/edited :-) 2007-08-07 08:30:25 +00:00
nicolasconnault
be55a047dc MDL-9628 Added title attributes to quickgrading and quickfeedback input elements, and gave the quickfeedback input a dashed 1px black border to distinguish it easily from the grade input. 2007-08-06 09:02:22 +00:00
nicolasconnault
859c72599f MDL-9628 Fixed sorting 2007-08-06 08:10:37 +00:00
nicolasconnault
ca145cc84e MDL-9628 Removed superfluous & in URL (part of $report->baseurl) and reversed the default sortitem order from ASC to DESC (highest grade first). 2007-08-06 06:07:23 +00:00
nicolasconnault
1815b45c1b MDL-10676 Added linking activity icons to grader report headers, based on user preference /config setting. 2007-08-01 14:52:14 +00:00
nicolasconnault
2e3987a935 MDL-10674 and MDL-10675 finished 2007-08-01 14:08:50 +00:00
nicolasconnault
fafe1cd23e MDL-9628 Reverting to using gradebook plugin module names in navigation 2007-08-01 07:41:13 +00:00
nicolasconnault
826c5f8635 MDL-9628 Refactoring the building of navigation array for gradebook pages 2007-08-01 06:47:35 +00:00