Commit graph

24302 commits

Author SHA1 Message Date
Jun Pataleta
584ea5b075 Merge branch 'MDL-67966-master' of https://github.com/junpataleta/moodle 2022-06-02 10:29:43 +08:00
Joshua Ebarvia
d5059795c9 MDL-67966 mod_workshop: Use condition to verify form is using editor
This adds a condition to check if Online text is used
for the submission. The functions file_postupdate_standard_editor
and file_postupdate_standard_filemanager needs the property
content_editor of the formdata.
2022-06-02 10:27:41 +08:00
Tim Hunt
e230bfa47f MDL-74752 qtype_multichoice: fix regrading logic
The implements the new regrade-related hooks, and also has
tests for the changes to the core system, now that we have a question
type we can use for them.
2022-05-31 09:22:22 +01:00
Tim Hunt
39abc01197 MDL-74752 question regrading: implement the required hooks
This commit implements the necessary core hooks to ensure we only
allow a regrade of a quetion attempt to take place if the new and old
versions of the question are sufficiently similar.

It will be followed by commits to each question type where the
new method needs to be implemented.

Automated tests will be included in the first of those (mulitple choice)
becuse we need a question type that implements the hooks to test
the core changes.
2022-05-31 09:22:22 +01:00
Leon Stringer
0cd4eadb35 MDL-73215 assign: Undefined var: plagiarismlinks
Fix: $plagiarismlinks is concatenated in return but may not have been
initialised.
2022-05-27 08:56:31 +01:00
Philipp Imhof
1c9c6c4139
MDL-74495 quiz override mark: do not hide_all_feedback 2022-05-27 08:47:25 +02:00
Noel De Martin
df9f610d1d MDL-74220 data: Implement behat generators 2022-05-26 10:38:11 +02:00
Jake Dallimore
aef7c3357d Merge branch 'MDL-73386-master' of https://github.com/junpataleta/moodle 2022-05-26 11:46:59 +08:00
Jun Pataleta
e60e8bc629 Merge branch 'MDL-73423-master' of https://github.com/marinaglancy/moodle 2022-05-26 00:18:35 +08:00
Dani Palou
f6520aa4b0 MDL-74816 mod_resource: Allow specify default file name in generator 2022-05-25 10:41:03 +02:00
Jake Dallimore
0839152f03 Merge branch 'MDL-73435-master' of https://github.com/marinaglancy/moodle 2022-05-25 11:31:52 +08:00
Paul Holden
4f644c3f39 MDL-74790 mod_resource: better detection of empty module intro. 2022-05-24 21:17:17 +01:00
Angelia Dela Cruz
8db6d451d7 MDL-74744 behat: Quiz behat generators use UI
Replace steps that manually add Quiz instances via the UI and use
Behat generators. This improves the speed of Behat test runs.
2022-05-24 10:54:26 +08:00
hieuvu
5cfaa18cad MDL-74533 core_completion: Update using new grade pass for completion 2022-05-23 15:14:12 +07:00
Jun Pataleta
60fcabfa6d MDL-73386 mod_quiz: Use plain text for quiz navigation fake block title
* No need to enclose the title of the quiz navigation fake block in
a span tag. The block title also gets appended to the skip link which
means that a block title with a span tag assigned with an identifier
can cause duplicate ID errors on the DOM.
2022-05-21 00:32:38 +08:00
Laurent David
bad2e0bb54 MDL-73225 mod_bigbluebuttonbn: Improve error message when joining
Display more friendly messages when:
    * When displaying activity and the server is not available
    * When we join a meeting and the server is not available or an error is detected
2022-05-20 13:07:14 +02:00
Dan Marsden
b95d2b94a5 MDL-74785 mod_scorm: Add scorm content filearea to global search. 2022-05-18 19:47:44 +12:00
Jun Pataleta
eae7ec37ca Merge branch 'MDL-74413' of https://github.com/stronk7/moodle 2022-05-12 12:09:05 +08:00
Shamiso.Jaravaza
41f40c7d7a MDL-74726 mod_bigbluebuttonbn: Fix muteonstart
Added missing muteonstart_editable in mod_form  block condition
2022-05-11 08:29:16 -06:00
Jun Pataleta
817db2b7f3 Merge branch 'MDL-74041' of https://github.com/timhunt/moodle 2022-05-10 17:59:45 +08:00
Ilya Tregubov
8de866dc3f MDL-74710 mod_bigbluebuttonbn: Fix settings url. 2022-05-10 11:11:51 +06:00
Eloy Lafuente (stronk7)
caf55abf17 MDL-74413 phpunit: Move more tests to use correct names and namespaces
Applied the following changes to various testcase classes:

- Namespaced with component[\level2-API]
- Moved to level2-API subdirectory when required.
- Fixed incorrect use statements with leading backslash.
- Remove file phpdoc block
- Remove MOODLE_INTERNAL if not needed.
- Changed code to point to global scope when needed.
- Fix some relative paths and comments here and there.
- All them passing individually.
- Complete runs passing too.

Special mention to:

- Moved to the level2 "privacy" namespace:
  - \mod_assign\privacy\feedback_legacy_polyfill_test
  - \mod_assign\privacy\submission_legacy_polyfill_test

- Moved to the level2 "task" namespace:
  - \core_message\task\migrate_message_data_test
  - \ltiservice_gradebookservices\task\cleanup_test
  - \message_email\task\send_email_test
  - \mod_lti\task\clean_access_tokens_test
  - \mod_workshop\task\cron_task_test

- Moved to the level2 "event" namespace:
  - \core_h5p\event\deleted_test
  - \core_h5p\event\viewed_test

- Renamed to a better name:
  - backup_forum_activity_task_test.php (missing "task")
2022-05-07 20:32:30 +02:00
Jake Dallimore
d84738eb08 MDL-74602 mod_assign: fix js error with assign grader on classic 2022-05-06 16:46:58 +08:00
Jun Pataleta
48cab7f948 Merge branch 'MDL-74584-master-v1' of https://github.com/mihailges/moodle 2022-05-06 14:47:04 +08:00
Mihail Geshoski
154dbce845 MDL-74584 mod_bigbluebuttonbn: Update behat tests 2022-05-06 14:39:06 +08:00
Mihail Geshoski
75d9476420 MDL-74584 mod_bigbluebuttonbn: Update unit tests 2022-05-06 14:39:06 +08:00
Mihail Geshoski
c23b67be46 MDL-74584 mod_bigbluebuttonbn: Add install script and new upgrade step
Adds a new install script for the BBB module and a new upgrade step.
The BBB module now will be disabled by default for new installations
and also it will be disabled for the existing sites that use the
default BBB server configuration. Admistrators will be required to
confirm the acceptance of the related DPA prior to (re)enabling the
plugin once again.
2022-05-06 14:39:06 +08:00
Mihail Geshoski
b9b9ec82d4 MDL-74584 mod_bigbluebuttonbn: Add DPA info in the general setting page
Adds a note in the BBB general settings page to raise awareness about
the legal obligations related to the data processing agreement with the
service provider which is currently configured.
2022-05-06 13:36:53 +08:00
Mihail Geshoski
6588baec97 MDL-74584 mod_bigbluebuttonbn: Implement 'pre_enable_plugin_actions'
Implements a function for the 'pre_enable_plugin_actions' callback.
When the default BBB server settings are used while the administrator
attempts to enable the BBB plugin, the function will prevent this
action and trigger a dynamic form requesting the admin to conifrm
their acceptance of the related data processing agreement. The process
of enabling the plugin will continue as usual in cases where the
admin has already confirmed the acceptance of the dpa or a different
BBB server configuration is used other than the default.
2022-05-06 13:36:53 +08:00
Ilya Tregubov
93e96e0aa2 Merge branch 'MDL-74602-master' of https://github.com/snake/moodle 2022-05-05 07:46:33 +06:00
Tim Hunt
aac5b47cea MDL-74041 quiz: use own size for paging the question bank 2022-05-04 11:01:44 +01:00
Paul Holden
6abe964bba MDL-74204 mod_assign: escape identity fields in allocate marker form. 2022-05-04 04:04:15 +02:00
Leon Stringer
b460ea470f MDL-74631 mod_lti: Remove </img>
Remove illegal HTML tag.

Added example context to pass CI checks.
2022-05-03 17:27:13 +01:00
Jun Pataleta
b625dabb83 Merge branch 'MDL-74543' of https://github.com/timhunt/moodle 2022-05-03 22:22:39 +08:00
Tim Hunt
7d3eaf892d MDL-74543 quiz attemptlib: covert string comparison to ===
Where obviously safe.
2022-05-03 13:45:39 +01:00
Tim Hunt
52b8962dbd MDL-74543 quiz: correctly record time when overdue attempt submitted 2022-05-03 13:41:45 +01:00
Jake Dallimore
9e70147e05 Merge branch 'MDL-74441-master' of https://github.com/cameron1729/moodle 2022-05-03 16:54:35 +08:00
Jake Dallimore
db933339fa MDL-74602 mod_wiki: disable activity header in wiki print view 2022-05-03 09:58:01 +08:00
Jake Dallimore
a8fcf50e55 MDL-74602 mod_chat: disable activity header in ajax chat interface 2022-05-03 09:57:19 +08:00
Jake Dallimore
edf2c5ea2f MDL-74602 mod_book: disable activity header on book print page 2022-05-03 09:56:56 +08:00
Jake Dallimore
0402dfdc95 MDL-74602 mod_assign: disable activity header on embedded grader page 2022-05-03 09:55:22 +08:00
Marina Glancy
ac7c952b84 MDL-73435 mod_wiki: htmlspecialchars changed default in PHP8.1 2022-04-29 16:22:43 +02:00
Marina Glancy
a0398fdde8 MDL-73423 core_privacy: Calling reset() on objects deprecated PHP8.1 2022-04-29 16:16:07 +02:00
Cameron Ball
34c3392f49 MDL-74441 mod_forum: Fix overflow in unified grader 2022-04-28 15:55:18 +08:00
Jun Pataleta
c0466920b3 Merge branch 'MDL-74537-master-enfix' of https://github.com/vmdef/moodle 2022-04-27 15:56:00 +06:00
Ilya Tregubov
af8155036f Merge branch 'MDL-74510' of https://github.com/stronk7/moodle 2022-04-27 15:56:00 +06:00
Víctor Déniz
57b300e27f Merge branch 'MDL-74320' of https://github.com/stronk7/moodle 2022-04-27 15:56:00 +06:00
Víctor Déniz
b7a06ebb68 Merge branch 'MDL-74514' of https://github.com/call-learning/moodle 2022-04-27 15:56:00 +06:00
Ilya Tregubov
03c237525c Merge branch 'MDL-74481-LTI13-InstructorRole' of https://github.com/cengage/moodle 2022-04-27 15:56:00 +06:00
Helen Foster
a1699a58f4 MDL-74537 lang: Import fixed English strings (en_fix) 2022-04-26 11:21:12 +01:00